mmc: core: annotate implicit fall through
PATCH 1/1 mmc: core: annotate implicit fall through
There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1).
In this particular case rewrote the comment to start with the string "fall through", so as to match the regular expression expected by GCC. Truncate the comment slightly to fit the max line length of 80 characters.
This commit remove the following warning:
drivers/mmc/core/host.c:196:14: warning: this statement may fall through [-Wimplicit-fallthrough=]
--- drivers/mmc/core/host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/core/host.c +1 -1
@@ -194,7 +194,7 @@ int mmc_of_parse(struct mmc_host *host)switch (bus_width) {case 8 : host->caps |=MMC_CAP_8_BIT_DATA ; -/* Hosts capable of 8-bit transfers can also do 4 bits */ +/* fall through - Hosts capable of 8-bit can also do 4 bits */ case 4 : host->caps |=MMC_CAP_4_BIT_DATA ;break ;
Signature · 1 line
2.19.2
Quoted 7 lines · Mathieu Malaterre
There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1).
In this particular case rewrote the comment to start with the string "fall through", so as to match the regular expression expected by GCC. Truncate the comment slightly to fit the max line length of 80 characters.
Quoted 5 lines
This commit remove the following warning:
drivers/mmc/core/host.c:196:14: warning: this statement may fall through [-Wimplicit-fallthrough=]Signed-off-by Mathieu Malaterre <[email protected]>
Thanks, Mathieu.
Quoted 18 lines
--- drivers/mmc/core/host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mmc/core/host.c +1
-1@@ -194,7 +194,7 @@ int mmc_of_parse(struct mmc_host *host)switch (bus_width) {case 8 : host->caps |=MMC_CAP_8_BIT_DATA ; -/* Hosts capable of 8-bit transfers can also do 4 bits */ +/* fall through - Hosts capable of 8-bit can also do 4 bits */ case 4 : host->caps |=MMC_CAP_4_BIT_DATA ;break ;
Quoted 8 lines · Mathieu Malaterre
There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1).
In this particular case rewrote the comment to start with the string "fall through", so as to match the regular expression expected by GCC. Truncate the comment slightly to fit the max line length of 80 characters.
Quoted 5 lines
This commit remove the following warning:
drivers/mmc/core/host.c:196:14: warning: this statement may fall through [-Wimplicit-fallthrough=]Signed-off-by Mathieu Malaterre <[email protected]>
Applied for next, thanks!
Kind regards
Uffe
Quoted 20 lines
--- drivers/mmc/core/host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mmc/core/host.c +1
-2@@ -194,7 +194,7 @@ int mmc_of_parse(struct mmc_host *host)switch (bus_width) {case 8 : host->caps |=MMC_CAP_8_BIT_DATA ; -/* Hosts capable of 8-bit transfers can also do 4 bits */ +/* fall through - Hosts capable of 8-bit can also do 4 bits */ case 4 : host->caps |=MMC_CAP_4_BIT_DATA ;break ; --2.19.2