watchdog: mt7621: Fix compiler error, missing include
Subsystems (2)
PATCH 1/1 watchdog: mt7621: Fix compiler error, missing include
drivers/watchdog/mt7621_wdt.c:174:34: error: array type has incomplete element type 'struct of_device_id'
static const struct of_device_id mt7621_wdt_match[] = {
^~~~~~~~~~~~~~~~
drivers/watchdog/mt7621_wdt.c:175:4: error: field name not in record or union initializer
{ .compatible = "mediatek,mt7621-wdt" },
^
drivers/watchdog/mt7621_wdt.c:175:4: note: (near initialization for 'mt7621_wdt_match')
drivers/watchdog/mt7621_wdt.c:174:34: warning: 'mt7621_wdt_match' defined but not used [-Wunused-variable]
static const struct of_device_id mt7621_wdt_match[] = {
^~~~~~~~~~~~~~~~--- drivers/watchdog/mt7621_wdt.c | 1 + 1 file changed, 1 insertion(+)
drivers/watchdog/mt7621_wdt.c +1 -0
@@ -16,6 +16,7 @@#include <linux/kernel.h> #include <linux/watchdog.h> #include <linux/moduleparam.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <asm/mach-ralink/ralink_regs.h>
Signature · 7 lines
2.19.1 _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek
A message that is not in the archive (sent off-list or not yet received): 20190114211719.11461-1-opensource-91nzXlUTePbQT0dZR+AlfA@public.gmane.org
Quoted 11 lines · René van Dorst
drivers/watchdog/mt7621_wdt.c:174:34: error: array type has incomplete element type 'structof_device_id'static const struct of_device_id mt7621_wdt_match[] = { ^~~~~~~~~~~~~~~~ drivers/watchdog/mt7621_wdt.c:175:4: error: field name not in record or union initializer { .compatible = "mediatek,mt7621-wdt" }, ^ drivers/watchdog/mt7621_wdt.c:175:4: note: (near initialization for 'mt7621_wdt_match') drivers/watchdog/mt7621_wdt.c:174:34: warning: 'mt7621_wdt_match' defined but not used [-Wunused-variable] static const struct of_device_id mt7621_wdt_match[] = { ^~~~~~~~~~~~~~~~
Did this work in the past?
I suppose so. Could you provide a fixes tag for stable.
Thanks,
Matthias
Quoted 11 lines
Signed-off-by René van Dorst <[email protected]>--- drivers/watchdog/mt7621_wdt.c | 1 + 1 file changed, 1 insertion(+)drivers/watchdog/mt7621_wdt.c +0
-0
drivers/watchdog/mt7621_wdt.c line 22
Quoted 7 lines
drivers/watchdog/mt7621_wdt.c +1
-0@@ -16,6 +16,7 @@#include <linux/kernel.h> #include <linux/watchdog.h> #include <linux/moduleparam.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <asm/mach-ralink/ralink_regs.h>
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
A message that is not in the archive (sent off-list or not yet received): a8b870f2-a50d-144e-cdca-b8a95d48846b-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Quoting Matthias Brugger <[email protected]>:
Quoted 13 lines · René van Dorst
Quoted 11 lines
drivers/watchdog/mt7621_wdt.c:174:34: error: array type has incomplete element type 'structof_device_id'static const struct of_device_id mt7621_wdt_match[] = { ^~~~~~~~~~~~~~~~ drivers/watchdog/mt7621_wdt.c:175:4: error: field name not in record or union initializer { .compatible = "mediatek,mt7621-wdt" }, ^ drivers/watchdog/mt7621_wdt.c:175:4: note: (near initialization for 'mt7621_wdt_match') drivers/watchdog/mt7621_wdt.c:174:34: warning: 'mt7621_wdt_match' defined but not used [-Wunused-variable] static const struct of_device_id mt7621_wdt_match[] = { ^~~~~~~~~~~~~~~~
Quoted 2 lines
Did this work in the past?
I suppose so. Could you provide a fixes tag for stable.
I see that I am not the first who spotted this. https://patchwork.kernel.org/patch/10745049/
So better drop this one.
Greats,
René
Quoted 19 lines
Thanks,
MatthiasQuoted 16 lines
Signed-off-by René van Dorst <[email protected]>--- drivers/watchdog/mt7621_wdt.c | 1 + 1 file changed, 1 insertion(+)drivers/watchdog/mt7621_wdt.c +1
-0@@ -16,6 +16,7 @@#include <linux/kernel.h> #include <linux/watchdog.h> #include <linux/moduleparam.h> +#include <linux/of.h> #include <linux/platform_device.h>
Quoted 2 lines
drivers/watchdog/mt7621_wdt.c line 22
Quoted 2 lines
drivers/watchdog/mt7621_wdt.c +0
-0#include <asm/mach-ralink/ralink_regs.h>
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek