drm/i915: Pass down rc in intel_encoder->compute_config()
Subsystems (2)
PATCH 1/1 drm/i915: Pass down rc in intel_encoder->compute_config()
Something that I completely missed when implementing the new MST VCPI atomic helpers is that with those helpers, there's technically a chance of us having to grab additional modeset locks in ->compute_config() and furthermore, that means we have the potential to hit a normal modeset deadlock. However, because ->compute_config() only returns a bool this means we can't return -EDEADLK when we need to drop locks and try again which means we end up just failing the atomic check permanently. Whoops.
So, fix this by modifying ->compute_config() to pass down an actual error code instead of a bool so that the atomic check can be restarted on modeset deadlocks.
Thanks to Ville Syrjälä for pointing this out!
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109320
--- drivers/gpu/drm/i915/icl_dsi.c | 8 +++---- drivers/gpu/drm/i915/intel_crt.c | 34 ++++++++++++++-------------- drivers/gpu/drm/i915/intel_ddi.c | 6 ++--- drivers/gpu/drm/i915/intel_display.c | 11 +++++---- drivers/gpu/drm/i915/intel_dp.c | 32 +++++++++++++------------- drivers/gpu/drm/i915/intel_dp_mst.c | 12 +++++----- drivers/gpu/drm/i915/intel_drv.h | 18 +++++++-------- drivers/gpu/drm/i915/intel_dvo.c | 10 ++++---- drivers/gpu/drm/i915/intel_hdmi.c | 12 +++++----- drivers/gpu/drm/i915/intel_lvds.c | 12 +++++----- drivers/gpu/drm/i915/intel_sdvo.c | 14 ++++++------ drivers/gpu/drm/i915/intel_tv.c | 8 +++---- drivers/gpu/drm/i915/vlv_dsi.c | 14 ++++++------ 13 files changed, 97 insertions(+), 94 deletions(-)
drivers/gpu/drm/i915/icl_dsi.c +4 -4
@@ -1188,9 +1188,9 @@ static void gen11_dsi_get_config(struct intel_encoder *encoder, pipe_config->output_types |=BIT (INTEL_OUTPUT_DSI ); } -static bool gen11_dsi_compute_config (struct intel_encoder *encoder, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state) +static int gen11_dsi_compute_config (struct intel_encoder *encoder, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state) { struct intel_dsi *intel_dsi = container_of(encoder, struct intel_dsi, base);
@@ -1215,7 +1215,7 @@ static bool gen11_dsi_compute_config(struct intel_encoder *encoder, pipe_config->clock_set = true; pipe_config->port_clock =intel_dsi_bitrate (intel_dsi) /5 ; -return true; +return 0 ; } static u64 gen11_dsi_get_power_domains(struct intel_encoder *encoder,
drivers/gpu/drm/i915/intel_crt.c +17 -17
@@ -345,51 +345,51 @@ intel_crt_mode_valid(struct drm_connector *connector,return MODE_OK ; } -static bool intel_crt_compute_config (struct intel_encoder *encoder, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state) +static int intel_crt_compute_config (struct intel_encoder *encoder, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state) {struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;if (adjusted_mode->flags &DRM_MODE_FLAG_DBLSCAN ) -return false; +return -EINVAL ; pipe_config->output_format =INTEL_OUTPUT_FORMAT_RGB ; -return true; +return 0 ; } -static bool pch_crt_compute_config (struct intel_encoder *encoder, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state) +static int pch_crt_compute_config (struct intel_encoder *encoder, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state) {struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;if (adjusted_mode->flags &DRM_MODE_FLAG_DBLSCAN ) -return false; +return -EINVAL ; pipe_config->has_pch_encoder = true; pipe_config->output_format =INTEL_OUTPUT_FORMAT_RGB ; -return true; +return 0 ; } -static bool hsw_crt_compute_config (struct intel_encoder *encoder, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state) +static int hsw_crt_compute_config (struct intel_encoder *encoder, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state) {struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev);struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;if (adjusted_mode->flags &DRM_MODE_FLAG_DBLSCAN ) -return false; +return -EINVAL ;/* HSW/BDW FDI limited to 4k */ if (adjusted_mode->crtc_hdisplay >4096 || adjusted_mode->crtc_hblank_start >4096 ) -return false; +return -ENOSPC ; pipe_config->has_pch_encoder = true; pipe_config->output_format =INTEL_OUTPUT_FORMAT_RGB ;
@@ -398,7 +398,7 @@ static bool hsw_crt_compute_config(struct intel_encoder *encoder,if (HAS_PCH_LPT (dev_priv)) {if (pipe_config->bw_constrained && pipe_config->pipe_bpp <24 ) {DRM_DEBUG_KMS ("LPT only supports 24bpp\n" ); -return false; +return -EINVAL ; } pipe_config->pipe_bpp =24 ;
@@ -407,7 +407,7 @@ static bool hsw_crt_compute_config(struct intel_encoder *encoder,/* FDI must always be 2.7 GHz */ pipe_config->port_clock =135000 *2 ; -return true; +return 0 ; }static bool intel_ironlake_crt_detect_hotplug (struct drm_connector *connector)
drivers/gpu/drm/i915/intel_ddi.c +3 -3
@@ -3837,9 +3837,9 @@ intel_ddi_compute_output_type(struct intel_encoder *encoder, } } -static bool intel_ddi_compute_config (struct intel_encoder *encoder, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state) +static int intel_ddi_compute_config (struct intel_encoder *encoder, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state) {struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev);enum port port = encoder->port;
drivers/gpu/drm/i915/intel_display.c +7 -4
@@ -11550,10 +11550,13 @@ intel_modeset_pipe_config(struct drm_crtc *crtc,continue ; encoder =to_intel_encoder (connector_state->best_encoder); - -if (!(encoder->compute_config (encoder, pipe_config, connector_state))) { -DRM_DEBUG_KMS ("Encoder config failure\n" ); -return -EINVAL ; + ret = encoder->compute_config (encoder, pipe_config, + connector_state); +if (ret <0 ) { +if (ret != -EDEADLK ) +DRM_DEBUG_KMS ("Encoder config failure: %d\n" , + ret); +return ret; } }
drivers/gpu/drm/i915/intel_dp.c +16 -16
@@ -1905,10 +1905,10 @@ static int intel_dp_dsc_compute_bpp(struct intel_dp *intel_dp, u8 dsc_max_bpc)return 0 ; } -static bool intel_dp_dsc_compute_config (struct intel_dp *intel_dp, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state, -struct link_config_limits *limits) +static int intel_dp_dsc_compute_config (struct intel_dp *intel_dp, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state, +struct link_config_limits *limits) {struct intel_digital_port *dig_port =dp_to_dig_port (intel_dp);struct drm_i915_private *dev_priv =to_i915 (dig_port->base.base.dev);
@@ -1917,7 +1917,7 @@ static bool intel_dp_dsc_compute_config(struct intel_dp *intel_dp,int pipe_bpp;if (!intel_dp_supports_dsc (intel_dp, pipe_config)) -return false; +return -EINVAL ; dsc_max_bpc =min_t (u8,DP_DSC_MAX_SUPPORTED_BPC , conn_state->max_requested_bpc);
@@ -1925,7 +1925,7 @@ static bool intel_dp_dsc_compute_config(struct intel_dp *intel_dp, pipe_bpp =intel_dp_dsc_compute_bpp (intel_dp, dsc_max_bpc);if (pipe_bpp <DP_DSC_MIN_SUPPORTED_BPC *3 ) {DRM_DEBUG_KMS ("No DSC support for less than 8bpc\n" ); -return false; +return -EINVAL ; }/*
@@ -1959,7 +1959,7 @@ static bool intel_dp_dsc_compute_config(struct intel_dp *intel_dp, adjusted_mode->crtc_hdisplay);if (!dsc_max_output_bpp || !dsc_dp_slice_count) {DRM_DEBUG_KMS ("Compressed BPP/Slice Count not supported\n" ); -return false; +return -EINVAL ; } pipe_config->dsc_params.compressed_bpp = min_t(u16, dsc_max_output_bpp >> 4,
@@ -1976,7 +1976,7 @@ static bool intel_dp_dsc_compute_config(struct intel_dp *intel_dp, pipe_config->dsc_params.dsc_split = true; }else {DRM_DEBUG_KMS ("Cannot split stream to use 2 VDSC instances\n" ); -return false; +return -EINVAL ; } }if (intel_dp_compute_dsc_params (intel_dp, pipe_config) <0 ) {
@@ -1984,7 +1984,7 @@ static bool intel_dp_dsc_compute_config(struct intel_dp *intel_dp,"Compressed BPP = %d\n" , pipe_config->pipe_bpp, pipe_config->dsc_params.compressed_bpp); -return false; +return -EINVAL ; } pipe_config->dsc_params.compression_enable = true; DRM_DEBUG_KMS("DP DSC computed with Input Bpp = %d "
@@ -1993,7 +1993,7 @@ static bool intel_dp_dsc_compute_config(struct intel_dp *intel_dp, pipe_config->dsc_params.compressed_bpp, pipe_config->dsc_params.slice_count); -return true; +return 0 ; } static bool
@@ -2094,7 +2094,7 @@ intel_dp_compute_link_config(struct intel_encoder *encoder,return true; } -bool +int intel_dp_compute_config (struct intel_encoder *encoder,struct intel_crtc_state *pipe_config,struct drm_connector_state *conn_state)
@@ -2147,20 +2147,20 @@ intel_dp_compute_config(struct intel_encoder *encoder, }if (adjusted_mode->flags &DRM_MODE_FLAG_DBLSCAN ) -return false; +return -EINVAL ;if (HAS_GMCH_DISPLAY (dev_priv) && adjusted_mode->flags &DRM_MODE_FLAG_INTERLACE ) -return false; +return -EINVAL ;if (adjusted_mode->flags &DRM_MODE_FLAG_DBLCLK ) -return false; +return -EINVAL ; pipe_config->fec_enable = !intel_dp_is_edp (intel_dp) &&intel_dp_supports_fec (intel_dp, pipe_config);if (!intel_dp_compute_link_config (encoder, pipe_config, conn_state)) -return false; +return -ENOSPC ;if (intel_conn_state->broadcast_rgb ==INTEL_BROADCAST_RGB_AUTO ) {/*
@@ -2208,7 +2208,7 @@ intel_dp_compute_config(struct intel_encoder *encoder,intel_psr_compute_config (intel_dp, pipe_config); -return true; +return 0 ; } void intel_dp_set_link_params(struct intel_dp *intel_dp,
drivers/gpu/drm/i915/intel_dp_mst.c +6 -6
@@ -29,9 +29,9 @@#include <drm/drm_crtc_helper.h> #include <drm/drm_edid.h> -static bool intel_dp_mst_compute_config (struct intel_encoder *encoder, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state) +static int intel_dp_mst_compute_config (struct intel_encoder *encoder, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state) {struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev);struct intel_dp_mst_encoder *intel_mst =enc_to_mst (&encoder->base);
@@ -52,7 +52,7 @@ static bool intel_dp_mst_compute_config(struct intel_encoder *encoder, DP_DPCD_QUIRK_CONSTANT_N);if (adjusted_mode->flags &DRM_MODE_FLAG_DBLSCAN ) -return false; +return -EINVAL ; pipe_config->output_format =INTEL_OUTPUT_FORMAT_RGB ; pipe_config->has_pch_encoder = false;
@@ -89,7 +89,7 @@ static bool intel_dp_mst_compute_config(struct intel_encoder *encoder,if (slots <0 ) {DRM_DEBUG_KMS ("failed finding vcpi slots:%d\n" , slots); -return false; +return slots; } }
@@ -107,7 +107,7 @@ static bool intel_dp_mst_compute_config(struct intel_encoder *encoder,intel_ddi_compute_min_voltage_level (dev_priv, pipe_config); -return true; +return 0 ; } static int
drivers/gpu/drm/i915/intel_drv.h +9 -9
@@ -225,9 +225,9 @@ struct intel_encoder {enum intel_output_type (*compute_output_type)(struct intel_encoder *,struct intel_crtc_state *,struct drm_connector_state *); -bool (*compute_config)(struct intel_encoder *, -struct intel_crtc_state *, -struct drm_connector_state *); +int (*compute_config)(struct intel_encoder *, +struct intel_crtc_state *, +struct drm_connector_state *);void (*pre_pll_enable)(struct intel_encoder *,const struct intel_crtc_state *,const struct drm_connector_state *);
@@ -1816,9 +1816,9 @@ void intel_dp_sink_set_decompression_state(struct intel_dp *intel_dp,void intel_dp_encoder_reset (struct drm_encoder *encoder);void intel_dp_encoder_suspend (struct intel_encoder *intel_encoder);void intel_dp_encoder_flush_work (struct drm_encoder *encoder); -bool intel_dp_compute_config (struct intel_encoder *encoder, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state); +int intel_dp_compute_config (struct intel_encoder *encoder, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state);bool intel_dp_is_edp (struct intel_dp *intel_dp);bool intel_dp_is_port_edp (struct drm_i915_private *dev_priv,enum port port); enum irqreturn intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port,
@@ -1978,9 +1978,9 @@ void intel_hdmi_init(struct drm_i915_private *dev_priv, i915_reg_t hdmi_reg,void intel_hdmi_init_connector (struct intel_digital_port *intel_dig_port,struct intel_connector *intel_connector);struct intel_hdmi *enc_to_intel_hdmi (struct drm_encoder *encoder); -bool intel_hdmi_compute_config (struct intel_encoder *encoder, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state); +int intel_hdmi_compute_config (struct intel_encoder *encoder, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state); bool intel_hdmi_handle_sink_scrambling(struct intel_encoder *encoder, struct drm_connector *connector, bool high_tmds_clock_ratio,
drivers/gpu/drm/i915/intel_dvo.c +5 -5
@@ -234,9 +234,9 @@ intel_dvo_mode_valid(struct drm_connector *connector,return intel_dvo->dev.dev_ops->mode_valid (&intel_dvo->dev, mode); } -static bool intel_dvo_compute_config (struct intel_encoder *encoder, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state) +static int intel_dvo_compute_config (struct intel_encoder *encoder, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state) {struct intel_dvo *intel_dvo =enc_to_dvo (encoder); const struct drm_display_mode *fixed_mode =
@@ -253,10 +253,10 @@ static bool intel_dvo_compute_config(struct intel_encoder *encoder,intel_fixed_panel_mode (fixed_mode, adjusted_mode);if (adjusted_mode->flags &DRM_MODE_FLAG_DBLSCAN ) -return false; +return -EINVAL ; pipe_config->output_format =INTEL_OUTPUT_FORMAT_RGB ; -return true; +return 0 ; } static void intel_dvo_pre_enable(struct intel_encoder *encoder,
drivers/gpu/drm/i915/intel_hdmi.c +6 -6
@@ -1704,9 +1704,9 @@ intel_hdmi_ycbcr420_config(struct drm_connector *connector,return true; } -bool intel_hdmi_compute_config (struct intel_encoder *encoder, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state) +int intel_hdmi_compute_config (struct intel_encoder *encoder, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state) {struct intel_hdmi *intel_hdmi =enc_to_intel_hdmi (&encoder->base);struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev);
@@ -1722,7 +1722,7 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder,bool force_dvi = intel_conn_state->force_audio ==HDMI_AUDIO_OFF_DVI ;if (adjusted_mode->flags &DRM_MODE_FLAG_DBLSCAN ) -return false; +return -EINVAL ; pipe_config->output_format =INTEL_OUTPUT_FORMAT_RGB ; pipe_config->has_hdmi_sink = !force_dvi && intel_hdmi->has_hdmi_sink;
@@ -1753,7 +1753,7 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder, &clock_12bpc, &clock_10bpc, &clock_8bpc)) {DRM_ERROR ("Can't support YCBCR420 output\n" ); -return false; +return -EINVAL ; } }
@@ -1822,7 +1822,7 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder, } } -return true; +return 0 ; } static void
drivers/gpu/drm/i915/intel_lvds.c +6 -6
@@ -380,9 +380,9 @@ intel_lvds_mode_valid(struct drm_connector *connector,return MODE_OK ; } -static bool intel_lvds_compute_config (struct intel_encoder *intel_encoder, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state) +static int intel_lvds_compute_config (struct intel_encoder *intel_encoder, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state) {struct drm_i915_private *dev_priv =to_i915 (intel_encoder->base.dev); struct intel_lvds_encoder *lvds_encoder =
@@ -396,7 +396,7 @@ static bool intel_lvds_compute_config(struct intel_encoder *intel_encoder,/* Should never happen!! */ if (INTEL_GEN (dev_priv) <4 && intel_crtc->pipe ==0 ) {DRM_ERROR ("Can't support LVDS on pipe A\n" ); -return false; +return -EINVAL ; }if (lvds_encoder->a3_power ==LVDS_A3_POWER_UP )
@@ -422,7 +422,7 @@ static bool intel_lvds_compute_config(struct intel_encoder *intel_encoder, adjusted_mode);if (adjusted_mode->flags &DRM_MODE_FLAG_DBLSCAN ) -return false; +return -EINVAL ;if (HAS_PCH_SPLIT (dev_priv)) { pipe_config->has_pch_encoder = true;
@@ -441,7 +441,7 @@ static bool intel_lvds_compute_config(struct intel_encoder *intel_encoder,* user's requested refresh rate. */ -return true; +return 0 ; } static enum drm_connector_status
drivers/gpu/drm/i915/intel_sdvo.c +7 -7
@@ -1107,9 +1107,9 @@ static void i9xx_adjust_sdvo_tv_clock(struct intel_crtc_state *pipe_config) pipe_config->clock_set = true; } -static bool intel_sdvo_compute_config (struct intel_encoder *encoder, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state) +static int intel_sdvo_compute_config (struct intel_encoder *encoder, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state) {struct intel_sdvo *intel_sdvo =to_sdvo (encoder); struct intel_sdvo_connector_state *intel_sdvo_state =
@@ -1134,7 +1134,7 @@ static bool intel_sdvo_compute_config(struct intel_encoder *encoder,*/ if (IS_TV (intel_sdvo_connector)) {if (!intel_sdvo_set_output_timings_from_mode (intel_sdvo, mode)) -return false; +return -EINVAL ; (void) intel_sdvo_get_preferred_input_mode(intel_sdvo, intel_sdvo_connector,
@@ -1144,7 +1144,7 @@ static bool intel_sdvo_compute_config(struct intel_encoder *encoder, }else if (IS_LVDS (intel_sdvo_connector)) {if (!intel_sdvo_set_output_timings_from_mode (intel_sdvo, intel_sdvo_connector->base.panel.fixed_mode)) -return false; +return -EINVAL ; (void) intel_sdvo_get_preferred_input_mode(intel_sdvo, intel_sdvo_connector,
@@ -1153,7 +1153,7 @@ static bool intel_sdvo_compute_config(struct intel_encoder *encoder, }if (adjusted_mode->flags &DRM_MODE_FLAG_DBLSCAN ) -return false; +return -EINVAL ;/* * Make the CRTC code factor in the SDVO pixel multiplier. The
@@ -1193,7 +1193,7 @@ static bool intel_sdvo_compute_config(struct intel_encoder *encoder,if (intel_sdvo_connector->is_hdmi) adjusted_mode->picture_aspect_ratio = conn_state->picture_aspect_ratio; -return true; +return 0 ; }#define UPDATE_PROPERTY (input,NAME ) \
drivers/gpu/drm/i915/intel_tv.c +4 -4
@@ -869,7 +869,7 @@ intel_tv_get_config(struct intel_encoder *encoder, pipe_config->base.adjusted_mode.crtc_clock = pipe_config->port_clock; } -static bool +static int intel_tv_compute_config (struct intel_encoder *encoder,struct intel_crtc_state *pipe_config,struct drm_connector_state *conn_state)
@@ -879,10 +879,10 @@ intel_tv_compute_config(struct intel_encoder *encoder, &pipe_config->base.adjusted_mode;if (!tv_mode) -return false; +return -EINVAL ;if (adjusted_mode->flags &DRM_MODE_FLAG_DBLSCAN ) -return false; +return -EINVAL ; pipe_config->output_format =INTEL_OUTPUT_FORMAT_RGB ; adjusted_mode->crtc_clock = tv_mode->clock;
@@ -897,7 +897,7 @@ intel_tv_compute_config(struct intel_encoder *encoder,* or whether userspace is doing something stupid. */ -return true; +return 0 ; } static void
drivers/gpu/drm/i915/vlv_dsi.c +7 -7
@@ -256,9 +256,9 @@ static void band_gap_reset(struct drm_i915_private *dev_priv)mutex_unlock (&dev_priv->sb_lock); } -static bool intel_dsi_compute_config (struct intel_encoder *encoder, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state) +static int intel_dsi_compute_config (struct intel_encoder *encoder, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state) {struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev); struct intel_dsi *intel_dsi = container_of(encoder, struct intel_dsi,
@@ -284,7 +284,7 @@ static bool intel_dsi_compute_config(struct intel_encoder *encoder, }if (adjusted_mode->flags &DRM_MODE_FLAG_DBLSCAN ) -return false; +return -EINVAL ;/* DSI uses short packets for sync events, so clear mode flags for DSI */ adjusted_mode->flags =0 ;
@@ -302,16 +302,16 @@ static bool intel_dsi_compute_config(struct intel_encoder *encoder, ret =bxt_dsi_pll_compute (encoder, pipe_config);if (ret) -return false; +return -EINVAL ; }else { ret =vlv_dsi_pll_compute (encoder, pipe_config);if (ret) -return false; +return -EINVAL ; } pipe_config->clock_set = true; -return true; +return 0 ; }static bool glk_dsi_enable_io (struct intel_encoder *encoder)
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for drm/i915: Pass down rc in intel_encoder->compute_config()
== Series Details ==
== Series Details ==
Series: drm/i915: Pass down rc in intel_encoder->compute_config()
URL : https://patchwork.freedesktop.org/series/55203/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip ee32ce9c3146 drm/i915: Pass down rc in intel_encoder->compute_config() -:353: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_encoder *' should also have an identifier name #353: FILE: drivers/gpu/drm/i915/intel_drv.h:228: + int (*compute_config)(struct intel_encoder *,
-:353: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_crtc_state *' should also have an identifier name #353: FILE: drivers/gpu/drm/i915/intel_drv.h:228:
+ int (*compute_config)(struct intel_encoder *,
-:353: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct drm_connector_state *' should also have an identifier name #353: FILE: drivers/gpu/drm/i915/intel_drv.h:228:
+ int (*compute_config)(struct intel_encoder *,
total: 0 errors, 3 warnings, 0 checks, 512 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.SPARSE: warning for drm/i915: Pass down rc in intel_encoder->compute_config()
In reply to Lyude Paul== Series Details ==
== Series Details ==
Series: drm/i915: Pass down rc in intel_encoder->compute_config()
URL : https://patchwork.freedesktop.org/series/55203/
State : warning
== Summary ==
$ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Pass down rc in intel_encoder->compute_config() -O:drivers/gpu/drm/i915/intel_dp.c:1922:23: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_dp.c:1922:23: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_dp.c:1964:58: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_dp.c:1964:58: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_dp.c:1964:58: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_dp.c:1964:58: warning: expression using sizeof(void)
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Pass down rc in intel_encoder->compute_config()
In reply to Lyude Paul== Series Details ==
== Series Details ==
Series: drm/i915: Pass down rc in intel_encoder->compute_config()
URL : https://patchwork.freedesktop.org/series/55203/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5418 -> Patchwork_11295
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/55203/revisions/1/mbox/
Known issues
------------
Here are the changes found in Patchwork_11295 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@i915_selftest@live_evict:
- fi-bsw-kefka: PASS -> DMESG-WARN [fdo#107709]
* igt@i915_selftest@live_hangcheck:
- fi-bwr-2160: PASS -> DMESG-FAIL [fdo#108735]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
- fi-byt-clapper: NOTRUN -> FAIL [fdo#107362]
#### Possible fixes ####
* igt@debugfs_test@read_all_entries:
- fi-kbl-7567u: DMESG-WARN [fdo#103558] / [fdo#105602] -> PASS
* igt@i915_selftest@live_hangcheck:
- fi-skl-iommu: INCOMPLETE [fdo#108602] / [fdo#108744] -> PASS
* igt@prime_vgem@basic-fence-flip:
- fi-ilk-650: FAIL [fdo#104008] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#104008]: https://bugs.freedesktop.org/show_bug.cgi?id=104008
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107709]: https://bugs.freedesktop.org/show_bug.cgi?id=107709
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#108735]: https://bugs.freedesktop.org/show_bug.cgi?id=108735
[fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
[fdo#109241]: https://bugs.freedesktop.org/show_bug.cgi?id=109241
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
Participating hosts (41 -> 41)
------------------------------
Additional (5): fi-hsw-peppy fi-apl-guc fi-pnv-d510 fi-byt-clapper fi-skl-6700k2
Missing (5): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-bxt-j4205 fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_5418 -> Patchwork_11295
CI_DRM_5418: 845c8d109d2e0d6bb66b25fc859c5b931baf6da7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4770: 8cb8fd13d592d9821c59eb321b1766725f9d1b37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11295: ee32ce9c3146663a02507247dc5579cb841c1259 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
ee32ce9c3146 drm/i915: Pass down rc in intel_encoder->compute_config()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11295/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915: Pass down rc in intel_encoder->compute_config()
In reply to Lyude Paul== Series Details ==
== Series Details ==
Series: drm/i915: Pass down rc in intel_encoder->compute_config()
URL : https://patchwork.freedesktop.org/series/55203/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5418_full -> Patchwork_11295_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_11295_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@pi-ringfull-render:
- shard-skl: NOTRUN -> FAIL [fdo#103158]
* igt@gem_softpin@noreloc-s3:
- shard-skl: PASS -> INCOMPLETE [fdo#104108] / [fdo#107773]
* igt@gem_userptr_blits@readonly-unsync:
- shard-skl: PASS -> TIMEOUT [fdo#108887]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
- shard-glk: PASS -> DMESG-WARN [fdo#107956]
- shard-apl: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#107956] +2
* igt@kms_cursor_crc@cursor-256x256-dpms:
- shard-apl: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-64x64-onscreen:
- shard-glk: PASS -> FAIL [fdo#103232]
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: PASS -> FAIL [fdo#105363]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: PASS -> FAIL [fdo#103167] +2
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- shard-glk: PASS -> FAIL [fdo#103167]
* igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
- shard-apl: PASS -> FAIL [fdo#108948]
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: NOTRUN -> FAIL [fdo#107815]
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-glk: PASS -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb:
- shard-skl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: PASS -> FAIL [fdo#107815]
* igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
- shard-apl: PASS -> FAIL [fdo#103166] +2
#### Possible fixes ####
* igt@kms_busy@extended-modeset-hang-newfb-render-b:
- shard-hsw: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_cursor_crc@cursor-256x256-random:
- shard-apl: FAIL [fdo#103232] -> PASS +2
* igt@kms_cursor_crc@cursor-64x64-random:
- shard-glk: FAIL [fdo#103232] -> PASS +1
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-untiled:
- shard-skl: FAIL [fdo#103184] / [fdo#108472] -> PASS
* igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-apl: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: FAIL [fdo#103167] -> PASS +2
* igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-wc:
- shard-skl: FAIL [fdo#103167] -> PASS
* igt@kms_plane@pixel-format-pipe-b-planes:
- shard-glk: FAIL [fdo#103166] -> PASS
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS +1
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-glk: DMESG-WARN [fdo#105763] / [fdo#106538] -> PASS
* igt@kms_setmode@basic:
- shard-apl: FAIL [fdo#99912] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103158]: https://bugs.freedesktop.org/show_bug.cgi?id=103158
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108472]: https://bugs.freedesktop.org/show_bug.cgi?id=108472
[fdo#108887]: https://bugs.freedesktop.org/show_bug.cgi?id=108887
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 6)
------------------------------
Missing (1): shard-iclb
Build changes
-------------
* Linux: CI_DRM_5418 -> Patchwork_11295
CI_DRM_5418: 845c8d109d2e0d6bb66b25fc859c5b931baf6da7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4770: 8cb8fd13d592d9821c59eb321b1766725f9d1b37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11295: ee32ce9c3146663a02507247dc5579cb841c1259 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11295/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 73 lines · Lyude Paul
Something that I completely missed when implementing the new MST VCPI atomic helpers is that with those helpers, there's technically a chance of us having to grab additional modeset locks in ->compute_config() and furthermore, that means we have the potential to hit a normal modeset deadlock. However, because ->compute_config() only returns a bool this means we can't return
-EDEADLKwhen we need to drop locks and try again which means we end up just failing the atomic check permanently. Whoops.So, fix this by modifying ->compute_config() to pass down an actual error code instead of a bool so that the atomic check can be restarted on modeset deadlocks.
Thanks to Ville Syrjälä for pointing this out!
Signed-off-by Lyude Paul <[email protected]>Cc Ville Syrjälä <[email protected]>Fixes eceae1472467 ("drm/dp_mst: Start tracking per-port VCPI allocations")Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109320
--- drivers/gpu/drm/i915/icl_dsi.c | 8 +++---- drivers/gpu/drm/i915/intel_crt.c | 34 ++++++++++++++-------------- drivers/gpu/drm/i915/intel_ddi.c | 6 ++--- drivers/gpu/drm/i915/intel_display.c | 11 +++++---- drivers/gpu/drm/i915/intel_dp.c | 32 +++++++++++++------------- drivers/gpu/drm/i915/intel_dp_mst.c | 12 +++++----- drivers/gpu/drm/i915/intel_drv.h | 18 +++++++-------- drivers/gpu/drm/i915/intel_dvo.c | 10 ++++---- drivers/gpu/drm/i915/intel_hdmi.c | 12 +++++----- drivers/gpu/drm/i915/intel_lvds.c | 12 +++++----- drivers/gpu/drm/i915/intel_sdvo.c | 14 ++++++------ drivers/gpu/drm/i915/intel_tv.c | 8 +++---- drivers/gpu/drm/i915/vlv_dsi.c | 14 ++++++------ 13 files changed, 97 insertions(+), 94 deletions(-)drivers/gpu/drm/i915/icl_dsi.c +4
-4@@ -1188,9 +1188,9 @@ static void gen11_dsi_get_config(struct intel_encoder *encoder, pipe_config->output_types |=BIT (INTEL_OUTPUT_DSI ); } -static bool gen11_dsi_compute_config (struct intel_encoder *encoder, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state) +static int gen11_dsi_compute_config (struct intel_encoder *encoder, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state) { struct intel_dsi *intel_dsi = container_of(encoder, struct intel_dsi, base);@@ -1215,7 +1215,7 @@ static bool gen11_dsi_compute_config(struct intel_encoder *encoder, pipe_config->clock_set = true; pipe_config->port_clock =intel_dsi_bitrate (intel_dsi) /5 ; -return true; +return 0 ; } static u64 gen11_dsi_get_power_domains(struct intel_encoder *encoder,drivers/gpu/drm/i915/intel_crt.c +2
-3@@ -345,51 +345,51 @@ intel_crt_mode_valid(struct drm_connector *connector,return MODE_OK ; } -static bool intel_crt_compute_config (struct intel_encoder *encoder, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state) +static int intel_crt_compute_config(struct intel_encoder *encoder, + struct intel_crtc_state *pipe_config,
drivers/gpu/drm/i915/intel_crt.c intel_crt_mode_valid(struct drm_connector *connector, · line 358
Quoted 10 lines
drivers/gpu/drm/i915/intel_crt.c +2
-1+ struct drm_connector_state *conn_state) {struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;if (adjusted_mode->flags &DRM_MODE_FLAG_DBLSCAN ) -return false; +return -EINVAL ; pipe_config->output_format =INTEL_OUTPUT_FORMAT_RGB ;
Please add a newline here while at it.
Quoted 35 lines
drivers/gpu/drm/i915/intel_crt.c +9
-9-return true; +return 0 ; } -static bool pch_crt_compute_config (struct intel_encoder *encoder, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state) +static int pch_crt_compute_config (struct intel_encoder *encoder, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state) {struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;if (adjusted_mode->flags &DRM_MODE_FLAG_DBLSCAN ) -return false; +return -EINVAL ; pipe_config->has_pch_encoder = true; pipe_config->output_format =INTEL_OUTPUT_FORMAT_RGB ; -return true; +return 0 ; } -static bool hsw_crt_compute_config (struct intel_encoder *encoder, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state) +static int hsw_crt_compute_config (struct intel_encoder *encoder, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state) {struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev);struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
drivers/gpu/drm/i915/intel_crt.c intel_crt_mode_valid(struct drm_connector *connector, · line 392
Quoted 10 lines
drivers/gpu/drm/i915/intel_crt.c +2
-2if (adjusted_mode->flags &DRM_MODE_FLAG_DBLSCAN ) -return false; +return -EINVAL ;/* HSW/BDW FDI limited to 4k */ if (adjusted_mode->crtc_hdisplay >4096 || adjusted_mode->crtc_hblank_start >4096 ) -return false; +return -ENOSPC ;
I'd go with -EINVAL here.
Quoted 28 lines
drivers/gpu/drm/i915/intel_crt.c +2
-2pipe_config->has_pch_encoder = true; pipe_config->output_format =INTEL_OUTPUT_FORMAT_RGB ;@@ -398,7 +398,7 @@ static bool hsw_crt_compute_config(struct intel_encoder *encoder,if (HAS_PCH_LPT (dev_priv)) {if (pipe_config->bw_constrained && pipe_config->pipe_bpp <24 ) {DRM_DEBUG_KMS ("LPT only supports 24bpp\n" ); -return false; +return -EINVAL ; } pipe_config->pipe_bpp =24 ;@@ -407,7 +407,7 @@ static bool hsw_crt_compute_config(struct intel_encoder *encoder,/* FDI must always be 2.7 GHz */ pipe_config->port_clock =135000 *2 ; -return true; +return 0 ; }static bool intel_ironlake_crt_detect_hotplug (struct drm_connector *connector)drivers/gpu/drm/i915/intel_ddi.c +0
-0@@ -3837,9 +3837,9 @@ intel_ddi_compute_output_type(struct intel_encoder *encoder, } }
drivers/gpu/drm/i915/intel_ddi.c intel_ddi_compute_output_type(struct intel_encoder *encoder, · line 3845
Quoted 10 lines
drivers/gpu/drm/i915/intel_ddi.c +3
-3-static bool intel_ddi_compute_config (struct intel_encoder *encoder, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state) +static int intel_ddi_compute_config (struct intel_encoder *encoder, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state) {struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev);enum port port = encoder->port;
Hmm. At first glance I was rather confused that you didn't change anything here, but indeed this guy already does what we want.
Quoted 78 lines
drivers/gpu/drm/i915/intel_display.c +7
-4@@ -11550,10 +11550,13 @@ intel_modeset_pipe_config(struct drm_crtc *crtc,continue ; encoder =to_intel_encoder (connector_state->best_encoder); - -if (!(encoder->compute_config (encoder, pipe_config, connector_state))) { -DRM_DEBUG_KMS ("Encoder config failure\n" ); -return -EINVAL ; + ret = encoder->compute_config (encoder, pipe_config, + connector_state); +if (ret <0 ) { +if (ret != -EDEADLK ) +DRM_DEBUG_KMS ("Encoder config failure: %d\n" , + ret); +return ret; } }drivers/gpu/drm/i915/intel_dp.c +8
-8@@ -1905,10 +1905,10 @@ static int intel_dp_dsc_compute_bpp(struct intel_dp *intel_dp, u8 dsc_max_bpc)return 0 ; } -static bool intel_dp_dsc_compute_config (struct intel_dp *intel_dp, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state, -struct link_config_limits *limits) +static int intel_dp_dsc_compute_config (struct intel_dp *intel_dp, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state, +struct link_config_limits *limits) {struct intel_digital_port *dig_port =dp_to_dig_port (intel_dp);struct drm_i915_private *dev_priv =to_i915 (dig_port->base.base.dev);@@ -1917,7 +1917,7 @@ static bool intel_dp_dsc_compute_config(struct intel_dp *intel_dp,int pipe_bpp;if (!intel_dp_supports_dsc (intel_dp, pipe_config)) -return false; +return -EINVAL ; dsc_max_bpc =min_t (u8,DP_DSC_MAX_SUPPORTED_BPC , conn_state->max_requested_bpc);@@ -1925,7 +1925,7 @@ static bool intel_dp_dsc_compute_config(struct intel_dp *intel_dp, pipe_bpp =intel_dp_dsc_compute_bpp (intel_dp, dsc_max_bpc);if (pipe_bpp <DP_DSC_MIN_SUPPORTED_BPC *3 ) {DRM_DEBUG_KMS ("No DSC support for less than 8bpc\n" ); -return false; +return -EINVAL ; }/* @@ -1959,7 +1959,7 @@ static bool intel_dp_dsc_compute_config(struct intel_dp *intel_dp, adjusted_mode->crtc_hdisplay);if (!dsc_max_output_bpp || !dsc_dp_slice_count) {DRM_DEBUG_KMS ("Compressed BPP/Slice Count not supported\n" ); -return false; +return -EINVAL ; } pipe_config->dsc_params.compressed_bpp = min_t(u16, dsc_max_output_bpp >> 4,@@ -1976,7 +1976,7 @@ static bool intel_dp_dsc_compute_config(struct intel_dp *intel_dp, pipe_config->dsc_params.dsc_split = true; }else {DRM_DEBUG_KMS ("Cannot split stream to use 2 VDSC instances\n" ); -return false; +return -EINVAL ; } }if (intel_dp_compute_dsc_params (intel_dp, pipe_config) <0 ) {
drivers/gpu/drm/i915/intel_dp.c static bool intel_dp_dsc_compute_config(struct intel_dp *intel_dp, · line 1987
Quoted 5 lines
drivers/gpu/drm/i915/intel_dp.c +1
-1@@ -1984,7 +1984,7 @@ static bool intel_dp_dsc_compute_config(struct intel_dp *intel_dp,"Compressed BPP = %d\n" , pipe_config->pipe_bpp, pipe_config->dsc_params.compressed_bpp); -return false; +return -EINVAL ;
Here we can propagate the return value fromintel_dp_compute_dsc_params() upwards.
Quoted 13 lines
drivers/gpu/drm/i915/intel_dp.c +1
-1} pipe_config->dsc_params.compression_enable = true; DRM_DEBUG_KMS("DP DSC computed with Input Bpp = %d "@@ -1993,7 +1993,7 @@ static bool intel_dp_dsc_compute_config(struct intel_dp *intel_dp, pipe_config->dsc_params.compressed_bpp, pipe_config->dsc_params.slice_count); -return true; +return 0 ; } static bool
drivers/gpu/drm/i915/intel_dp.c intel_dp_compute_link_config(struct intel_encoder *encoder, · line 2095
Quoted 2 lines
drivers/gpu/drm/i915/intel_dp.c +0
-0@@ -2094,7 +2094,7 @@ intel_dp_compute_link_config(struct intel_encoder *encoder,return true; }
You changed intel_dp_dsc_compute_config() but didn't update the caller? Probably best to change all the intel_dp_compute_link_config*() functions to return an int as well for consistency.
drivers/gpu/drm/i915/intel_dp.c intel_dp_compute_config(struct intel_encoder *encoder,
Quoted 7 lines
drivers/gpu/drm/i915/intel_dp.c +1
-1-bool +int intel_dp_compute_config (struct intel_encoder *encoder,struct intel_crtc_state *pipe_config,struct drm_connector_state *conn_state)@@ -2147,20 +2147,20 @@ intel_dp_compute_config(struct intel_encoder *encoder,
Oh wow. I just noticed that a1b2278e4dfc ("drm/i915: skylake panel fitting using shared scalers") already assumed that .compute_config() returns an int. That might even explain some oddball scaler fails people have seen.
Quoted 138 lines
drivers/gpu/drm/i915/intel_dp.c +5
-5}if (adjusted_mode->flags &DRM_MODE_FLAG_DBLSCAN ) -return false; +return -EINVAL ;if (HAS_GMCH_DISPLAY (dev_priv) && adjusted_mode->flags &DRM_MODE_FLAG_INTERLACE ) -return false; +return -EINVAL ;if (adjusted_mode->flags &DRM_MODE_FLAG_DBLCLK ) -return false; +return -EINVAL ; pipe_config->fec_enable = !intel_dp_is_edp (intel_dp) &&intel_dp_supports_fec (intel_dp, pipe_config);if (!intel_dp_compute_link_config (encoder, pipe_config, conn_state)) -return false; +return -ENOSPC ;if (intel_conn_state->broadcast_rgb ==INTEL_BROADCAST_RGB_AUTO ) {/* @@ -2208,7 +2208,7 @@ intel_dp_compute_config(struct intel_encoder *encoder,intel_psr_compute_config (intel_dp, pipe_config); -return true; +return 0 ; } void intel_dp_set_link_params(struct intel_dp *intel_dp,drivers/gpu/drm/i915/intel_dp_mst.c +6
-6@@ -29,9 +29,9 @@#include <drm/drm_crtc_helper.h> #include <drm/drm_edid.h> -static bool intel_dp_mst_compute_config (struct intel_encoder *encoder, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state) +static int intel_dp_mst_compute_config (struct intel_encoder *encoder, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state) {struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev);struct intel_dp_mst_encoder *intel_mst =enc_to_mst (&encoder->base);@@ -52,7 +52,7 @@ static bool intel_dp_mst_compute_config(struct intel_encoder *encoder, DP_DPCD_QUIRK_CONSTANT_N);if (adjusted_mode->flags &DRM_MODE_FLAG_DBLSCAN ) -return false; +return -EINVAL ; pipe_config->output_format =INTEL_OUTPUT_FORMAT_RGB ; pipe_config->has_pch_encoder = false;@@ -89,7 +89,7 @@ static bool intel_dp_mst_compute_config(struct intel_encoder *encoder,if (slots <0 ) {DRM_DEBUG_KMS ("failed finding vcpi slots:%d\n" , slots); -return false; +return slots; } }@@ -107,7 +107,7 @@ static bool intel_dp_mst_compute_config(struct intel_encoder *encoder,intel_ddi_compute_min_voltage_level (dev_priv, pipe_config); -return true; +return 0 ; } static intdrivers/gpu/drm/i915/intel_drv.h +9
-9@@ -225,9 +225,9 @@ struct intel_encoder {enum intel_output_type (*compute_output_type)(struct intel_encoder *,struct intel_crtc_state *,struct drm_connector_state *); -bool (*compute_config)(struct intel_encoder *, -struct intel_crtc_state *, -struct drm_connector_state *); +int (*compute_config)(struct intel_encoder *, +struct intel_crtc_state *, +struct drm_connector_state *);void (*pre_pll_enable)(struct intel_encoder *,const struct intel_crtc_state *,const struct drm_connector_state *);@@ -1816,9 +1816,9 @@ void intel_dp_sink_set_decompression_state(struct intel_dp *intel_dp,void intel_dp_encoder_reset (struct drm_encoder *encoder);void intel_dp_encoder_suspend (struct intel_encoder *intel_encoder);void intel_dp_encoder_flush_work (struct drm_encoder *encoder); -bool intel_dp_compute_config (struct intel_encoder *encoder, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state); +int intel_dp_compute_config (struct intel_encoder *encoder, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state);bool intel_dp_is_edp (struct intel_dp *intel_dp);bool intel_dp_is_port_edp (struct drm_i915_private *dev_priv,enum port port); enum irqreturn intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port,@@ -1978,9 +1978,9 @@ void intel_hdmi_init(struct drm_i915_private *dev_priv, i915_reg_t hdmi_reg,void intel_hdmi_init_connector (struct intel_digital_port *intel_dig_port,struct intel_connector *intel_connector);struct intel_hdmi *enc_to_intel_hdmi (struct drm_encoder *encoder); -bool intel_hdmi_compute_config (struct intel_encoder *encoder, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state); +int intel_hdmi_compute_config (struct intel_encoder *encoder, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state); bool intel_hdmi_handle_sink_scrambling(struct intel_encoder *encoder, struct drm_connector *connector, bool high_tmds_clock_ratio,drivers/gpu/drm/i915/intel_dvo.c +3
-3@@ -234,9 +234,9 @@ intel_dvo_mode_valid(struct drm_connector *connector,return intel_dvo->dev.dev_ops->mode_valid (&intel_dvo->dev, mode); } -static bool intel_dvo_compute_config (struct intel_encoder *encoder, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state) +static int intel_dvo_compute_config (struct intel_encoder *encoder, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state) {struct intel_dvo *intel_dvo =enc_to_dvo (encoder); const struct drm_display_mode *fixed_mode =
drivers/gpu/drm/i915/intel_dvo.c static bool intel_dvo_compute_config(struct intel_encoder *encoder, · line 258
Quoted 7 lines
drivers/gpu/drm/i915/intel_dvo.c +1
-1@@ -253,10 +253,10 @@ static bool intel_dvo_compute_config(struct intel_encoder *encoder,intel_fixed_panel_mode (fixed_mode, adjusted_mode);if (adjusted_mode->flags &DRM_MODE_FLAG_DBLSCAN ) -return false; +return -EINVAL ; pipe_config->output_format =INTEL_OUTPUT_FORMAT_RGB ;
Please add a newline here while at it.
Quoted 32 lines
drivers/gpu/drm/i915/intel_dvo.c +1
-1-return true; +return 0 ; } static void intel_dvo_pre_enable(struct intel_encoder *encoder,drivers/gpu/drm/i915/intel_hdmi.c +4
-4@@ -1704,9 +1704,9 @@ intel_hdmi_ycbcr420_config(struct drm_connector *connector,return true; } -bool intel_hdmi_compute_config (struct intel_encoder *encoder, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state) +int intel_hdmi_compute_config (struct intel_encoder *encoder, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state) {struct intel_hdmi *intel_hdmi =enc_to_intel_hdmi (&encoder->base);struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev);@@ -1722,7 +1722,7 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder,bool force_dvi = intel_conn_state->force_audio ==HDMI_AUDIO_OFF_DVI ;if (adjusted_mode->flags &DRM_MODE_FLAG_DBLSCAN ) -return false; +return -EINVAL ; pipe_config->output_format =INTEL_OUTPUT_FORMAT_RGB ; pipe_config->has_hdmi_sink = !force_dvi && intel_hdmi->has_hdmi_sink;
drivers/gpu/drm/i915/intel_hdmi.c bool intel_hdmi_compute_config(struct intel_encoder *encoder, · line 1759
Quoted 8 lines
drivers/gpu/drm/i915/intel_hdmi.c +1
-1@@ -1753,7 +1753,7 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder, &clock_12bpc, &clock_10bpc, &clock_8bpc)) {DRM_ERROR ("Can't support YCBCR420 output\n" ); -return false; +return -EINVAL ; } }
Looks like you missed the if(hdmi_port_clock_valid()) branch here.
Quoted 189 lines
drivers/gpu/drm/i915/intel_hdmi.c +1
-1@@ -1822,7 +1822,7 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder, } } -return true; +return 0 ; } static voiddrivers/gpu/drm/i915/intel_lvds.c +6
-6@@ -380,9 +380,9 @@ intel_lvds_mode_valid(struct drm_connector *connector,return MODE_OK ; } -static bool intel_lvds_compute_config (struct intel_encoder *intel_encoder, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state) +static int intel_lvds_compute_config (struct intel_encoder *intel_encoder, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state) {struct drm_i915_private *dev_priv =to_i915 (intel_encoder->base.dev); struct intel_lvds_encoder *lvds_encoder =@@ -396,7 +396,7 @@ static bool intel_lvds_compute_config(struct intel_encoder *intel_encoder,/* Should never happen!! */ if (INTEL_GEN (dev_priv) <4 && intel_crtc->pipe ==0 ) {DRM_ERROR ("Can't support LVDS on pipe A\n" ); -return false; +return -EINVAL ; }if (lvds_encoder->a3_power ==LVDS_A3_POWER_UP )@@ -422,7 +422,7 @@ static bool intel_lvds_compute_config(struct intel_encoder *intel_encoder, adjusted_mode);if (adjusted_mode->flags &DRM_MODE_FLAG_DBLSCAN ) -return false; +return -EINVAL ;if (HAS_PCH_SPLIT (dev_priv)) { pipe_config->has_pch_encoder = true;@@ -441,7 +441,7 @@ static bool intel_lvds_compute_config(struct intel_encoder *intel_encoder,* user's requested refresh rate. */ -return true; +return 0 ; } static enum drm_connector_statusdrivers/gpu/drm/i915/intel_sdvo.c +7
-7@@ -1107,9 +1107,9 @@ static void i9xx_adjust_sdvo_tv_clock(struct intel_crtc_state *pipe_config) pipe_config->clock_set = true; } -static bool intel_sdvo_compute_config (struct intel_encoder *encoder, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state) +static int intel_sdvo_compute_config (struct intel_encoder *encoder, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state) {struct intel_sdvo *intel_sdvo =to_sdvo (encoder); struct intel_sdvo_connector_state *intel_sdvo_state =@@ -1134,7 +1134,7 @@ static bool intel_sdvo_compute_config(struct intel_encoder *encoder,*/ if (IS_TV (intel_sdvo_connector)) {if (!intel_sdvo_set_output_timings_from_mode (intel_sdvo, mode)) -return false; +return -EINVAL ; (void) intel_sdvo_get_preferred_input_mode(intel_sdvo, intel_sdvo_connector,@@ -1144,7 +1144,7 @@ static bool intel_sdvo_compute_config(struct intel_encoder *encoder, }else if (IS_LVDS (intel_sdvo_connector)) {if (!intel_sdvo_set_output_timings_from_mode (intel_sdvo, intel_sdvo_connector->base.panel.fixed_mode)) -return false; +return -EINVAL ; (void) intel_sdvo_get_preferred_input_mode(intel_sdvo, intel_sdvo_connector,@@ -1153,7 +1153,7 @@ static bool intel_sdvo_compute_config(struct intel_encoder *encoder, }if (adjusted_mode->flags &DRM_MODE_FLAG_DBLSCAN ) -return false; +return -EINVAL ;/* * Make the CRTC code factor in the SDVO pixel multiplier. The @@ -1193,7 +1193,7 @@ static bool intel_sdvo_compute_config(struct intel_encoder *encoder,if (intel_sdvo_connector->is_hdmi) adjusted_mode->picture_aspect_ratio = conn_state->picture_aspect_ratio; -return true; +return 0 ; }#define UPDATE_PROPERTY (input,NAME ) \drivers/gpu/drm/i915/intel_tv.c +4
-4@@ -869,7 +869,7 @@ intel_tv_get_config(struct intel_encoder *encoder, pipe_config->base.adjusted_mode.crtc_clock = pipe_config->port_clock; } -static bool +static int intel_tv_compute_config (struct intel_encoder *encoder,struct intel_crtc_state *pipe_config,struct drm_connector_state *conn_state)@@ -879,10 +879,10 @@ intel_tv_compute_config(struct intel_encoder *encoder, &pipe_config->base.adjusted_mode;if (!tv_mode) -return false; +return -EINVAL ;if (adjusted_mode->flags &DRM_MODE_FLAG_DBLSCAN ) -return false; +return -EINVAL ; pipe_config->output_format =INTEL_OUTPUT_FORMAT_RGB ; adjusted_mode->crtc_clock = tv_mode->clock;@@ -897,7 +897,7 @@ intel_tv_compute_config(struct intel_encoder *encoder,* or whether userspace is doing something stupid. */ -return true; +return 0 ; } static voiddrivers/gpu/drm/i915/vlv_dsi.c +7
-7@@ -256,9 +256,9 @@ static void band_gap_reset(struct drm_i915_private *dev_priv)mutex_unlock (&dev_priv->sb_lock); } -static bool intel_dsi_compute_config (struct intel_encoder *encoder, -struct intel_crtc_state *pipe_config, -struct drm_connector_state *conn_state) +static int intel_dsi_compute_config (struct intel_encoder *encoder, +struct intel_crtc_state *pipe_config, +struct drm_connector_state *conn_state) {struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev); struct intel_dsi *intel_dsi = container_of(encoder, struct intel_dsi,@@ -284,7 +284,7 @@ static bool intel_dsi_compute_config(struct intel_encoder *encoder, }if (adjusted_mode->flags &DRM_MODE_FLAG_DBLSCAN ) -return false; +return -EINVAL ;/* DSI uses short packets for sync events, so clear mode flags for DSI */ adjusted_mode->flags =0 ;@@ -302,16 +302,16 @@ static bool intel_dsi_compute_config(struct intel_encoder *encoder, ret =bxt_dsi_pll_compute (encoder, pipe_config);if (ret) -return false; +return -EINVAL ; }else { ret =vlv_dsi_pll_compute (encoder, pipe_config);if (ret) -return false; +return -EINVAL ; } pipe_config->clock_set = true; -return true; +return 0 ; }static bool glk_dsi_enable_io (struct intel_encoder *encoder)Signature · 1 line
2.20.1
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel