drm/amdgpu: Replace kzalloc with kcalloc
Subsystems (3)
PATCH 1/1 drm/amdgpu: Replace kzalloc with kcalloc
Replace kzalloc() function with its 2-factor argument form, kcalloc().
This patch replaces cases of:
kzalloc(a * b, gfp)
with:
kcalloc(a, b, gfp)
Also, improve the coding style and the use of sizeof during allocation by changing sizeof(struct dc_surface_update) and sizeof(struct dc_plane_state) to sizeof(*updates) and sizeof(*surfaces), correspondingly.
This code was detected with the help of Coccinelle.
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +5 -2
@@ -5782,11 +5782,14 @@ dm_determine_update_type_for_commit(struct dc *dc,struct dm_crtc_state *new_dm_crtc_state, *old_dm_crtc_state;struct dc_stream_status *status =NULL ; -struct dc_surface_update *updates =kzalloc (MAX_SURFACES *sizeof (struct dc_surface_update ),GFP_KERNEL ); -struct dc_plane_state *surface =kzalloc (MAX_SURFACES *sizeof (struct dc_plane_state ),GFP_KERNEL ); +struct dc_surface_update *updates; +struct dc_plane_state *surface;struct dc_stream_update stream_update;enum surface_update_type update_type =UPDATE_TYPE_FAST ; + updates =kcalloc (MAX_SURFACES ,sizeof (*updates),GFP_KERNEL ); + surface =kcalloc (MAX_SURFACES ,sizeof (*surface),GFP_KERNEL ); +if (!updates || !surface) {DRM_ERROR ("Plane or surface update failed to allocate" );/* Set type to FULL to avoid crashing in DC*/
Signature · 1 line
2.20.1
Alex Deucher
AppliedQuoted 10 lines · Gustavo A. R. Silva
Replace
kzalloc()function with its 2-factor argument form,kcalloc().This patch replaces cases of:
kzalloc(a * b, gfp)with:
kcalloc(a, b, gfp)
Quoted 8 lines
Also, improve the coding style and the use of sizeof during allocation by changing
sizeof(struct dc_surface_update)andsizeof(struct dc_plane_state)tosizeof(*updates)andsizeof(*surfaces), correspondingly.This code was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied. thanks!
Alex
Quoted 28 lines
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +5
-3@@ -5782,11 +5782,14 @@ dm_determine_update_type_for_commit(struct dc *dc,struct dm_crtc_state *new_dm_crtc_state, *old_dm_crtc_state;struct dc_stream_status *status =NULL ; -struct dc_surface_update *updates =kzalloc (MAX_SURFACES *sizeof (struct dc_surface_update ),GFP_KERNEL ); -struct dc_plane_state *surface =kzalloc (MAX_SURFACES *sizeof (struct dc_plane_state ),GFP_KERNEL ); +struct dc_surface_update *updates; +struct dc_plane_state *surface;struct dc_stream_update stream_update;enum surface_update_type update_type =UPDATE_TYPE_FAST ; + updates =kcalloc (MAX_SURFACES ,sizeof (*updates),GFP_KERNEL ); + surface =kcalloc (MAX_SURFACES ,sizeof (*surface),GFP_KERNEL ); +if (!updates || !surface) {DRM_ERROR ("Plane or surface update failed to allocate" );/* Set type to FULL to avoid crashing in DC*/ --2.20.1
Quoted 4 lines
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel