Skip to contentSkip to conversation

dmaengine: Add Synopsys eDMA IP PCIe glue-logic

RFC Superseded Andy Shevchenko 1 participant 1 message Jan 15, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

RFC v3 5/7 dmaengine: Add Synopsys eDMA IP PCIe glue-logic

Quoted 10 lines · Gustavo Pimentel
Quoted 8 lines · Andy Shevchenko

Review

Quoted 3 lines · Gustavo Pimentel
(quoted diff) +3 -0
+static bool disable_msix;
+module_param(disable_msix, bool, 0644);
+MODULE_PARM_DESC(disable_msix, "Disable MSI-X interrupts");

Why?!
We are no allow new module parameters without very strong arguments.

Quoted 6 lines

Since this is a reference driver and might be used to test customized HW solutions, I added this parameter to allow the possibility to test the solution forcing the MSI feature binding. This is required specially if who will test this solution has a Root Complex with both features available (MSI and MSI-X), because the Kernel will give always preference to MSI-X binding (assuming that the EP has also both features available).

Yes, you may do it for testing purposes, but it doesn't fit the kernel standards.

Quoted 9 lines
Quoted 6 lines

Review

Quoted 4 lines
(quoted diff) +4 -0
+	if (!pdata) {
+		dev_err(dev, "%s missing data structure\n", pci_name(pdev));
+		return -EFAULT;
+	}

Useless check.

Why? It's just a precaution, isn't it a good practice always to think of the worst case?

You just can put an implicit requirement of pdata rather than doing this useless check. I don't believe it would make sense to have NULL pdata for the driver since it wouldn't be functional anyhow.

Quoted 10 lines
Quoted 9 lines
Quoted 9 lines
(quoted diff) +8 -0
+	/* Mapping PCI BAR regions */
+	err = pcim_iomap_regions(pdev, BIT(pdata->rg_bar) |
+				       BIT(pdata->ll_bar) |
+				       BIT(pdata->dt_bar),
+				 pci_name(pdev));
+	if (err) {
 
+		return err;
+	}
Quoted 7 lines
Quoted 4 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+	if (!pcim_iomap_table(pdev))
+		return -EACCES;

Never happen condition. Thus useless.

pcim_iomap_table() can return NULL in case of allocation failure. Besides that, isn't it a good practice always to think of the worst case?

No, it can't in the conditions your have in the code. See above the lines I left. If pcim_iomap_regions() successfully finished...

Quoted 5 lines
Quoted 3 lines

Review

Quoted 1 line
(quoted diff) +1 -0
+	dev_info(dev, "DesignWare eDMA PCIe driver loaded completely\n");

Useless.

It's helpful for bring up, I can pass it to dbg.

It just shows that someone didn't use existing tools and features. This message and similar are useless.
Hint: initcall_debug.

Quoted 5 lines
Quoted 3 lines

Review

Quoted 1 line
(quoted diff) +1 -0
+	dev_info(dev, "DesignWare eDMA PCIe driver unloaded completely\n");

Ditto.

It's helpful for bring up, I can pass it to dbg.

Ditto.