Skip to contentSkip to conversation

vhost_user: remove statement for non-existed function

PATCH Superseded Xiaolong Ye 3 participants 6 messages Jan 11, 2019 – Jan 17, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vhost_user: remove statement for non-existed function

vhost_user_host_notifier_ctrl is not existed anymore, its statement in header file should be removed accordingly.

Fixes 43f34e35663f ("vhost: provide helper for host notifier ctrl")
---
 lib/librte_vhost/vhost_user.h | 1 -
 1 file changed, 1 deletion(-)
lib/librte_vhost/vhost_user.h +0 -1
index dc97be843..2a650fe4b 100644
@@ -148,7 +148,6 @@ typedef struct VhostUserMsg {
 /* vhost_user.c */
 int vhost_user_msg_handler(int vid, int fd);
 int vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm);
-int vhost_user_host_notifier_ctrl(int vid, bool enable);
 
 /* socket.c */
 int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds,
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 1 line

vhost_user: remove statement for non-existed function

s/vhost_user/vhost/

Quoted 6 lines · Xiaolong Ye

vhost_user_host_notifier_ctrl is not existed anymore, its statement in header file should be removed accordingly.

Fixes 43f34e35663f ("vhost: provide helper for host notifier ctrl")

There is no need to cc stable, because above commit is part of 19.02 which hasn't been released yet.

For the rest,

Quoted 21 lines
---
 lib/librte_vhost/vhost_user.h | 1 -
 1 file changed, 1 deletion(-)
lib/librte_vhost/vhost_user.h +0 -1
index dc97be843..2a650fe4b 100644
@@ -148,7 +148,6 @@ typedef struct VhostUserMsg {
 /* vhost_user.c */
 int vhost_user_msg_handler(int vid, int fd);
 int vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm);
-int vhost_user_host_notifier_ctrl(int vid, bool enable);
 
 /* socket.c */
 int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds,
Signature · 1 line
2.17.1
#2 lore raw
Quoted 12 lines · Tiwei Bie
Quoted 1 line

vhost_user: remove statement for non-existed function

s/vhost_user/vhost/

Quoted 6 lines · Xiaolong Ye

vhost_user_host_notifier_ctrl is not existed anymore, its statement in header file should be removed accordingly.

Fixes 43f34e35663f ("vhost: provide helper for host notifier ctrl")
Quoted 5 lines

There is no need to cc stable, because above commit is part of 19.02 which hasn't been released yet.

For the rest,

Thanks for the review.
In this kind of case, I suppose there is no need to reroll the patch, right?

Thanks,
Xiaolong

Quoted 22 lines
Quoted 22 lines
---
 lib/librte_vhost/vhost_user.h | 1 -
 1 file changed, 1 deletion(-)
lib/librte_vhost/vhost_user.h +0 -1
index dc97be843..2a650fe4b 100644
@@ -148,7 +148,6 @@ typedef struct VhostUserMsg {
 /* vhost_user.c */
 int vhost_user_msg_handler(int vid, int fd);
 int vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm);
-int vhost_user_host_notifier_ctrl(int vid, bool enable);
 
 /* socket.c */
 int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds,
Signature · 1 line
2.17.1
#3 lore raw

PATCH v2 1/1 vhost: remove statement for non-existed function

In reply to Xiaolong Ye

vhost_user_host_notifier_ctrl is not existed anymore, its statement in header file should be removed accordingly.

Fixes 43f34e35663f ("vhost: provide helper for host notifier ctrl")
---
 lib/librte_vhost/vhost_user.h | 1 -
 1 file changed, 1 deletion(-)
lib/librte_vhost/vhost_user.h +0 -1
index dc97be843..2a650fe4b 100644
@@ -148,7 +148,6 @@ typedef struct VhostUserMsg {
 /* vhost_user.c */
 int vhost_user_msg_handler(int vid, int fd);
 int vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm);
-int vhost_user_host_notifier_ctrl(int vid, bool enable);
 
 /* socket.c */
 int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds,
Signature · 1 line
2.17.1
Reviewed-by on v2 1/1
#4 lore raw

Re: [PATCH v2] vhost: remove statement for non-existed function

Quoted 25 lines · Xiaolong Ye

vhost_user_host_notifier_ctrl is not existed anymore, its statement in header file should be removed accordingly.

Fixes 43f34e35663f ("vhost: provide helper for host notifier ctrl")
---
 lib/librte_vhost/vhost_user.h | 1 -
 1 file changed, 1 deletion(-)
lib/librte_vhost/vhost_user.h +0 -1
index dc97be843..2a650fe4b 100644
@@ -148,7 +148,6 @@ typedef struct VhostUserMsg {
 /* vhost_user.c */
 int vhost_user_msg_handler(int vid, int fd);
 int vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm);
-int vhost_user_host_notifier_ctrl(int vid, bool enable);
 
 /* socket.c */
 int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds,
Signature · 1 line
2.17.1
#5 lore raw

Re: [PATCH v2] vhost: remove statement for non-existed function

In reply to Xiaolong Ye
Quoted 10 lines · Xiaolong Ye

vhost_user_host_notifier_ctrl is not existed anymore, its statement in header file should be removed accordingly.

Fixes 43f34e35663f ("vhost: provide helper for host notifier ctrl")
---
  lib/librte_vhost/vhost_user.h | 1 -
  1 file changed, 1 deletion(-)

Applied to dpdk-next-virtio/master.

Thanks,
Maxime