vhost_user: remove statement for non-existed function
PATCH 1/1 vhost_user: remove statement for non-existed function
vhost_user_host_notifier_ctrl is not existed anymore, its statement in header file should be removed accordingly.
--- lib/librte_vhost/vhost_user.h | 1 - 1 file changed, 1 deletion(-)
lib/librte_vhost/vhost_user.h +0 -1
@@ -148,7 +148,6 @@ typedef struct VhostUserMsg {/* vhost_user.c */ int vhost_user_msg_handler (int vid,int fd);int vhost_user_iotlb_miss (struct virtio_net *dev,uint64_t iova,uint8_t perm); -int vhost_user_host_notifier_ctrl (int vid,bool enable);/* socket.c */ int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds,
Signature · 1 line
2.17.1
Quoted 1 line
vhost_user: remove statement for non-existed function
s/vhost_user/vhost/
Quoted 6 lines · Xiaolong Ye
vhost_user_host_notifier_ctrlis not existed anymore, its statement in header file should be removed accordingly.Fixes 43f34e35663f ("vhost: provide helper for host notifier ctrl")
There is no need to cc stable, because above commit is part of 19.02 which hasn't been released yet.
For the rest,
Quoted 21 lines
Signed-off-by Xiaolong Ye <[email protected]>--- lib/librte_vhost/vhost_user.h | 1 - 1 file changed, 1 deletion(-)lib/librte_vhost/vhost_user.h +0
-1@@ -148,7 +148,6 @@ typedef struct VhostUserMsg {/* vhost_user.c */ int vhost_user_msg_handler (int vid,int fd);int vhost_user_iotlb_miss (struct virtio_net *dev,uint64_t iova,uint8_t perm); -int vhost_user_host_notifier_ctrl (int vid,bool enable);/* socket.c */ int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds,Signature · 1 line
2.17.1
Quoted 12 lines · Tiwei Bie
Quoted 1 line
vhost_user: remove statement for non-existed functions/vhost_user/vhost/
Quoted 6 lines · Xiaolong Ye
vhost_user_host_notifier_ctrlis not existed anymore, its statement in header file should be removed accordingly.Fixes 43f34e35663f ("vhost: provide helper for host notifier ctrl")
Quoted 5 lines
There is no need to cc stable, because above commit is part of 19.02 which hasn't been released yet.
For the rest,
Reviewed-by Tiwei Bie <[email protected]>
Thanks for the review.
In this kind of case, I suppose there is no need to reroll the patch, right?
Thanks,
Xiaolong
Quoted 22 lines
Quoted 22 lines
Signed-off-by Xiaolong Ye <[email protected]>--- lib/librte_vhost/vhost_user.h | 1 - 1 file changed, 1 deletion(-)lib/librte_vhost/vhost_user.h +0
-1@@ -148,7 +148,6 @@ typedef struct VhostUserMsg {/* vhost_user.c */ int vhost_user_msg_handler (int vid,int fd);int vhost_user_iotlb_miss (struct virtio_net *dev,uint64_t iova,uint8_t perm); -int vhost_user_host_notifier_ctrl (int vid,bool enable);/* socket.c */ int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds,Signature · 1 line
2.17.1
PATCH v2 1/1 vhost: remove statement for non-existed function
In reply to Xiaolong Yevhost_user_host_notifier_ctrl is not existed anymore, its statement in header file should be removed accordingly.
--- lib/librte_vhost/vhost_user.h | 1 - 1 file changed, 1 deletion(-)
lib/librte_vhost/vhost_user.h +0 -1
@@ -148,7 +148,6 @@ typedef struct VhostUserMsg {/* vhost_user.c */ int vhost_user_msg_handler (int vid,int fd);int vhost_user_iotlb_miss (struct virtio_net *dev,uint64_t iova,uint8_t perm); -int vhost_user_host_notifier_ctrl (int vid,bool enable);/* socket.c */ int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds,
Signature · 1 line
2.17.1
Re: [PATCH v2] vhost: remove statement for non-existed function
Quoted 25 lines · Xiaolong Ye
vhost_user_host_notifier_ctrlis not existed anymore, its statement in header file should be removed accordingly.Fixes 43f34e35663f ("vhost: provide helper for host notifier ctrl")Signed-off-by Xiaolong Ye <[email protected]>--- lib/librte_vhost/vhost_user.h | 1 - 1 file changed, 1 deletion(-)lib/librte_vhost/vhost_user.h +0
-1@@ -148,7 +148,6 @@ typedef struct VhostUserMsg {/* vhost_user.c */ int vhost_user_msg_handler (int vid,int fd);int vhost_user_iotlb_miss (struct virtio_net *dev,uint64_t iova,uint8_t perm); -int vhost_user_host_notifier_ctrl (int vid,bool enable);/* socket.c */ int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds,Signature · 1 line
2.17.1
Maxime Coquelin
AppliedRe: [PATCH v2] vhost: remove statement for non-existed function
In reply to Xiaolong YeQuoted 10 lines · Xiaolong Ye
vhost_user_host_notifier_ctrlis not existed anymore, its statement in header file should be removed accordingly.Fixes 43f34e35663f ("vhost: provide helper for host notifier ctrl")Signed-off-by Xiaolong Ye <[email protected]>--- lib/librte_vhost/vhost_user.h | 1 - 1 file changed, 1 deletion(-)
Applied to dpdk-next-virtio/master.
Thanks,
Maxime