staging/vboxvideo: Don't set FBINFO_MISC_ALWAYS_SETPAR
PATCH 1/2 staging/vboxvideo: Don't set FBINFO_MISC_ALWAYS_SETPAR
It's a debug hack flag useful to work around driver bugs. That's not a good idea for a new driver. Especially for a new drm driver.
Aside: the fbdev support should probably be converted over to the new generic fbdev support.
--- drivers/staging/vboxvideo/vbox_fb.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/staging/vboxvideo/vbox_fb.c +0 -5
@@ -91,11 +91,6 @@ int vboxfb_create(struct drm_fb_helper *helper, fb = &vbox->afb.base; helper->fb = fb; -/* -* The last flag forces a mode set on VT switches even if the kernel -* does not think it is needed. -*/ - info->flags =FBINFO_MISC_ALWAYS_SETPAR ; info->fbops = &vboxfb_ops;/*
Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 2/2 staging/xgifb: Needs to be converted to a drm driver
Although given the lack of progress since 2010, maybe time to ditch it from staging outright?
--- drivers/staging/xgifb/TODO | 3 +++ 1 file changed, 3 insertions(+)
drivers/staging/xgifb/TODO +3 -0
@@ -9,5 +9,8 @@ TODO: - remove useless/wrong/unused code... - get rid of non-linux related stuff +This needs to become a drm driver, the fbdev subsystem doesn't take new drivers +anymore. + Please send patches to: Arnaud Patard <[email protected]>
Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 12 lines · Daniel Vetter
It's a debug hack flag useful to work around driver bugs. That's not a good idea for a new driver. Especially for a new drm driver.
Aside: the fbdev support should probably be converted over to the new generic fbdev support.
Signed-off-by Daniel Vetter <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Cc Hans de Goede <[email protected]>Cc Daniel Vetter <[email protected]>Cc Bartlomiej Zolnierkiewicz <[email protected]>Cc Alexander Kapshuk <[email protected]>
Quoted 4 lines
--- drivers/staging/vboxvideo/vbox_fb.c | 5 ----- 1 file changed, 5 deletions(-)
Quoted 18 lines · Greg Kroah-Hartman
Quoted 12 lines · Daniel Vetter
It's a debug hack flag useful to work around driver bugs. That's not a good idea for a new driver. Especially for a new drm driver.
Aside: the fbdev support should probably be converted over to the new generic fbdev support.
Signed-off-by Daniel Vetter <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Cc Hans de Goede <[email protected]>Cc Daniel Vetter <[email protected]>Cc Bartlomiej Zolnierkiewicz <[email protected]>Cc Alexander Kapshuk <[email protected]>Quoted 4 lines
--- drivers/staging/vboxvideo/vbox_fb.c | 5 ----- 1 file changed, 5 deletions(-)
Quoted 1 line
Reviewed-by Greg Kroah-Hartman <[email protected]>
Since Hans wants to destage vboxvideo this cycle probably best I merge this through drm-misc? Just to make sure it's not lost. -Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Greg Kroah-Hartman
maintainerQuoted 19 lines · Daniel Vetter
Quoted 18 lines · Greg Kroah-Hartman
Quoted 16 lines · Daniel Vetter
It's a debug hack flag useful to work around driver bugs. That's not a good idea for a new driver. Especially for a new drm driver.
Aside: the fbdev support should probably be converted over to the new generic fbdev support.
Signed-off-by Daniel Vetter <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Cc Hans de Goede <[email protected]>Cc Daniel Vetter <[email protected]>Cc Bartlomiej Zolnierkiewicz <[email protected]>Cc Alexander Kapshuk <[email protected]>--- drivers/staging/vboxvideo/vbox_fb.c | 5 ----- 1 file changed, 5 deletions(-)
Quoted 4 lines
Quoted 1 line
Reviewed-by Greg Kroah-Hartman <[email protected]>Since Hans wants to destage vboxvideo this cycle probably best I merge this through drm-misc? Just to make sure it's not lost.
Feel free to do so!
thanks,
greg k-h
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Daniel Vetter
AppliedQuoted 20 lines · Greg Kroah-Hartman
Quoted 19 lines · Daniel Vetter
Quoted 18 lines · Greg Kroah-Hartman
Quoted 16 lines · Daniel Vetter
It's a debug hack flag useful to work around driver bugs. That's not a good idea for a new driver. Especially for a new drm driver.
Aside: the fbdev support should probably be converted over to the new generic fbdev support.
Signed-off-by Daniel Vetter <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Cc Hans de Goede <[email protected]>Cc Daniel Vetter <[email protected]>Cc Bartlomiej Zolnierkiewicz <[email protected]>Cc Alexander Kapshuk <[email protected]>--- drivers/staging/vboxvideo/vbox_fb.c | 5 ----- 1 file changed, 5 deletions(-)
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Reviewed-by Greg Kroah-Hartman <[email protected]>Since Hans wants to destage vboxvideo this cycle probably best I merge this through drm-misc? Just to make sure it's not lost.
Feel free to do so!
Applied, thanks for your review.
I think 2/2 is directly staging material for you (somehow get_maintainers.pl didn't add you to the cc: list, not sure why ...). -Daniel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Greg Kroah-Hartman
maintainerQuoted 26 lines · Daniel Vetter
Quoted 25 lines · Greg Kroah-Hartman
Quoted 23 lines · Daniel Vetter
Quoted 18 lines · Greg Kroah-Hartman
Quoted 12 lines · Daniel Vetter
It's a debug hack flag useful to work around driver bugs. That's not a good idea for a new driver. Especially for a new drm driver.
Aside: the fbdev support should probably be converted over to the new generic fbdev support.
Signed-off-by Daniel Vetter <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Cc Hans de Goede <[email protected]>Cc Daniel Vetter <[email protected]>Cc Bartlomiej Zolnierkiewicz <[email protected]>Cc Alexander Kapshuk <[email protected]>Quoted 4 lines
--- drivers/staging/vboxvideo/vbox_fb.c | 5 ----- 1 file changed, 5 deletions(-)Quoted 1 line
Reviewed-by Greg Kroah-Hartman <[email protected]>Since Hans wants to destage vboxvideo this cycle probably best I merge this through drm-misc? Just to make sure it's not lost.
Quoted 6 lines
Quoted 1 line
Feel free to do so!
Applied, thanks for your review.
I think 2/2 is directly staging material for you (somehow get_maintainers.pl didn't add you to the cc: list, not sure why ...).
Can you resend it, I don't see it anywhere...
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 28 lines · Greg Kroah-Hartman
Quoted 26 lines · Daniel Vetter
Quoted 25 lines · Greg Kroah-Hartman
Quoted 23 lines · Daniel Vetter
Quoted 18 lines · Greg Kroah-Hartman
Quoted 12 lines · Daniel Vetter
It's a debug hack flag useful to work around driver bugs. That's not a good idea for a new driver. Especially for a new drm driver.
Aside: the fbdev support should probably be converted over to the new generic fbdev support.
Signed-off-by Daniel Vetter <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Cc Hans de Goede <[email protected]>Cc Daniel Vetter <[email protected]>Cc Bartlomiej Zolnierkiewicz <[email protected]>Cc Alexander Kapshuk <[email protected]>Quoted 4 lines
--- drivers/staging/vboxvideo/vbox_fb.c | 5 ----- 1 file changed, 5 deletions(-)Quoted 1 line
Reviewed-by Greg Kroah-Hartman <[email protected]>Since Hans wants to destage vboxvideo this cycle probably best I merge this through drm-misc? Just to make sure it's not lost.
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Feel free to do so!
Applied, thanks for your review.
I think 2/2 is directly staging material for you (somehow get_maintainers.pl didn't add you to the cc: list, not sure why ...).
Can you resend it, I don't see it anywhere...
resent with you added explicitly to the Cc: list, it's
Subject: [PATCH] staging/xgifb: Needs to be converted to a drm driver
Date: Wed, 16 Jan 2019 11:04:40 +0100
Message-Id: <[email protected]>
Cheers, Daniel
Quoted 4 lines
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
Quoted 21 lines · Daniel Vetter
It's a debug hack flag useful to work around driver bugs. That's not a good idea for a new driver. Especially for a new drm driver.
Aside: the fbdev support should probably be converted over to the new generic fbdev support.
Signed-off-by Daniel Vetter <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Cc Hans de Goede <[email protected]>Cc Daniel Vetter <[email protected]>Cc Bartlomiej Zolnierkiewicz <[email protected]>Cc Alexander Kapshuk <[email protected]>--- drivers/staging/vboxvideo/vbox_fb.c | 5 ----- 1 file changed, 5 deletions(-)drivers/staging/vboxvideo/vbox_fb.c +0
-0
drivers/staging/vboxvideo/vbox_fb.c int vboxfb_create(struct drm_fb_helper *helper, · line 98
Quoted 8 lines
drivers/staging/vboxvideo/vbox_fb.c +0
-5@@ -91,11 +91,6 @@ int vboxfb_create(struct drm_fb_helper *helper, fb = &vbox->afb.base; helper->fb = fb; -/* -* The last flag forces a mode set on VT switches even if the kernel -* does not think it is needed. -*/ - info->flags =FBINFO_MISC_ALWAYS_SETPAR ;
For the record I screwed up rebasing this one because it was in some patch that also removed FBINFO_DEFAULT (which is 0, so pointless to set since the structure is kzalloc'ed). Actually merged patch also removes FBINFO_DEFAULT :-/ No real harm done though since as explained 0 doesn't matter here.
-Daniel
Quoted 6 lines
drivers/staging/vboxvideo/vbox_fb.c +0
-0info->fbops = &vboxfb_ops;/* Signature · 1 line
2.20.1
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel