Skip to contentSkip to conversation

doc: correct default scheduler in xen-command-line.pandoc

PATCH In review Juergen Gross 4 participants 8 messages Jan 15, 2019 – Jan 17, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 doc: correct default scheduler in xen-command-line.pandoc

We have switched to credit2. Let the documentation reflect that.

---
 docs/misc/xen-command-line.pandoc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
docs/misc/xen-command-line.pandoc +1 -1
index d39bcee928..e24e3a45e4 100644
@@ -1705,7 +1705,7 @@ with read and write permissions.
 ### sched
 > `= credit | credit2 | arinc653 | rtds | null`
 
-> Default: `sched=credit`
+> Default: `sched=credit2`
 
 Choose the default scheduler.
 
Signature · 7 lines
2.16.4


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#2 lore raw
In reply to Juergen Gross
Quoted 12 lines · Juergen Gross

We have switched to credit2. Let the documentation reflect that.

---
 docs/misc/xen-command-line.pandoc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
docs/misc/xen-command-line.pandoc +0 -0
index d39bcee928..e24e3a45e4 100644

docs/misc/xen-command-line.pandoc with read and write permissions. · line 1711

Quoted 8 lines
docs/misc/xen-command-line.pandoc +1 -1
@@ -1705,7 +1705,7 @@ with read and write permissions.
 ### sched
 > `= credit | credit2 | arinc653 | rtds | null`
 
-> Default: `sched=credit`
+> Default: `sched=credit2`
 
 Choose the default scheduler.
 

Like XSM, this is Kconfig controlled, not a static default, and also depends on the compiled schedulers.  This should read something like:

Quoted 1 line

Default: selectable via Kconfig.  Depends on enabled schedulers.

~Andrew

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#3 lore raw
Quoted 16 lines · Andrew Cooper
Quoted 15 lines · Juergen Gross

We have switched to credit2. Let the documentation reflect that.

---
 docs/misc/xen-command-line.pandoc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
docs/misc/xen-command-line.pandoc +0 -0
index d39bcee928..e24e3a45e4 100644
@@ -1705,7 +1705,7 @@ with read and write permissions.
 ### sched
 > `= credit | credit2 | arinc653 | rtds | null`
 
Quoted 10 lines

docs/misc/xen-command-line.pandoc with read and write permissions. · line 1711

Quoted 5 lines
docs/misc/xen-command-line.pandoc +1 -1
-> Default: `sched=credit`
+> Default: `sched=credit2`
 
 Choose the default scheduler.
 

Like XSM, this is Kconfig controlled, not a static default, and also depends on the compiled schedulers.  This should read something like:

Quoted 1 line

Default: selectable via Kconfig.  Depends on enabled schedulers.

The Kconfig default is credit2.

Juergen

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#4 lore raw
Quoted 20 lines · Juergen Gross
Quoted 19 lines · Andrew Cooper
Quoted 18 lines · Juergen Gross

We have switched to credit2. Let the documentation reflect that.

---
 docs/misc/xen-command-line.pandoc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
docs/misc/xen-command-line.pandoc +1 -1
index d39bcee928..e24e3a45e4 100644
@@ -1705,7 +1705,7 @@ with read and write permissions.
 ### sched
 > `= credit | credit2 | arinc653 | rtds | null`
 
-> Default: `sched=credit`
+> Default: `sched=credit2`
 
Quoted 7 lines
Quoted 6 lines

docs/misc/xen-command-line.pandoc with read and write permissions. · line 1711

Quoted 2 lines
docs/misc/xen-command-line.pandoc +0 -0
 Choose the default scheduler.
 

Like XSM, this is Kconfig controlled, not a static default, and also depends on the compiled schedulers.  This should read something like:

Quoted 1 line

Default: selectable via Kconfig.  Depends on enabled schedulers.

The Kconfig default is credit2.

Only when credit2 is compiled in, which isn't even the the case for all Kconfig fragments we have in tree.

~Andrew

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#5 lore raw
Quoted 26 lines · Andrew Cooper
Quoted 25 lines · Juergen Gross
Quoted 24 lines · Andrew Cooper
Quoted 12 lines · Juergen Gross

We have switched to credit2. Let the documentation reflect that.

---
 docs/misc/xen-command-line.pandoc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
docs/misc/xen-command-line.pandoc +0 -0
index d39bcee928..e24e3a45e4 100644

docs/misc/xen-command-line.pandoc with read and write permissions. · line 1711

Quoted 8 lines
docs/misc/xen-command-line.pandoc +1 -1
@@ -1705,7 +1705,7 @@ with read and write permissions.
 ### sched
 > `= credit | credit2 | arinc653 | rtds | null`
 
-> Default: `sched=credit`
+> Default: `sched=credit2`
 
 Choose the default scheduler.
 

Like XSM, this is Kconfig controlled, not a static default, and also depends on the compiled schedulers.  This should read something like:

Quoted 5 lines
Quoted 2 lines
Quoted 1 line
Quoted 1 line

Default: selectable via Kconfig.  Depends on enabled schedulers.

The Kconfig default is credit2.

Only when credit2 is compiled in, which isn't even the the case for all Kconfig fragments we have in tree.

I still think it is sensible to specify an actual default here.

Adding other caveats for special Kconfig variants might be okay, but this should be another patch then (post 4.12 probably).

In the end one of the features highlighted for 4.12 will be:

"Credit 2 is now the default scheduler".

Our documentation should reflect that.

Juergen

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#6 lore raw
In reply to Andrew Cooper
Quoted 23 lines · Andrew Cooper
Quoted 22 lines · Juergen Gross
Quoted 21 lines · Andrew Cooper
Quoted 7 lines · Juergen Gross
docs/misc/xen- renamed from docs/misc/xen-command-line.pandoc +0 -0

command-line.pandoc
index d39bcee928..e24e3a45e4 100644

docs/misc/xen-command-line.pandoc with read and write permissions. · line 1711

Quoted 8 lines
docs/misc/xen-command-line.pandoc +1 -1
@@ -1705,7 +1705,7 @@ with read and write permissions.
 ### sched
 > `= credit | credit2 | arinc653 | rtds | null`
 
-> Default: `sched=credit`
+> Default: `sched=credit2`
 
 Choose the default scheduler.
 

Like XSM, this is Kconfig controlled, not a static default, and also
depends on the compiled schedulers. This should read something like:

Quoted 8 lines
Quoted 3 lines
Quoted 2 lines
Quoted 2 lines

Default: selectable via Kconfig. Depends on enabled schedulers.

The Kconfig default is credit2.

Only when credit2 is compiled in, which isn't even the the case for all
Kconfig fragments we have in tree.

So, basically, what you're saying is that we need a patch that removes any mention to what the default is, right?

Like removing the line:

Default: sched=credit

without replacing it with anything else?

Dario

Signature · 4 lines
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Software Engineer @ SUSE https://www.suse.com/

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel