Fixmap support and MM cleanups
cover Fixmap support and MM cleanups
This patchset does:
1. Moves MM related code from kernel/setup.c to mm/init.c
2. Implements compile-time fixed mappings
Using fixed mappings available, we can now get earlyprints even without SBI calls. For example, we can use kernel parameter "earlycon=uart8250,mmio,0x10000000" to get early prints on QEMU virt machine without using SBI calls.
The patchset is tested on QEMU virt machine. It is based on Linux-5.0-rc1 and can be found at riscv_fixmap_v1 branch of:
https://github.com/avpatel/linux.git.
Anup Patel (5):
RISC-V: Move free_initrd_mem() to kernel/setup.c
RISC-V: Setup init_mm before parse_early_param()
RISC-V: Move setup_bootmem() to mm/init.c
RISC-V: Move setup_vm() to mm/init.c
RISC-V: Implement compile-time fixed mappings
arch/riscv/Kconfig | 3 + arch/riscv/include/asm/fixmap.h | 52 +++++++++++++ arch/riscv/include/asm/pgtable.h | 1 + arch/riscv/kernel/setup.c | 106 +++----------------------- arch/riscv/mm/init.c | 123 ++++++++++++++++++++++++++++++- 5 files changed, 186 insertions(+), 99 deletions(-) create mode 100644 arch/riscv/include/asm/fixmap.h
Signature · 1 line
2.17.1
PATCH 1/5 RISC-V: Move free_initrd_mem() to kernel/setup.c
From: Anup Patel <[email protected]>
We move free_initrd_mem() to kernel/setup.c so that all initrd related functions are in one place.
--- arch/riscv/kernel/setup.c | 4 ++++ arch/riscv/mm/init.c | 7 ------- 2 files changed, 4 insertions(+), 7 deletions(-)
arch/riscv/kernel/setup.c +4 -0
@@ -96,6 +96,10 @@ static void __init setup_initrd(void) initrd_start =0 ; initrd_end =0 ; } + +void free_initrd_mem (unsigned long start,unsigned long end) +{ +}#endif /* CONFIG_BLK_DEV_INITRD */ pgd_t swapper_pg_dir[PTRS_PER_PGD] __page_aligned_bss;
arch/riscv/mm/init.c +0 -7
@@ -14,7 +14,6 @@#include <linux/init.h> #include <linux/mm.h> #include <linux/memblock.h> -#include <linux/initrd.h> #include <linux/swap.h> #include <linux/sizes.h>
@@ -63,9 +62,3 @@ void free_initmem(void) {free_initmem_default (0 ); } - -#ifdef CONFIG_BLK_DEV_INITRD -void free_initrd_mem (unsigned long start,unsigned long end) -{ -} -#endif /* CONFIG_BLK_DEV_INITRD */
Signature · 1 line
2.17.1
Re: [PATCH 1/5] RISC-V: Move free_initrd_mem() to kernel/setup.c
Quoted 6 lines · Anup Patel
From: Anup Patel <[email protected]>
We move
free_initrd_mem()tokernel/setup.cso that all initrd related functions are in one place.Signed-off-by Anup Patel <[email protected]>
Looks fine:
Talking about free_initrd_mem - don't we need to call free_reserved_area to actually release the memory?
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Re: [PATCH 1/5] RISC-V: Move free_initrd_mem() to kernel/setup.c
Quoted 7 lines · Christoph Hellwig
Quoted 5 lines · Anup Patel
From: Anup Patel <[email protected]>
We move
free_initrd_mem()tokernel/setup.cso that all initrd related functions are in one place.
Quoted 8 lines
Quoted 1 line
Signed-off-by Anup Patel <[email protected]>Looks fine:
Reviewed-by Christoph Hellwig <[email protected]>Talking about
free_initrd_mem- don't we need to callfree_reserved_areato actually release the memory?
Yes, we should. Thanks for pointing.
I will include separate patch for it.
Thanks,
Anup
PATCH 2/5 RISC-V: Setup init_mm before parse_early_param()
In reply to Anup PatelFrom: Anup Patel <[email protected]>
We should setup init_mm before doing parse_early_param() in setup_arch() to be consistent with setup_arch() of other architectures such as x86, ARM, and ARM64.
--- arch/riscv/kernel/setup.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
arch/riscv/kernel/setup.c +4 -5
@@ -201,15 +201,15 @@ static void __init setup_bootmem(void)void __init setup_arch (char **cmdline_p) { - *cmdline_p = boot_command_line; - -parse_early_param (); - init_mm.start_code = (unsigned long ) _stext; init_mm.end_code = (unsigned long ) _etext; init_mm.end_data = (unsigned long ) _edata; init_mm.brk = (unsigned long ) _end; + *cmdline_p = boot_command_line; + +parse_early_param (); +setup_bootmem ();paging_init ();unflatten_device_tree ();
@@ -228,4 +228,3 @@ void __init setup_arch(char **cmdline_p)riscv_fill_hwcap (); } -
Signature · 1 line
2.17.1
Re: [PATCH 2/5] RISC-V: Setup init_mm before parse_early_param()
Quoted 7 lines · Anup Patel
From: Anup Patel <[email protected]>
We should setup
init_mmbefore doingparse_early_param()insetup_arch()to be consistent withsetup_arch()of other architectures such as x86, ARM, and ARM64.Signed-off-by Anup Patel <[email protected]>
Is there any good inherent reason why the order matters? Not that I really care either way..
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Re: [PATCH 2/5] RISC-V: Setup init_mm before parse_early_param()
Quoted 4 lines · Christoph Hellwig
Quoted 2 lines · Anup Patel
From: Anup Patel <[email protected]>
Quoted 8 lines
Quoted 5 lines
We should setup
init_mmbefore doingparse_early_param()insetup_arch()to be consistent withsetup_arch()of other architectures such as x86, ARM, and ARM64.Signed-off-by Anup Patel <[email protected]>Is there any good inherent reason why the order matters? Not that I really care either way..
The parse_early_param() calls param callbacks in variety of subsystems including MM. Doing init_mm setup before parse_early_param() ensures that initial MM state is available when MM param callbacks are called.
My intention was mainly to make boot-up flow similar to x86, ARM and ARM64 so that it is easy to add features already present in these arch ports.
Regards,
Anup
PATCH 3/5 RISC-V: Move setup_bootmem() to mm/init.c
In reply to Anup PatelFrom: Anup Patel <[email protected]>
The setup_bootmem() mainly populates memblocks and does early memory reservations. The right location for this function is mm/init.c.
--- arch/riscv/include/asm/pgtable.h | 1 + arch/riscv/kernel/setup.c | 48 ++++---------------------------- arch/riscv/mm/init.c | 40 ++++++++++++++++++++++++++ 3 files changed, 46 insertions(+), 43 deletions(-)
arch/riscv/include/asm/pgtable.h +1 -0
@@ -404,6 +404,7 @@ static inline int ptep_clear_flush_young(struct vm_area_struct *vma,#define kern_addr_valid (addr) (1)/* FIXME */ #endif +extern void setup_bootmem (void );extern void paging_init (void );static inline void pgtable_cache_init (void )
arch/riscv/kernel/setup.c +5 -43
60 lines not on this page · raw message
arch/riscv/mm/init.c +40 -0
@@ -16,6 +16,7 @@#include <linux/memblock.h> #include <linux/swap.h> #include <linux/sizes.h> +#include <linux/of_fdt.h> #include <asm/tlbflush.h> #include <asm/sections.h>
@@ -62,3 +63,42 @@ void free_initmem(void) {free_initmem_default (0 ); } + +void __init setup_bootmem (void ) +{ +struct memblock_region *reg; +phys_addr_t mem_size =0 ; + +/* Find the memory region containing the kernel */ +for_each_memblock (memory, reg) { +phys_addr_t vmlinux_end =__pa (_end); +phys_addr_t end = reg->base + reg->size; + +if (reg->base <= vmlinux_end && vmlinux_end <= end) { +/* +* Reserve from the start of the region to the end of +* the kernel +*/ +memblock_reserve (reg->base, vmlinux_end - reg->base); + mem_size =min (reg->size, (phys_addr_t)-PAGE_OFFSET ); + } + } +BUG_ON (mem_size ==0 ); + +set_max_mapnr (PFN_DOWN (mem_size)); + max_low_pfn =memblock_end_of_DRAM (); + +early_init_fdt_reserve_self (); +early_init_fdt_scan_reserved_mem (); +memblock_allow_resize (); +memblock_dump_all (); + +for_each_memblock (memory, reg) { +unsigned long start_pfn =memblock_region_memory_base_pfn (reg); +unsigned long end_pfn =memblock_region_memory_end_pfn (reg); + +memblock_set_node (PFN_PHYS (start_pfn), +PFN_PHYS (end_pfn - start_pfn), + &memblock.memory,0 ); + } +}
Signature · 1 line
2.17.1
Re: [PATCH 3/5] RISC-V: Move setup_bootmem() to mm/init.c
Quoted 7 lines · Anup Patel
From: Anup Patel <[email protected]>
The
setup_bootmem()mainly populates memblocks and does early memory reservations. The right location for this function ismm/init.c.Signed-off-by Anup Patel <[email protected]>
Looks fine:
Btw, please use up the available 72 chars per line in your changelogs where possible.
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Re: [PATCH 3/5] RISC-V: Move setup_bootmem() to mm/init.c
Quoted 8 lines · Christoph Hellwig
Quoted 6 lines · Anup Patel
From: Anup Patel <[email protected]>
The
setup_bootmem()mainly populates memblocks and does early memory reservations. The right location for this function ismm/init.c.
Quoted 8 lines
Quoted 1 line
Signed-off-by Anup Patel <[email protected]>Looks fine:
Reviewed-by Christoph Hellwig <[email protected]>Btw, please use up the available 72 chars per line in your changelogs where possible.
Sure will do.
Thanks,
Anup
PATCH 4/5 RISC-V: Move setup_vm() to mm/init.c
In reply to Anup PatelFrom: Anup Patel <[email protected]>
The setup_vm() is responsible for setting up initial page table hence should be placed in mm/init.c.
--- arch/riscv/kernel/setup.c | 49 -------------------------------------- arch/riscv/mm/init.c | 50 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 50 insertions(+), 49 deletions(-)
arch/riscv/kernel/setup.c +0 -49
@@ -102,55 +102,6 @@ void free_initrd_mem(unsigned long start, unsigned long end) }#endif /* CONFIG_BLK_DEV_INITRD */ -pgd_t swapper_pg_dir[PTRS_PER_PGD] __page_aligned_bss; -pgd_t trampoline_pg_dir[PTRS_PER_PGD ]__initdata __aligned(PAGE_SIZE) ; - -#ifndef __PAGETABLE_PMD_FOLDED -#define NUM_SWAPPER_PMDS ((uintptr_t)-PAGE_OFFSET >> PGDIR_SHIFT) -pmd_t swapper_pmd[PTRS_PER_PMD*((-PAGE_OFFSET)/PGDIR_SIZE)] __page_aligned_bss; -pmd_t trampoline_pmd[PTRS_PER_PGD ]__initdata __aligned(PAGE_SIZE) ; -#endif - -asmlinkage void __init setup_vm(void) -{ -extern char _start; -uintptr_t i; -uintptr_t pa = (uintptr_t ) &_start; -pgprot_t prot =__pgprot (pgprot_val (PAGE_KERNEL ) | _PAGE_EXEC); - - va_pa_offset =PAGE_OFFSET - pa; - pfn_base =PFN_DOWN (pa); - -/* Sanity check alignment and size */ -BUG_ON ((PAGE_OFFSET %PGDIR_SIZE ) !=0 ); -BUG_ON ((pa % (PAGE_SIZE *PTRS_PER_PTE )) !=0 ); - -#ifndef __PAGETABLE_PMD_FOLDED - trampoline_pg_dir[(PAGE_OFFSET >>PGDIR_SHIFT ) %PTRS_PER_PGD ] = -pfn_pgd (PFN_DOWN ((uintptr_t )trampoline_pmd), -__pgprot (_PAGE_TABLE)); - trampoline_pmd[0 ] =pfn_pmd (PFN_DOWN (pa), prot); - -for (i =0 ; i < (-PAGE_OFFSET )/PGDIR_SIZE ; ++i) { -size_t o = (PAGE_OFFSET >>PGDIR_SHIFT ) %PTRS_PER_PGD + i; - swapper_pg_dir[o] = -pfn_pgd (PFN_DOWN ((uintptr_t )swapper_pmd) + i, -__pgprot (_PAGE_TABLE)); - } -for (i =0 ; i <ARRAY_SIZE (swapper_pmd); i++) - swapper_pmd[i] =pfn_pmd (PFN_DOWN (pa + i *PMD_SIZE ), prot); -#else - trampoline_pg_dir[(PAGE_OFFSET >>PGDIR_SHIFT ) %PTRS_PER_PGD ] = -pfn_pgd (PFN_DOWN (pa), prot); - -for (i =0 ; i < (-PAGE_OFFSET )/PGDIR_SIZE ; ++i) { -size_t o = (PAGE_OFFSET >>PGDIR_SHIFT ) %PTRS_PER_PGD + i; - swapper_pg_dir[o] = -pfn_pgd (PFN_DOWN (pa + i *PGDIR_SIZE ), prot); - } -#endif -} -void __init parse_dtb (unsigned int hartid,void *dtb) {early_init_dt_scan (__va (dtb));
arch/riscv/mm/init.c +50 -0
53 lines not on this page · raw message
Signature · 1 line
2.17.1
Re: [PATCH 4/5] RISC-V: Move setup_vm() to mm/init.c
Quoted 6 lines · Anup Patel
From: Anup Patel <[email protected]>
The
setup_vm()is responsible for setting up initial page table hence should be placed inmm/init.c.Signed-off-by Anup Patel <[email protected]>
Looks fine,
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
PATCH 5/5 RISC-V: Implement compile-time fixed mappings
In reply to Anup PatelFrom: Anup Patel <[email protected]>
This patch implements compile-time virtual to physical mappings. These compile-time fixed mappings can be used by earlycon, ACPI, and early ioremap for creating fixed mappings when FIX_EARLYCON_MEM=y.
To start with, we have enabled compile-time fixed
mappings for earlycon.
--- arch/riscv/Kconfig | 3 ++ arch/riscv/include/asm/fixmap.h | 52 +++++++++++++++++++++++++++++++++ arch/riscv/mm/init.c | 32 ++++++++++++++++++++ 3 files changed, 87 insertions(+) create mode 100644 arch/riscv/include/asm/fixmap.h
arch/riscv/Kconfig +3 -0
@@ -86,6 +86,9 @@ config GENERIC_CSUM config GENERIC_HWEIGHT def_bool y +config FIX_EARLYCON_MEM + def_bool y + config PGTABLE_LEVELS int default 3 if 64BIT
arch/riscv/include/asm/fixmap.h new file +52 -0
52 lines not on this page · raw message
arch/riscv/mm/init.c +32 -0
@@ -18,6 +18,7 @@#include <linux/sizes.h> #include <linux/of_fdt.h> +#include <asm/fixmap.h> #include <asm/tlbflush.h> #include <asm/sections.h> #include <asm/pgtable.h>
@@ -110,8 +111,28 @@ pgd_t trampoline_pg_dir[PTRS_PER_PGD] __initdata __aligned(PAGE_SIZE);#define NUM_SWAPPER_PMDS ((uintptr_t)-PAGE_OFFSET >> PGDIR_SHIFT) pmd_t swapper_pmd[PTRS_PER_PMD*((-PAGE_OFFSET)/PGDIR_SIZE)] __page_aligned_bss;pmd_t trampoline_pmd[PTRS_PER_PGD ]__initdata __aligned(PAGE_SIZE) ; +pmd_t fixmap_pmd[PTRS_PER_PMD] __page_aligned_bss;#endif +pte_t fixmap_pte[PTRS_PER_PTE] __page_aligned_bss; + +void __set_fixmap (enum fixed_addresses idx,phys_addr_t phys,pgprot_t prot) +{ +unsigned long addr =__fix_to_virt (idx); +pte_t *ptep; + +BUG_ON (idx <=FIX_HOLE || idx >= __end_of_fixed_addresses); + + ptep = &fixmap_pte[pte_index (addr)]; + +if (pgprot_val (prot)) { +set_pte (ptep,pfn_pte (phys >>PAGE_SHIFT , prot)); + }else { +pte_clear (&init_mm, addr, ptep); +local_flush_tlb_page (addr); + } +} + asmlinkage void __init setup_vm(void) {extern char _start;
@@ -141,6 +162,13 @@ asmlinkage void __init setup_vm(void) }for (i =0 ; i <ARRAY_SIZE (swapper_pmd); i++) swapper_pmd[i] =pfn_pmd (PFN_DOWN (pa + i *PMD_SIZE ), prot); + + swapper_pg_dir[(FIXADDR_START >>PGDIR_SHIFT ) %PTRS_PER_PGD ] = +pfn_pgd (PFN_DOWN ((uintptr_t )fixmap_pmd), +__pgprot (_PAGE_TABLE)); + fixmap_pmd[(FIXADDR_START >>PMD_SHIFT ) %PTRS_PER_PMD ] = +pfn_pmd (PFN_DOWN ((uintptr_t )fixmap_pte), +__pgprot (_PAGE_TABLE));#else trampoline_pg_dir[(PAGE_OFFSET >>PGDIR_SHIFT ) %PTRS_PER_PGD ] =pfn_pgd (PFN_DOWN (pa), prot);
@@ -150,5 +178,9 @@ asmlinkage void __init setup_vm(void) swapper_pg_dir[o] = pfn_pgd(PFN_DOWN(pa + i * PGDIR_SIZE), prot); } + + swapper_pg_dir[(FIXADDR_START >>PGDIR_SHIFT ) %PTRS_PER_PGD ] = +pfn_pgd (PFN_DOWN ((uintptr_t )fixmap_pte), +__pgprot (_PAGE_TABLE));#endif }
Signature · 1 line
2.17.1
Re: [PATCH 5/5] RISC-V: Implement compile-time fixed mappings
Quoted 23 lines · Anup Patel
From: Anup Patel <[email protected]>
This patch implements compile-time virtual to physical mappings. These compile-time fixed mappings can be used by earlycon, ACPI, and early ioremap for creating fixed mappings when FIX_EARLYCON_MEM=y.
To start with, we have enabled compile-time fixed
mappings for earlycon.Signed-off-by Anup Patel <[email protected]>--- arch/riscv/Kconfig | 3 ++ arch/riscv/include/asm/fixmap.h | 52 +++++++++++++++++++++++++++++++++ arch/riscv/mm/init.c | 32 ++++++++++++++++++++ 3 files changed, 87 insertions(+) create mode 100644 arch/riscv/include/asm/fixmap.harch/riscv/Kconfig +0
-0
arch/riscv/Kconfig config GENERIC_CSUM · line 91
Quoted 6 lines
arch/riscv/Kconfig +3
-0@@ -86,6 +86,9 @@ config GENERIC_CSUM config GENERIC_HWEIGHT def_bool y +config FIX_EARLYCON_MEM + def_bool y +
Can you please throw in a prep patch to move FIX_EARLYCON_MEM to drivers/tty/serial/Kconfig and only select it from the architectures that use it?
arch/riscv/Kconfig config GENERIC_CSUM · line 92
Quoted 1 line
arch/riscv/Kconfig +1
-0+ * fixmap.h: compile-time virtual memory allocation
No need to mention the header name.
arch/riscv/Kconfig config GENERIC_CSUM
Quoted 6 lines
arch/riscv/Kconfig +6
-0+ */ + +#ifndef _ASM_RISCV_FIXMAP_H +#define _ASM_RISCV_FIXMAP_H + +#ifndef __ASSEMBLY__
As far as I can tell we never include this header from assembly files, so this ifdef should not be needed.
Quoted 10 lines
+/*
+ * Here we define all the compile-time 'special' virtual
+ * addresses. The point is to have a constant address at
+ * compile time, but to set the physical address only
+ * in the boot process.
+ *
+ * These 'compile-time allocated' memory buffers are
+ * page-sized. Useset_fixmap(idx,phys)to associate
+ * physical memory with fixmap indices.
+ */
Please use up the available 80 chars per line for comments.
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Re: [PATCH 5/5] RISC-V: Implement compile-time fixed mappings
Quoted 40 lines · Christoph Hellwig
Quoted 23 lines · Anup Patel
From: Anup Patel <[email protected]>
This patch implements compile-time virtual to physical mappings. These compile-time fixed mappings can be used by earlycon, ACPI, and early ioremap for creating fixed mappings when FIX_EARLYCON_MEM=y.
To start with, we have enabled compile-time fixed
mappings for earlycon.Signed-off-by Anup Patel <[email protected]>--- arch/riscv/Kconfig | 3 ++ arch/riscv/include/asm/fixmap.h | 52 +++++++++++++++++++++++++++++++++ arch/riscv/mm/init.c | 32 ++++++++++++++++++++ 3 files changed, 87 insertions(+) create mode 100644 arch/riscv/include/asm/fixmap.harch/riscv/Kconfig +0
-0arch/riscv/Kconfig config GENERIC_CSUM · line 91
Quoted 6 lines
arch/riscv/Kconfig +3
-0@@ -86,6 +86,9 @@ config GENERIC_CSUM config GENERIC_HWEIGHT def_bool y +config FIX_EARLYCON_MEM + def_bool y +Can you please throw in a prep patch to move
FIX_EARLYCON_MEMtodrivers/tty/serial/Kconfigand only select it from the architectures that use it?arch/riscv/Kconfig config GENERIC_CSUM · line 92
Quoted 1 line
arch/riscv/Kconfig +1
-0+ * fixmap.h: compile-time virtual memory allocationNo need to mention the header name.
Quoted 9 lines
arch/riscv/Kconfig config GENERIC_CSUM
Quoted 6 lines
arch/riscv/Kconfig +6
-0+ */ + +#ifndef _ASM_RISCV_FIXMAP_H +#define _ASM_RISCV_FIXMAP_H + +#ifndef __ASSEMBLY__As far as I can tell we never include this header from assembly files, so this ifdef should not be needed.
Okay, will drop #ifndef
Quoted 12 lines
Quoted 11 lines
+/*
+ * Here we define all the compile-time 'special' virtual
+ * addresses. The point is to have a constant address at
+ * compile time, but to set the physical address only
+ * in the boot process.
+ *
+ * These 'compile-time allocated' memory buffers are
+ * page-sized. Useset_fixmap(idx,phys)to associate
+ * physical memory with fixmap indices.
+ */
Quoted 1 line
Please use up the available 80 chars per line for comments.
Sure, will do.
Regards,
Anup
Re: [PATCH 5/5] RISC-V: Implement compile-time fixed mappings
In reply to Christoph HellwigQuoted 28 lines · Christoph Hellwig
Quoted 26 lines · Anup Patel
From: Anup Patel <[email protected]>
This patch implements compile-time virtual to physical mappings. These compile-time fixed mappings can be used by earlycon, ACPI, and early ioremap for creating fixed mappings when FIX_EARLYCON_MEM=y.
To start with, we have enabled compile-time fixed
mappings for earlycon.Signed-off-by Anup Patel <[email protected]>--- arch/riscv/Kconfig | 3 ++ arch/riscv/include/asm/fixmap.h | 52 +++++++++++++++++++++++++++++++++ arch/riscv/mm/init.c | 32 ++++++++++++++++++++ 3 files changed, 87 insertions(+) create mode 100644 arch/riscv/include/asm/fixmap.harch/riscv/Kconfig +0
-0@@ -86,6 +86,9 @@ config GENERIC_CSUM config GENERIC_HWEIGHT def_bool y
Quoted 7 lines
arch/riscv/Kconfig config GENERIC_CSUM · line 91
Quoted 3 lines
arch/riscv/Kconfig +3
-0+config FIX_EARLYCON_MEM + def_bool y +Can you please throw in a prep patch to move
FIX_EARLYCON_MEMtodrivers/tty/serial/Kconfigand only select it from the architectures that use it?
Implementing fixmap is totally optional for architectures so it makes sense to have FIX_EARLYCON_MEM as architecture specific kconfig option. There are many such architecture specific options provided as "def_bool y" in arch/<xyz>/Kconfig. Also, having such "def_bool y" kconfig options in arch/<xyz>/Kconfig gives us idea about optional features implemented by <xyz> arch support.
I don't agree with this suggestion. If you still feel this is right way to go then please go ahead and send patch to move FIX_EARLYCON_MEM option in drivers/tty/serial/Kconfig.
Quoted 4 lines
arch/riscv/Kconfig config GENERIC_CSUM · line 92
Quoted 2 lines
arch/riscv/Kconfig +1
-0+ * fixmap.h: compile-time virtual memory allocationNo need to mention the header name.
Sure, will remove header name.
Quoted 22 lines
arch/riscv/Kconfig config GENERIC_CSUM
Quoted 7 lines
arch/riscv/Kconfig +6
-0+ */ + +#ifndef _ASM_RISCV_FIXMAP_H +#define _ASM_RISCV_FIXMAP_H + +#ifndef __ASSEMBLY__As far as I can tell we never include this header from assembly files, so this ifdef should not be needed.
Quoted 10 lines
+/*
+ * Here we define all the compile-time 'special' virtual
+ * addresses. The point is to have a constant address at
+ * compile time, but to set the physical address only
+ * in the boot process.
+ *
+ * These 'compile-time allocated' memory buffers are
+ * page-sized. Useset_fixmap(idx,phys)to associate
+ * physical memory with fixmap indices.
+ */
Quoted 1 line
Please use up the available 80 chars per line for comments.
Regards,
Anup