Skip to contentSkip to conversation

drm: Fix drm.h uapi header for GNU/kFreeBSD

PATCH In review James Clarke 4 participants 10 messages Jan 15, 2019 – May 16, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: Fix drm.h uapi header for GNU/kFreeBSD

Like GNU/Linux, GNU/kFreeBSD's sys/types.h does not define the uintX_t types, which differs from the BSDs' headers. Thus we should include stdint.h to ensure we have all the required integer types.

---
 include/uapi/drm/drm.h | 1 +
 1 file changed, 1 insertion(+)
include/uapi/drm/drm.h +1 -0
index 300f33663..caf4d9b38 100644
@@ -50,6 +50,7 @@ typedef unsigned int drm_handle_t;
 
 #else /* One of the BSDs */
 
+#include <stdint.h>
 #include <sys/ioccom.h>
 #include <sys/types.h>
 typedef int8_t   __s8;
Signature · 6 lines
2.17.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw
Quoted 5 lines · James Clarke

Like GNU/Linux, GNU/kFreeBSD's sys/types.h does not define the uintX_t types, which differs from the BSDs' headers. Thus we should include stdint.h to ensure we have all the required integer types.

Would be good to get an ack from some other *bsd that this is still all fine. lgtm otherwise.
-Daniel

Quoted 23 lines
---
 include/uapi/drm/drm.h | 1 +
 1 file changed, 1 insertion(+)
include/uapi/drm/drm.h +1 -0
index 300f33663..caf4d9b38 100644
@@ -50,6 +50,7 @@ typedef unsigned int drm_handle_t;
 
 #else /* One of the BSDs */
 
+#include <stdint.h>
 #include <sys/ioccom.h>
 #include <sys/types.h>
 typedef int8_t   __s8;
Signature · 6 lines
2.17.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#2 lore raw
Quoted 10 lines · Daniel Vetter
Quoted 5 lines · James Clarke

Like GNU/Linux, GNU/kFreeBSD's sys/types.h does not define the uintX_t types, which differs from the BSDs' headers. Thus we should include stdint.h to ensure we have all the required integer types.

Would be good to get an ack from some other *bsd that this is still all fine. lgtm otherwise.
-Daniel

I think there was some need for inttypes.h instead of stdint like a decade ago when I was working on BSDs, but that was already almost irrelevant then.

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw
Quoted 10 lines · Eric Anholt
Quoted 7 lines · Daniel Vetter
Quoted 5 lines · James Clarke

Like GNU/Linux, GNU/kFreeBSD's sys/types.h does not define the uintX_t types, which differs from the BSDs' headers. Thus we should include stdint.h to ensure we have all the required integer types.

Quoted 7 lines
Quoted 3 lines

Would be good to get an ack from some other *bsd that this is still all fine. lgtm otherwise.
-Daniel

I think there was some need for inttypes.h instead of stdint like a decade ago when I was working on BSDs, but that was already almost irrelevant then.

Hi, just following up on this; is there still the need for an ACK?

Regards,
James

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#4 lore raw
Quoted 15 lines · James Clarke
Quoted 14 lines · Eric Anholt
Quoted 10 lines · Daniel Vetter
Quoted 5 lines · James Clarke

Like GNU/Linux, GNU/kFreeBSD's sys/types.h does not define the uintX_t types, which differs from the BSDs' headers. Thus we should include stdint.h to ensure we have all the required integer types.

Would be good to get an ack from some other *bsd that this is still all fine. lgtm otherwise.
-Daniel

Quoted 5 lines
Quoted 3 lines

I think there was some need for inttypes.h instead of stdint like a decade ago when I was working on BSDs, but that was already almost irrelevant then.

Hi, just following up on this; is there still the need for an ACK?

Yeah and ack without a "decades ago" qualifier would be nice. -Daniel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#5 lore raw
Quoted 16 lines · Daniel Vetter
Quoted 15 lines · James Clarke
Quoted 14 lines · Eric Anholt
Quoted 10 lines · Daniel Vetter
Quoted 5 lines · James Clarke

Like GNU/Linux, GNU/kFreeBSD's sys/types.h does not define the uintX_t types, which differs from the BSDs' headers. Thus we should include stdint.h to ensure we have all the required integer types.

Would be good to get an ack from some other *bsd that this is still all fine. lgtm otherwise.
-Daniel

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

I think there was some need for inttypes.h instead of stdint like a decade ago when I was working on BSDs, but that was already almost irrelevant then.

Hi, just following up on this; is there still the need for an ACK?

Yeah and ack without a "decades ago" qualifier would be nice. -Daniel

I have the following from Brooks Davis, FreeBSD contributor and core team member:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

With respect to the thread:
https://lists.freedesktop.org/archives/dri-devel/2019-May/216784.html

I can't see any reason why you'd want to include inttypes.h instead of stdint.h unless you want the intmax_t using types/functions it defines. Your patch is certainly safe on FreeBSD.

At a glance it looks like the same is true (with somewhat different implementation) on OpenBSD.

- -- Brooks

-----BEGIN PGP SIGNATURE-----

iQEcBAEBAgAGBQJc0LwmAAoJEKzQXbSebgfArrIIAItDHcDG5d9QcMnbQibk+d6w EW1OnvijeVZ6PCNcbEEldZEHXsRFOe7zE8sYKSPegDnYve1y8jVyh2YyJtDI7eWL hD2dSY3DGOKatEfd3CxoG2vpN8zv3giDS35hXIqMRF1iD0/jYixTYLcfZgQ7U6Ml 34gxe3q6v30ZoWK5SHCDCac4z0OYjfKTpwZnyNkag/DW5CqqOTQOao6AJOLcosqJ orIUZVl0nvk0dIGzK09ef+BWOyVA5h6f+V3F3x/cK3E2qiTRxVLhhLVaEgdBDp5C hPXH33q/GK54m5jWVaZ5BtpKSA1Et6HjF48+wyJCADQh//DxIWGEAa1fmvKryQw= =oJBq
-----END PGP SIGNATURE-----

Hopefully the signature survives; I converted it from PGP/MIME and it seems to verify locally.

Regards,
James

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#6 lore raw
Quoted 58 lines · James Clarke
Quoted 16 lines · Daniel Vetter
Quoted 15 lines · James Clarke
Quoted 14 lines · Eric Anholt
Quoted 10 lines · Daniel Vetter
Quoted 5 lines · James Clarke

Like GNU/Linux, GNU/kFreeBSD's sys/types.h does not define the uintX_t types, which differs from the BSDs' headers. Thus we should include stdint.h to ensure we have all the required integer types.

Would be good to get an ack from some other *bsd that this is still all fine. lgtm otherwise.
-Daniel

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

I think there was some need for inttypes.h instead of stdint like a decade ago when I was working on BSDs, but that was already almost irrelevant then.

Hi, just following up on this; is there still the need for an ACK?

Yeah and ack without a "decades ago" qualifier would be nice. -Daniel

I have the following from Brooks Davis, FreeBSD contributor and core team member:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

With respect to the thread:
https://lists.freedesktop.org/archives/dri-devel/2019-May/216784.html

I can't see any reason why you'd want to include inttypes.h instead of stdint.h unless you want the intmax_t using types/functions it defines. Your patch is certainly safe on FreeBSD.

At a glance it looks like the same is true (with somewhat different implementation) on OpenBSD.

- -- Brooks

-----BEGIN PGP SIGNATURE-----

iQEcBAEBAgAGBQJc0LwmAAoJEKzQXbSebgfArrIIAItDHcDG5d9QcMnbQibk+d6w EW1OnvijeVZ6PCNcbEEldZEHXsRFOe7zE8sYKSPegDnYve1y8jVyh2YyJtDI7eWL hD2dSY3DGOKatEfd3CxoG2vpN8zv3giDS35hXIqMRF1iD0/jYixTYLcfZgQ7U6Ml 34gxe3q6v30ZoWK5SHCDCac4z0OYjfKTpwZnyNkag/DW5CqqOTQOao6AJOLcosqJ orIUZVl0nvk0dIGzK09ef+BWOyVA5h6f+V3F3x/cK3E2qiTRxVLhhLVaEgdBDp5C hPXH33q/GK54m5jWVaZ5BtpKSA1Et6HjF48+wyJCADQh//DxIWGEAa1fmvKryQw= =oJBq
-----END PGP SIGNATURE-----

Quoted 2 lines

Hopefully the signature survives; I converted it from PGP/MIME and it seems to verify locally.

It's not about the signature, we don't care, it's about the email addresses, so in case there's ever a change in the future we'll have people to contact.

Can you pls resend that patch with those acks (including mail address) added? Needs permission of the people involved ofc (which is usually implied for public mailing lists, but this seems like a private mail).

Thanks, Daniel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v1 1/1
#7 lore raw
In reply to James Clarke
Quoted 5 lines · James Clarke

Like GNU/Linux, GNU/kFreeBSD's sys/types.h does not define the uintX_t types, which differs from the BSDs' headers. Thus we should include stdint.h to ensure we have all the required integer types.

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#8 lore raw
Quoted 10 lines · Eric Anholt

[ Unknown signature status ]

Quoted 5 lines · James Clarke

Like GNU/Linux, GNU/kFreeBSD's sys/types.h does not define the uintX_t types, which differs from the BSDs' headers. Thus we should include stdint.h to ensure we have all the required integer types.

And pushed to drm-misc-next now.

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#9 lore raw
Quoted 9 lines · Eric Anholt
Quoted 7 lines · Eric Anholt

[ Unknown signature status ]

Quoted 4 lines · James Clarke

Like GNU/Linux, GNU/kFreeBSD's sys/types.h does not define the uintX_t types, which differs from the BSDs' headers. Thus we should include stdint.h to ensure we have all the required integer types.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

And pushed to drm-misc-next now.

Thanks Eric!

James, that means you can now sync libdrm to get the fix there as well :)

See include/drm/README for details
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel