Skip to contentSkip to conversation

pylibfdt: Use Python 2 in Makefile

PATCH In review Josef Lusticky 3 participants 4 messages Jan 8, 2019 – Jan 16, 2019 Device tree

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pylibfdt: Use Python 2 in Makefile

pylibfdt needs Python 2 to build.
Replace $(PYTHON) with $(PYTHON2) in pylibfdt Makefile to ensure Python 2 is used to build it.

This fixes build on systems where Python 3 is the default version of the "python" interpreter.

---
 scripts/dtc/pylibfdt/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/dtc/pylibfdt/Makefile +1 -1
index c769d7db06..15e66ad44d 100644
@@ -21,7 +21,7 @@ quiet_cmd_pymod = PYMOD   $@
 		CPPFLAGS="$(HOSTCFLAGS) -I$(LIBFDT_srcdir)" OBJDIR=$(obj) \
 		SOURCES="$(PYLIBFDT_srcs)" \
 		SWIG_OPTS="-I$(LIBFDT_srcdir) -I$(LIBFDT_srcdir)/.." \
-		$(PYTHON) $< --quiet build_ext --inplace
+		$(PYTHON2) $< --quiet build_ext --inplace
 
 $(obj)/_libfdt.so: $(src)/setup.py $(PYLIBFDT_srcs) FORCE
 	$(call if_changed,pymod)
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 pylibfdt: Use Python 2 in Makefile

Quoted 11 lines · Josef Lusticky

pylibfdt needs Python 2 to build.
Replace $(PYTHON) with $(PYTHON2) in pylibfdt Makefile to ensure Python 2 is used to build it.

This fixes build on systems where Python 3 is the default version of the "python" interpreter.

---
 scripts/dtc/pylibfdt/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

At some point we should sync this with upstream which I think plans to support both.

#2 lore raw

PATCH 1/1 pylibfdt: Use Python 2 in Makefile

Quoted 13 lines · Simon Glass
Quoted 11 lines · Josef Lusticky

pylibfdt needs Python 2 to build.
Replace $(PYTHON) with $(PYTHON2) in pylibfdt Makefile to ensure Python 2 is used to build it.

This fixes build on systems where Python 3 is the default version of the "python" interpreter.

---
 scripts/dtc/pylibfdt/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 4 lines

At some point we should sync this with upstream which I think plans to support both.

Given the impending death of Python2, that's good news.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190110/01d13623/attachment.sig>
#3 lore raw
In reply to Josef Lusticky
Quoted 7 lines · Josef Lusticky

pylibfdt needs Python 2 to build.
Replace $(PYTHON) with $(PYTHON2) in pylibfdt Makefile to ensure Python 2 is used to build it.

This fixes build on systems where Python 3 is the default version of the "python" interpreter.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190115/8d95dd85/attachment.sig>