Skip to contentSkip to conversation

btrfs: remove unused workqueue helpers

PATCH In review David Sterba 3 participants 3 messages Jan 17, 2019 – Jan 21, 2019 Btrfs file system

lore
Share & tools
lore

David Sterba

author maintainer
#0 lore raw

PATCH 1/1 btrfs: remove unused workqueue helpers

The _owner helpers havent' been used since its introduction in cb001095ca705dcd95 ("btrfs: plumb fs_info into btrfs_work"), there are no external users of the private wq::fs_info pointer.

---
 fs/btrfs/async-thread.c | 12 ------------
 fs/btrfs/async-thread.h |  2 --
 2 files changed, 14 deletions(-)
fs/btrfs/async-thread.c +0 -12
index d522494698fa..44a7942f0457 100644
@@ -61,18 +61,6 @@ noinline_for_stack void btrfs_##name(struct work_struct *arg)		\
 	normal_work_helper(work);					\
 }
 
-struct btrfs_fs_info *
-btrfs_workqueue_owner(const struct __btrfs_workqueue *wq)
-{
-	return wq->fs_info;
-}
-
-struct btrfs_fs_info *
-btrfs_work_owner(const struct btrfs_work *work)
-{
-	return work->wq->fs_info;
-}
-
 bool btrfs_workqueue_normal_congested(const struct btrfs_workqueue *wq)
 {
 	/*
fs/btrfs/async-thread.h +0 -2
index 7861c9feba5f..3aceb2e6373a 100644
@@ -70,8 +70,6 @@ void btrfs_queue_work(struct btrfs_workqueue *wq,
 void btrfs_destroy_workqueue(struct btrfs_workqueue *wq);
 void btrfs_workqueue_set_max(struct btrfs_workqueue *wq, int max);
 void btrfs_set_work_high_priority(struct btrfs_work *work);
-struct btrfs_fs_info *btrfs_work_owner(const struct btrfs_work *work);
-struct btrfs_fs_info *btrfs_workqueue_owner(const struct __btrfs_workqueue *wq);
 bool btrfs_workqueue_normal_congested(const struct btrfs_workqueue *wq);
 
 #endif
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · David Sterba

The _owner helpers havent' been used since its introduction in cb001095ca705dcd95 ("btrfs: plumb fs_info into btrfs_work"), there are no external users of the private wq::fs_info pointer.

Quoted 42 lines
---
 fs/btrfs/async-thread.c | 12 ------------
 fs/btrfs/async-thread.h |  2 --
 2 files changed, 14 deletions(-)
fs/btrfs/async-thread.c +0 -12
index d522494698fa..44a7942f0457 100644
@@ -61,18 +61,6 @@ noinline_for_stack void btrfs_##name(struct work_struct *arg)		\
 	normal_work_helper(work);					\
 }
 
-struct btrfs_fs_info *
-btrfs_workqueue_owner(const struct __btrfs_workqueue *wq)
-{
-	return wq->fs_info;
-}
-
-struct btrfs_fs_info *
-btrfs_work_owner(const struct btrfs_work *work)
-{
-	return work->wq->fs_info;
-}
-
 bool btrfs_workqueue_normal_congested(const struct btrfs_workqueue *wq)
 {
 	/*
fs/btrfs/async-thread.h +0 -2
index 7861c9feba5f..3aceb2e6373a 100644
@@ -70,8 +70,6 @@ void btrfs_queue_work(struct btrfs_workqueue *wq,
 void btrfs_destroy_workqueue(struct btrfs_workqueue *wq);
 void btrfs_workqueue_set_max(struct btrfs_workqueue *wq, int max);
 void btrfs_set_work_high_priority(struct btrfs_work *work);
-struct btrfs_fs_info *btrfs_work_owner(const struct btrfs_work *work);
-struct btrfs_fs_info *btrfs_workqueue_owner(const struct __btrfs_workqueue *wq);
 bool btrfs_workqueue_normal_congested(const struct btrfs_workqueue *wq);
 
 #endif
#2 lore raw
In reply to David Sterba
Quoted 3 lines · David Sterba

The _owner helpers havent' been used since its introduction in cb001095ca705dcd95 ("btrfs: plumb fs_info into btrfs_work"), there are no external users of the private wq::fs_info pointer.

Tracepoints ... patch dropped.