Skip to contentSkip to conversation

media: imx-csi: Input connections to CSI should be optional

PATCH In review Steve Longerbeam 2 participants 2 messages Jan 17, 2019

Subsystems (5)
lore
Share & tools
lore

Steve Longerbeam

author maintainer
#0 lore raw

PATCH v2 1/1 media: imx-csi: Input connections to CSI should be optional

Some imx platforms do not have fwnode connections to all CSI input ports, and should not be treated as an error. This includes the imx6q SabreAuto, which has no connections to ipu1_csi1 and ipu2_csi0. Return -ENOTCONN in imx_csi_parse_endpoint() so that v4l2-fwnode endpoint parsing will not treat an unconnected CSI input port as an error.

Fixes c893500a16baf ("media: imx: csi: Register a subdev notifier")

---
Changes in v2:
- Added some acks and Cc: stable. No functional changes.

---
 drivers/staging/media/imx/imx-media-csi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/imx/imx-media-csi.c +1 -1
index 555aa45e02e3..e18f58f56dfb 100644
@@ -1861,7 +1861,7 @@ static int imx_csi_parse_endpoint(struct device *dev,
 				  struct v4l2_fwnode_endpoint *vep,
 				  struct v4l2_async_subdev *asd)
 {
-	return fwnode_device_is_available(asd->match.fwnode) ? 0 : -EINVAL;
+	return fwnode_device_is_available(asd->match.fwnode) ? 0 : -ENOTCONN;
 }
 
 static int imx_csi_async_register(struct csi_priv *priv)
Signature · 1 line
2.17.1
reviewer Tested-by on v2 1/1
#1 lore raw

Hi Steve,

Quoted 8 lines · Steve Longerbeam

Some imx platforms do not have fwnode connections to all CSI input ports, and should not be treated as an error. This includes the imx6q SabreAuto, which has no connections to ipu1_csi1 and ipu2_csi0. Return -ENOTCONN in imx_csi_parse_endpoint() so that v4l2-fwnode endpoint parsing will not treat an unconnected CSI input port as an error.

Quoted 6 lines
Fixes c893500a16baf ("media: imx: csi: Register a subdev notifier")

Thanks. This fixes the following error messages:

[    3.449564] imx-ipuv3 2400000.ipu: driver could not parse
port@1/endpoint@0 (-22)
[    3.457342] imx-ipuv3-csi: probe of imx-ipuv3-csi.1 failed with error -22
[    3.464498] imx-ipuv3 2800000.ipu: driver could not parse
port@0/endpoint@0 (-22)
[    3.472120] imx-ipuv3-csi: probe of imx-ipuv3-csi.4 failed with error -22