Skip to contentSkip to conversation

f71882fg: add support f81804 & f81966

PATCH Guenter Roeck 1 participant 1 message Jan 17, 2019 Hardware monitoring

lore
Share & tools
lore

Guenter Roeck

author maintainer
#0 lore raw

On Tue, Jan 15, 2019 at 11:27:22AM +0100, Steffen Kothe wrote:

Please do not send patches as attachment.

Quoted 4 lines

Support for Fintek F81804 & F81966.
Enumerate chip and use Fintek F81866 as template,
because implementation is the same.

Can someone confirm that this correct ? I don't have access to any Fintek datasheets.

Quoted 18 lines
---
 drivers/hwmon/f71882fg.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/hwmon/f71882fg.c +1 -0
index ca54ce5c8e10..8a2bc1ecf991 100644
@@ -62,6 +62,7 @@
 #define SIO_F81768D_ID		0x1210	/* Chipset ID */
 #define SIO_F81865_ID		0x0704	/* Chipset ID */
 #define SIO_F81866_ID		0x1010	/* Chipset ID */
+#define SIO_F81804_ID		0x1502	/* Chipset ID, same for Fintek F81966 */
 
 #define REGION_LENGTH		8
 #define ADDR_REG_OFFSET		5

drivers/hwmon/f71882fg.c static int __init f71882fg_find(int sioaddr, struct f71882fg_sio_data *sio_data) · line 2690

Quoted 6 lines
drivers/hwmon/f71882fg.c +2 -1
@@ -2685,7 +2686,8 @@ static int __init f71882fg_find(int sioaddr, struct f71882fg_sio_data *sio_data)
 		sio_data->type = f81865f;
 		break;
 	case SIO_F81866_ID:
-		sio_data->type = f81866a;
+	case SIO_F81804_ID:
+		sio_data->type = f81866a;	/*correlates to Fintek f81866a*/

The downside of this solution is that the kernel will report that it found a f81866a. Introducing a new ID seems excessive if the chips are truly compatible, but I am open to a better solution.

At the very least, I think it would be appropriate to change the log message to something like "Found XXXX or compatible chip at ...".

Thanks,
Guenter

Quoted 5 lines
drivers/hwmon/f71882fg.c +0 -0
 		break;
 	default:
 		pr_info("Unsupported Fintek device: %04x\n",
Signature · 1 line
2.17.1