package/libsndfile: add upstream post-1.0.28 security fixes
PATCH 1/1 package/libsndfile: add upstream post-1.0.28 security fixes
Fixes the following security vulnerabilities:
CVE-2017-14634: In libsndfile 1.0.28, a divide-by-zero error exists in the function double64_init() in double64.c, which may lead to DoS when playing a crafted audio file
CVE-2017-17456: The function d2alaw_array() in alaw.c of libsndfile 1.0.29pre1 may lead to a remote DoS attack (SEGV on unknown address 0x000000000000), a different vulnerability than CVE-2017-14245
CVE-2017-17457: The function d2ulaw_array() in ulaw.c of libsndfile 1.0.29pre1 may lead to a remote DoS attack (SEGV on unknown address 0x000000000000), a different vulnerability than CVE-2017-14246
CVE-2018-13139: A stack-based buffer overflow in psf_memset in common.c in libsndfile 1.0.28 allows remote attackers to cause a denial of service (application crash) or possibly have unspecified other impact via a crafted audio file. The vulnerability can be triggered by the executable sndfile-deinterleave
CVE-2018-19661: An issue was discovered in libsndfile 1.0.28. There is a buffer over-read in the function i2ulaw_array in ulaw.c that will lead to a denial of service
CVE-2018-19662: An issue was discovered in libsndfile 1.0.28. There is a buffer over-read in the function i2alaw_array in alaw.c that will lead to a denial of service
--- ...it-Check-psf-sf.channels-against-upper-bo.patch | 39 +++++++++ ...heck-MAX_CHANNELS-in-sndfile-deinterleave.patch | 36 ++++++++ ...-a-ulaw-fix-multiple-buffer-overflows-432.patch | 96 ++++++++++++++++++++++ 3 files changed, 171 insertions(+) create mode 100644 package/libsndfile/0001-double64_init-Check-psf-sf.channels-against-upper-bo.patch create mode 100644 package/libsndfile/0002-Check-MAX_CHANNELS-in-sndfile-deinterleave.patch create mode 100644 package/libsndfile/0003-a-ulaw-fix-multiple-buffer-overflows-432.patch
package/libsndfile/0001-double64_init-Check-psf-sf.channels-against-upper-bo.patch new file +39 -0
@@ -0,0 +1,39 @@ +From 85c877d5072866aadbe8ed0c3e0590fbb5e16788 Mon Sep 17 00:00:00 2001 +From: Fabian Greffrath <[email protected]> +Date: Thu, 28 Sep 2017 12:15:04 +0200 +Subject: [PATCH] double64_init: Check psf->sf.channels against upper bound + +This prevents division by zero later in the code. + +While the trivial case to catch this (i.e. sf.channels < 1) has already +been covered, a crafted file may report a number of channels that is +so high (i.e. > INT_MAX/sizeof(double)) that it "somehow" gets +miscalculated to zero (if this makes sense) in the determination of the +blockwidth. Since we only support a limited number of channels anyway, +make sure to check here as well. + +CVE-2017-14634 + +Closes: https://github.com/erikd/libsndfile/issues/318 +Signed-off-by: Erik de Castro Lopo <[email protected]> +Signed-off-by: Peter Korsgaard <[email protected]> +--- + src/double64.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/src/double64.c b/src/double64.c +index b318ea86..78dfef7f 100644 +--- a/src/double64.c ++++ b/src/double64.c +@@ -91,7 +91,7 @@ int + double64_init (SF_PRIVATE *psf) + { static int double64_caps ; + +- if (psf->sf.channels < 1) ++ if (psf->sf.channels < 1 || psf->sf.channels > SF_MAX_CHANNELS) + { psf_log_printf (psf, "double64_init : internal error : channels = %d\n", psf->sf.channels) ; + return SFE_INTERNAL ; + } ; +-- +2.11.0 +
package/libsndfile/0002-Check-MAX_CHANNELS-in-sndfile-deinterleave.patch new file +36 -0
@@ -0,0 +1,36 @@ +From aaea680337267bfb6d2544da878890ee7f1c5077 Mon Sep 17 00:00:00 2001 +From: "Brett T. Warden" <[email protected]> +Date: Tue, 28 Aug 2018 12:01:17 -0700 +Subject: [PATCH] Check MAX_CHANNELS in sndfile-deinterleave + +Allocated buffer has space for only 16 channels. Verify that input file +meets this limit. + +Fixes #397 + +Signed-off-by: Peter Korsgaard <[email protected]> +--- + programs/sndfile-deinterleave.c | 7 +++++++ + 1 file changed, 7 insertions(+) + +diff --git a/programs/sndfile-deinterleave.c b/programs/sndfile-deinterleave.c +index 53660310..225b4d54 100644 +--- a/programs/sndfile-deinterleave.c ++++ b/programs/sndfile-deinterleave.c +@@ -89,6 +89,13 @@ main (int argc, char **argv) + exit (1) ; + } ; + ++ if (sfinfo.channels > MAX_CHANNELS) ++ { printf ("\nError : Input file '%s' has too many (%d) channels. Limit is %d.\n", ++ argv [1], sfinfo.channels, MAX_CHANNELS) ; ++ exit (1) ; ++ } ; ++ ++ + state.channels = sfinfo.channels ; + sfinfo.channels = 1 ; + +-- +2.11.0 +
package/libsndfile/0003-a-ulaw-fix-multiple-buffer-overflows-432.patch new file +96 -0
96 lines not on this page · raw message
Signature · 1 line
2.11.0
PATCH 1/1 package/libsndfile: add upstream post-1.0.28 security fixes
Quoted 25 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Peter" == Peter Korsgaard <[email protected]> writes:
Fixes the following security vulnerabilities:
CVE-2017-14634: In libsndfile 1.0.28, a divide-by-zero error exists in the functiondouble64_init()indouble64.c, which may lead to DoS when playing a crafted audio fileCVE-2017-17456: The function
d2alaw_array()inalaw.cof libsndfile 1.0.29pre1 may lead to a remote DoS attack (SEGV on unknown address0x000000000000), a different vulnerability than CVE-2017-14245CVE-2017-17457: The function
d2ulaw_array()inulaw.cof libsndfile 1.0.29pre1 may lead to a remote DoS attack (SEGV on unknown address0x000000000000), a different vulnerability than CVE-2017-14246CVE-2018-13139: A stack-based buffer overflow in
psf_memsetincommon.cin libsndfile 1.0.28 allows remote attackers to cause a denial of service (application crash) or possibly have unspecified other impact via a crafted audio file. The vulnerability can be triggered by the executable sndfile-deinterleaveCVE-2018-19661: An issue was discovered in libsndfile 1.0.28. There is a buffer over-read in the function
i2ulaw_arrayinulaw.cthat will lead to a denial of service
Quoted 5 lines
CVE-2018-19662: An issue was discovered in libsndfile 1.0.28. There is a buffer over-read in the function
i2alaw_arrayinalaw.cthat will lead to a denial of serviceSigned-off-by Peter Korsgaard <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 package/libsndfile: add upstream post-1.0.28 security fixes
In reply to Peter KorsgaardQuoted 25 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Peter" == Peter Korsgaard <[email protected]> writes:
Fixes the following security vulnerabilities:
CVE-2017-14634: In libsndfile 1.0.28, a divide-by-zero error exists in the functiondouble64_init()indouble64.c, which may lead to DoS when playing a crafted audio fileCVE-2017-17456: The function
d2alaw_array()inalaw.cof libsndfile 1.0.29pre1 may lead to a remote DoS attack (SEGV on unknown address0x000000000000), a different vulnerability than CVE-2017-14245CVE-2017-17457: The function
d2ulaw_array()inulaw.cof libsndfile 1.0.29pre1 may lead to a remote DoS attack (SEGV on unknown address0x000000000000), a different vulnerability than CVE-2017-14246CVE-2018-13139: A stack-based buffer overflow in
psf_memsetincommon.cin libsndfile 1.0.28 allows remote attackers to cause a denial of service (application crash) or possibly have unspecified other impact via a crafted audio file. The vulnerability can be triggered by the executable sndfile-deinterleaveCVE-2018-19661: An issue was discovered in libsndfile 1.0.28. There is a buffer over-read in the function
i2ulaw_arrayinulaw.cthat will lead to a denial of service
Quoted 5 lines
CVE-2018-19662: An issue was discovered in libsndfile 1.0.28. There is a buffer over-read in the function
i2alaw_arrayinalaw.cthat will lead to a denial of serviceSigned-off-by Peter Korsgaard <[email protected]>
Committed to 2018.02.x and 2018.11.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard