Skip to contentSkip to conversation

Revert "tools: imx8image: set dcd_skip to true"

PATCH In review Fabio Estevam 4 participants 4 messages Jan 18, 2019 – Jan 30, 2019 Arm i.MX and Layerscape

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 Revert "tools: imx8image: set dcd_skip to true"

This reverts commit f7e475db4011d18b4ae974154eb022c3af6a4d16.

This commit breaks the boot on imx8qxp evk and it should only be re-applied after imx8qxp evk is converted to SPL.

Revert it for now, so that imx8qxp evk can be functional.

---
 tools/imx8image.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/imx8image.c +1 -1
index 435f308b99..d93de733ab 100644
@@ -968,7 +968,7 @@ int imx8image_copy_image(int outfd, struct image_tool_params *mparams)
 	fprintf(stdout, "CONTAINER SW VERSION:\t0x%04x\n", sw_version);
 
 	build_container(soc, sector_size, emmc_fastboot,
-			img_sp, true, fuse_version, sw_version, outfd);
+			img_sp, false, fuse_version, sw_version, outfd);
 
 	return 0;
 }
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 Revert "tools: imx8image: set dcd_skip to true"

Quoted 29 lines

-----Original Message-----
From: Fabio Estevam [mailto:festevam at gmail.com]
Sent: 2019年1月18日 21:00
To: sbabic at denx.de
Cc: Peng Fan <[email protected]>; u-boot at lists.denx.de; Breno Matheus Lima <[email protected]>; dl-uboot-imx <[email protected]>; Fabio Estevam <[email protected]>
Subject: [PATCH] Revert "tools: imx8image: set dcd_skip to true"

This reverts commit f7e475db4011d18b4ae974154eb022c3af6a4d16.

This commit breaks the boot on imx8qxp evk and it should only be re-applied after imx8qxp evk is converted to SPL.

Revert it for now, so that imx8qxp evk can be functional.

---
 tools/imx8image.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/imx8image.c index renamed from tools/imx8image.c +0 -0

435f308b99..d93de733ab 100644

tools/imx8image.c int imx8image_copy_image(int outfd, struct · line 972

Quoted 6 lines
tools/imx8image.c +1 -1
@@ -968,7 +968,7 @@ int imx8image_copy_image(int outfd, struct
 image_tool_params *mparams)
 	fprintf(stdout, "CONTAINER SW VERSION:\t0x%04x\n", sw_version);
 
 	build_container(soc, sector_size, emmc_fastboot,
-			img_sp, true, fuse_version, sw_version, outfd);
+			img_sp, false, fuse_version, sw_version, outfd);

Thanks for spotting this.

Thanks,
Peng.

Quoted 5 lines
tools/imx8image.c +0 -1
 	return 0;
 }
--

2.17.1

#2 lore raw

PATCH 1/1 Revert "tools: imx8image: set dcd_skip to true"

In reply to Fabio Estevam

Hi Fabio,

Em sex, 18 de jan de 2019 às 11:00, Fabio Estevam <[email protected]> escreveu:

Quoted 10 lines

This reverts commit f7e475db4011d18b4ae974154eb022c3af6a4d16.

This commit breaks the boot on imx8qxp evk and it should only be re-applied after imx8qxp evk is converted to SPL.

Revert it for now, so that imx8qxp evk can be functional.

Thanks,
Breno Lima

#3 lore raw
In reply to Fabio Estevam
Quoted 8 lines

This reverts commit f7e475db4011d18b4ae974154eb022c3af6a4d16. This commit breaks the boot on imx8qxp evk and it should only be re-applied after imx8qxp evk is converted to SPL. Revert it for now, so that imx8qxp evk can be functional.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================