Skip to contentSkip to conversation

USB: serial: keyspan_usa: add proper SPDX lines for .h files

DISCUSSION Johan Hovold 1 participant 1 message Jan 18, 2019 USB

lore
Share & tools
lore
#0 lore raw
Quoted 28 lines · Greg Kroah-Hartman
Quoted 24 lines · Johan Hovold
Quoted 18 lines · Greg Kroah-Hartman

The keyspan_usa??msg.h files are under a BSD-3 style license, so properly label them as such with a SPDX line at the top of the file.

---
 drivers/usb/serial/keyspan_usa26msg.h | 1 +
 drivers/usb/serial/keyspan_usa28msg.h | 1 +
 drivers/usb/serial/keyspan_usa49msg.h | 1 +
 drivers/usb/serial/keyspan_usa67msg.h | 1 +
 drivers/usb/serial/keyspan_usa90msg.h | 1 +
 5 files changed, 5 insertions(+)
drivers/usb/serial/keyspan_usa26msg.h +0 -0
index 09e21e84fc4e..a68f1fb25b8a 100644

drivers/usb/serial/keyspan_usa26msg.h line 1

Quoted 1 line
drivers/usb/serial/keyspan_usa26msg.h +1 -0
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: BSD-3-Clause */

Actually, all but the keyspan_usa67msg.h appear to use a modified BSD-3-Clause with the second (binary-distribution) clause removed.

Quoted 2 lines

I assume you're aware of this and that the BSD-3-Clause identifier is still applicable. Just thought I'd mention it.

Quoted 7 lines

Yeah, I saw that, it's kind of the 2-clause, but there are 3 clauses in it :)

The intent is for it to be 3 clause from what I can tell and what I remember. The goal was to allow the BSDs to be able to use the header file in their kernels, and they did, so all was good. I don't think the company is around anymore, so I doubt it really matters.

Good, thanks for confirming.

Johan