Skip to contentSkip to conversation

ARM: dts: n900: fix mmc1 card detect gpio polarity

PATCH In review Arthur Demchenkov 4 participants 7 messages Jan 21, 2019 – Jan 22, 2019 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: n900: fix mmc1 card detect gpio polarity

Wrong polarity of card detect GPIO pin leads to the system not booting from external mmc, if the back cover of N900 is closed. When the cover is open the system boots fine.

This wasn't noticed before, because of a bug, which was fixed by commit e63201f19 (mmc: omap_hsmmc: Delete platform data GPIO CD and WP).

Kernels up to 4.19 ignored the card detect GPIO from DT.

---
 arch/arm/boot/dts/omap3-n900.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/omap3-n900.dts +1 -1
index 182a53991c90..826920e6b878 100644
@@ -814,7 +814,7 @@
 	/* For debugging, it is often good idea to remove this GPIO.
 	   It means you can remove back cover (to reboot by removing
 	   battery) and still use the MMC card. */
-	cd-gpios = <&gpio6 0 GPIO_ACTIVE_HIGH>; /* 160 */
+	cd-gpios = <&gpio6 0 GPIO_ACTIVE_LOW>; /* 160 */
 };
 
 /* most boards use vaux3, only some old versions use vmmc2 instead */
Signature · 1 line
2.11.0
#1 lore raw

Hi,

Quoted 7 lines · Arthur Demchenkov

Wrong polarity of card detect GPIO pin leads to the system not booting from external mmc, if the back cover of N900 is closed. When the cover is open the system boots fine.

This wasn't noticed before, because of a bug, which was fixed by commit e63201f19 (mmc: omap_hsmmc: Delete platform data GPIO CD and WP).

Aaro, does this work for your test case too?

Quoted 1 line

Kernels up to 4.19 ignored the card detect GPIO from DT.

Hmm so should this have a Fixes tag or not?

Regards,

Tony

Quoted 19 lines
 arch/arm/boot/dts/omap3-n900.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/omap3-n900.dts +1 -1
index 182a53991c90..826920e6b878 100644
@@ -814,7 +814,7 @@
 	/* For debugging, it is often good idea to remove this GPIO.
 	   It means you can remove back cover (to reboot by removing
 	   battery) and still use the MMC card. */
-	cd-gpios = <&gpio6 0 GPIO_ACTIVE_HIGH>; /* 160 */
+	cd-gpios = <&gpio6 0 GPIO_ACTIVE_LOW>; /* 160 */
 };
 
 /* most boards use vaux3, only some old versions use vmmc2 instead */
Signature · 1 line
2.11.0
#2 lore raw

Hi,

Quoted 10 lines · Tony Lindgren
Quoted 7 lines · Arthur Demchenkov

Wrong polarity of card detect GPIO pin leads to the system not booting from external mmc, if the back cover of N900 is closed. When the cover is open the system boots fine.

This wasn't noticed before, because of a bug, which was fixed by commit e63201f19 (mmc: omap_hsmmc: Delete platform data GPIO CD and WP).

Aaro, does this work for your test case too?

Yeah..

Quoted 3 lines
Quoted 1 line

Kernels up to 4.19 ignored the card detect GPIO from DT.

Hmm so should this have a Fixes tag or not?

I think it should as v4.20 is broken.

A.

Quoted 23 lines

Regards,

Tony

Quoted 19 lines
 arch/arm/boot/dts/omap3-n900.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/omap3-n900.dts +1 -1
index 182a53991c90..826920e6b878 100644
@@ -814,7 +814,7 @@
 	/* For debugging, it is often good idea to remove this GPIO.
 	   It means you can remove back cover (to reboot by removing
 	   battery) and still use the MMC card. */
-	cd-gpios = <&gpio6 0 GPIO_ACTIVE_HIGH>; /* 160 */
+	cd-gpios = <&gpio6 0 GPIO_ACTIVE_LOW>; /* 160 */
 };
 
 /* most boards use vaux3, only some old versions use vmmc2 instead */
Signature · 1 line
2.11.0
#3 lore raw
In reply to Arthur Demchenkov
Quoted 10 lines · Arthur Demchenkov

Wrong polarity of card detect GPIO pin leads to the system not booting from external mmc, if the back cover of N900 is closed. When the cover is open the system boots fine.

This wasn't noticed before, because of a bug, which was fixed by commit e63201f19 (mmc: omap_hsmmc: Delete platform data GPIO CD and WP).

Kernels up to 4.19 ignored the card detect GPIO from DT.

Signed-off-by tag is missing.

#4 lore raw
Quoted 6 lines · Fabio Estevam
Quoted 5 lines · Arthur Demchenkov

Wrong polarity of card detect GPIO pin leads to the system not booting from external mmc, if the back cover of N900 is closed. When the cover is open the system boots fine.

Quoted 7 lines
Quoted 5 lines

This wasn't noticed before, because of a bug, which was fixed by commit e63201f19 (mmc: omap_hsmmc: Delete platform data GPIO CD and WP).

Kernels up to 4.19 ignored the card detect GPIO from DT.

Signed-off-by tag is missing.

Arthur, please reply with your Signed-off-by for this thread so I can apply it. That is unless you want to repost the patch for updated comments etc.

Regards,

Tony