External trigger stamp fifo support for ptp_qoriq
Subsystems (6)
Yangbo Lu
maintainerv3 cover External trigger stamp fifo support for ptp_qoriq
This patch-set is to add external trigger stamp fifo support by a new binding "fsl,extts-fifo", and to add fiper pulse loopback support which is very useful for validating trigger without external hardware. Also fixed issues in interrupt enabling/handling.
"fsl,extts-fifo" is required to be added into 1588 timer dts node whose hardware supports it. The work will be done for some QorIQ platforms dts in the near future.
Yangbo Lu (6):
ptp_qoriq: fix interrupt enabling and handling
ptp_qoriq: support external trigger stamp FIFO
dt-binding: ptp_qoriq: document "fsl,extts-fifo" property
ARM: dts: ls1021a: add 1588 external trigger stamp fifo support
ptp: add debugfs support for ptp_qoriq
MAINTAINERS: add drivers/ptp/ptp_qoriq_debugfs.c into QorIQ PTP list
.../devicetree/bindings/ptp/ptp-qoriq.txt | 2 + MAINTAINERS | 1 + arch/arm/boot/dts/ls1021a.dtsi | 1 + drivers/ptp/Kconfig | 2 +- drivers/ptp/Makefile | 4 +- drivers/ptp/ptp_qoriq.c | 129 +++++++++++++------- drivers/ptp/ptp_qoriq_debugfs.c | 101 +++++++++++++++ include/linux/fsl/ptp_qoriq.h | 15 +++ 8 files changed, 210 insertions(+), 45 deletions(-) create mode 100644 drivers/ptp/ptp_qoriq_debugfs.c
Yangbo Lu
maintainerPATCH v3 1/6 ptp_qoriq: fix interrupt enabling and handling
The tmr_tevent register would update event bits no matter tmr_temask bits were set or not. So we should get interrupts by tmr_tevent & tmr_temask, and clean up interrupts in tmr_tevent before enabling them.
---
Changes for v2:
- Remove useless lock/register operations.
Changes for v3:
- None.
--- drivers/ptp/ptp_qoriq.c | 62 +++++++++++++++++++++++----------------------- 1 files changed, 31 insertions(+), 31 deletions(-)
drivers/ptp/ptp_qoriq.c +31 -31
@@ -98,11 +98,18 @@ static irqreturn_t isr(int irq, void *priv)struct qoriq_ptp_registers *regs = &qoriq_ptp->regs;struct ptp_clock_event event;u64 ns; -u32 ack =0 , lo, hi, mask, val; +u32 ack =0 , lo, hi, mask, val, irqs; + +spin_lock (&qoriq_ptp->lock); val =qoriq_read (®s->ctrl_regs->tmr_tevent); + mask =qoriq_read (®s->ctrl_regs->tmr_temask); + +spin_unlock (&qoriq_ptp->lock); + + irqs = val & mask; -if (val &ETS1 ) { +if (irqs &ETS1 ) { ack |=ETS1 ; hi =qoriq_read (®s->etts_regs->tmr_etts1_h); lo =qoriq_read (®s->etts_regs->tmr_etts1_l);
@@ -113,7 +120,7 @@ static irqreturn_t isr(int irq, void *priv)ptp_clock_event (qoriq_ptp->clock, &event); } -if (val &ETS2 ) { +if (irqs &ETS2 ) { ack |=ETS2 ; hi =qoriq_read (®s->etts_regs->tmr_etts2_h); lo =qoriq_read (®s->etts_regs->tmr_etts2_l);
@@ -124,7 +131,7 @@ static irqreturn_t isr(int irq, void *priv)ptp_clock_event (qoriq_ptp->clock, &event); } -if (val &ALM2 ) { +if (irqs &ALM2 ) { ack |=ALM2 ;if (qoriq_ptp->alarm_value) { event.type =PTP_CLOCK_ALARM ;
@@ -136,13 +143,10 @@ static irqreturn_t isr(int irq, void *priv) ns = qoriq_ptp->alarm_value + qoriq_ptp->alarm_interval; hi = ns >>32 ; lo = ns &0xffffffff ; -spin_lock (&qoriq_ptp->lock);qoriq_write (®s->alarm_regs->tmr_alarm2_l, lo);qoriq_write (®s->alarm_regs->tmr_alarm2_h, hi); -spin_unlock (&qoriq_ptp->lock); qoriq_ptp->alarm_value = ns; }else { -qoriq_write (®s->ctrl_regs->tmr_tevent,ALM2 );spin_lock (&qoriq_ptp->lock); mask =qoriq_read (®s->ctrl_regs->tmr_temask); mask &= ~ALM2EN ;
@@ -153,7 +157,7 @@ static irqreturn_t isr(int irq, void *priv) } } -if (val &PP1 ) { +if (irqs &PP1 ) { ack |=PP1 ; event.type =PTP_CLOCK_PPS ;ptp_clock_event (qoriq_ptp->clock, &event);
@@ -260,7 +264,7 @@ static int ptp_qoriq_enable(struct ptp_clock_info *ptp, struct qoriq_ptp *qoriq_ptp = container_of(ptp, struct qoriq_ptp, caps);struct qoriq_ptp_registers *regs = &qoriq_ptp->regs;unsigned long flags; -u32 bit, mask; +u32 bit, mask =0 ;switch (rq->type) {case PTP_CLK_REQ_EXTTS :
@@ -274,32 +278,28 @@ static int ptp_qoriq_enable(struct ptp_clock_info *ptp,default :return -EINVAL ; } -spin_lock_irqsave (&qoriq_ptp->lock, flags); - mask =qoriq_read (®s->ctrl_regs->tmr_temask); -if (on) - mask |= bit; -else - mask &= ~bit; -qoriq_write (®s->ctrl_regs->tmr_temask, mask); -spin_unlock_irqrestore (&qoriq_ptp->lock, flags); -return 0 ; - +break ;case PTP_CLK_REQ_PPS : -spin_lock_irqsave (&qoriq_ptp->lock, flags); - mask =qoriq_read (®s->ctrl_regs->tmr_temask); -if (on) - mask |=PP1EN ; -else - mask &= ~PP1EN ; -qoriq_write (®s->ctrl_regs->tmr_temask, mask); -spin_unlock_irqrestore (&qoriq_ptp->lock, flags); -return 0 ; - -default : + bit =PP1EN ;break ; +default : +return -EOPNOTSUPP ; } -return -EOPNOTSUPP ; +spin_lock_irqsave (&qoriq_ptp->lock, flags); + + mask =qoriq_read (®s->ctrl_regs->tmr_temask); +if (on) { + mask |= bit; +qoriq_write (®s->ctrl_regs->tmr_tevent, bit); + }else { + mask &= ~bit; + } + +qoriq_write (®s->ctrl_regs->tmr_temask, mask); + +spin_unlock_irqrestore (&qoriq_ptp->lock, flags); +return 0 ; }static const struct ptp_clock_info ptp_qoriq_caps = {
Signature · 1 line
1.7.1
Yangbo Lu
maintainerPATCH v3 2/6 ptp_qoriq: support external trigger stamp FIFO
In reply to Yangbo LuThe external trigger stamp FIFO was introduced as a new feature for QorIQ 1588 timer IP block. This patch is to support it by adding a new dts property "fsl,extts-fifo". Any QorIQ 1588 timer supporting this feature is required to add this property in its dts node.
In addition, the FIFO should be cleaned up before enabling external trigger interrupts. Otherwise, there will be interrupts immediately just after enabling external trigger interrupts.
---
Changes for v2:
- Converted to use extts_clean_up instead.
Changes for v3:
- None.
--- drivers/ptp/ptp_qoriq.c | 68 ++++++++++++++++++++++++++++++++-------- include/linux/fsl/ptp_qoriq.h | 3 ++ 2 files changed, 57 insertions(+), 14 deletions(-)
drivers/ptp/ptp_qoriq.c +54 -14
@@ -88,6 +88,49 @@ static void set_fipers(struct qoriq_ptp *qoriq_ptp)qoriq_write (®s->fiper_regs->tmr_fiper2, qoriq_ptp->tmr_fiper2); } +static int extts_clean_up (struct qoriq_ptp *qoriq_ptp,int index, +bool update_event) +{ +struct qoriq_ptp_registers *regs = &qoriq_ptp->regs; +struct ptp_clock_event event; +void __iomem *reg_etts_l; +void __iomem *reg_etts_h; +u32 valid, stat, lo, hi; + +switch (index) { +case 0 : + valid =ETS1_VLD ; + reg_etts_l = ®s->etts_regs->tmr_etts1_l; + reg_etts_h = ®s->etts_regs->tmr_etts1_h; +break ; +case 1 : + valid =ETS2_VLD ; + reg_etts_l = ®s->etts_regs->tmr_etts2_l; + reg_etts_h = ®s->etts_regs->tmr_etts2_h; +break ; +default : +return -EINVAL ; + } + + event.type =PTP_CLOCK_EXTTS ; + event.index = index; + +do { + lo =qoriq_read (reg_etts_l); + hi =qoriq_read (reg_etts_h); + +if (update_event) { + event.timestamp = ((u64 ) hi) <<32 ; + event.timestamp |= lo; +ptp_clock_event (qoriq_ptp->clock, &event); + } + + stat =qoriq_read (®s->ctrl_regs->tmr_stat); + }while (qoriq_ptp->extts_fifo_support && (stat & valid)); + +return 0 ; +} +/* * Interrupt service routine */
@@ -111,24 +154,12 @@ static irqreturn_t isr(int irq, void *priv)if (irqs &ETS1 ) { ack |=ETS1 ; - hi =qoriq_read (®s->etts_regs->tmr_etts1_h); - lo =qoriq_read (®s->etts_regs->tmr_etts1_l); - event.type =PTP_CLOCK_EXTTS ; - event.index =0 ; - event.timestamp = ((u64 ) hi) <<32 ; - event.timestamp |= lo; -ptp_clock_event (qoriq_ptp->clock, &event); +extts_clean_up (qoriq_ptp,0 , true); }if (irqs &ETS2 ) { ack |=ETS2 ; - hi =qoriq_read (®s->etts_regs->tmr_etts2_h); - lo =qoriq_read (®s->etts_regs->tmr_etts2_l); - event.type =PTP_CLOCK_EXTTS ; - event.index =1 ; - event.timestamp = ((u64 ) hi) <<32 ; - event.timestamp |= lo; -ptp_clock_event (qoriq_ptp->clock, &event); +extts_clean_up (qoriq_ptp,1 , true); }if (irqs &ALM2 ) {
@@ -278,6 +309,10 @@ static int ptp_qoriq_enable(struct ptp_clock_info *ptp,default :return -EINVAL ; } + +if (on) +extts_clean_up (qoriq_ptp, rq->extts.index, false); +break ;case PTP_CLK_REQ_PPS : bit =PP1EN ;
@@ -441,6 +476,11 @@ static int qoriq_ptp_probe(struct platform_device *dev)if (of_property_read_u32 (node,"fsl,cksel" , &qoriq_ptp->cksel)) qoriq_ptp->cksel =DEFAULT_CKSEL ; +if (of_property_read_bool (node,"fsl,extts-fifo" )) + qoriq_ptp->extts_fifo_support = true; +else + qoriq_ptp->extts_fifo_support = false; +if (of_property_read_u32 (node,"fsl,tclk-period" , &qoriq_ptp->tclk_period) || of_property_read_u32(node,
include/linux/fsl/ptp_qoriq.h +3 -0
@@ -120,6 +120,8 @@ struct qoriq_ptp_registers {/* Bit definitions for the TMR_STAT register */ #define STAT_VEC_SHIFT (0)/* Timer general purpose status vector */ #define STAT_VEC_MASK (0x3f) +#define ETS1_VLD (1<<24) +#define ETS2_VLD (1<<25)/* Bit definitions for the TMR_PRSC register */ #define PRSC_OCK_SHIFT (0)/* Output clock division/prescale factor. */
@@ -141,6 +143,7 @@ struct qoriq_ptp {struct ptp_clock *clock;struct ptp_clock_info caps;struct resource *rsrc; +bool extts_fifo_support;int irq;int phc_index;u64 alarm_interval;/* for periodic alarm */
Signature · 1 line
1.7.1
Yangbo Lu
maintainerPATCH v3 3/6 dt-binding: ptp_qoriq: document "fsl,extts-fifo" property
In reply to Yangbo LuDocumented "fsl,extts-fifo" property.
---
Changes for v2:
- Modified binding description.
Changes for v3:
- Rephrased fsl,extts-fifo.
--- .../devicetree/bindings/ptp/ptp-qoriq.txt | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
Documentation/devicetree/bindings/ptp/ptp-qoriq.txt +2 -0
@@ -17,6 +17,8 @@ Clock Properties: - fsl,tmr-fiper1 Fixed interval period pulse generator. - fsl,tmr-fiper2 Fixed interval period pulse generator. - fsl,max-adj Maximum frequency adjustment in parts per billion. + - fsl,extts-fifo The presence of this property indicates hardware + support for the external trigger stamp FIFO. These properties set the operational parameters for the PTP clock. You must choose these carefully for the clock to work right.
Signature · 1 line
1.7.1
Re: [v3, 3/6] dt-binding: ptp_qoriq: document "fsl,extts-fifo" property
Quoted 12 lines · Yangbo Lu
Documented "fsl,extts-fifo" property.
Signed-off-by Yangbo Lu <[email protected]>---
Changes for v2:
- Modified binding description.
Changes for v3:
- Rephrased fsl,extts-fifo.--- .../devicetree/bindings/ptp/ptp-qoriq.txt | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
Yangbo Lu
maintainerPATCH v3 4/6 ARM: dts: ls1021a: add 1588 external trigger stamp fifo support
In reply to Yangbo LuThis patch is to add external trigger stamp fifo support for 1588 timer.
---
Changes for v2:
- None.
Changes for v3:
- None.
--- arch/arm/boot/dts/ls1021a.dtsi | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/boot/dts/ls1021a.dtsi +1 -0
@@ -706,6 +706,7 @@ fsl,tmr-fiper1 = <999999995>; fsl,tmr-fiper2 = <99990>; fsl,max-adj = <499999999>; + fsl,extts-fifo; }; enet0: ethernet@2d10000 {
Signature · 1 line
1.7.1
Yangbo Lu
maintainerPATCH v3 5/6 ptp: add debugfs support for ptp_qoriq
In reply to Yangbo LuThis patch is to add debugfs support for ptp_qoriq. Current debugfs supports to control fiper1/fiper2 loopback mode. If the loopback mode is enabled, the fiper1/fiper2 pulse is looped back into trigger1/ trigger2 input. This is very useful for validating hardware and driver without external hardware. Below is an example to enable fiper1 loopback.
echo 1 > /sys/kernel/debug/2d10e00.ptp_clock/fiper1-loopback
---
Changes for v2:
- None.
Changes for v3:
- Converted to use debugfs.
--- drivers/ptp/Kconfig | 2 +- drivers/ptp/Makefile | 4 +- drivers/ptp/ptp_qoriq.c | 3 + drivers/ptp/ptp_qoriq_debugfs.c | 101 +++++++++++++++++++++++++++++++++++++++ include/linux/fsl/ptp_qoriq.h | 12 +++++ 5 files changed, 120 insertions(+), 2 deletions(-) create mode 100644 drivers/ptp/ptp_qoriq_debugfs.c
drivers/ptp/Kconfig +1 -1
@@ -53,7 +53,7 @@ config PTP_1588_CLOCK_QORIQ packets using the SO_TIMESTAMPING API. To compile this driver as a module, choose M here: the module - will be called ptp_qoriq. + will be called ptp-qoriq. config PTP_1588_CLOCK_IXP46X tristate "Intel IXP46x as PTP clock"
drivers/ptp/Makefile +3 -1
@@ -9,4 +9,6 @@ obj-$(CONFIG_PTP_1588_CLOCK_DTE) += ptp_dte.o obj-$(CONFIG_PTP_1588_CLOCK_IXP46X) += ptp_ixp46x.o obj-$(CONFIG_PTP_1588_CLOCK_PCH) += ptp_pch.o obj-$(CONFIG_PTP_1588_CLOCK_KVM) += ptp_kvm.o -obj-$(CONFIG_PTP_1588_CLOCK_QORIQ) += ptp_qoriq.o +obj-$(CONFIG_PTP_1588_CLOCK_QORIQ) += ptp-qoriq.o +ptp-qoriq-y += ptp_qoriq.o +ptp-qoriq-$(CONFIG_DEBUG_FS) += ptp_qoriq_debugfs.o
drivers/ptp/ptp_qoriq.c +3 -0
@@ -471,6 +471,7 @@ static int qoriq_ptp_probe(struct platform_device *dev) err = -EINVAL ; + qoriq_ptp->dev = &dev->dev; qoriq_ptp->caps = ptp_qoriq_caps;if (of_property_read_u32 (node,"fsl,cksel" , &qoriq_ptp->cksel))
@@ -572,6 +573,7 @@ static int qoriq_ptp_probe(struct platform_device *dev) } qoriq_ptp->phc_index =ptp_clock_index (qoriq_ptp->clock); +ptp_qoriq_create_debugfs (qoriq_ptp);platform_set_drvdata (dev, qoriq_ptp);return 0 ;
@@ -597,6 +599,7 @@ static int qoriq_ptp_remove(struct platform_device *dev)qoriq_write (®s->ctrl_regs->tmr_temask,0 );qoriq_write (®s->ctrl_regs->tmr_ctrl,0 ); +ptp_qoriq_remove_debugfs (qoriq_ptp);ptp_clock_unregister (qoriq_ptp->clock);iounmap (qoriq_ptp->base);release_resource (qoriq_ptp->rsrc);
drivers/ptp/ptp_qoriq_debugfs.c new file +101 -0
101 lines not on this page · raw message
include/linux/fsl/ptp_qoriq.h +12 -0
@@ -143,6 +143,8 @@ struct qoriq_ptp {struct ptp_clock *clock;struct ptp_clock_info caps;struct resource *rsrc; +struct dentry *debugfs_root; +struct device *dev;bool extts_fifo_support;int irq;int phc_index;
@@ -169,4 +171,14 @@ static inline void qoriq_write(unsigned __iomem *addr, u32 val) iowrite32be(val, addr); } +#ifdef CONFIG_DEBUG_FS +void ptp_qoriq_create_debugfs (struct qoriq_ptp *qoriq_ptp); +void ptp_qoriq_remove_debugfs (struct qoriq_ptp *qoriq_ptp); +#else +static inline void ptp_qoriq_create_debugfs (struct qoriq_ptp *qoriq_ptp) +{ } +static inline void ptp_qoriq_remove_debugfs (struct qoriq_ptp *qoriq_ptp) +{ } +#endif +#endif
Signature · 1 line
1.7.1
Yangbo Lu
maintainerPATCH v3 6/6 MAINTAINERS: add drivers/ptp/ptp_qoriq_debugfs.c into QorIQ PTP list
In reply to Yangbo LuAdded drivers/ptp/ptp_qoriq_debugfs.c into QorIQ PTP clock driver list.
---
Changes for v3:
- Added this patch.
--- MAINTAINERS | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
MAINTAINERS +1 -0
@@ -6088,6 +6088,7 @@ M: Yangbo Lu <[email protected]> L: [email protected] S: Maintained F: drivers/ptp/ptp_qoriq.c +F: drivers/ptp/ptp_qoriq_debugfs.c F: include/linux/fsl/ptp_qoriq.h F: Documentation/devicetree/bindings/ptp/ptp-qoriq.txt
Signature · 1 line
1.7.1
David Miller
maintainerFrom: Yangbo Lu <[email protected]>
Date: Mon, 21 Jan 2019 18:41:37 +0800
Quoted 8 lines
This patch-set is to add external trigger stamp fifo support by a new binding "fsl,extts-fifo", and to add fiper pulse loopback support which is very useful for validating trigger without external hardware. Also fixed issues in interrupt enabling/handling.
"fsl,extts-fifo" is required to be added into 1588 timer dts node whose hardware supports it. The work will be done for some QorIQ platforms dts in the near future.
Series applied to net-next.