Skip to contentSkip to conversation

ASoC: dapm: Skip suspending widgets with ignore flag

PATCH In review Zhiwei Jiang 2 participants 2 messages Jan 21, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: dapm: Skip suspending widgets with ignore flag

For endpoint wigdets which have set the suspend ignore flag, asoc shouldn't mark them as dirty when ASoC suspend function is called.

---
 sound/soc/soc-dapm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/soc-dapm.c +1 -1
index a5178845065b..68c49090f561 100644
@@ -278,7 +278,7 @@ void dapm_mark_endpoints_dirty(struct snd_soc_card *card)
 	mutex_lock(&card->dapm_mutex);
 
 	list_for_each_entry(w, &card->widgets, list) {
-		if (w->is_ep) {
+		if (w->is_ep && !w->ignore_suspend) {
 			dapm_mark_dirty(w, "Rechecking endpoints");
 			if (w->is_ep & SND_SOC_DAPM_EP_SINK)
 				dapm_widget_invalidate_output_paths(w);
Signature · 1 line
2.19.0
maintainer
#1 lore raw
Quoted 2 lines · Zhiwei Jiang

For endpoint wigdets which have set the suspend ignore flag, asoc shouldn't mark them as dirty when ASoC suspend function is called.

Why not? It will cost us a bit of time confirming that they should be kept enabled if they're part of a valid path but it also ensures that we've reexamined everything which is a bit safer.