drm/amd/display: Fix disabled cursor on top screen edge
PATCH 1/1 drm/amd/display: Fix disabled cursor on top screen edge
From: Nicholas Kazlauskas <[email protected]>
[Why]
The cursor vanishes when touching the top of edge of the screen for Raven on Linux.
This occurs because the cursor height is not taken into account when deciding to disable the cursor.
[How]
Factor in the cursor height into the cursor calculations - and mimic the existing x position calculations.
Fixes 94a4ffd1d40b ("drm/amd/display: fix PIP bugs on Dal3")
Signed-off-by Nicholas Kazlauskas <[email protected]>
Reviewed-by Harry Wentland <[email protected]>
Acked-by Leo Li <[email protected]>
Signed-off-by Alex Deucher <[email protected]>
(cherry picked from commit ae1cf20df7a9c60ff5ef41c3315c33c1a5fafd77)
--- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp.c | 2 +- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp.c +1 -1
@@ -463,7 +463,7 @@ void dpp1_set_cursor_position(if (src_y_offset >= (int )param->viewport.height) cur_en =0 ;/* not visible beyond bottom edge*/ -if (src_y_offset <0 ) +if (src_y_offset + (int )height <=0 ) cur_en =0 ;/* not visible beyond top edge*/ REG_UPDATE(CURSOR0_CONTROL,
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c +1 -1
@@ -1134,7 +1134,7 @@ void hubp1_cursor_set_position(if (src_y_offset >= (int )param->viewport.height) cur_en =0 ;/* not visible beyond bottom edge*/ -if (src_y_offset <0 )//+ (int)hubp->curs_attr.height +if (src_y_offset + (int )hubp->curs_attr.height <=0 ) cur_en =0 ;/* not visible beyond top edge*/ if (cur_en &®_READ (CURSOR_SURFACE_ADDRESS ) ==0 )
Signature · 1 line
2.20.1