Skip to contentSkip to conversation

am335x: Changes in DDR init procedure to Support Samsung K4B2G1646EBIH9 memory chip

RFC PATCH New Maciej Zagrabski 2 participants 2 messages Jan 21, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 am335x: Changes in DDR init procedure to Support Samsung K4B2G1646EBIH9 memory chip

K4B2G1646EBIH9 Samsung memory chip used now on chiliSOM requires refresh register REF CTRL to be initialized with large enough value, faster than it is implemented in config_sdram in ddr.c for am33xx, that mean before setting ZQ CTRL. Change should not interferee with already supported DDR chips cause refresh rate value is large enough to cover initialization, but it will finish during udelay below anyway. If this is not acceptable I can ifdef this line with config introduced in previous patch.

---
 arch/arm/mach-omap2/am33xx/ddr.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
arch/arm/mach-omap2/am33xx/ddr.c +3 -2
index be6f4d72ccd..3684508bb1c 100644
@@ -171,12 +171,13 @@ void config_sdram(const struct emif_regs *regs, int nr)
 	writel(regs->ref_ctrl, &emif_reg[nr]->emif_sdram_ref_ctrl);
 #else
 	if (regs->zq_config) {
+		/* Trigger initialization */
+		writel(0x00003100, &emif_reg[nr]->emif_sdram_ref_ctrl);
+
 		writel(regs->zq_config, &emif_reg[nr]->emif_zq_config);
 		writel(regs->sdram_config, &cstat->secure_emif_sdram_config);
 		writel(regs->sdram_config, &emif_reg[nr]->emif_sdram_config);
 
-		/* Trigger initialization */
-		writel(0x00003100, &emif_reg[nr]->emif_sdram_ref_ctrl);
 		/* Wait 1ms because of L3 timeout error */
 		udelay(1000);
 
Signature · 1 line
2.11.0
#1 lore raw

RFC PATCH 1/1 am335x: Changes in DDR init procedure to Support Samsung K4B2G1646EBIH9 memory chip

Quoted 24 lines · Maciej Zagrabski

K4B2G1646EBIH9 Samsung memory chip used now on chiliSOM requires refresh register REF CTRL to be initialized with large enough value, faster than it is implemented in config_sdram in ddr.c for am33xx, that mean before setting ZQ CTRL. Change should not interferee with already supported DDR chips cause refresh rate value is large enough to cover initialization, but it will finish during udelay below anyway. If this is not acceptable I can ifdef this line with config introduced in previous patch.

---
 arch/arm/mach-omap2/am33xx/ddr.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
arch/arm/mach-omap2/am33xx/ddr.c +2 -0
index be6f4d72ccd..3684508bb1c 100644
@@ -171,12 +171,13 @@ void config_sdram(const struct emif_regs *regs, int nr)
 	writel(regs->ref_ctrl, &emif_reg[nr]->emif_sdram_ref_ctrl);
 #else
 	if (regs->zq_config) {
+		/* Trigger initialization */
+		writel(0x00003100, &emif_reg[nr]->emif_sdram_ref_ctrl);

arch/arm/mach-omap2/am33xx/ddr.c void config_sdram(const struct emif_regs *regs, int nr) · line 183

Quoted 10 lines
arch/arm/mach-omap2/am33xx/ddr.c +1 -2
+
 		writel(regs->zq_config, &emif_reg[nr]->emif_zq_config);
 		writel(regs->sdram_config, &cstat->secure_emif_sdram_config);
 		writel(regs->sdram_config, &emif_reg[nr]->emif_sdram_config);
 
-		/* Trigger initialization */
-		writel(0x00003100, &emif_reg[nr]->emif_sdram_ref_ctrl);
 		/* Wait 1ms because of L3 timeout error */
 		udelay(1000);
 

Adding James Doublesin here as I know he knows all the ins and outs of these particular parts. Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190121/a1481f85/attachment.sig>