Skip to contentSkip to conversation

drm/amdkfd: Fix if preprocessor statement above kfd_fill_iolink_info_for_cpu

PATCH In review Nathan Chancellor 3 participants 3 messages Jan 21, 2019 – Feb 4, 2019 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 drm/amdkfd: Fix if preprocessor statement above kfd_fill_iolink_info_for_cpu

Clang warns:

drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c:866:5: warning:
'CONFIG_X86_64' is not defined, evaluates to 0 [-Wundef]

#if CONFIG_X86_64
    ^

1 warning generated.

Fixes d1c234e2cd10 ("drm/amdkfd: Allow building KFD on ARM64 (v2)")

---

Resending as I forgot to add the lists...

 drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdkfd/kfd_crat.c +1 -1
index 5d85ff341385..2e7c44955f43 100644
@@ -863,7 +863,7 @@ static int kfd_fill_mem_info_for_cpu(int numa_node_id, int *avail_size,
 	return 0;
 }
 
-#if CONFIG_X86_64
+#ifdef CONFIG_X86_64
 static int kfd_fill_iolink_info_for_cpu(int numa_node_id, int *avail_size,
 				uint32_t *num_entries,
 				struct crat_subtype_iolink *sub_type_hdr)
Signature · 1 line
2.20.1
maintainer
#2 lore raw

Thank you, Nathan. I applied your patch to amd-staging-drm-next.

Sorry for the late response. I'm catching up with my email backlog after a vacation.

Regards,
  Felix

Quoted 30 lines · Nathan Chancellor

Clang warns:

drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c:866:5: warning:
'CONFIG_X86_64' is not defined, evaluates to 0 [-Wundef]

#if CONFIG_X86_64
     ^

1 warning generated.

Fixes d1c234e2cd10 ("drm/amdkfd: Allow building KFD on ARM64 (v2)")

---

Resending as I forgot to add the lists...

  drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdkfd/kfd_crat.c +1 -1
index 5d85ff341385..2e7c44955f43 100644
@@ -863,7 +863,7 @@ static int kfd_fill_mem_info_for_cpu(int numa_node_id, int *avail_size,
  	return 0;
  }
 
-#if CONFIG_X86_64
+#ifdef CONFIG_X86_64
  static int kfd_fill_iolink_info_for_cpu(int numa_node_id, int *avail_size,
  				uint32_t *num_entries,
  				struct crat_subtype_iolink *sub_type_hdr)
maintainer
#3 lore raw

Alex,

can you get this into next and resend the pull?

I don't like adding warnings.

Dave.

Quoted 35 lines · Felix

Thank you, Nathan. I applied your patch to amd-staging-drm-next.

Sorry for the late response. I'm catching up with my email backlog after a vacation.

Regards,
Felix

Quoted 25 lines · Nathan Chancellor

Clang warns:

drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c:866:5: warning:
'CONFIG_X86_64' is not defined, evaluates to 0 [-Wundef]

#if CONFIG_X86_64
     ^

1 warning generated.

Fixes d1c234e2cd10 ("drm/amdkfd: Allow building KFD on ARM64 (v2)")

---

Resending as I forgot to add the lists...

  drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdkfd/kfd_crat.c +0 -0
index 5d85ff341385..2e7c44955f43 100644
@@ -863,7 +863,7 @@ static int kfd_fill_mem_info_for_cpu(int numa_node_id, int *avail_size,
      return 0;
  }
 
Quoted 9 lines

drivers/gpu/drm/amd/amdkfd/kfd_crat.c static int kfd_fill_mem_info_for_cpu(int numa_node_id, int *avail_size, · line 869

Quoted 5 lines
drivers/gpu/drm/amd/amdkfd/kfd_crat.c +1 -1
-#if CONFIG_X86_64
+#ifdef CONFIG_X86_64
  static int kfd_fill_iolink_info_for_cpu(int numa_node_id, int *avail_size,
                              uint32_t *num_entries,
                              struct crat_subtype_iolink *sub_type_hdr)

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx