drm/sun4i: hdmi: Fix usage of TMDS clock
PATCH 1/1 drm/sun4i: hdmi: Fix usage of TMDS clock
From: Priit Laes <[email protected]>
Although TMDS clock is required for HDMI to properly function, nobody called clk_prepare_enable(). This fixes reference counting issues and makes sure clock is running when it needs to be running.
Due to TDMS clock being parent clock for DDC clock, TDMS clock was turned on/off for each EDID probe, causing spurious failures for certain HDMI/DVI screens.
--- drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c +4 -0
@@ -92,6 +92,8 @@ static void sun4i_hdmi_disable(struct drm_encoder *encoder) val =readl (hdmi->base +SUN4I_HDMI_VID_CTRL_REG ); val &= ~SUN4I_HDMI_VID_CTRL_ENABLE ;writel (val, hdmi->base +SUN4I_HDMI_VID_CTRL_REG ); + +clk_disable_unprepare (hdmi->tmds_clk); }static void sun4i_hdmi_enable (struct drm_encoder *encoder)
@@ -112,6 +114,8 @@ static void sun4i_hdmi_enable(struct drm_encoder *encoder) val |=SUN4I_HDMI_VID_CTRL_HDMI_MODE ;writel (val, hdmi->base +SUN4I_HDMI_VID_CTRL_REG ); + +clk_prepare_enable (hdmi->tmds_clk); } static void sun4i_hdmi_mode_set(struct drm_encoder *encoder,
Signature · 1 line
2.11.0
Quoted 31 lines · Priit Laes
From: Priit Laes <[email protected]>
Although TMDS clock is required for HDMI to properly function, nobody called
clk_prepare_enable(). This fixes reference counting issues and makes sure clock is running when it needs to be running.Due to TDMS clock being parent clock for DDC clock, TDMS clock was turned on/off for each EDID probe, causing spurious failures for certain HDMI/DVI screens.
Fixes 9c5681011a0c ("drm/sun4i: Add HDMI support")Signed-off-by Priit Laes <[email protected]>--- drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c +2
-0@@ -92,6 +92,8 @@ static void sun4i_hdmi_disable(struct drm_encoder *encoder) val =readl (hdmi->base +SUN4I_HDMI_VID_CTRL_REG ); val &= ~SUN4I_HDMI_VID_CTRL_ENABLE ;writel (val, hdmi->base +SUN4I_HDMI_VID_CTRL_REG ); + +clk_disable_unprepare (hdmi->tmds_clk); }static void sun4i_hdmi_enable (struct drm_encoder *encoder)
drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c static void sun4i_hdmi_enable(struct drm_encoder *encoder) · line 118
Quoted 5 lines
drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c +2
-0@@ -112,6 +114,8 @@ static void sun4i_hdmi_enable(struct drm_encoder *encoder) val |=SUN4I_HDMI_VID_CTRL_HDMI_MODE ;writel (val, hdmi->base +SUN4I_HDMI_VID_CTRL_REG ); + +clk_prepare_enable (hdmi->tmds_clk);
We'll probably need to enable that clock to send the infoframes as well. I moved it earlier (and that allows the enable and disable function to be symetric as well).
Thanks for figuring this out!
Maxime
Signature · 3 lines
Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com