Skip to contentSkip to conversation

hw/block: clean up stake xen_disk trace entries

PATCH Applied Paul Durrant 5 participants 6 messages Jan 22, 2019 – Jan 30, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/block: clean up stake xen_disk trace entries

This should have been removed then xen_disk.c was removed but I missed them.

---
Cc: Kevin Wolf <[email protected]>
Cc: Max Reitz <[email protected]>

---
 hw/block/trace-events | 7 -------
 1 file changed, 7 deletions(-)
hw/block/trace-events +0 -7
index 55e5a5500c..d0851953c5 100644
@@ -121,13 +121,6 @@ nvme_ub_db_wr_invalid_cqhead(uint32_t qid, uint16_t new_head) "completion queue
 nvme_ub_db_wr_invalid_sq(uint32_t qid) "submission queue doorbell write for nonexistent queue, sqid=%"PRIu32", ignoring"
 nvme_ub_db_wr_invalid_sqtail(uint32_t qid, uint16_t new_tail) "submission queue doorbell write value beyond queue size, sqid=%"PRIu32", new_head=%"PRIu16", ignoring"
 
-# hw/block/xen_disk.c
-xen_disk_alloc(char *name) "%s"
-xen_disk_init(char *name) "%s"
-xen_disk_connect(char *name) "%s"
-xen_disk_disconnect(char *name) "%s"
-xen_disk_free(char *name) "%s"
-
 # hw/block/xen-block.c
 xen_block_realize(const char *type, uint32_t disk, uint32_t partition) "%s d%up%u"
 xen_block_connect(const char *type, uint32_t disk, uint32_t partition) "%s d%up%u"
Signature · 1 line
2.20.1.2.gb21ebb6
#1 lore raw

Ping?

I realize that I typo-ed the commit comment but, assuming that can be fixed, can I get an ack or otherwise on this?

Thanks,

Paul

Quoted 45 lines

-----Original Message-----
From: Paul Durrant [mailto:[email protected]]
Sent: 22 January 2019 14:52
To: [email protected]; [email protected]
Cc: Paul Durrant <[email protected]>; Kevin Wolf <[email protected]>; Max Reitz <[email protected]>
Subject: [PATCH] hw/block: clean up stake xen_disk trace entries

This should have been removed then xen_disk.c was removed but I missed them.

---
Cc: Kevin Wolf <[email protected]>
Cc: Max Reitz <[email protected]>

---
 hw/block/trace-events | 7 -------
 1 file changed, 7 deletions(-)
hw/block/trace-events +0 -0
index 55e5a5500c..d0851953c5 100644
@@ -121,13 +121,6 @@ nvme_ub_db_wr_invalid_cqhead(uint32_t qid, uint16_t

new_head) "completion queue
nvme_ub_db_wr_invalid_sq(uint32_t qid) "submission queue doorbell write
for nonexistent queue, sqid=%"PRIu32", ignoring"
nvme_ub_db_wr_invalid_sqtail(uint32_t qid, uint16_t new_tail) "submission
queue doorbell write value beyond queue size, sqid=%"PRIu32", new_head=%"PRIu16", ignoring"

hw/block/trace-events +0 -7
-# hw/block/xen_disk.c
-xen_disk_alloc(char *name) "%s"
-xen_disk_init(char *name) "%s"
-xen_disk_connect(char *name) "%s"
-xen_disk_disconnect(char *name) "%s"
-xen_disk_free(char *name) "%s"
-
 # hw/block/xen-block.c
 xen_block_realize(const char *type, uint32_t disk, uint32_t partition)

"%s d%up%u"
xen_block_connect(const char *type, uint32_t disk, uint32_t partition)
"%s d%up%u"
--
2.20.1.2.gb21ebb6

Reviewed-by on v1 1/1
#2 lore raw
In reply to Paul Durrant

Cc'ing QEMU Trivial.

Quoted 1 line · Paul Durrant

This should have been removed then xen_disk.c was removed but I missed them.

... when xen_disk.c was removed (19f87870baa) ...

Quoted 2 lines
Quoted 26 lines

---
Cc: Kevin Wolf <[email protected]>
Cc: Max Reitz <[email protected]>

---
 hw/block/trace-events | 7 -------
 1 file changed, 7 deletions(-)
hw/block/trace-events +0 -7
index 55e5a5500c..d0851953c5 100644
@@ -121,13 +121,6 @@ nvme_ub_db_wr_invalid_cqhead(uint32_t qid, uint16_t new_head) "completion queue
 nvme_ub_db_wr_invalid_sq(uint32_t qid) "submission queue doorbell write for nonexistent queue, sqid=%"PRIu32", ignoring"
 nvme_ub_db_wr_invalid_sqtail(uint32_t qid, uint16_t new_tail) "submission queue doorbell write value beyond queue size, sqid=%"PRIu32", new_head=%"PRIu16", ignoring"
 
-# hw/block/xen_disk.c
-xen_disk_alloc(char *name) "%s"
-xen_disk_init(char *name) "%s"
-xen_disk_connect(char *name) "%s"
-xen_disk_disconnect(char *name) "%s"
-xen_disk_free(char *name) "%s"
-
 # hw/block/xen-block.c
 xen_block_realize(const char *type, uint32_t disk, uint32_t partition) "%s d%up%u"
 xen_block_connect(const char *type, uint32_t disk, uint32_t partition) "%s d%up%u"
#3 lore raw
Quoted 7 lines · Philippe Mathieu-Daudé

Cc'ing QEMU Trivial.

Quoted 1 line · Paul Durrant

This should have been removed then xen_disk.c was removed but I missed them.

... when xen_disk.c was removed (19f87870baa) ...

also s/stake/stale/ in the subject line I guess ?

thanks
-- PMM

#4 lore raw
Quoted 11 lines · Peter Maydell
Quoted 7 lines · Philippe Mathieu-Daudé

Cc'ing QEMU Trivial.

Quoted 1 line · Paul Durrant

This should have been removed then xen_disk.c was removed but I missed them.

... when xen_disk.c was removed (19f87870baa) ...

also s/stake/stale/ in the subject line I guess ?

Applied to my trivial-patches branch with changes above.

Thanks,
Laurent