mm: cleancache: no need to check return value of debugfs_create functions
PATCH 1/1 mm: cleancache: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc Konrad Rzeszutek Wilk <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
--- mm/cleancache.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
mm/cleancache.c +1 -2
@@ -305,8 +305,7 @@ static int __init init_cleancache(void) {#ifdef CONFIG_DEBUG_FS struct dentry *root =debugfs_create_dir ("cleancache" ,NULL ); -if (root ==NULL ) -return -ENXIO ; +debugfs_create_u64 ("succ_gets" ,0444 , root, &cleancache_succ_gets);debugfs_create_u64 ("failed_gets" ,0444 , root, &cleancache_failed_gets);debugfs_create_u64 ("puts" ,0444 , root, &cleancache_puts);
Signature · 1 line
2.20.1
Quoted 5 lines · Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc Konrad Rzeszutek Wilk <[email protected]>
OK.
or I can push it through my tree but it may be just easier for Andrew too do it
Quoted 23 lines
Signed-off-by Greg Kroah-Hartman <[email protected]>--- mm/cleancache.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)mm/cleancache.c +1
-2@@ -305,8 +305,7 @@ static int __init init_cleancache(void) {#ifdef CONFIG_DEBUG_FS struct dentry *root =debugfs_create_dir ("cleancache" ,NULL ); -if (root ==NULL ) -return -ENXIO ; +debugfs_create_u64 ("succ_gets" ,0444 , root, &cleancache_succ_gets);debugfs_create_u64 ("failed_gets" ,0444 , root, &cleancache_failed_gets);debugfs_create_u64 ("puts" ,0444 , root, &cleancache_puts);Signature · 1 line
2.20.1