power: qos: no need to check return value of debugfs_create functions
Subsystems (2)
PATCH 1/1 power: qos: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
--- kernel/power/qos.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
kernel/power/qos.c +2 -6
@@ -582,10 +582,8 @@ static int register_pm_qos_misc(struct pm_qos_object *qos, struct dentry *d) qos->pm_qos_power_miscdev.name = qos->name; qos->pm_qos_power_miscdev.fops = &pm_qos_power_fops; -if (d) { - (void )debugfs_create_file (qos->name,S_IRUGO , d, - (void *)qos, &pm_qos_debug_fops); - } +debugfs_create_file (qos->name,S_IRUGO , d, (void *)qos, + &pm_qos_debug_fops);return misc_register (&qos->pm_qos_power_miscdev); }
@@ -685,8 +683,6 @@ static int __init pm_qos_power_init(void)BUILD_BUG_ON (ARRAY_SIZE (pm_qos_array) !=PM_QOS_NUM_CLASSES ); d =debugfs_create_dir ("pm_qos" ,NULL ); -if (IS_ERR_OR_NULL (d)) - d =NULL ;for (i =PM_QOS_CPU_DMA_LATENCY ; i <PM_QOS_NUM_CLASSES ; i++) { ret =register_pm_qos_misc (pm_qos_array[i], d);
Signature · 1 line
2.20.1
Rafael J. Wysocki
maintainerQuoted 10 lines · Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc "Rafael J. Wysocki" <[email protected]>Cc Len Brown <[email protected]>Cc Pavel Machek <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
All of these changes are fine by me and I can take the patches touching the code maintained by me, so please let me know.
Quoted 33 lines
--- kernel/power/qos.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)kernel/power/qos.c +2
-7@@ -582,10 +582,8 @@ static int register_pm_qos_misc(struct pm_qos_object *qos, struct dentry *d) qos->pm_qos_power_miscdev.name = qos->name; qos->pm_qos_power_miscdev.fops = &pm_qos_power_fops; -if (d) { - (void )debugfs_create_file (qos->name,S_IRUGO , d, - (void *)qos, &pm_qos_debug_fops); - } +debugfs_create_file (qos->name,S_IRUGO , d, (void *)qos, + &pm_qos_debug_fops);return misc_register (&qos->pm_qos_power_miscdev); }@@ -685,8 +683,6 @@ static int __init pm_qos_power_init(void)BUILD_BUG_ON (ARRAY_SIZE (pm_qos_array) !=PM_QOS_NUM_CLASSES ); d =debugfs_create_dir ("pm_qos" ,NULL ); -if (IS_ERR_OR_NULL (d)) - d =NULL ;for (i =PM_QOS_CPU_DMA_LATENCY ; i <PM_QOS_NUM_CLASSES ; i++) { ret =register_pm_qos_misc (pm_qos_array[i], d); --2.20.1
Quoted 7 lines · Rafael J. Wysocki
Quoted 5 lines · Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Quoted 8 lines
Quoted 5 lines
Cc "Rafael J. Wysocki" <[email protected]>Cc Len Brown <[email protected]>Cc Pavel Machek <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>All of these changes are fine by me and I can take the patches touching the code maintained by me, so please let me know.
Please take them!
thanks,
greg k-h
Rafael J. Wysocki
AppliedQuoted 32 lines · CET Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc "Rafael J. Wysocki" <[email protected]>Cc Len Brown <[email protected]>Cc Pavel Machek <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>--- kernel/power/qos.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)kernel/power/qos.c +2
-4@@ -582,10 +582,8 @@ static int register_pm_qos_misc(struct pm_qos_object *qos, struct dentry *d) qos->pm_qos_power_miscdev.name = qos->name; qos->pm_qos_power_miscdev.fops = &pm_qos_power_fops; -if (d) { - (void )debugfs_create_file (qos->name,S_IRUGO , d, - (void *)qos, &pm_qos_debug_fops); - } +debugfs_create_file (qos->name,S_IRUGO , d, (void *)qos, + &pm_qos_debug_fops);return misc_register (&qos->pm_qos_power_miscdev); }
kernel/power/qos.c static int __init pm_qos_power_init(void) · line 688
Quoted 8 lines
kernel/power/qos.c +0
-2@@ -685,8 +683,6 @@ static int __init pm_qos_power_init(void)BUILD_BUG_ON (ARRAY_SIZE (pm_qos_array) !=PM_QOS_NUM_CLASSES ); d =debugfs_create_dir ("pm_qos" ,NULL ); -if (IS_ERR_OR_NULL (d)) - d =NULL ;for (i =PM_QOS_CPU_DMA_LATENCY ; i <PM_QOS_NUM_CLASSES ; i++) { ret =register_pm_qos_misc (pm_qos_array[i], d);
Applied, thanks!