Skip to contentSkip to conversation

ath: move spin_lock_bh to spin_lock in tasklet

PATCH In review Zhiwei Jiang 2 participants 4 messages Jan 22, 2019 – Feb 7, 2019 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath: move spin_lock_bh to spin_lock in tasklet

as you are already in a tasklet, it is unnecessary to call spin_lock_bh, because softirq already disable BH.

---
 drivers/net/wireless/ath/ath9k/htc_drv_txrx.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/wireless/ath/ath9k/htc_drv_txrx.c +3 -3
index 799010ed04e0..4e8e80ac8341 100644
@@ -574,12 +574,12 @@ void ath9k_tx_failed_tasklet(unsigned long data)
 {
 	struct ath9k_htc_priv *priv = (struct ath9k_htc_priv *)data;
 
-	spin_lock_bh(&priv->tx.tx_lock);
+	spin_lock(&priv->tx.tx_lock);
 	if (priv->tx.flags & ATH9K_HTC_OP_TX_DRAIN) {
-		spin_unlock_bh(&priv->tx.tx_lock);
+		spin_unlock(&priv->tx.tx_lock);
 		return;
 	}
-	spin_unlock_bh(&priv->tx.tx_lock);
+	spin_unlock(&priv->tx.tx_lock);
 
 	ath9k_htc_tx_drainq(priv, &priv->tx.tx_failed);
 }
Signature · 1 line
2.19.0

A message that is not in the archive (sent off-list or not yet received): CANHzP_uiEoYaSg4fC1gHHjc=gRLjaxt8S3=p6a-rkg5-WjR7MA@mail.gmail.com

#3 lore raw
Quoted 1 line · 姜智伟

Will do, thanks!

Also don't send HTML mail :) Maillists drop those automatically.

Signature · 1 line
Kalle Valo
#4 lore raw
In reply to Zhiwei Jiang
Quoted 5 lines · Zhiwei Jiang

as you are already in a tasklet, it is unnecessary to call spin_lock_bh, because softirq already disable BH.

Patch applied to ath-next branch of ath.git, thanks.

b789f333d7ac ath: move spin_lock_bh to spin_lock in tasklet

Signature · 3 lines
https://patchwork.kernel.org/patch/10775865/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches