tty: serial: 8250_mtk: Fix potential NULL pointer dereference

PATCH New Gustavo A. R. Silva 1 participant 1 message Jan 22, 2019

Subsystems (2)

Arm MediaTek TTY layer and serial drivers

lore

Share & tools

lore

Gustavo A. R. Silva

author

2019-01-22 19:57 UTC #0 lore raw

PATCH 1/1 tty: serial: 8250_mtk: Fix potential NULL pointer dereference

There is a potential NULL pointer dereference in case devm_kzalloc() fails and returns NULL.

Fix this by adding a NULL check on data->dma

This bug was detected with the help of Coccinelle.

Fixes 85b5c1dd0456 ("serial: 8250-mtk: add uart DMA support")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/tty/serial/8250/8250_mtk.c | 3 +++
 1 file changed, 3 insertions(+)

drivers/tty/serial/8250/8250_mtk.c +3 -0

index e2c407656fa6..c1fdbc0b6840 100644
@@ -357,6 +357,9 @@ static int mtk8250_probe_of(struct platform_device *pdev, struct uart_port *p,
 	if (dmacnt == 2) {
 		data->dma = devm_kzalloc(&pdev->dev, sizeof(*data->dma),
 					 GFP_KERNEL);
+		if (!data->dma)
+			return -ENOMEM;
+
 		data->dma->fn = mtk8250_dma_filter;
 		data->dma->rx_size = MTK_UART_RX_SIZE;
 		data->dma->rxconf.src_maxburst = MTK_UART_RX_TRIGGER;

Signature · 1 line

2.20.1