drm: rcar-du: Fix build error
Subsystems (3)
PATCH 1/1 drm: rcar-du: Fix build error
On arm{32,64} allyesconfig builds:
drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c:40:1: error: incomplete result type 'enum drm_mode_status' in function definition drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c:47:10: error: incomplete definition of type 'struct drm_display_mode' drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c:48:10: error: use of undeclared identifier 'MODE_CLOCK_HIGH' drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c:50:9: error: use of undeclared identifier 'MODE_OK'
After the removal of drmP.h from this file and its removal from bridge/dw_hdmi.h, these types are not defined anymore, as they were implicitly coming into that file through drm_crtc.h.
--- drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c +1 -0
@@ -12,6 +12,7 @@#include <linux/platform_device.h> #include <drm/bridge/dw_hdmi.h> +#include <drm/drm_modes.h> #define RCAR_HDMI_PHY_OPMODE_PLLCFG 0x06/* Mode of operation and PLL dividers */ #define RCAR_HDMI_PHY_PLLCURRGMPCTRL 0x10/* PLL current and Gmp (conductance) */
Signature · 1 line
2.20.1
Hi Nathan,
Thank you for the patch.
Quoted 7 lines · Nathan Chancellor
On arm{32,64} allyesconfig builds:
drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c:40:1: error: incomplete result type 'enumdrm_mode_status' in function definitiondrivers/gpu/drm/rcar-du/rcar_dw_hdmi.c:47:10: error: incomplete definition of type 'structdrm_display_mode'drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c:48:10: error: use of undeclared identifier 'MODE_CLOCK_HIGH'drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c:50:9: error: use of undeclared identifier 'MODE_OK'
Quoted 7 lines
After the removal of
drmP.hfrom this file and its removal frombridge/dw_hdmi.h, these types are not defined anymore, as they were implicitly coming into that file throughdrm_crtc.h.Fixes 428747ae5cca ("drm: remove include of drmP.h from bridge/dw_hdmi.h")Fixes 9a47db8e7a9d ("drm: rcar-du: Remove inclusion of drmP.h")Signed-off-by Nathan Chancellor <[email protected]>
This was included by Dave in merge commit f164a94c2c87 ("Merge tag 'drm-misc-next-2019-01-16' of git://anongit.freedesktop.org/drm/drm-misc
into drm-next").
Quoted 16 lines
--- drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c +1
-0@@ -12,6 +12,7 @@#include <linux/platform_device.h> #include <drm/bridge/dw_hdmi.h> +#include <drm/drm_modes.h> #define RCAR_HDMI_PHY_OPMODE_PLLCFG 0x06/* Mode of operation and PLL dividers */ #define RCAR_HDMI_PHY_PLLCURRGMPCTRL 0x10/* PLL current and Gmp (conductance) */
Signature · 3 lines
Regards, Laurent Pinchart