Skip to contentSkip to conversation

devlink: Use after free in devlink_health_reporter_destroy()

PATCH In review Dan Carpenter 2 participants 2 messages Jan 23, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 devlink: Use after free in devlink_health_reporter_destroy()

This calls kfree(reporter); before dereferencing reporter on the next line when it does mutex_unlock(&reporter->devlink->lock);

Fixes 880ee82f0313 ("devlink: Add health reporter create/destroy functionality")
---
 net/core/devlink.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
net/core/devlink.c +4 -2
index 60248a53c0ad..deccce13285a 100644
@@ -4223,14 +4223,16 @@ EXPORT_SYMBOL_GPL(devlink_health_reporter_create);
 void
 devlink_health_reporter_destroy(struct devlink_health_reporter *reporter)
 {
-	mutex_lock(&reporter->devlink->lock);
+	struct devlink *devlink = reporter->devlink;
+
+	mutex_lock(&devlink->lock);
 	list_del(&reporter->list);
 	devlink_health_buffers_destroy(reporter->dump_buffers_array,
 				       DEVLINK_HEALTH_SIZE_TO_BUFFERS(reporter->ops->dump_size));
 	devlink_health_buffers_destroy(reporter->diagnose_buffers_array,
 				       DEVLINK_HEALTH_SIZE_TO_BUFFERS(reporter->ops->diagnose_size));
 	kfree(reporter);
-	mutex_unlock(&reporter->devlink->lock);
+	mutex_unlock(&devlink->lock);
 }
 EXPORT_SYMBOL_GPL(devlink_health_reporter_destroy);
 
Signature · 1 line
2.17.1
#1 lore raw

DQoNCk9uIDEvMjMvMjAxOSAxMTo0NCBBTSwgRGFuIENhcnBlbnRlciB3cm90ZToNCj4gVGhpcyBj YWxscyBrZnJlZShyZXBvcnRlcik7IGJlZm9yZSBkZXJlZmVyZW5jaW5nIHJlcG9ydGVyIG9uIHRo ZSBuZXh0DQo+IGxpbmUgd2hlbiBpdCBkb2VzIG11dGV4X3VubG9jaygmcmVwb3J0ZXItPmRldmxp bmstPmxvY2spOw0KPiANCj4gRml4ZXM6IDg4MGVlODJmMDMxMyAoImRldmxpbms6IEFkZCBoZWFs dGggcmVwb3J0ZXIgY3JlYXRlL2Rlc3Ryb3kgZnVuY3Rpb25hbGl0eSIpDQo+IFNpZ25lZC1vZmYt Ynk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4NCg0KSGksIHRoYW5r cyBmb3IgdGhlIGZpeC4NCkl0IGlzIGlkZW50aWNhbCB0byBvbmUgSSBwb3N0ZWQgeWVzdGVyZGF5 Lg0KaHR0cHM6Ly9wYXRjaHdvcmsub3psYWJzLm9yZy9wYXRjaC8xMDI5MzU4Lw0KDQo+IC0tLQ0K PiAgIG5ldC9jb3JlL2RldmxpbmsuYyB8IDYgKysrKy0tDQo+ICAgMSBmaWxlIGNoYW5nZWQsIDQg aW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9uZXQvY29y ZS9kZXZsaW5rLmMgYi9uZXQvY29yZS9kZXZsaW5rLmMNCj4gaW5kZXggNjAyNDhhNTNjMGFkLi5k ZWNjY2UxMzI4NWEgMTAwNjQ0DQo+IC0tLSBhL25ldC9jb3JlL2RldmxpbmsuYw0KPiArKysgYi9u ZXQvY29yZS9kZXZsaW5rLmMNCj4gQEAgLTQyMjMsMTQgKzQyMjMsMTYgQEAgRVhQT1JUX1NZTUJP TF9HUEwoZGV2bGlua19oZWFsdGhfcmVwb3J0ZXJfY3JlYXRlKTsNCj4gICB2b2lkDQo+ICAgZGV2 bGlua19oZWFsdGhfcmVwb3J0ZXJfZGVzdHJveShzdHJ1Y3QgZGV2bGlua19oZWFsdGhfcmVwb3J0 ZXIgKnJlcG9ydGVyKQ0KPiAgIHsNCj4gLQltdXRleF9sb2NrKCZyZXBvcnRlci0+ZGV2bGluay0+ bG9jayk7DQo+ICsJc3RydWN0IGRldmxpbmsgKmRldmxpbmsgPSByZXBvcnRlci0+ZGV2bGluazsN Cj4gKw0KPiArCW11dGV4X2xvY2soJmRldmxpbmstPmxvY2spOw0KPiAgIAlsaXN0X2RlbCgmcmVw b3J0ZXItPmxpc3QpOw0KPiAgIAlkZXZsaW5rX2hlYWx0aF9idWZmZXJzX2Rlc3Ryb3kocmVwb3J0 ZXItPmR1bXBfYnVmZmVyc19hcnJheSwNCj4gICAJCQkJICAgICAgIERFVkxJTktfSEVBTFRIX1NJ WkVfVE9fQlVGRkVSUyhyZXBvcnRlci0+b3BzLT5kdW1wX3NpemUpKTsNCj4gICAJZGV2bGlua19o ZWFsdGhfYnVmZmVyc19kZXN0cm95KHJlcG9ydGVyLT5kaWFnbm9zZV9idWZmZXJzX2FycmF5LA0K PiAgIAkJCQkgICAgICAgREVWTElOS19IRUFMVEhfU0laRV9UT19CVUZGRVJTKHJlcG9ydGVyLT5v cHMtPmRpYWdub3NlX3NpemUpKTsNCj4gICAJa2ZyZWUocmVwb3J0ZXIpOw0KPiAtCW11dGV4X3Vu bG9jaygmcmVwb3J0ZXItPmRldmxpbmstPmxvY2spOw0KPiArCW11dGV4X3VubG9jaygmZGV2bGlu ay0+bG9jayk7DQo+ICAgfQ0KPiAgIEVYUE9SVF9TWU1CT0xfR1BMKGRldmxpbmtfaGVhbHRoX3Jl cG9ydGVyX2Rlc3Ryb3kpOw0KPiAgIA0KPiANCg=