Skip to contentSkip to conversation

net/virtio: remove unnecessary forward declaration

PATCH Applied Rami Rosen 2 participants 3 messages Jan 23, 2019 – Feb 8, 2019 Network drivers

lore
Share & tools
lore

Rami Rosen

author
#0 lore raw

PATCH 1/1 net/virtio: remove unnecessary forward declaration

This minor cleanup patch removes an unecessary forward declaration of virtio_intr_enable() in net/virtio PMD.

Fixes fe19d49cb525 ("net/virtio: fix Rx interrupt with VFIO")
Cc [email protected]
Signed-off-by Rami Rosen <[email protected]>
---
 drivers/net/virtio/virtio_ethdev.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/virtio/virtio_ethdev.c +0 -1
index ee5a98b..d8fd288 100644
@@ -71,7 +71,6 @@ static int virtio_mac_addr_add(struct rte_eth_dev *dev,
 static int virtio_mac_addr_set(struct rte_eth_dev *dev,
 				struct ether_addr *mac_addr);
 
-static int virtio_intr_enable(struct rte_eth_dev *dev);
 static int virtio_intr_disable(struct rte_eth_dev *dev);
 
 static int virtio_dev_queue_stats_mapping_set(
Signature · 1 line
1.8.3.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 1 line · Rami Rosen

This minor cleanup patch removes an unecessary forward

s/unecessary/unnecessary/

Quoted 15 lines

declaration of virtio_intr_enable() in net/virtio PMD.

Fixes fe19d49cb525 ("net/virtio: fix Rx interrupt with VFIO")
Cc [email protected]
Signed-off-by Rami Rosen <[email protected]>
---
  drivers/net/virtio/virtio_ethdev.c | 1 -
  1 file changed, 1 deletion(-)
drivers/net/virtio/virtio_ethdev.c +0 -0
index ee5a98b..d8fd288 100644

drivers/net/virtio/virtio_ethdev.c static int virtio_mac_addr_add(struct rte_eth_dev *dev, · line 76

Quoted 7 lines
drivers/net/virtio/virtio_ethdev.c +0 -1
@@ -71,7 +71,6 @@ static int virtio_mac_addr_add(struct rte_eth_dev *dev,
  static int virtio_mac_addr_set(struct rte_eth_dev *dev,
  				struct ether_addr *mac_addr);
 
-static int virtio_intr_enable(struct rte_eth_dev *dev);
  static int virtio_intr_disable(struct rte_eth_dev *dev);
 
  static int virtio_dev_queue_stats_mapping_set(
Reviewed-by Maxime Coquelin <[email protected]>

I'll fix the typo while applying.

Thanks,
Maxime