Skip to contentSkip to conversation

ASoC: Use __printf markup to silence compiler

PATCH In review Mathieu Malaterre 2 participants 2 messages Jan 23, 2019 – Feb 12, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: Use __printf markup to silence compiler

Silence warnings (triggered at W=1) by adding relevant __printf attributes.

sound/soc/soc-dapm.c:149:2: warning: function 'pop_dbg' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]

---
 sound/soc/soc-dapm.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/soc-dapm.c +1 -0
index a5178845065b..92a2e7dab5fe 100644
@@ -133,6 +133,7 @@ static void pop_wait(u32 pop_time)
 		schedule_timeout_uninterruptible(msecs_to_jiffies(pop_time));
 }
 
+__printf(3, 4)
 static void pop_dbg(struct device *dev, u32 pop_time, const char *fmt, ...)
 {
 	va_list args;
Signature · 1 line
2.19.2
maintainer
#1 lore raw

Applied "ASoC: Use __printf markup to silence compiler" to the asoc tree

The patch

ASoC: Use __printf markup to silence compiler

has been applied to the asoc tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 595d2f74cd3caedb704a118bd09c1b4dfbfc0ec0 Mon Sep 17 00:00:00 2001

From: Mathieu Malaterre <[email protected]>
Date: Wed, 23 Jan 2019 20:41:30 +0100
Subject: [PATCH] ASoC: Use __printf markup to silence compiler

Silence warnings (triggered at W=1) by adding relevant __printf attributes.

sound/soc/soc-dapm.c:149:2: warning: function 'pop_dbg' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]

---
 sound/soc/soc-dapm.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/soc-dapm.c +1 -0
index d31d295b540f..dea6fc2353e4 100644
@@ -157,6 +157,7 @@ static void pop_wait(u32 pop_time)
 		schedule_timeout_uninterruptible(msecs_to_jiffies(pop_time));
 }
 
+__printf(3, 4)
 static void pop_dbg(struct device *dev, u32 pop_time, const char *fmt, ...)
 {
 	va_list args;
Signature · 1 line
2.20.1