arch-arm: Do not add -march options for arm architecture
PATCH 1/1 arch-arm: Do not add -march options for arm architecture
tune files which inherit the arch definitions already define appropriate -mcpu option, which is equivalent of right -march and -mtune combination and is preferred since gcc is getting stricter and stricter with option check semantics and can now find incompatible -march and -mcpu options better with every release. It does internal feature consistency check and if it finds out discrepency between what -mcpu would expand to as compared to -march it will flag the options to be incompatible, for naked eye it sounds wrong but gcc would translate -mcpu to a given -march internally and it might not match to what we set in these arch files.
The effects are quite subtle, where this can result in configure test failing to compile due to these incompatible options and a feature option getting disabled for a recipe for no reason.
e.g. with gcc9 which can now detect that -mcpu=cortex-a5 and -march=armv7-a are incompatible, many features in libstdc++ ends up disabled due to configure check failures e.g. size_t size, ptrdiff_t sizes, which inturn results in compiling libstdc++ with unwanted disabled features.
--- meta/conf/machine/include/arm/arch-armv4.inc | 1 - meta/conf/machine/include/arm/arch-armv5.inc | 1 - meta/conf/machine/include/arm/arch-armv6.inc | 1 - meta/conf/machine/include/arm/arch-armv7a.inc | 1 - meta/conf/machine/include/arm/arch-armv7ve.inc | 1 - meta/conf/machine/include/tune-iwmmxt.inc | 2 +- 6 files changed, 1 insertion(+), 6 deletions(-)
meta/conf/machine/include/arm/arch-armv4.inc +0 -1
@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv4" TUNEVALID[arm] = "Enable ARM instruction set" TUNEVALID[armv4] = "Enable instructions for ARMv4" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv4', ' -march=armv4t', '', d)}" # enable --fix-v4bx when we have armv4 in TUNE_FEATURES, but then disable it when we have also armv5 or thumb # maybe we should extend bb.utils.contains to support check for any checkvalues in value, now it does # checkvalues.issubset(val) which cannot be used for negative test of foo neither bar in value
meta/conf/machine/include/arm/arch-armv5.inc +0 -1
@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv5" TUNEVALID[armv5] = "Enable instructions for ARMv5" TUNECONFLICTS[armv5] = "armv4" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv5', ' -march=armv5t${ARMPKGSFX_DSP}', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv5', 'armv5:', '' ,d)}" require conf/machine/include/arm/arch-armv4.inc
meta/conf/machine/include/arm/arch-armv6.inc +0 -1
@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv6hf" TUNEVALID[armv6] = "Enable instructions for ARMv6" TUNECONFLICTS[armv6] = "armv4 armv5" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv6', ' -march=armv6', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv6', 'armv6:', '' ,d)}" require conf/machine/include/arm/arch-armv5-dsp.inc
meta/conf/machine/include/arm/arch-armv7a.inc +0 -1
@@ -3,7 +3,6 @@ ARM_INSTRUCTION_SET ?= "thumb" TUNEVALID[armv7a] = "Enable instructions for ARMv7-a" TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv7a', ' -march=armv7-a', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv7a', 'armv7a:', '' ,d)}" require conf/machine/include/arm/arch-armv6.inc
meta/conf/machine/include/arm/arch-armv7ve.inc +0 -1
@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv7vethf" TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve" TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv7ve', ' -march=armv7ve', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv7ve', 'armv7ve:', '' ,d)}" require conf/machine/include/arm/arch-armv7a.inc
meta/conf/machine/include/tune-iwmmxt.inc +1 -1
@@ -6,7 +6,7 @@ DEFAULTTUNE ?= "iwmmxt" require conf/machine/include/arm/arch-armv5-dsp.inc TUNEVALID[iwmmxt] = "Enable Intel PXA27x specific processor optimizations" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'iwmmxt', ' -march=iwmmxt -mcpu=iwmmxt', '', d)}" +TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'iwmmxt', ' -mcpu=iwmmxt', '', d)}" AVAILTUNES += "iwmmxt" ARMPKGARCH_tune-iwmmxt = "iwmmxt"
Signature · 1 line
2.20.1
Quoted 3 lines · Khem Raj
tune files which inherit the arch definitions already define appropriate -mcpu option, which is equivalent of right -march and -mtune combination
And what about machines which inherit an arch definition instead of a cpu definition? Is that no longer supported?
Quoted 13 lines
and is preferred since gcc is getting stricter and stricter with option check semantics and can now find incompatible -march and -mcpu options better with every release. It does internal feature consistency check and if it finds out discrepency between what -mcpu would expand to as compared to -march it will flag the options to be incompatible, for naked eye it sounds wrong but gcc would translate -mcpu to a given -march internally and it might not match to what we set in these arch files.
The effects are quite subtle, where this can result in configure test failing to compile due to these incompatible options and a feature option getting disabled for a recipe for no reason.
Quoted 5 lines
e.g. with gcc9 which can now detect that -mcpu=cortex-a5 and -march=armv7-a are incompatible, many features in libstdc++ ends up disabled due to configure check failures e.g.
size_tsize,ptrdiff_tsizes, which inturn results in compiling libstdc++ with unwanted disabled features.
It would be interesting to see more specific details of this.
Quoted 91 lines
Signed-off-by Khem Raj <[email protected]>--- meta/conf/machine/include/arm/arch-armv4.inc | 1 - meta/conf/machine/include/arm/arch-armv5.inc | 1 - meta/conf/machine/include/arm/arch-armv6.inc | 1 - meta/conf/machine/include/arm/arch-armv7a.inc | 1 - meta/conf/machine/include/arm/arch-armv7ve.inc | 1 - meta/conf/machine/include/tune-iwmmxt.inc | 2 +- 6 files changed, 1 insertion(+), 6 deletions(-)meta/conf/machine/include/arm/arch-armv4.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv4" TUNEVALID[arm] = "Enable ARM instruction set" TUNEVALID[armv4] = "Enable instructions for ARMv4" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv4', ' -march=armv4t', '', d)}" # enable --fix-v4bx when we have armv4 in TUNE_FEATURES, but then disable it when we have also armv5 or thumb # maybe we should extend bb.utils.contains to support check for any checkvalues in value, now it does # checkvalues.issubset(val) which cannot be used for negative test of foo neither bar in valuemeta/conf/machine/include/arm/arch-armv5.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv5" TUNEVALID[armv5] = "Enable instructions for ARMv5" TUNECONFLICTS[armv5] = "armv4" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv5', ' -march=armv5t${ARMPKGSFX_DSP}', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv5', 'armv5:', '' ,d)}" require conf/machine/include/arm/arch-armv4.incmeta/conf/machine/include/arm/arch-armv6.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv6hf" TUNEVALID[armv6] = "Enable instructions for ARMv6" TUNECONFLICTS[armv6] = "armv4 armv5" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv6', ' -march=armv6', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv6', 'armv6:', '' ,d)}" require conf/machine/include/arm/arch-armv5-dsp.incmeta/conf/machine/include/arm/arch-armv7a.inc +0
-1@@ -3,7 +3,6 @@ ARM_INSTRUCTION_SET ?= "thumb" TUNEVALID[armv7a] = "Enable instructions for ARMv7-a" TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv7a', ' -march=armv7-a', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv7a', 'armv7a:', '' ,d)}" require conf/machine/include/arm/arch-armv6.incmeta/conf/machine/include/arm/arch-armv7ve.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv7vethf" TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve" TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv7ve', ' -march=armv7ve', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv7ve', 'armv7ve:', '' ,d)}" require conf/machine/include/arm/arch-armv7a.incmeta/conf/machine/include/tune-iwmmxt.inc +1
-2@@ -6,7 +6,7 @@ DEFAULTTUNE ?= "iwmmxt" require conf/machine/include/arm/arch-armv5-dsp.inc TUNEVALID[iwmmxt] = "Enable Intel PXA27x specific processor optimizations" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'iwmmxt', ' -march=iwmmxt -mcpu=iwmmxt', '', d)}" +TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'iwmmxt', ' -mcpu=iwmmxt', '', d)}" AVAILTUNES += "iwmmxt" ARMPKGARCH_tune-iwmmxt = "iwmmxt" --2.20.1
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 8 lines · Andre McCurdy
Quoted 3 lines · Khem Raj
tune files which inherit the arch definitions already define appropriate -mcpu option, which is equivalent of right -march and -mtune combination
And what about machines which inherit an arch definition instead of a cpu definition? Is that no longer supported?
I could not find such a machine configuration in several BSP layers I looked at. Do you know of machine definitions where these files are included directly in machine configs ?
if so, then we have to either use _remove or introduce a weak variable to set march only if
mcpu is not set which
Quoted 14 lines
Quoted 14 lines
and is preferred since gcc is getting stricter and stricter with option check semantics and can now find incompatible -march and -mcpu options better with every release. It does internal feature consistency check and if it finds out discrepency between what -mcpu would expand to as compared to -march it will flag the options to be incompatible, for naked eye it sounds wrong but gcc would translate -mcpu to a given -march internally and it might not match to what we set in these arch files.
The effects are quite subtle, where this can result in configure test failing to compile due to these incompatible options and a feature option getting disabled for a recipe for no reason.
Quoted 7 lines
Quoted 5 lines
e.g. with gcc9 which can now detect that -mcpu=cortex-a5 and -march=armv7-a are incompatible, many features in libstdc++ ends up disabled due to configure check failures e.g.
size_tsize,ptrdiff_tsizes, which inturn results in compiling libstdc++ with unwanted disabled features.It would be interesting to see more specific details of this.
These are configure tests which fail when -Werror is in use and is not limited to libstdc++
it can happen in any package. Since the diagnostic about incompatible march mcpu pair
is a warning in general, it does not matter, but when we have -Werror enabled this turns
into error, You can simply try a small helloworld example to see the effects.
Quoted 92 lines
Quoted 92 lines
Signed-off-by Khem Raj <[email protected]>--- meta/conf/machine/include/arm/arch-armv4.inc | 1 - meta/conf/machine/include/arm/arch-armv5.inc | 1 - meta/conf/machine/include/arm/arch-armv6.inc | 1 - meta/conf/machine/include/arm/arch-armv7a.inc | 1 - meta/conf/machine/include/arm/arch-armv7ve.inc | 1 - meta/conf/machine/include/tune-iwmmxt.inc | 2 +- 6 files changed, 1 insertion(+), 6 deletions(-)meta/conf/machine/include/arm/arch-armv4.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv4" TUNEVALID[arm] = "Enable ARM instruction set" TUNEVALID[armv4] = "Enable instructions for ARMv4" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv4', ' -march=armv4t', '', d)}" # enable --fix-v4bx when we have armv4 in TUNE_FEATURES, but then disable it when we have also armv5 or thumb # maybe we should extend bb.utils.contains to support check for any checkvalues in value, now it does # checkvalues.issubset(val) which cannot be used for negative test of foo neither bar in valuemeta/conf/machine/include/arm/arch-armv5.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv5" TUNEVALID[armv5] = "Enable instructions for ARMv5" TUNECONFLICTS[armv5] = "armv4" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv5', ' -march=armv5t${ARMPKGSFX_DSP}', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv5', 'armv5:', '' ,d)}" require conf/machine/include/arm/arch-armv4.incmeta/conf/machine/include/arm/arch-armv6.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv6hf" TUNEVALID[armv6] = "Enable instructions for ARMv6" TUNECONFLICTS[armv6] = "armv4 armv5" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv6', ' -march=armv6', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv6', 'armv6:', '' ,d)}" require conf/machine/include/arm/arch-armv5-dsp.incmeta/conf/machine/include/arm/arch-armv7a.inc +0
-1@@ -3,7 +3,6 @@ ARM_INSTRUCTION_SET ?= "thumb" TUNEVALID[armv7a] = "Enable instructions for ARMv7-a" TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv7a', ' -march=armv7-a', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv7a', 'armv7a:', '' ,d)}" require conf/machine/include/arm/arch-armv6.incmeta/conf/machine/include/arm/arch-armv7ve.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv7vethf" TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve" TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv7ve', ' -march=armv7ve', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv7ve', 'armv7ve:', '' ,d)}" require conf/machine/include/arm/arch-armv7a.incmeta/conf/machine/include/tune-iwmmxt.inc +1
-2@@ -6,7 +6,7 @@ DEFAULTTUNE ?= "iwmmxt" require conf/machine/include/arm/arch-armv5-dsp.inc TUNEVALID[iwmmxt] = "Enable Intel PXA27x specific processor optimizations" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'iwmmxt', ' -march=iwmmxt -mcpu=iwmmxt', '', d)}" +TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'iwmmxt', ' -mcpu=iwmmxt', '', d)}" AVAILTUNES += "iwmmxt" ARMPKGARCH_tune-iwmmxt = "iwmmxt" --2.20.1
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 8 lines · Khem Raj
Quoted 6 lines · Andre McCurdy
Quoted 3 lines · Khem Raj
tune files which inherit the arch definitions already define appropriate -mcpu option, which is equivalent of right -march and -mtune combination
Quoted 6 lines
Quoted 2 lines
And what about machines which inherit an arch definition instead of a cpu definition? Is that no longer supported?
I could not find such a machine configuration in several BSP layers I looked at. Do you know of machine definitions where these files are included directly in machine configs ?
Using a CPU specific include but then leaving the generic DEFAULTTUNE (ie not enabling any CPU specific TUNE_CCARGS) is equivalent, and I guess quite common.
Quoted 3 lines
if so, then we have to either use
_removeor introduce a weak variable to set march only if
mcpu is not set which
I think the solution is to ensure that the CPU specific tuning options are always compatible with any architecture specific options which may be active.
In general our CPU specific tuning files are a little sloppy (e.g. defaulting to combinations of VFP versions and architecture levels which never exist in the real world). If newer versions of gcc are making those issues more apparent then why not take the opportunity to fix them properly?
Quoted 121 lines
Quoted 13 lines
Quoted 13 lines
and is preferred since gcc is getting stricter and stricter with option check semantics and can now find incompatible -march and -mcpu options better with every release. It does internal feature consistency check and if it finds out discrepency between what -mcpu would expand to as compared to -march it will flag the options to be incompatible, for naked eye it sounds wrong but gcc would translate -mcpu to a given -march internally and it might not match to what we set in these arch files.
The effects are quite subtle, where this can result in configure test failing to compile due to these incompatible options and a feature option getting disabled for a recipe for no reason.
Quoted 7 lines
Quoted 5 lines
e.g. with gcc9 which can now detect that -mcpu=cortex-a5 and -march=armv7-a are incompatible, many features in libstdc++ ends up disabled due to configure check failures e.g.
size_tsize,ptrdiff_tsizes, which inturn results in compiling libstdc++ with unwanted disabled features.It would be interesting to see more specific details of this.
These are configure tests which fail when -Werror is in use and is not limited to libstdc++
it can happen in any package. Since the diagnostic about incompatible march mcpu pair
is a warning in general, it does not matter, but when we have -Werror enabled this turns
into error, You can simply try a small helloworld example to see the effects.Quoted 92 lines
Quoted 92 lines
Signed-off-by Khem Raj <[email protected]>--- meta/conf/machine/include/arm/arch-armv4.inc | 1 - meta/conf/machine/include/arm/arch-armv5.inc | 1 - meta/conf/machine/include/arm/arch-armv6.inc | 1 - meta/conf/machine/include/arm/arch-armv7a.inc | 1 - meta/conf/machine/include/arm/arch-armv7ve.inc | 1 - meta/conf/machine/include/tune-iwmmxt.inc | 2 +- 6 files changed, 1 insertion(+), 6 deletions(-)meta/conf/machine/include/arm/arch-armv4.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv4" TUNEVALID[arm] = "Enable ARM instruction set" TUNEVALID[armv4] = "Enable instructions for ARMv4" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv4', ' -march=armv4t', '', d)}" # enable --fix-v4bx when we have armv4 in TUNE_FEATURES, but then disable it when we have also armv5 or thumb # maybe we should extend bb.utils.contains to support check for any checkvalues in value, now it does # checkvalues.issubset(val) which cannot be used for negative test of foo neither bar in valuemeta/conf/machine/include/arm/arch-armv5.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv5" TUNEVALID[armv5] = "Enable instructions for ARMv5" TUNECONFLICTS[armv5] = "armv4" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv5', ' -march=armv5t${ARMPKGSFX_DSP}', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv5', 'armv5:', '' ,d)}" require conf/machine/include/arm/arch-armv4.incmeta/conf/machine/include/arm/arch-armv6.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv6hf" TUNEVALID[armv6] = "Enable instructions for ARMv6" TUNECONFLICTS[armv6] = "armv4 armv5" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv6', ' -march=armv6', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv6', 'armv6:', '' ,d)}" require conf/machine/include/arm/arch-armv5-dsp.incmeta/conf/machine/include/arm/arch-armv7a.inc +0
-1@@ -3,7 +3,6 @@ ARM_INSTRUCTION_SET ?= "thumb" TUNEVALID[armv7a] = "Enable instructions for ARMv7-a" TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv7a', ' -march=armv7-a', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv7a', 'armv7a:', '' ,d)}" require conf/machine/include/arm/arch-armv6.incmeta/conf/machine/include/arm/arch-armv7ve.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv7vethf" TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve" TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv7ve', ' -march=armv7ve', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv7ve', 'armv7ve:', '' ,d)}" require conf/machine/include/arm/arch-armv7a.incmeta/conf/machine/include/tune-iwmmxt.inc +1
-2@@ -6,7 +6,7 @@ DEFAULTTUNE ?= "iwmmxt" require conf/machine/include/arm/arch-armv5-dsp.inc TUNEVALID[iwmmxt] = "Enable Intel PXA27x specific processor optimizations" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'iwmmxt', ' -march=iwmmxt -mcpu=iwmmxt', '', d)}" +TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'iwmmxt', ' -mcpu=iwmmxt', '', d)}" AVAILTUNES += "iwmmxt" ARMPKGARCH_tune-iwmmxt = "iwmmxt" --2.20.1
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 13 lines · Andre McCurdy
Quoted 11 lines · Khem Raj
Quoted 8 lines · Andre McCurdy
Quoted 3 lines · Khem Raj
tune files which inherit the arch definitions already define appropriate -mcpu option, which is equivalent of right -march and -mtune combination
And what about machines which inherit an arch definition instead of a cpu definition? Is that no longer supported?
Quoted 7 lines
Quoted 3 lines
I could not find such a machine configuration in several BSP layers I looked at. Do you know of machine definitions where these files are included directly in machine configs ?
Using a CPU specific include but then leaving the generic DEFAULTTUNE (ie not enabling any CPU specific
TUNE_CCARGS) is equivalent, and I guess quite common.
defaulttune does not play much part in appending -mcpu option to compiler flags, A case
where this could bypass the setting mcpu is when we do not include a tune-* for arm based machine
and thats the case I was interested to know.
again if there is such a BSP I would be interested to test it out.
Quoted 9 lines
Quoted 4 lines
if so, then we have to either use
_removeor introduce a weak variable to set march only if
mcpu is not set whichI think the solution is to ensure that the CPU specific tuning options are always compatible with any architecture specific options which may be active.
Quoted 5 lines
In general our CPU specific tuning files are a little sloppy (e.g. defaulting to combinations of VFP versions and architecture levels which never exist in the real world). If newer versions of gcc are making those issues more apparent then why not take the opportunity to fix them properly?
the mcpu option is helping with right march/mtune combination. while we can use specific -march=arch(+-)features syntax and combine with right -mtune to match -mcpu I think we should use
compiler defaults and not try to recreate something that -mcpu would do it easily for us.
So either we drop the idea of setting mcpu and use basic -march value combined with -mtune ( which btw. was default in past)
or if we want to let compiler use ISA for a particular arch implementation ( cortexXXX ) then we should just use -mcpu and drop using -mtune and -march.
I would include towards option 1.
Quoted 122 lines
Quoted 122 lines
Quoted 14 lines
Quoted 14 lines
and is preferred since gcc is getting stricter and stricter with option check semantics and can now find incompatible -march and -mcpu options better with every release. It does internal feature consistency check and if it finds out discrepency between what -mcpu would expand to as compared to -march it will flag the options to be incompatible, for naked eye it sounds wrong but gcc would translate -mcpu to a given -march internally and it might not match to what we set in these arch files.
The effects are quite subtle, where this can result in configure test failing to compile due to these incompatible options and a feature option getting disabled for a recipe for no reason.
Quoted 7 lines
Quoted 5 lines
e.g. with gcc9 which can now detect that -mcpu=cortex-a5 and -march=armv7-a are incompatible, many features in libstdc++ ends up disabled due to configure check failures e.g.
size_tsize,ptrdiff_tsizes, which inturn results in compiling libstdc++ with unwanted disabled features.It would be interesting to see more specific details of this.
These are configure tests which fail when -Werror is in use and is not limited to libstdc++
it can happen in any package. Since the diagnostic about incompatible march mcpu pair
is a warning in general, it does not matter, but when we have -Werror enabled this turns
into error, You can simply try a small helloworld example to see the effects.Quoted 92 lines
Quoted 92 lines
Signed-off-by Khem Raj <[email protected]>--- meta/conf/machine/include/arm/arch-armv4.inc | 1 - meta/conf/machine/include/arm/arch-armv5.inc | 1 - meta/conf/machine/include/arm/arch-armv6.inc | 1 - meta/conf/machine/include/arm/arch-armv7a.inc | 1 - meta/conf/machine/include/arm/arch-armv7ve.inc | 1 - meta/conf/machine/include/tune-iwmmxt.inc | 2 +- 6 files changed, 1 insertion(+), 6 deletions(-)meta/conf/machine/include/arm/arch-armv4.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv4" TUNEVALID[arm] = "Enable ARM instruction set" TUNEVALID[armv4] = "Enable instructions for ARMv4" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv4', ' -march=armv4t', '', d)}" # enable --fix-v4bx when we have armv4 in TUNE_FEATURES, but then disable it when we have also armv5 or thumb # maybe we should extend bb.utils.contains to support check for any checkvalues in value, now it does # checkvalues.issubset(val) which cannot be used for negative test of foo neither bar in valuemeta/conf/machine/include/arm/arch-armv5.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv5" TUNEVALID[armv5] = "Enable instructions for ARMv5" TUNECONFLICTS[armv5] = "armv4" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv5', ' -march=armv5t${ARMPKGSFX_DSP}', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv5', 'armv5:', '' ,d)}" require conf/machine/include/arm/arch-armv4.incmeta/conf/machine/include/arm/arch-armv6.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv6hf" TUNEVALID[armv6] = "Enable instructions for ARMv6" TUNECONFLICTS[armv6] = "armv4 armv5" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv6', ' -march=armv6', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv6', 'armv6:', '' ,d)}" require conf/machine/include/arm/arch-armv5-dsp.incmeta/conf/machine/include/arm/arch-armv7a.inc +0
-1@@ -3,7 +3,6 @@ ARM_INSTRUCTION_SET ?= "thumb" TUNEVALID[armv7a] = "Enable instructions for ARMv7-a" TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv7a', ' -march=armv7-a', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv7a', 'armv7a:', '' ,d)}" require conf/machine/include/arm/arch-armv6.incmeta/conf/machine/include/arm/arch-armv7ve.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv7vethf" TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve" TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv7ve', ' -march=armv7ve', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv7ve', 'armv7ve:', '' ,d)}" require conf/machine/include/arm/arch-armv7a.incmeta/conf/machine/include/tune-iwmmxt.inc +1
-2@@ -6,7 +6,7 @@ DEFAULTTUNE ?= "iwmmxt" require conf/machine/include/arm/arch-armv5-dsp.inc TUNEVALID[iwmmxt] = "Enable Intel PXA27x specific processor optimizations" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'iwmmxt', ' -march=iwmmxt -mcpu=iwmmxt', '', d)}" +TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'iwmmxt', ' -mcpu=iwmmxt', '', d)}" AVAILTUNES += "iwmmxt" ARMPKGARCH_tune-iwmmxt = "iwmmxt" --2.20.1
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 50 lines · Khem Raj
Quoted 13 lines · Andre McCurdy
Quoted 11 lines · Khem Raj
Quoted 8 lines · Andre McCurdy
Quoted 3 lines · Khem Raj
tune files which inherit the arch definitions already define appropriate -mcpu option, which is equivalent of right -march and -mtune combination
And what about machines which inherit an arch definition instead of a cpu definition? Is that no longer supported?
Quoted 7 lines
Quoted 3 lines
I could not find such a machine configuration in several BSP layers I looked at. Do you know of machine definitions where these files are included directly in machine configs ?
Using a CPU specific include but then leaving the generic DEFAULTTUNE (ie not enabling any CPU specific
TUNE_CCARGS) is equivalent, and I guess quite common.defaulttune does not play much part in appending -mcpu option to compiler flags, A case
where this could bypass the setting mcpu is when we do not include a tune-* for arm based machine
and thats the case I was interested to know.again if there is such a BSP I would be interested to test it out.
Quoted 9 lines
Quoted 4 lines
if so, then we have to either use
_removeor introduce a weak variable to set march only if
mcpu is not set whichI think the solution is to ensure that the CPU specific tuning options are always compatible with any architecture specific options which may be active.
Quoted 5 lines
In general our CPU specific tuning files are a little sloppy (e.g. defaulting to combinations of VFP versions and architecture levels which never exist in the real world). If newer versions of gcc are making those issues more apparent then why not take the opportunity to fix them properly?
the mcpu option is helping with right march/mtune combination. while we can use specific -march=arch(+-)features syntax and combine with right -mtune to match -mcpu I think we should use
compiler defaults and not try to recreate something that -mcpu would do it easily for us.
Quoted 7 lines
So either we drop the idea of setting mcpu and use basic -march value combined with -mtune ( which btw. was default in past)
or if we want to let compiler use ISA for a particular arch implementation ( cortexXXX ) then we should just use -mcpu and drop using -mtune and -march.I would include towards option 1.
I know this is a bit of a 'me too' response, but we have to pick one format and stay with it. Either option, but not both.
-IF- we know that the appropriate -mcpu options are available for all of the potential combinations out there, then this is by far the preferred method in my mind. Much easier to handle and manage...
However, the more complex route came out as various 'odd-ball' (and people claim don't exist, but they do) custom ARM cores get released without 'mandatory' math units, or some other odd ball variation. (I've seen this numerous times over the last 20 years that something that doesn't exist, does... all because it's a custom part.)
If we have an easy way to define the -mcpu= means some magic combination of -march/-mtune within the GCC spec itself, then I'm 100% for moving to -mcpu to rid ourselves of this mess.. and then we still have the flexibility to easily update/add tunes and GCC configuration for the odd-balls that seem to crop up regularly.
(I know -I- can always patch GCC for new -mcpu combinations, but I'm not thinking about 'me', I'm thinking about the user of OE who is told 'use this CPU, it has this set of functions' and is NOT a compiler expert who can wade through GCC spec files and generate patches with any confidence.)
--Mark
Quoted 122 lines
Quoted 122 lines
Quoted 122 lines
Quoted 14 lines
Quoted 14 lines
and is preferred since gcc is getting stricter and stricter with option check semantics and can now find incompatible -march and -mcpu options better with every release. It does internal feature consistency check and if it finds out discrepency between what -mcpu would expand to as compared to -march it will flag the options to be incompatible, for naked eye it sounds wrong but gcc would translate -mcpu to a given -march internally and it might not match to what we set in these arch files.
The effects are quite subtle, where this can result in configure test failing to compile due to these incompatible options and a feature option getting disabled for a recipe for no reason.
Quoted 7 lines
Quoted 5 lines
e.g. with gcc9 which can now detect that -mcpu=cortex-a5 and -march=armv7-a are incompatible, many features in libstdc++ ends up disabled due to configure check failures e.g.
size_tsize,ptrdiff_tsizes, which inturn results in compiling libstdc++ with unwanted disabled features.It would be interesting to see more specific details of this.
These are configure tests which fail when -Werror is in use and is not limited to libstdc++
it can happen in any package. Since the diagnostic about incompatible march mcpu pair
is a warning in general, it does not matter, but when we have -Werror enabled this turns
into error, You can simply try a small helloworld example to see the effects.Quoted 92 lines
Quoted 92 lines
Signed-off-by Khem Raj <[email protected]>--- meta/conf/machine/include/arm/arch-armv4.inc | 1 - meta/conf/machine/include/arm/arch-armv5.inc | 1 - meta/conf/machine/include/arm/arch-armv6.inc | 1 - meta/conf/machine/include/arm/arch-armv7a.inc | 1 - meta/conf/machine/include/arm/arch-armv7ve.inc | 1 - meta/conf/machine/include/tune-iwmmxt.inc | 2 +- 6 files changed, 1 insertion(+), 6 deletions(-)meta/conf/machine/include/arm/arch-armv4.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv4" TUNEVALID[arm] = "Enable ARM instruction set" TUNEVALID[armv4] = "Enable instructions for ARMv4" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv4', ' -march=armv4t', '', d)}" # enable --fix-v4bx when we have armv4 in TUNE_FEATURES, but then disable it when we have also armv5 or thumb # maybe we should extend bb.utils.contains to support check for any checkvalues in value, now it does # checkvalues.issubset(val) which cannot be used for negative test of foo neither bar in valuemeta/conf/machine/include/arm/arch-armv5.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv5" TUNEVALID[armv5] = "Enable instructions for ARMv5" TUNECONFLICTS[armv5] = "armv4" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv5', ' -march=armv5t${ARMPKGSFX_DSP}', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv5', 'armv5:', '' ,d)}" require conf/machine/include/arm/arch-armv4.incmeta/conf/machine/include/arm/arch-armv6.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv6hf" TUNEVALID[armv6] = "Enable instructions for ARMv6" TUNECONFLICTS[armv6] = "armv4 armv5" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv6', ' -march=armv6', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv6', 'armv6:', '' ,d)}" require conf/machine/include/arm/arch-armv5-dsp.incmeta/conf/machine/include/arm/arch-armv7a.inc +0
-1@@ -3,7 +3,6 @@ ARM_INSTRUCTION_SET ?= "thumb" TUNEVALID[armv7a] = "Enable instructions for ARMv7-a" TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv7a', ' -march=armv7-a', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv7a', 'armv7a:', '' ,d)}" require conf/machine/include/arm/arch-armv6.incmeta/conf/machine/include/arm/arch-armv7ve.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv7vethf" TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve" TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv7ve', ' -march=armv7ve', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv7ve', 'armv7ve:', '' ,d)}" require conf/machine/include/arm/arch-armv7a.incmeta/conf/machine/include/tune-iwmmxt.inc +1
-2@@ -6,7 +6,7 @@ DEFAULTTUNE ?= "iwmmxt" require conf/machine/include/arm/arch-armv5-dsp.inc TUNEVALID[iwmmxt] = "Enable Intel PXA27x specific processor optimizations" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'iwmmxt', ' -march=iwmmxt -mcpu=iwmmxt', '', d)}" +TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'iwmmxt', ' -mcpu=iwmmxt', '', d)}" AVAILTUNES += "iwmmxt" ARMPKGARCH_tune-iwmmxt = "iwmmxt" --2.20.1
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 3 lines · Mark Hatle
Quoted 1 line · Khem Raj
On Wed, Jan 23, 2019 at 6:11 PM Andre McCurdy <[email protected]>
Quoted 4 lines · wrote:
Quoted 4 lines
Quoted 4 lines · Khem Raj
Quoted 2 lines
On Wed, Jan 23, 2019 at 5:27 PM Andre McCurdy <[email protected]>
Quoted 4 lines · wrote:
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines · Khem Raj
Quoted 2 lines
tune files which inherit the arch definitions already define
appropriate
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
-mcpu option, which is equivalent of right -march and -mtune
combination
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 3 lines
And what about machines which inherit an arch definition instead of a cpu definition? Is that no longer supported?
I could not find such a machine configuration in several BSP layers I
looked at.
Quoted 23 lines
Quoted 23 lines
Quoted 6 lines
Quoted 2 lines
Do you know of machine definitions where these files are included directly in machine configs ?
Using a CPU specific include but then leaving the generic DEFAULTTUNE (ie not enabling any CPU specific
TUNE_CCARGS) is equivalent, and I guess quite common.defaulttune does not play much part in appending -mcpu option to compiler flags, A case
where this could bypass the setting mcpu is when we do not include a tune-* for arm based machine
and thats the case I was interested to know.again if there is such a BSP I would be interested to test it out.
Quoted 9 lines
Quoted 4 lines
if so, then we have to either use
_removeor introduce a weak variable to set march only if
mcpu is not set whichI think the solution is to ensure that the CPU specific tuning options are always compatible with any architecture specific options which may be active.
Quoted 7 lines
Quoted 7 lines
Quoted 5 lines
In general our CPU specific tuning files are a little sloppy (e.g. defaulting to combinations of VFP versions and architecture levels which never exist in the real world). If newer versions of gcc are making those issues more apparent then why not take the opportunity to fix them properly?
the mcpu option is helping with right march/mtune combination. while we
can
Quoted 11 lines
Quoted 11 lines
use specific -march=arch(+-)features syntax and combine with right -mtune to match -mcpu I think we should use
compiler defaults and not try to recreate something that -mcpu would do it easily for us.So either we drop the idea of setting mcpu and use basic -march value combined with -mtune ( which btw. was default in past)
or if we want to let compiler use ISA for a particular arch implementation ( cortexXXX ) then we should just use -mcpu and drop using -mtune and -march.
Quoted 3 lines
Quoted 1 line
I would include towards option 1.
I know this is a bit of a 'me too' response, but we have to pick one
format and
Quoted 1 line
stay with it. Either option, but not both.
I concur.
Quoted 2 lines
-IF- we know that the appropriate -mcpu options are available for all of
the
Quoted 1 line
potential combinations out there, then this is by far the preferred
method in my
Quoted 1 line
mind. Much easier to handle and manage...
-mcpu options are available for known CPU implementations. But there always will
be weird ones, given how people can pick and choose subsystems for SOC on this
architecture, and its highly probable that they wont be in gcc. so real question we need to answer for is, should we design for those cases and how often does this often.
Quoted 2 lines
However, the more complex route came out as various 'odd-ball' (and
people claim
Quoted 1 line
don't exist, but they do) custom ARM cores get released without
'mandatory' math
Quoted 1 line
units, or some other odd ball variation. (I've seen this numerous times
over
Quoted 1 line
the last 20 years that something that doesn't exist, does... all because
it's a
Quoted 1 line
custom part.)
Yes, I am dealing with one such design even today
Quoted 2 lines
If we have an easy way to define the -mcpu= means some magic combination
of
Quoted 1 line
-march/-mtune within the GCC spec itself, then I'm 100% for moving to
-mcpu to
Quoted 1 line
rid ourselves of this mess.. and then we still have the flexibility to
easily
Quoted 1 line
update/add tunes and GCC configuration for the odd-balls that seem to
crop up
Quoted 1 line
regularly.
So yes we can do nearly same but not exactly same. We have to start adding or deleting
features via -march and -mtune would be same value, but there are cases where gcc defines
internal properties based on mcpu, that is not representable in those suffixes we will add. so
we will come very close but not exact and I think compiler is right in this case because we
are not exactly telling it about a CPU implementation, but we are telling the cpu has these properties, so it really may not be one of standard cpu implementation.
Quoted 3 lines
(I know -I- can always patch GCC for new -mcpu combinations, but I'm not thinking about 'me', I'm thinking about the user of OE who is told 'use
this
Quoted 1 line
CPU, it has this set of functions' and is NOT a compiler expert who can
wade
Quoted 2 lines
through GCC spec files and generate patches with any confidence.)
I would think we can solve this for these niche cases, via using -march/-mtune and drop
-mcpu, we can append adding/deleting a given feature e.g. neon or vfp or vfpv3 etc.
but this would mean we have to rename our package feed names as well to match this
new representation, which currently is mapped to mcpu values. This is quite a departure
from package feeds point of view. but its more aligned with how we have defined arch and tunes.
so pick the battles.
Quoted 4 lines
--Mark
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
and is preferred since gcc is getting stricter and stricter with
option
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
check semantics and can now find incompatible -march and -mcpu
options
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
better with every release. It does internal feature consistency
check
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
and if it finds out discrepency between what -mcpu would expand to
as
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
compared to -march it will flag the options to be incompatible, for naked eye it sounds wrong but gcc would translate -mcpu to a given -march internally and it might not match to what we set in these
arch
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
files.
The effects are quite subtle, where this can result in configure
test
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 10 lines
Quoted 8 lines
failing to compile due to these incompatible options and a feature option getting disabled for a recipe for no reason.
e.g. with gcc9 which can now detect that -mcpu=cortex-a5 and -march=armv7-a are incompatible, many features in libstdc++ ends up disabled due to configure check failures e.g.
size_tsize,ptrdiff_tsizes, which inturn results in compiling libstdc++ with unwanted disabled features.It would be interesting to see more specific details of this.
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
These are configure tests which fail when -Werror is in use and is not limited to libstdc++
it can happen in any package. Since the diagnostic about incompatible march mcpu pair
is a warning in general, it does not matter, but when we have -Werror enabled this turns
into error, You can simply try a small helloworld example to see the
effects.
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Signed-off-by Khem Raj <[email protected]>--- meta/conf/machine/include/arm/arch-armv4.inc | 1 - meta/conf/machine/include/arm/arch-armv5.inc | 1 - meta/conf/machine/include/arm/arch-armv6.inc | 1 - meta/conf/machine/include/arm/arch-armv7a.inc | 1 - meta/conf/machine/include/arm/arch-armv7ve.inc | 1 - meta/conf/machine/include/tune-iwmmxt.inc | 2 +- 6 files changed, 1 insertion(+), 6 deletions(-)
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Review
Quoted 1 line
(quoted diff) +0
-0
b/meta/conf/machine/include/arm/arch-armv4.inc
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
meta/conf/machine/include/arm/arch-armv4.inc DEFAULTTUNE ?= "armv4" · line 5
Quoted 8 lines
index
47a7ad2830..52d8ab1e8f100644meta/conf/machine/include/arm/arch-armv4.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv4" TUNEVALID[arm] = "Enable ARM instruction set" TUNEVALID[armv4] = "Enable instructions for ARMv4" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv4', '
-march=armv4t', '', d)}"
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/arm/arch-armv4.inc DEFAULTTUNE ?= "armv4" · line 5
Quoted 1 line
meta/conf/machine/include/arm/arch-armv4.inc +0
-0# enable --fix-v4bx when we have armv4 in TUNE_FEATURES, but then
disable it when we have also armv5 or thumb
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/arm/arch-armv4.inc DEFAULTTUNE ?= "armv4" · line 6
Quoted 1 line
meta/conf/machine/include/arm/arch-armv4.inc +0
-0# maybe we should extend bb.utils.contains to support check for
any checkvalues in value, now it does
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/arm/arch-armv4.inc DEFAULTTUNE ?= "armv4" · line 7
Quoted 1 line
meta/conf/machine/include/arm/arch-armv4.inc +0
-0# checkvalues.issubset(val) which cannot be used for negative test
of foo neither bar in value
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Review
Quoted 1 line
(quoted diff) +0
-0
b/meta/conf/machine/include/arm/arch-armv5.inc
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
meta/conf/machine/include/arm/arch-armv5.inc DEFAULTTUNE ?= "armv5" · line 5
Quoted 8 lines
index
f9068af9de..1fe1b6b8e4100644meta/conf/machine/include/arm/arch-armv5.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv5" TUNEVALID[armv5] = "Enable instructions for ARMv5" TUNECONFLICTS[armv5] = "armv4" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv5', '
-march=armv5t${ARMPKGSFX_DSP}', '', d)}"
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/arm/arch-armv5.inc DEFAULTTUNE ?= "armv5" · line 5
Quoted 1 line
meta/conf/machine/include/arm/arch-armv5.inc +0
-0MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES',
'armv5', 'armv5:', '' ,d)}"
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Review
Quoted 3 lines
meta/conf/machine/include/arm/arch-armv5.inc +0
-0require conf/machine/include/arm/arch-armv4.inc(quoted diff) +0
-0
b/meta/conf/machine/include/arm/arch-armv6.inc
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
meta/conf/machine/include/arm/arch-armv6.inc DEFAULTTUNE ?= "armv6hf" · line 5
Quoted 8 lines
index
6c838e999c..adb9be8050100644meta/conf/machine/include/arm/arch-armv6.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv6hf" TUNEVALID[armv6] = "Enable instructions for ARMv6" TUNECONFLICTS[armv6] = "armv4 armv5" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv6', '
-march=armv6', '', d)}"
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/arm/arch-armv6.inc DEFAULTTUNE ?= "armv6hf" · line 5
Quoted 1 line
meta/conf/machine/include/arm/arch-armv6.inc +0
-0MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES',
'armv6', 'armv6:', '' ,d)}"
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Review
Quoted 3 lines
meta/conf/machine/include/arm/arch-armv6.inc +0
-0require conf/machine/include/arm/arch-armv5-dsp.inc(quoted diff) +0
-0
b/meta/conf/machine/include/arm/arch-armv7a.inc
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
meta/conf/machine/include/arm/arch-armv7a.inc ARM_INSTRUCTION_SET ?= "thumb" · line 6
Quoted 8 lines
index
a2663d8008..09d2c03a5d100644meta/conf/machine/include/arm/arch-armv7a.inc +0
-1@@ -3,7 +3,6 @@ ARM_INSTRUCTION_SET ?= "thumb" TUNEVALID[armv7a] = "Enable instructions for ARMv7-a" TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv7a', '
-march=armv7-a', '', d)}"
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/arm/arch-armv7a.inc ARM_INSTRUCTION_SET ?= "thumb" · line 6
Quoted 1 line
meta/conf/machine/include/arm/arch-armv7a.inc +0
-0MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES',
'armv7a', 'armv7a:', '' ,d)}"
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Review
Quoted 3 lines
meta/conf/machine/include/arm/arch-armv7a.inc +0
-0require conf/machine/include/arm/arch-armv6.inc(quoted diff) +0
-0
b/meta/conf/machine/include/arm/arch-armv7ve.inc
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
meta/conf/machine/include/arm/arch-armv7ve.inc DEFAULTTUNE ?= "armv7vethf" · line 5
Quoted 8 lines
index
4d9260fecb..31e334f645100644meta/conf/machine/include/arm/arch-armv7ve.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv7vethf" TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve" TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv7ve', '
-march=armv7ve', '', d)}"
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/arm/arch-armv7ve.inc DEFAULTTUNE ?= "armv7vethf" · line 5
Quoted 1 line
meta/conf/machine/include/arm/arch-armv7ve.inc +0
-0MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES',
'armv7ve', 'armv7ve:', '' ,d)}"
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Review
Quoted 3 lines
meta/conf/machine/include/arm/arch-armv7ve.inc +0
-0require conf/machine/include/arm/arch-armv7a.inc(quoted diff) +0
-0
b/meta/conf/machine/include/tune-iwmmxt.inc
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
meta/conf/machine/include/tune-iwmmxt.inc DEFAULTTUNE ?= "iwmmxt" · line 8
Quoted 7 lines
index
f27423cb2e..6e577697cc100644meta/conf/machine/include/tune-iwmmxt.inc +0
-0@@ -6,7 +6,7 @@ DEFAULTTUNE ?= "iwmmxt" require conf/machine/include/arm/arch-armv5-dsp.inc TUNEVALID[iwmmxt] = "Enable Intel PXA27x specific processor
optimizations"
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/tune-iwmmxt.inc DEFAULTTUNE ?= "iwmmxt" · line 9
Quoted 1 line
meta/conf/machine/include/tune-iwmmxt.inc +0
-1-TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'iwmmxt', '
-march=iwmmxt -mcpu=iwmmxt', '', d)}"
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/tune-iwmmxt.inc DEFAULTTUNE ?= "iwmmxt" · line 9
Quoted 1 line
meta/conf/machine/include/tune-iwmmxt.inc +1
-0+TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'iwmmxt', '
-mcpu=iwmmxt', '', d)}"
Quoted 12 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
meta/conf/machine/include/tune-iwmmxt.inc +0
-1AVAILTUNES += "iwmmxt" ARMPKGARCH_tune-iwmmxt = "iwmmxt" --2.20.1
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Which -mcpu/-march combination is causing issue in gcc9?
I know we had this issue with armv7a tunes before, that's why I've added separate armv7ve before the switch from -mtune to -mcpu.
I still believe -mcpu (with or without -march) is better option.
Using -mtune without indicating which -mtune was actually used in the package arch is bad (especially if you have multiple MACHINEs with different DEFAULTTUNEs e.g. cortexa7, cortexa8 in -mtune, but both ending in armv7a package arch, unpacking all packages from sstate every time you switch MACHINE and the package manager on target never knowing which -mtune was used to build given package upgrade from feed).
Switching from -mcpu to -mtune while keeping the current cpu-specific package architectures is better, but then the use case, that I build everything e.g. with cortexa8 in -mtune and install this cortexa8 package feed on cortexa7 MACHINEs also looks strange, yes it will work in runtime, but why not use generic armv7a DEFAULTTUNE to make it clear (to package manager as well as end user) that I'm not really optimizing for given CPU).
From the naive openssl benchmarks I did few years back, there was very small difference between mtune/mcpu/just-march, but still for projects where I have separate package feeds for each device (e.g. LG TVs) I prefer to use -mcpu (because I really know that such packages won't ever be used on device with different CPU) and e.g. in LuneOS we're more concerned about package feed size and build time, so we select more generic DEFAULTTUNE which is shared across many MACHINEs and that doesn't have any -mcpu (nor -mtune) options in it, so should be fine as well.
We can easily extend the tune-test script I've used back then when switching to -mcpu to not only use bitbake -e, but also call gcc-cross to check for possible warnings from incompatible march/mcpu combinations and fix those. The old version is here:
http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/tune-test
it was used in mcpu switch here:
http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/tune2-test
http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/tune3
From the gcc git log I don't see many changes in:
https://github.com/gcc-mirror/gcc/commits/master/gcc/config/arm/driver-arm.c
nor
https://github.com/gcc-mirror/gcc/commits/master/gcc/config/arm/arm-cpus.in
so I'm really interested which combination issues the warning now.
Regards,
Quoted 316 lines · Khem Raj
Quoted 3 lines · Mark Hatle
Quoted 1 line · Khem Raj
On Wed, Jan 23, 2019 at 6:11 PM Andre McCurdy <[email protected]>
Quoted 4 lines · wrote:
Quoted 4 lines
Quoted 4 lines · Khem Raj
Quoted 2 lines
On Wed, Jan 23, 2019 at 5:27 PM Andre McCurdy <[email protected]>
Quoted 2 lines · wrote:
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
On Wed, Jan 23, 2019 at 12:05 PM Khem Raj <[email protected]>
Quoted 2 lines · wrote:
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
tune files which inherit the arch definitions already define
appropriate
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
-mcpu option, which is equivalent of right -march and -mtune
combination
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
And what about machines which inherit an arch definition instead of
a
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line
cpu definition? Is that no longer supported?
I could not find such a machine configuration in several BSP layers
I looked at.
Quoted 13 lines
Quoted 13 lines
Quoted 6 lines
Quoted 2 lines
Do you know of machine definitions where these files are included directly in machine configs ?
Using a CPU specific include but then leaving the generic DEFAULTTUNE (ie not enabling any CPU specific
TUNE_CCARGS) is equivalent, and I guess quite common.defaulttune does not play much part in appending -mcpu option to compiler flags, A case
where this could bypass the setting mcpu is when we do not include a tune-* for arm based machine
and thats the case I was interested to know.Quoted 3 lines
Quoted 3 lines
again if there is such a BSP I would be interested to test it out.
Quoted 2 lines
Quoted 2 lines
if so, then we have to either use
_removeor introduce a weakvariable
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 2 lines
to set march only if
mcpu is not set whichI think the solution is to ensure that the CPU specific tuning options are always compatible with any architecture specific options which may be active.
Quoted 7 lines
Quoted 7 lines
Quoted 5 lines
In general our CPU specific tuning files are a little sloppy (e.g. defaulting to combinations of VFP versions and architecture levels which never exist in the real world). If newer versions of gcc are making those issues more apparent then why not take the opportunity to fix them properly?
the mcpu option is helping with right march/mtune combination. while
we can
Quoted 11 lines
Quoted 11 lines
use specific -march=arch(+-)features syntax and combine with right -mtune to match -mcpu I think we should use
compiler defaults and not try to recreate something that -mcpu would do it easily for us.So either we drop the idea of setting mcpu and use basic -march value combined with -mtune ( which btw. was default in past)
or if we want to let compiler use ISA for a particular arch implementation ( cortexXXX ) then we should just use -mcpu and drop using -mtune and -march.Quoted 3 lines
Quoted 1 line
I would include towards option 1.
I know this is a bit of a 'me too' response, but we have to pick one
format and
Quoted 1 line
stay with it. Either option, but not both.
I concur.
Quoted 2 lines
-IF- we know that the appropriate -mcpu options are available for all of
the
Quoted 1 line
potential combinations out there, then this is by far the preferred
method in my
Quoted 1 line
mind. Much easier to handle and manage...
-mcpu options are available for known CPU implementations. But there always will
be weird ones, given how people can pick and choose subsystems for SOC on this
architecture, and its highly probable that they wont be in gcc. so real question we need to answer for is, should we design for those cases and how often does this often.Quoted 2 lines
However, the more complex route came out as various 'odd-ball' (and
people claim
Quoted 1 line
don't exist, but they do) custom ARM cores get released without
'mandatory' math
Quoted 1 line
units, or some other odd ball variation. (I've seen this numerous times
over
Quoted 1 line
the last 20 years that something that doesn't exist, does... all because
it's a
Quoted 1 line
custom part.)
Yes, I am dealing with one such design even today
Quoted 2 lines
If we have an easy way to define the -mcpu= means some magic combination
of
Quoted 1 line
-march/-mtune within the GCC spec itself, then I'm 100% for moving to
-mcpu to
Quoted 1 line
rid ourselves of this mess.. and then we still have the flexibility to
easily
Quoted 1 line
update/add tunes and GCC configuration for the odd-balls that seem to
crop up
Quoted 1 line
regularly.
So yes we can do nearly same but not exactly same. We have to start adding or deleting
features via -march and -mtune would be same value, but there are cases where gcc defines
internal properties based on mcpu, that is not representable in those suffixes we will add. so
we will come very close but not exact and I think compiler is right in this case because we
are not exactly telling it about a CPU implementation, but we are telling the cpu has these properties, so it really may not be one of standard cpu implementation.Quoted 3 lines
(I know -I- can always patch GCC for new -mcpu combinations, but I'm not thinking about 'me', I'm thinking about the user of OE who is told 'use
this
Quoted 1 line
CPU, it has this set of functions' and is NOT a compiler expert who can
wade
Quoted 2 lines
through GCC spec files and generate patches with any confidence.)
I would think we can solve this for these niche cases, via using
(quoted diff) +0
-2-march/-mtune and drop -mcpu, we can append adding/deleting a given feature e.g. neon or vfp orvfpv3 etc.
but this would mean we have to rename our package feed names as well to match this
new representation, which currently is mapped to mcpu values. This is quite a departure
from package feeds point of view. but its more aligned with how we have defined arch and tunes.
so pick the battles.Quoted 4 lines
--Mark
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
and is preferred since gcc is getting stricter and stricter with
option
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
check semantics and can now find incompatible -march and -mcpu
options
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
better with every release. It does internal feature consistency
check
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
and if it finds out discrepency between what -mcpu would expand to
as
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
compared to -march it will flag the options to be incompatible, for naked eye it sounds wrong but gcc would translate -mcpu to a given -march internally and it might not match to what we set in these
arch
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
files.
The effects are quite subtle, where this can result in configure
test
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
failing to compile due to these incompatible options and a feature option getting disabled for a recipe for no reason.
e.g. with gcc9 which can now detect that -mcpu=cortex-a5 and -march=armv7-a are incompatible, many features in libstdc++ ends up disabled due to configure check failures e.g.
size_tsize,
ptrdiff_tQuoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
sizes, which inturn results in compiling libstdc++ with unwanted disabled features.
It would be interesting to see more specific details of this.
These are configure tests which fail when -Werror is in use and is
not
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
limited to libstdc++
it can happen in any package. Since the diagnostic about incompatible march mcpu pair
is a warning in general, it does not matter, but when we have -Werror enabled this turns
into error, You can simply try a small helloworld example to see theeffects.
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Signed-off-by Khem Raj <[email protected]>--- meta/conf/machine/include/arm/arch-armv4.inc | 1 - meta/conf/machine/include/arm/arch-armv5.inc | 1 - meta/conf/machine/include/arm/arch-armv6.inc | 1 - meta/conf/machine/include/arm/arch-armv7a.inc | 1 - meta/conf/machine/include/arm/arch-armv7ve.inc | 1 - meta/conf/machine/include/tune-iwmmxt.inc | 2 +- 6 files changed, 1 insertion(+), 6 deletions(-)Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Review
Quoted 1 line
(quoted diff) +0
-0b/meta/conf/machine/include/arm/arch-armv4.inc
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
meta/conf/machine/include/arm/arch-armv4.inc DEFAULTTUNE ?= "armv4" · line 5
Quoted 8 lines
index
47a7ad2830..52d8ab1e8f100644meta/conf/machine/include/arm/arch-armv4.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv4" TUNEVALID[arm] = "Enable ARM instruction set" TUNEVALID[armv4] = "Enable instructions for ARMv4" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv4', '-march=armv4t', '', d)}"
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/arm/arch-armv4.inc DEFAULTTUNE ?= "armv4" · line 5
Quoted 1 line
meta/conf/machine/include/arm/arch-armv4.inc +0
-0# enable --fix-v4bx when we have armv4 in TUNE_FEATURES, but thendisable it when we have also armv5 or thumb
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/arm/arch-armv4.inc DEFAULTTUNE ?= "armv4" · line 6
Quoted 1 line
meta/conf/machine/include/arm/arch-armv4.inc +0
-0# maybe we should extend bb.utils.contains to support check forany checkvalues in value, now it does
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/arm/arch-armv4.inc DEFAULTTUNE ?= "armv4" · line 7
Quoted 1 line
meta/conf/machine/include/arm/arch-armv4.inc +0
-0# checkvalues.issubset(val) which cannot be used for negativetest of foo neither bar in value
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Review
Quoted 1 line
(quoted diff) +0
-0b/meta/conf/machine/include/arm/arch-armv5.inc
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
meta/conf/machine/include/arm/arch-armv5.inc DEFAULTTUNE ?= "armv5" · line 5
Quoted 8 lines
index
f9068af9de..1fe1b6b8e4100644meta/conf/machine/include/arm/arch-armv5.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv5" TUNEVALID[armv5] = "Enable instructions for ARMv5" TUNECONFLICTS[armv5] = "armv4" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv5', '-march=armv5t${ARMPKGSFX_DSP}', '', d)}"
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/arm/arch-armv5.inc DEFAULTTUNE ?= "armv5" · line 5
Quoted 1 line
meta/conf/machine/include/arm/arch-armv5.inc +0
-0MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES','armv5', 'armv5:', '' ,d)}"
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Review
Quoted 3 lines
meta/conf/machine/include/arm/arch-armv5.inc +0
-0require conf/machine/include/arm/arch-armv4.inc(quoted diff) +0
-0b/meta/conf/machine/include/arm/arch-armv6.inc
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
meta/conf/machine/include/arm/arch-armv6.inc DEFAULTTUNE ?= "armv6hf" · line 5
Quoted 8 lines
index
6c838e999c..adb9be8050100644meta/conf/machine/include/arm/arch-armv6.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv6hf" TUNEVALID[armv6] = "Enable instructions for ARMv6" TUNECONFLICTS[armv6] = "armv4 armv5" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv6', '-march=armv6', '', d)}"
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/arm/arch-armv6.inc DEFAULTTUNE ?= "armv6hf" · line 5
Quoted 1 line
meta/conf/machine/include/arm/arch-armv6.inc +0
-0MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES','armv6', 'armv6:', '' ,d)}"
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Review
Quoted 3 lines
meta/conf/machine/include/arm/arch-armv6.inc +0
-0require conf/machine/include/arm/arch-armv5-dsp.inc(quoted diff) +0
-0b/meta/conf/machine/include/arm/arch-armv7a.inc
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
meta/conf/machine/include/arm/arch-armv7a.inc ARM_INSTRUCTION_SET ?= "thumb" · line 6
Quoted 8 lines
index
a2663d8008..09d2c03a5d100644meta/conf/machine/include/arm/arch-armv7a.inc +0
-1@@ -3,7 +3,6 @@ ARM_INSTRUCTION_SET ?= "thumb" TUNEVALID[armv7a] = "Enable instructions for ARMv7-a" TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv7a', '-march=armv7-a', '', d)}"
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/arm/arch-armv7a.inc ARM_INSTRUCTION_SET ?= "thumb" · line 6
Quoted 1 line
meta/conf/machine/include/arm/arch-armv7a.inc +0
-0MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES','armv7a', 'armv7a:', '' ,d)}"
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Review
Quoted 3 lines
meta/conf/machine/include/arm/arch-armv7a.inc +0
-0require conf/machine/include/arm/arch-armv6.inc(quoted diff) +0
-0b/meta/conf/machine/include/arm/arch-armv7ve.inc
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
meta/conf/machine/include/arm/arch-armv7ve.inc DEFAULTTUNE ?= "armv7vethf" · line 5
Quoted 8 lines
index
4d9260fecb..31e334f645100644meta/conf/machine/include/arm/arch-armv7ve.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv7vethf" TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve" TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv7ve',' -march=armv7ve', '', d)}"
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/arm/arch-armv7ve.inc DEFAULTTUNE ?= "armv7vethf" · line 5
Quoted 1 line
meta/conf/machine/include/arm/arch-armv7ve.inc +0
-0MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES','armv7ve', 'armv7ve:', '' ,d)}"
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Review
Quoted 3 lines
meta/conf/machine/include/arm/arch-armv7ve.inc +0
-0require conf/machine/include/arm/arch-armv7a.inc(quoted diff) +0
-0b/meta/conf/machine/include/tune-iwmmxt.inc
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
meta/conf/machine/include/tune-iwmmxt.inc DEFAULTTUNE ?= "iwmmxt" · line 8
Quoted 7 lines
index
f27423cb2e..6e577697cc100644meta/conf/machine/include/tune-iwmmxt.inc +0
-0@@ -6,7 +6,7 @@ DEFAULTTUNE ?= "iwmmxt" require conf/machine/include/arm/arch-armv5-dsp.inc TUNEVALID[iwmmxt] = "Enable Intel PXA27x specific processoroptimizations"
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/tune-iwmmxt.inc DEFAULTTUNE ?= "iwmmxt" · line 9
Quoted 1 line
meta/conf/machine/include/tune-iwmmxt.inc +0
-1-TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'iwmmxt', '-march=iwmmxt -mcpu=iwmmxt', '', d)}"
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/tune-iwmmxt.inc DEFAULTTUNE ?= "iwmmxt" · line 9
Quoted 1 line
meta/conf/machine/include/tune-iwmmxt.inc +1
-0+TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'iwmmxt', '-mcpu=iwmmxt', '', d)}"
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
meta/conf/machine/include/tune-iwmmxt.inc +0
-1AVAILTUNES += "iwmmxt" ARMPKGARCH_tune-iwmmxt = "iwmmxt" --2.20.1
Quoted 6 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 2 lines · Martin Jansa
Which -mcpu/-march combination is causing issue in gcc9?
Its when using cortex-a5 tunes, -march=armv7-a -mcpu=cortex-a5, but if we move the needle to fix the issue or test coverage then we miss the point here, the fact that this keeps coming up means we have a fundamental problem.
Quoted 3 lines
I know we had this issue with armv7a tunes before, that's why I've added separate armv7ve before the switch from -mtune to -mcpu.
Thats fine, however as I have explained before -mcpu is a combination of implicit -march and -mtune, so for best results should not be mixed with them. Originally the tune design in OE is one to one if we used -march + -mtune
method. That does not mean that -mcpu approach is inferior on the contrary might be better in certain cases and in fact in majority of cases we have.
Quoted 2 lines
I still believe -mcpu (with or without -march) is better option.
I think on one hand it is, but there is another part which Mark brought up of customized CPU implementations with not to common choices of subsystems, which may not be exactly represented by -mcpu options. I am inclined to
provide provisions to make it happen but I am not in favor of designing it to address these corner implementations. I would rather make it easy for 99% usecases.
Quoted 2 lines
Using -mtune without indicating which -mtune was actually used in the package arch is bad (especially if you have multiple MACHINEs with different DEFAULTTUNEs e.g. cortexa7, cortexa8 in -mtune, but both ending in armv7a package arch, unpacking all packages from sstate every time you switch MACHINE and the package manager on target never knowing which -mtune was used to build given package upgrade from feed).
Yes this was a change for better.
Quoted 2 lines
Switching from -mcpu to -mtune while keeping the current cpu-specific package architectures is better, but then the use case, that I build everything e.g. with cortexa8 in -mtune and install this cortexa8 package feed on cortexa7 MACHINEs also looks strange, yes it will work in runtime, but why not use generic armv7a DEFAULTTUNE to make it clear (to package manager as well as end user) that I'm not really optimizing for given CPU).
In current design I think we have design for using more optimized for a CPU and be able to generate feeds which are cpu specific which is great for certain use cases and hopefully more tunes to that CPU implementation.
Quoted 1 line
From the naive openssl benchmarks I did few years back, there was very small difference between mtune/mcpu/just-march, but still for projects where I have separate package feeds for each device (e.g. LG TVs) I prefer to use -mcpu (because I really know that such packages won't ever be used on device with different CPU) and e.g. in LuneOS we're more concerned about package feed size and build time, so we select more generic DEFAULTTUNE which is shared across many MACHINEs and that doesn't have any -mcpu (nor -mtune) options in it, so should be fine as well.
Exactly, the point here, we will be best served if we make it one way or other, e.g. raspbian used thumb1 ISA across all rpi implementations and they can use same feeds across all RPis that have even existed. It has advantages of
its own to be able to do that, especially for people who work on higher stacks they would be happy with such a setup.
So I have to suggest on of three approached
1. Change -mcpu to -mtune and keep everything same. This make feed arches point to tuned packages but fundamentally same for base architecture ( e.g. armv7-a),
2. Just use -mcpu and do not use -march/-mtune and may be provide mechanism to override -mcpu, which is done by packages anyway ( maps directly to package architectures )
3. Just use -march and drop -mcpu and -mtune - Rename feed arches to map to arch+features conventions instead of being CPU specific, this will freak the users since it will be overwhelming to understand the combinations
e.g. armv7ve+neon+vfpv4 etc. so the combination becomes
equivalent to -mcpu, current tune architecture we can construct this easily by appending to march based on TUNE_FEATURES but I think
package arches will be a massive to deal with and users
might ask what is this long -march/-mtune pointing to in terms of CPU, but it will address Mark's usecase and will bring us closer to using mcpu usecase, We can probaly do a bettter error reporting
as well for conflicting tune features.
I can cook up patches for option 3 from tunes part, packaging part I am not sure maybe we can live with what we have
option 2 I already have posted a patch, option 1 would be a simplest patch of all which can be done quickly as well.
Quoted 264 lines
We can easily extend the tune-test script I've used back then when switching to -mcpu to not only use bitbake -e, but also call gcc-cross to check for possible warnings from incompatible march/mcpu combinations and fix those. The old version is here:
http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/tune-test
it was used in mcpu switch here:
http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/tune2-test
http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/tune3From the gcc git log I don't see many changes in:
https://github.com/gcc-mirror/gcc/commits/master/gcc/config/arm/driver-arm.c
nor
https://github.com/gcc-mirror/gcc/commits/master/gcc/config/arm/arm-cpus.in
so I'm really interested which combination issues the warning now.Regards,
Quoted 248 lines · Khem Raj
Quoted 58 lines · Mark Hatle
Quoted 56 lines · Khem Raj
Quoted 13 lines · Andre McCurdy
Quoted 11 lines · Khem Raj
Quoted 8 lines · Andre McCurdy
Quoted 3 lines · Khem Raj
tune files which inherit the arch definitions already define appropriate -mcpu option, which is equivalent of right -march and -mtune combination
And what about machines which inherit an arch definition instead of a cpu definition? Is that no longer supported?
Quoted 7 lines
Quoted 3 lines
I could not find such a machine configuration in several BSP layers I looked at. Do you know of machine definitions where these files are included directly in machine configs ?
Using a CPU specific include but then leaving the generic DEFAULTTUNE (ie not enabling any CPU specific
TUNE_CCARGS) is equivalent, and I guess quite common.defaulttune does not play much part in appending -mcpu option to compiler flags, A case
where this could bypass the setting mcpu is when we do not include a tune-* for arm based machine
and thats the case I was interested to know.again if there is such a BSP I would be interested to test it out.
Quoted 9 lines
Quoted 4 lines
if so, then we have to either use
_removeor introduce a weak variable to set march only if
mcpu is not set whichI think the solution is to ensure that the CPU specific tuning options are always compatible with any architecture specific options which may be active.
Quoted 5 lines
In general our CPU specific tuning files are a little sloppy (e.g. defaulting to combinations of VFP versions and architecture levels which never exist in the real world). If newer versions of gcc are making those issues more apparent then why not take the opportunity to fix them properly?
the mcpu option is helping with right march/mtune combination. while we can use specific -march=arch(+-)features syntax and combine with right -mtune to match -mcpu I think we should use
compiler defaults and not try to recreate something that -mcpu would do it easily for us.So either we drop the idea of setting mcpu and use basic -march value combined with -mtune ( which btw. was default in past)
or if we want to let compiler use ISA for a particular arch implementation ( cortexXXX ) then we should just use -mcpu and drop using -mtune and -march.Quoted 4 lines
Quoted 1 line
I would include towards option 1.
I know this is a bit of a 'me too' response, but we have to pick one format and stay with it. Either option, but not both.
I concur.
Quoted 4 lines
-IF- we know that the appropriate -mcpu options are available for all of the potential combinations out there, then this is by far the preferred method in my mind. Much easier to handle and manage...
-mcpu options are available for known CPU implementations. But there always will
be weird ones, given how people can pick and choose subsystems for SOC on this
architecture, and its highly probable that they wont be in gcc. so real question we need to answer for is, should we design for those cases and how often does this often.Quoted 6 lines
However, the more complex route came out as various 'odd-ball' (and people claim don't exist, but they do) custom ARM cores get released without 'mandatory' math units, or some other odd ball variation. (I've seen this numerous times over the last 20 years that something that doesn't exist, does... all because it's a custom part.)
Yes, I am dealing with one such design even today
Quoted 6 lines
If we have an easy way to define the -mcpu= means some magic combination of -march/-mtune within the GCC spec itself, then I'm 100% for moving to -mcpu to rid ourselves of this mess.. and then we still have the flexibility to easily update/add tunes and GCC configuration for the odd-balls that seem to crop up regularly.
So yes we can do nearly same but not exactly same. We have to start adding or deleting
features via -march and -mtune would be same value, but there are cases where gcc defines
internal properties based on mcpu, that is not representable in those suffixes we will add. so
we will come very close but not exact and I think compiler is right in this case because we
are not exactly telling it about a CPU implementation, but we are telling the cpu has these properties, so it really may not be one of standard cpu implementation.Quoted 6 lines
(I know -I- can always patch GCC for new -mcpu combinations, but I'm not thinking about 'me', I'm thinking about the user of OE who is told 'use this CPU, it has this set of functions' and is NOT a compiler expert who can wade through GCC spec files and generate patches with any confidence.)
I would think we can solve this for these niche cases, via using -march/-mtune and drop -mcpu, we can append adding/deleting a given feature e.g. neon or vfp or vfpv3 etc. but this would mean we have to rename our package feed names as well to match this new representation, which currently is mapped to mcpu values. This is quite a departure from package feeds point of view. but its more aligned with how we have defined arch and tunes. so pick the battles.
Quoted 119 lines
--Mark
Quoted 117 lines
Quoted 117 lines
Quoted 117 lines
Quoted 14 lines
Quoted 14 lines
and is preferred since gcc is getting stricter and stricter with option check semantics and can now find incompatible -march and -mcpu options better with every release. It does internal feature consistency check and if it finds out discrepency between what -mcpu would expand to as compared to -march it will flag the options to be incompatible, for naked eye it sounds wrong but gcc would translate -mcpu to a given -march internally and it might not match to what we set in these arch files.
The effects are quite subtle, where this can result in configure test failing to compile due to these incompatible options and a feature option getting disabled for a recipe for no reason.
Quoted 7 lines
Quoted 5 lines
e.g. with gcc9 which can now detect that -mcpu=cortex-a5 and -march=armv7-a are incompatible, many features in libstdc++ ends up disabled due to configure check failures e.g.
size_tsize,ptrdiff_tsizes, which inturn results in compiling libstdc++ with unwanted disabled features.It would be interesting to see more specific details of this.
These are configure tests which fail when -Werror is in use and is not limited to libstdc++
it can happen in any package. Since the diagnostic about incompatible march mcpu pair
is a warning in general, it does not matter, but when we have -Werror enabled this turns
into error, You can simply try a small helloworld example to see the effects.Quoted 87 lines
Quoted 87 lines
Signed-off-by Khem Raj <[email protected]>--- meta/conf/machine/include/arm/arch-armv4.inc | 1 - meta/conf/machine/include/arm/arch-armv5.inc | 1 - meta/conf/machine/include/arm/arch-armv6.inc | 1 - meta/conf/machine/include/arm/arch-armv7a.inc | 1 - meta/conf/machine/include/arm/arch-armv7ve.inc | 1 - meta/conf/machine/include/tune-iwmmxt.inc | 2 +- 6 files changed, 1 insertion(+), 6 deletions(-)meta/conf/machine/include/arm/arch-armv4.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv4" TUNEVALID[arm] = "Enable ARM instruction set" TUNEVALID[armv4] = "Enable instructions for ARMv4" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv4', ' -march=armv4t', '', d)}" # enable --fix-v4bx when we have armv4 in TUNE_FEATURES, but then disable it when we have also armv5 or thumb # maybe we should extend bb.utils.contains to support check for any checkvalues in value, now it does # checkvalues.issubset(val) which cannot be used for negative test of foo neither bar in valuemeta/conf/machine/include/arm/arch-armv5.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv5" TUNEVALID[armv5] = "Enable instructions for ARMv5" TUNECONFLICTS[armv5] = "armv4" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv5', ' -march=armv5t${ARMPKGSFX_DSP}', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv5', 'armv5:', '' ,d)}" require conf/machine/include/arm/arch-armv4.incmeta/conf/machine/include/arm/arch-armv6.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv6hf" TUNEVALID[armv6] = "Enable instructions for ARMv6" TUNECONFLICTS[armv6] = "armv4 armv5" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv6', ' -march=armv6', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv6', 'armv6:', '' ,d)}" require conf/machine/include/arm/arch-armv5-dsp.incmeta/conf/machine/include/arm/arch-armv7a.inc +0
-1@@ -3,7 +3,6 @@ ARM_INSTRUCTION_SET ?= "thumb" TUNEVALID[armv7a] = "Enable instructions for ARMv7-a" TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv7a', ' -march=armv7-a', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv7a', 'armv7a:', '' ,d)}" require conf/machine/include/arm/arch-armv6.incmeta/conf/machine/include/arm/arch-armv7ve.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv7vethf" TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve" TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv7ve', ' -march=armv7ve', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv7ve', 'armv7ve:', '' ,d)}" require conf/machine/include/arm/arch-armv7a.incmeta/conf/machine/include/tune-iwmmxt.inc +1
-2@@ -6,7 +6,7 @@ DEFAULTTUNE ?= "iwmmxt" require conf/machine/include/arm/arch-armv5-dsp.inc TUNEVALID[iwmmxt] = "Enable Intel PXA27x specific processor optimizations" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'iwmmxt', ' -march=iwmmxt -mcpu=iwmmxt', '', d)}" +TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'iwmmxt', ' -mcpu=iwmmxt', '', d)}" AVAILTUNES += "iwmmxt" ARMPKGARCH_tune-iwmmxt = "iwmmxt" --2.20.1
Quoted 6 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 1 line
2. Just use -mcpu and do not use -march/-mtune and may be
provide mechanism to override -mcpu, which is done by packages anyway ( maps directly to package architectures )
This would be my preferred solution, I know that tune files are already quite complicated, but another variable which will hold either just march (for more generic DEFAULTTUNEs as Andre reported) or mcpu (for DEFAULTTUNEs targeting specific cpu) or possibly mtune as well (if someone really wants and overrides this variable in his DISTRO) doesn't make it much more complicated and should work fine for everybody.
Quoted 453 lines · Khem Raj
Quoted 2 lines · Martin Jansa
Which -mcpu/-march combination is causing issue in gcc9?
Its when using cortex-a5 tunes, -march=armv7-a -mcpu=cortex-a5, but if we move the needle to fix the issue or test coverage then we miss the point here, the fact that this keeps coming up means we have a fundamental problem.
Quoted 2 lines
I know we had this issue with armv7a tunes before, that's why I've added
separate armv7ve before the switch from -mtune to -mcpu.
Quoted 1 line
Thats fine, however as I have explained before -mcpu is a combination of implicit -march and -mtune, so for best results should not be mixed with them. Originally the tune design in OE is one to one if we used -march + -mtune
method. That does not mean that -mcpu approach is inferior on the contrary might be better in certain cases and in fact in majority of cases we have.Quoted 2 lines
I still believe -mcpu (with or without -march) is better option.
I think on one hand it is, but there is another part which Mark brought up of customized CPU implementations with not to common choices of subsystems, which may not be exactly represented by -mcpu options. I am inclined to
provide provisions to make it happen but I am not in favor of designing it to address these corner implementations. I would rather make it easy for 99% usecases.Quoted 1 line
Using -mtune without indicating which -mtune was actually used in the
package arch is bad (especially if you have multiple MACHINEs with different DEFAULTTUNEs e.g. cortexa7, cortexa8 in -mtune, but both ending in armv7a package arch, unpacking all packages from sstate every time you switch MACHINE and the package manager on target never knowing which -mtune was used to build given package upgrade from feed).
Quoted 1 line
Yes this was a change for better.
Quoted 1 line
Switching from -mcpu to -mtune while keeping the current cpu-specific
package architectures is better, but then the use case, that I build everything e.g. with cortexa8 in -mtune and install this cortexa8 package feed on cortexa7 MACHINEs also looks strange, yes it will work in runtime, but why not use generic armv7a DEFAULTTUNE to make it clear (to package manager as well as end user) that I'm not really optimizing for given CPU).
Quoted 1 line
In current design I think we have design for using more optimized for a CPU and be able to generate feeds which are cpu specific which is great for certain use cases and hopefully more tunes to that CPU implementation.
Quoted 1 line
From the naive openssl benchmarks I did few years back, there was very
small difference between mtune/mcpu/just-march, but still for projects where I have separate package feeds for each device (e.g. LG TVs) I prefer to use -mcpu (because I really know that such packages won't ever be used on device with different CPU) and e.g. in LuneOS we're more concerned about package feed size and build time, so we select more generic DEFAULTTUNE which is shared across many MACHINEs and that doesn't have any -mcpu (nor -mtune) options in it, so should be fine as well.
Exactly, the point here, we will be best served if we make it one way or other, e.g. raspbian used thumb1 ISA across all rpi implementations and they can use same feeds across all RPis that have even existed. It has advantages of
its own to be able to do that, especially for people who work on higher stacks they would be happy with such a setup.So I have to suggest on of three approached
1. Change -mcpu to -mtune and keep everything same. This make feed arches point to tuned packages but fundamentally same for base architecture ( e.g. armv7-a),
2. Just use -mcpu and do not use -march/-mtune and may be provide mechanism to override -mcpu, which is done by packages anyway ( maps directly to package architectures )
3. Just use -march and drop -mcpu and -mtune - Rename feed arches to map to arch+features conventions instead of being CPU specific, this will freak the users since it will be overwhelming to understand the combinations
e.g. armv7ve+neon+vfpv4 etc. so the combination becomes
equivalent to -mcpu, current tune architecture we can construct this easily by appending to march based onTUNE_FEATURESbut I think
package arches will be a massive to deal with and users
might ask what is this long -march/-mtune pointing to in terms of CPU, but it will address Mark's usecase and will bring us closer to using mcpu usecase, We can probaly do a bettter error reporting
as well for conflicting tune features.I can cook up patches for option 3 from tunes part, packaging part I am not sure maybe we can live with what we have
option 2 I already have posted a patch, option 1 would be a simplest patch of all which can be done quickly as well.Quoted 2 lines
We can easily extend the tune-test script I've used back then when
switching to -mcpu to not only use bitbake -e, but also call gcc-cross to check for possible warnings from incompatible march/mcpu combinations and fix those. The old version is here:
Quoted 1 line
http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/tune-test
Quoted 2 lines
it was used in mcpu switch here:
http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/tune2-test
Quoted 4 lines
http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/tune3
From the gcc git log I don't see many changes in:
https://github.com/gcc-mirror/gcc/commits/master/gcc/config/arm/driver-arm.c
Quoted 2 lines
nor
https://github.com/gcc-mirror/gcc/commits/master/gcc/config/arm/arm-cpus.in
Quoted 8 lines
so I'm really interested which combination issues the warning now.
Regards,
Quoted 3 lines · Khem Raj
On Fri, Jan 25, 2019 at 12:32 PM Mark Hatle <[email protected]>
Quoted 3 lines · wrote:
Quoted 3 lines
Quoted 3 lines · Khem Raj
Quoted 1 line
On Wed, Jan 23, 2019 at 6:11 PM Andre McCurdy <[email protected]>
Quoted 2 lines · wrote:
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
On Wed, Jan 23, 2019 at 2:50 PM Khem Raj <[email protected]>
Quoted 2 lines · wrote:
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
On Wed, Jan 23, 2019 at 5:27 PM Andre McCurdy <
Quoted 2 lines · [email protected]> wrote:
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
On Wed, Jan 23, 2019 at 12:05 PM Khem Raj <[email protected]>
Quoted 2 lines · wrote:
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
tune files which inherit the arch definitions already define
appropriate
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
-mcpu option, which is equivalent of right -march and -mtune
combination
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
And what about machines which inherit an arch definition instead
of a
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line
cpu definition? Is that no longer supported?
I could not find such a machine configuration in several BSP
layers I looked at.
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
Do you know of machine definitions where these files are included directly in machine configs ?
Using a CPU specific include but then leaving the generic
DEFAULTTUNE
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 2 lines
(ie not enabling any CPU specific
TUNE_CCARGS) is equivalent, and I guess quite common.defaulttune does not play much part in appending -mcpu option to compiler flags, A case
where this could bypass the setting mcpu is when we do not include a tune-* for arm based machine
and thats the case I was interested to know.Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
again if there is such a BSP I would be interested to test it out.
Quoted 2 lines
Quoted 2 lines
if so, then we have to either use
_removeor introduce a weakvariable
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
to set march only if
mcpu is not set whichI think the solution is to ensure that the CPU specific tuning
options
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
are always compatible with any architecture specific options which
may
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
be active.
In general our CPU specific tuning files are a little sloppy (e.g. defaulting to combinations of VFP versions and architecture levels which never exist in the real world). If newer versions of gcc are making those issues more apparent then why not take the
opportunity to
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line
fix them properly?
the mcpu option is helping with right march/mtune combination.
while we can
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
use specific -march=arch(+-)features syntax and combine with right -mtune to match -mcpu I think we should use
compiler defaults and not try to recreate something that -mcpu would do it easily for us.So either we drop the idea of setting mcpu and use basic -march
value
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 6 lines
combined with -mtune ( which btw. was default in past) or if we want to let compiler use ISA for a particular arch implementation ( cortexXXX ) then we should just use -mcpu and drop using -mtune and -march.
I would include towards option 1.
I know this is a bit of a 'me too' response, but we have to pick one
format and
Quoted 7 lines
Quoted 7 lines
Quoted 1 line
stay with it. Either option, but not both.
I concur.
Quoted 2 lines
-IF- we know that the appropriate -mcpu options are available for all
of the
Quoted 1 line
Quoted 1 line
Quoted 1 line
potential combinations out there, then this is by far the preferred
method in my
Quoted 3 lines
Quoted 3 lines
Quoted 1 line
mind. Much easier to handle and manage...
-mcpu options are available for known CPU implementations. But there
always will
Quoted 1 line
Quoted 1 line
be weird ones, given how people can pick and choose subsystems for SOC
on this
Quoted 1 line
Quoted 1 line
architecture, and its highly probable that they wont be in gcc. so real
question we need to answer for is, should we design for those cases and how often does this often.
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
However, the more complex route came out as various 'odd-ball' (and
people claim
Quoted 1 line
Quoted 1 line
Quoted 1 line
don't exist, but they do) custom ARM cores get released without
'mandatory' math
Quoted 1 line
Quoted 1 line
Quoted 1 line
units, or some other odd ball variation. (I've seen this numerous
times over
Quoted 1 line
Quoted 1 line
Quoted 1 line
the last 20 years that something that doesn't exist, does... all
because it's a
Quoted 7 lines
Quoted 7 lines
Quoted 1 line
custom part.)
Yes, I am dealing with one such design even today
Quoted 2 lines
If we have an easy way to define the -mcpu= means some magic
combination of
Quoted 1 line
Quoted 1 line
Quoted 1 line
-march/-mtune within the GCC spec itself, then I'm 100% for moving to
-mcpu to
Quoted 1 line
Quoted 1 line
Quoted 1 line
rid ourselves of this mess.. and then we still have the flexibility
to easily
Quoted 1 line
Quoted 1 line
Quoted 1 line
update/add tunes and GCC configuration for the odd-balls that seem to
crop up
Quoted 3 lines
Quoted 3 lines
Quoted 1 line
regularly.
So yes we can do nearly same but not exactly same. We have to start
adding or deleting
Quoted 1 line
Quoted 1 line
features via -march and -mtune would be same value, but there are cases
where gcc defines
Quoted 1 line
Quoted 1 line
internal properties based on mcpu, that is not representable in those
suffixes we will add. so
Quoted 1 line
Quoted 1 line
we will come very close but not exact and I think compiler is right in
this case because we
Quoted 1 line
Quoted 1 line
are not exactly telling it about a CPU implementation, but we are
telling the cpu has these properties, so it really may not be one of standard cpu implementation.
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
(I know -I- can always patch GCC for new -mcpu combinations, but I'm
not
Quoted 1 line
Quoted 1 line
Quoted 1 line
thinking about 'me', I'm thinking about the user of OE who is told
'use this
Quoted 1 line
Quoted 1 line
Quoted 1 line
CPU, it has this set of functions' and is NOT a compiler expert who
can wade
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
through GCC spec files and generate patches with any confidence.)
I would think we can solve this for these niche cases, via using
-march/-mtune and drop
Quoted 1 line
Quoted 1 line
-mcpu, we can append adding/deleting a given feature e.g. neon or vfp
or vfpv3 etc.
Quoted 1 line
Quoted 1 line
but this would mean we have to rename our package feed names as well to
match this
Quoted 1 line
Quoted 1 line
new representation, which currently is mapped to mcpu values. This is
quite a departure
Quoted 1 line
Quoted 1 line
from package feeds point of view. but its more aligned with how we have
defined arch and tunes.
Quoted 7 lines
Quoted 7 lines
so pick the battles.
Quoted 4 lines
--Mark
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
and is preferred since gcc is getting stricter and stricter
with option
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
check semantics and can now find incompatible -march and -mcpu
options
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
better with every release. It does internal feature consistency
check
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
and if it finds out discrepency between what -mcpu would expand
to as
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
compared to -march it will flag the options to be incompatible,
for
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
naked eye it sounds wrong but gcc would translate -mcpu to a
given
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
-march internally and it might not match to what we set in
these arch
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
files.
The effects are quite subtle, where this can result in
configure test
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
failing to compile due to these incompatible options and a
feature
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
option getting disabled for a recipe for no reason.
e.g. with gcc9 which can now detect that -mcpu=cortex-a5 and -march=armv7-a are incompatible, many features in libstdc++
ends up
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
disabled due to configure check failures e.g.
size_tsize,
ptrdiff_tQuoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
sizes, which inturn results in compiling libstdc++ with unwanted disabled features.
It would be interesting to see more specific details of this.
These are configure tests which fail when -Werror is in use and
is not
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
limited to libstdc++
it can happen in any package. Since the diagnostic aboutincompatible
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
march mcpu pair
is a warning in general, it does not matter, but when we have-Werror
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
enabled this turns
into error, You can simply try a small helloworld example to seethe effects.
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Signed-off-by Khem Raj <[email protected]>--- meta/conf/machine/include/arm/arch-armv4.inc | 1 - meta/conf/machine/include/arm/arch-armv5.inc | 1 - meta/conf/machine/include/arm/arch-armv6.inc | 1 - meta/conf/machine/include/arm/arch-armv7a.inc | 1 - meta/conf/machine/include/arm/arch-armv7ve.inc | 1 - meta/conf/machine/include/tune-iwmmxt.inc | 2 +- 6 files changed, 1 insertion(+), 6 deletions(-)Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Review
Quoted 1 line
(quoted diff) +0
-0b/meta/conf/machine/include/arm/arch-armv4.inc
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
meta/conf/machine/include/arm/arch-armv4.inc DEFAULTTUNE ?= "armv4" · line 5
Quoted 8 lines
index
47a7ad2830..52d8ab1e8f100644meta/conf/machine/include/arm/arch-armv4.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv4" TUNEVALID[arm] = "Enable ARM instruction set" TUNEVALID[armv4] = "Enable instructions for ARMv4" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv4',' -march=armv4t', '', d)}"
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/arm/arch-armv4.inc DEFAULTTUNE ?= "armv4" · line 5
Quoted 1 line
meta/conf/machine/include/arm/arch-armv4.inc +0
-0# enable --fix-v4bx when we have armv4 in TUNE_FEATURES, butthen disable it when we have also armv5 or thumb
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/arm/arch-armv4.inc DEFAULTTUNE ?= "armv4" · line 6
Quoted 1 line
meta/conf/machine/include/arm/arch-armv4.inc +0
-0# maybe we should extend bb.utils.contains to support checkfor any checkvalues in value, now it does
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/arm/arch-armv4.inc DEFAULTTUNE ?= "armv4" · line 7
Quoted 1 line
meta/conf/machine/include/arm/arch-armv4.inc +0
-0# checkvalues.issubset(val) which cannot be used for negativetest of foo neither bar in value
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Review
Quoted 1 line
(quoted diff) +0
-0b/meta/conf/machine/include/arm/arch-armv5.inc
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
meta/conf/machine/include/arm/arch-armv5.inc DEFAULTTUNE ?= "armv5" · line 5
Quoted 8 lines
index
f9068af9de..1fe1b6b8e4100644meta/conf/machine/include/arm/arch-armv5.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv5" TUNEVALID[armv5] = "Enable instructions for ARMv5" TUNECONFLICTS[armv5] = "armv4" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv5',' -march=armv5t${ARMPKGSFX_DSP}', '', d)}"
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/arm/arch-armv5.inc DEFAULTTUNE ?= "armv5" · line 5
Quoted 1 line
meta/conf/machine/include/arm/arch-armv5.inc +0
-0MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES','armv5', 'armv5:', '' ,d)}"
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Review
Quoted 3 lines
meta/conf/machine/include/arm/arch-armv5.inc +0
-0require conf/machine/include/arm/arch-armv4.inc(quoted diff) +0
-0b/meta/conf/machine/include/arm/arch-armv6.inc
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
meta/conf/machine/include/arm/arch-armv6.inc DEFAULTTUNE ?= "armv6hf" · line 5
Quoted 8 lines
index
6c838e999c..adb9be8050100644meta/conf/machine/include/arm/arch-armv6.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv6hf" TUNEVALID[armv6] = "Enable instructions for ARMv6" TUNECONFLICTS[armv6] = "armv4 armv5" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv6',' -march=armv6', '', d)}"
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/arm/arch-armv6.inc DEFAULTTUNE ?= "armv6hf" · line 5
Quoted 1 line
meta/conf/machine/include/arm/arch-armv6.inc +0
-0MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES','armv6', 'armv6:', '' ,d)}"
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Review
Quoted 3 lines
meta/conf/machine/include/arm/arch-armv6.inc +0
-0require conf/machine/include/arm/arch-armv5-dsp.inc(quoted diff) +0
-0b/meta/conf/machine/include/arm/arch-armv7a.inc
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
meta/conf/machine/include/arm/arch-armv7a.inc ARM_INSTRUCTION_SET ?= "thumb" · line 6
Quoted 8 lines
index
a2663d8008..09d2c03a5d100644meta/conf/machine/include/arm/arch-armv7a.inc +0
-1@@ -3,7 +3,6 @@ ARM_INSTRUCTION_SET ?= "thumb" TUNEVALID[armv7a] = "Enable instructions for ARMv7-a" TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES','armv7a', ' -march=armv7-a', '', d)}"
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/arm/arch-armv7a.inc ARM_INSTRUCTION_SET ?= "thumb" · line 6
Quoted 1 line
meta/conf/machine/include/arm/arch-armv7a.inc +0
-0MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES','armv7a', 'armv7a:', '' ,d)}"
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Review
Quoted 3 lines
meta/conf/machine/include/arm/arch-armv7a.inc +0
-0require conf/machine/include/arm/arch-armv6.inc(quoted diff) +0
-0b/meta/conf/machine/include/arm/arch-armv7ve.inc
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
meta/conf/machine/include/arm/arch-armv7ve.inc DEFAULTTUNE ?= "armv7vethf" · line 5
Quoted 8 lines
index
4d9260fecb..31e334f645100644meta/conf/machine/include/arm/arch-armv7ve.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv7vethf" TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve" TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES','armv7ve', ' -march=armv7ve', '', d)}"
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/arm/arch-armv7ve.inc DEFAULTTUNE ?= "armv7vethf" · line 5
Quoted 1 line
meta/conf/machine/include/arm/arch-armv7ve.inc +0
-0MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES','armv7ve', 'armv7ve:', '' ,d)}"
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Review
Quoted 3 lines
meta/conf/machine/include/arm/arch-armv7ve.inc +0
-0require conf/machine/include/arm/arch-armv7a.inc(quoted diff) +0
-0b/meta/conf/machine/include/tune-iwmmxt.inc
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
meta/conf/machine/include/tune-iwmmxt.inc DEFAULTTUNE ?= "iwmmxt" · line 8
Quoted 7 lines
index
f27423cb2e..6e577697cc100644meta/conf/machine/include/tune-iwmmxt.inc +0
-0@@ -6,7 +6,7 @@ DEFAULTTUNE ?= "iwmmxt" require conf/machine/include/arm/arch-armv5-dsp.inc TUNEVALID[iwmmxt] = "Enable Intel PXA27x specific processoroptimizations"
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/tune-iwmmxt.inc DEFAULTTUNE ?= "iwmmxt" · line 9
Quoted 1 line
meta/conf/machine/include/tune-iwmmxt.inc +0
-1-TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES','iwmmxt', ' -march=iwmmxt -mcpu=iwmmxt', '', d)}"
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/conf/machine/include/tune-iwmmxt.inc DEFAULTTUNE ?= "iwmmxt" · line 9
Quoted 1 line
meta/conf/machine/include/tune-iwmmxt.inc +1
-0+TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES','iwmmxt', ' -mcpu=iwmmxt', '', d)}"
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
meta/conf/machine/include/tune-iwmmxt.inc +0
-1AVAILTUNES += "iwmmxt" ARMPKGARCH_tune-iwmmxt = "iwmmxt" --2.20.1
--
_______________________________________________
Openembedded-core mailing list
[email protected]http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 6 lines
Quoted 6 lines
Quoted 1 line
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 4 lines · Martin Jansa
Quoted 2 lines
2. Just use -mcpu and do not use -march/-mtune and may be provide mechanism to override -mcpu, which is done by packages anyway ( maps directly to package architectures )
This would be my preferred solution, I know that tune files are already quite complicated, but another variable which will hold either just march (for more generic DEFAULTTUNEs as Andre reported) or mcpu (for DEFAULTTUNEs targeting specific cpu) or possibly mtune as well (if someone really wants and overrides this variable in his DISTRO) doesn't make it much more complicated and should work fine for everybody.
is it something that does this fine ?
https://patchwork.openembedded.org/patch/158189/
Quoted 349 lines · Khem Raj
Quoted 345 lines · Martin Jansa
Quoted 2 lines
Which -mcpu/-march combination is causing issue in gcc9?
Its when using cortex-a5 tunes, -march=armv7-a -mcpu=cortex-a5, but if we move the needle to fix the issue or test coverage then we miss the point here, the fact that this keeps coming up means we have a fundamental problem.
Quoted 3 lines
I know we had this issue with armv7a tunes before, that's why I've added separate armv7ve before the switch from -mtune to -mcpu.
Thats fine, however as I have explained before -mcpu is a combination of implicit -march and -mtune, so for best results should not be mixed with them. Originally the tune design in OE is one to one if we used -march + -mtune
method. That does not mean that -mcpu approach is inferior on the contrary might be better in certain cases and in fact in majority of cases we have.Quoted 2 lines
I still believe -mcpu (with or without -march) is better option.
I think on one hand it is, but there is another part which Mark brought up of customized CPU implementations with not to common choices of subsystems, which may not be exactly represented by -mcpu options. I am inclined to
provide provisions to make it happen but I am not in favor of designing it to address these corner implementations. I would rather make it easy for 99% usecases.Quoted 2 lines
Using -mtune without indicating which -mtune was actually used in the package arch is bad (especially if you have multiple MACHINEs with different DEFAULTTUNEs e.g. cortexa7, cortexa8 in -mtune, but both ending in armv7a package arch, unpacking all packages from sstate every time you switch MACHINE and the package manager on target never knowing which -mtune was used to build given package upgrade from feed).
Yes this was a change for better.
Quoted 2 lines
Switching from -mcpu to -mtune while keeping the current cpu-specific package architectures is better, but then the use case, that I build everything e.g. with cortexa8 in -mtune and install this cortexa8 package feed on cortexa7 MACHINEs also looks strange, yes it will work in runtime, but why not use generic armv7a DEFAULTTUNE to make it clear (to package manager as well as end user) that I'm not really optimizing for given CPU).
In current design I think we have design for using more optimized for a CPU and be able to generate feeds which are cpu specific which is great for certain use cases and hopefully more tunes to that CPU implementation.
Quoted 1 line
From the naive openssl benchmarks I did few years back, there was very small difference between mtune/mcpu/just-march, but still for projects where I have separate package feeds for each device (e.g. LG TVs) I prefer to use -mcpu (because I really know that such packages won't ever be used on device with different CPU) and e.g. in LuneOS we're more concerned about package feed size and build time, so we select more generic DEFAULTTUNE which is shared across many MACHINEs and that doesn't have any -mcpu (nor -mtune) options in it, so should be fine as well.
Exactly, the point here, we will be best served if we make it one way or other, e.g. raspbian used thumb1 ISA across all rpi implementations and they can use same feeds across all RPis that have even existed. It has advantages of
its own to be able to do that, especially for people who work on higher stacks they would be happy with such a setup.So I have to suggest on of three approached
1. Change -mcpu to -mtune and keep everything same. This make feed arches point to tuned packages but fundamentally same for base architecture ( e.g. armv7-a),
2. Just use -mcpu and do not use -march/-mtune and may be provide mechanism to override -mcpu, which is done by packages anyway ( maps directly to package architectures )
3. Just use -march and drop -mcpu and -mtune - Rename feed arches to map to arch+features conventions instead of being CPU specific, this will freak the users since it will be overwhelming to understand the combinations
e.g. armv7ve+neon+vfpv4 etc. so the combination becomes
equivalent to -mcpu, current tune architecture we can construct this easily by appending to march based onTUNE_FEATURESbut I think
package arches will be a massive to deal with and users
might ask what is this long -march/-mtune pointing to in terms of CPU, but it will address Mark's usecase and will bring us closer to using mcpu usecase, We can probaly do a bettter error reporting
as well for conflicting tune features.I can cook up patches for option 3 from tunes part, packaging part I am not sure maybe we can live with what we have
option 2 I already have posted a patch, option 1 would be a simplest patch of all which can be done quickly as well.Quoted 264 lines
We can easily extend the tune-test script I've used back then when switching to -mcpu to not only use bitbake -e, but also call gcc-cross to check for possible warnings from incompatible march/mcpu combinations and fix those. The old version is here:
http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/tune-test
it was used in mcpu switch here:
http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/tune2-test
http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/tune3From the gcc git log I don't see many changes in:
https://github.com/gcc-mirror/gcc/commits/master/gcc/config/arm/driver-arm.c
nor
https://github.com/gcc-mirror/gcc/commits/master/gcc/config/arm/arm-cpus.in
so I'm really interested which combination issues the warning now.Regards,
Quoted 248 lines · Khem Raj
Quoted 58 lines · Mark Hatle
Quoted 56 lines · Khem Raj
Quoted 13 lines · Andre McCurdy
Quoted 11 lines · Khem Raj
Quoted 8 lines · Andre McCurdy
Quoted 3 lines · Khem Raj
tune files which inherit the arch definitions already define appropriate -mcpu option, which is equivalent of right -march and -mtune combination
And what about machines which inherit an arch definition instead of a cpu definition? Is that no longer supported?
Quoted 7 lines
Quoted 3 lines
I could not find such a machine configuration in several BSP layers I looked at. Do you know of machine definitions where these files are included directly in machine configs ?
Using a CPU specific include but then leaving the generic DEFAULTTUNE (ie not enabling any CPU specific
TUNE_CCARGS) is equivalent, and I guess quite common.defaulttune does not play much part in appending -mcpu option to compiler flags, A case
where this could bypass the setting mcpu is when we do not include a tune-* for arm based machine
and thats the case I was interested to know.again if there is such a BSP I would be interested to test it out.
Quoted 9 lines
Quoted 4 lines
if so, then we have to either use
_removeor introduce a weak variable to set march only if
mcpu is not set whichI think the solution is to ensure that the CPU specific tuning options are always compatible with any architecture specific options which may be active.
Quoted 5 lines
In general our CPU specific tuning files are a little sloppy (e.g. defaulting to combinations of VFP versions and architecture levels which never exist in the real world). If newer versions of gcc are making those issues more apparent then why not take the opportunity to fix them properly?
the mcpu option is helping with right march/mtune combination. while we can use specific -march=arch(+-)features syntax and combine with right -mtune to match -mcpu I think we should use
compiler defaults and not try to recreate something that -mcpu would do it easily for us.So either we drop the idea of setting mcpu and use basic -march value combined with -mtune ( which btw. was default in past)
or if we want to let compiler use ISA for a particular arch implementation ( cortexXXX ) then we should just use -mcpu and drop using -mtune and -march.Quoted 4 lines
Quoted 1 line
I would include towards option 1.
I know this is a bit of a 'me too' response, but we have to pick one format and stay with it. Either option, but not both.
I concur.
Quoted 4 lines
-IF- we know that the appropriate -mcpu options are available for all of the potential combinations out there, then this is by far the preferred method in my mind. Much easier to handle and manage...
-mcpu options are available for known CPU implementations. But there always will
be weird ones, given how people can pick and choose subsystems for SOC on this
architecture, and its highly probable that they wont be in gcc. so real question we need to answer for is, should we design for those cases and how often does this often.Quoted 6 lines
However, the more complex route came out as various 'odd-ball' (and people claim don't exist, but they do) custom ARM cores get released without 'mandatory' math units, or some other odd ball variation. (I've seen this numerous times over the last 20 years that something that doesn't exist, does... all because it's a custom part.)
Yes, I am dealing with one such design even today
Quoted 6 lines
If we have an easy way to define the -mcpu= means some magic combination of -march/-mtune within the GCC spec itself, then I'm 100% for moving to -mcpu to rid ourselves of this mess.. and then we still have the flexibility to easily update/add tunes and GCC configuration for the odd-balls that seem to crop up regularly.
So yes we can do nearly same but not exactly same. We have to start adding or deleting
features via -march and -mtune would be same value, but there are cases where gcc defines
internal properties based on mcpu, that is not representable in those suffixes we will add. so
we will come very close but not exact and I think compiler is right in this case because we
are not exactly telling it about a CPU implementation, but we are telling the cpu has these properties, so it really may not be one of standard cpu implementation.Quoted 6 lines
(I know -I- can always patch GCC for new -mcpu combinations, but I'm not thinking about 'me', I'm thinking about the user of OE who is told 'use this CPU, it has this set of functions' and is NOT a compiler expert who can wade through GCC spec files and generate patches with any confidence.)
I would think we can solve this for these niche cases, via using -march/-mtune and drop -mcpu, we can append adding/deleting a given feature e.g. neon or vfp or vfpv3 etc. but this would mean we have to rename our package feed names as well to match this new representation, which currently is mapped to mcpu values. This is quite a departure from package feeds point of view. but its more aligned with how we have defined arch and tunes. so pick the battles.
Quoted 119 lines
--Mark
Quoted 117 lines
Quoted 117 lines
Quoted 117 lines
Quoted 14 lines
Quoted 14 lines
and is preferred since gcc is getting stricter and stricter with option check semantics and can now find incompatible -march and -mcpu options better with every release. It does internal feature consistency check and if it finds out discrepency between what -mcpu would expand to as compared to -march it will flag the options to be incompatible, for naked eye it sounds wrong but gcc would translate -mcpu to a given -march internally and it might not match to what we set in these arch files.
The effects are quite subtle, where this can result in configure test failing to compile due to these incompatible options and a feature option getting disabled for a recipe for no reason.
Quoted 7 lines
Quoted 5 lines
e.g. with gcc9 which can now detect that -mcpu=cortex-a5 and -march=armv7-a are incompatible, many features in libstdc++ ends up disabled due to configure check failures e.g.
size_tsize,ptrdiff_tsizes, which inturn results in compiling libstdc++ with unwanted disabled features.It would be interesting to see more specific details of this.
These are configure tests which fail when -Werror is in use and is not limited to libstdc++
it can happen in any package. Since the diagnostic about incompatible march mcpu pair
is a warning in general, it does not matter, but when we have -Werror enabled this turns
into error, You can simply try a small helloworld example to see the effects.Quoted 87 lines
Quoted 87 lines
Signed-off-by Khem Raj <[email protected]>--- meta/conf/machine/include/arm/arch-armv4.inc | 1 - meta/conf/machine/include/arm/arch-armv5.inc | 1 - meta/conf/machine/include/arm/arch-armv6.inc | 1 - meta/conf/machine/include/arm/arch-armv7a.inc | 1 - meta/conf/machine/include/arm/arch-armv7ve.inc | 1 - meta/conf/machine/include/tune-iwmmxt.inc | 2 +- 6 files changed, 1 insertion(+), 6 deletions(-)meta/conf/machine/include/arm/arch-armv4.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv4" TUNEVALID[arm] = "Enable ARM instruction set" TUNEVALID[armv4] = "Enable instructions for ARMv4" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv4', ' -march=armv4t', '', d)}" # enable --fix-v4bx when we have armv4 in TUNE_FEATURES, but then disable it when we have also armv5 or thumb # maybe we should extend bb.utils.contains to support check for any checkvalues in value, now it does # checkvalues.issubset(val) which cannot be used for negative test of foo neither bar in valuemeta/conf/machine/include/arm/arch-armv5.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv5" TUNEVALID[armv5] = "Enable instructions for ARMv5" TUNECONFLICTS[armv5] = "armv4" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv5', ' -march=armv5t${ARMPKGSFX_DSP}', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv5', 'armv5:', '' ,d)}" require conf/machine/include/arm/arch-armv4.incmeta/conf/machine/include/arm/arch-armv6.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv6hf" TUNEVALID[armv6] = "Enable instructions for ARMv6" TUNECONFLICTS[armv6] = "armv4 armv5" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv6', ' -march=armv6', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv6', 'armv6:', '' ,d)}" require conf/machine/include/arm/arch-armv5-dsp.incmeta/conf/machine/include/arm/arch-armv7a.inc +0
-1@@ -3,7 +3,6 @@ ARM_INSTRUCTION_SET ?= "thumb" TUNEVALID[armv7a] = "Enable instructions for ARMv7-a" TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv7a', ' -march=armv7-a', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv7a', 'armv7a:', '' ,d)}" require conf/machine/include/arm/arch-armv6.incmeta/conf/machine/include/arm/arch-armv7ve.inc +0
-1@@ -2,7 +2,6 @@ DEFAULTTUNE ?= "armv7vethf" TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve" TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'armv7ve', ' -march=armv7ve', '', d)}" MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv7ve', 'armv7ve:', '' ,d)}" require conf/machine/include/arm/arch-armv7a.incmeta/conf/machine/include/tune-iwmmxt.inc +1
-2@@ -6,7 +6,7 @@ DEFAULTTUNE ?= "iwmmxt" require conf/machine/include/arm/arch-armv5-dsp.inc TUNEVALID[iwmmxt] = "Enable Intel PXA27x specific processor optimizations" -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'iwmmxt', ' -march=iwmmxt -mcpu=iwmmxt', '', d)}" +TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'iwmmxt', ' -mcpu=iwmmxt', '', d)}" AVAILTUNES += "iwmmxt" ARMPKGARCH_tune-iwmmxt = "iwmmxt" --2.20.1
Quoted 6 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 59 lines · Khem Raj
Quoted 20 lines · Andre McCurdy
Quoted 9 lines · Khem Raj
Quoted 7 lines · Andre McCurdy
Quoted 4 lines · Khem Raj
tune files which inherit the arch definitions already define appropriate
-mcpu option, which is equivalent of right -march and -mtune combinationQuoted 8 lines
Quoted 3 lines
And what about machines which inherit an arch definition instead of a
cpu definition? Is that no longer supported?I could not find such a machine configuration in several BSP layers I looked at.
Do you know of machine definitions where these files are included directly in machine configs ?Quoted 4 lines
Using a CPU specific include but then leaving the generic DEFAULTTUNE
(ie not enabling any CPU specificTUNE_CCARGS) is equivalent, and I guess quite common.defaulttune does not play much part in appending -mcpu option to compiler flags, A case
where this could bypass the setting mcpu is when we do not include a tune-* for arm based machine
and thats the case I was interested to know.again if there is such a BSP I would be interested to test it out.
Quoted 11 lines
Quoted 4 lines
if so, then we have to either use
_removeor introduce a weak variable
to set march only if
mcpu is not set whichI think the solution is to ensure that the CPU specific tuning options
are always compatible with any architecture specific options which may
be active.Quoted 6 lines
In general our CPU specific tuning files are a little sloppy (e.g. defaulting to combinations of VFP versions and architecture levels which never exist in the real world). If newer versions of gcc are making those issues more apparent then why not take the opportunity to
fix them properly?the mcpu option is helping with right march/mtune combination. while we can
use specific -march=arch(+-)features syntax and combine with right -mtune to match -mcpu I think we should use
compiler defaults and not try to recreate something that -mcpu would do it easily for us.
Quoted 7 lines
So either we drop the idea of setting mcpu and use basic -march value combined with -mtune ( which btw. was default in past)
or if we want to let compiler use ISA for a particular arch implementation ( cortexXXX ) then we should just use -mcpu and drop using -mtune and -march.I would include towards option 1.
I think the friction is partly because we support "generic" tunes as well as cpu specific ones. Having a system which allows all of these to be switched between is hard.
I do agree we need to have a system which does one or the other and is clearer than the current setup though.
The v2 patch isn't right as it will only work for one end result case and won't dynamically adjust as the current code is designed to do. We can fix that and make such a patch work, we just need to decide what we're aiming for first and document it.
I'd also love to understand which of the tunes are actually used and which ones we could prune out...
Cheers,
Richard