Skip to contentSkip to conversation

input-linux: customizable grab toggle keys v5

PATCH In review Ryan El Kochta 2 participants 3 messages Jan 23, 2019 – Jan 24, 2019

lore
Share & tools
lore
#0 lore raw

cover input-linux: customizable grab toggle keys v5

This patch adds a new option to the input-linux object:

grab-toggle=[key-combo]

The key combination can be one of the following:

* ctrl-ctrl
* alt-alt
* meta-meta
* scrolllock
* ctrl-scrolllock

The user can pick any of these key combinations. The VM's grab of the evdev device will be toggled when the key combination is pressed.

Any invalid setting will result in an error. No setting will result in the current default of ctrl-ctrl.

The right and left ctrl key both work for Ctrl-Scrolllock.

If scrolllock is selected as one of the grab-toggle keys, it will be entirely disabled and not passed to the guest at all. This is to prevent enabling it while attempting to leave or enter the VM. On the host, scrolllock can be disabled using xmodmap.

First, find the modifier that Scroll_Lock is bound to:

$ xmodmap -pm

Then, remove Scroll_Lock from it, replacing modX with the modifier:

$ xmodmap -e 'remove modX = Scroll_Lock'

If Scroll_Lock is not bound to any modifier, it is already disabled.

To save the changes, add them to your xinitrc.

Ryan El Kochta (1):
input-linux: customizable grab toggle keys v5

 qapi/ui.json     | 10 ++++++++
 ui/input-linux.c | 66 +++++++++++++++++++++++++++++++++++++++++++++---
 2 files changed, 73 insertions(+), 3 deletions(-)
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 input-linux: customizable grab toggle keys v5

The latest revision of the input-linux customizable grab toggle keys patch.

---
 qapi/ui.json     | 10 ++++++++
 ui/input-linux.c | 66 +++++++++++++++++++++++++++++++++++++++++++++---
 2 files changed, 73 insertions(+), 3 deletions(-)
qapi/ui.json +10 -0
index 5ad1324..7d9c4bd 100644
@@ -1016,6 +1016,16 @@
             '*head'  : 'int',
             'events' : [ 'InputEvent' ] } }
 
+##
+# @GrabToggleKeys:
+#
+# Keys to toggle input-linux between host and guest.
+#
+# Since: 4.0
+#
+##
+{ 'enum': 'GrabToggleKeys',
+  'data': [ 'ctrl-ctrl', 'alt-alt', 'meta-meta', 'scrolllock', 'ctrl-scrolllock' ] }
 
 ##
 # @DisplayGTK:
ui/input-linux.c +63 -3

107 lines not on this page · raw message

Signature · 1 line
2.20.1
#2 lore raw
In reply to Ryan El Kochta
Quoted 3 lines · Ryan El Kochta

This patch adds a new option to the input-linux object:

grab-toggle=[key-combo]

Other way around: commit message describing the patch goes to the patch (1/1), the series description (and changes to previous revisions if any) go to the cover letter (0/1).

Picked up the patch, copied over the description from the cover letter.

thanks,
Gerd