staging: ks7010: remove unnecessary parentheses
PATCH 1/1 staging: ks7010: remove unnecessary parentheses
Remove unnecessary parentheses reported by checkpatch.
--- drivers/staging/ks7010/ks_hostif.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/ks7010/ks_hostif.c +3 -3
@@ -35,7 +35,7 @@ static inline u8 get_byte(struct ks_wlan_private *priv) {u8 data; - data = *(priv->rxp)++; + data = *priv->rxp++;/* length check in advance ! */ --(priv->rx_size);return data;
@@ -171,7 +171,7 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info)"- rate_set_size=%d\n" , ap->bssid[0 ], ap->bssid[1 ], ap->bssid[2 ], ap->bssid[3 ], ap->bssid[4 ], ap->bssid[5 ], - &(ap->ssid.body[0 ]), + &ap->ssid.body[0 ], ap->rate_set.body[0 ], ap->rate_set.body[1 ], ap->rate_set.body[2 ], ap->rate_set.body[3 ], ap->rate_set.body[4], ap->rate_set.body[5],
@@ -732,7 +732,7 @@ void hostif_scan_indication(struct ks_wlan_private *priv)netdev_dbg (priv->net_dev," scan_ind_count=%d :: aplist.size=%d\n" , priv->scan_ind_count, priv->aplist.size);get_ap_information (priv, (struct ap_info *)(priv->rxp), - &(priv->aplist.ap[priv->scan_ind_count -1 ])); + &priv->aplist.ap[priv->scan_ind_count -1 ]); priv->aplist.size = priv->scan_ind_count; }else { netdev_dbg(priv->net_dev, " count over :: scan_ind_count=%d\n",
Signature · 1 line
2.7.4
Quoted 1 line · Matt McCoy
Remove unnecessary parentheses reported by checkpatch.
[]
drivers/staging/ks7010/ks_hostif.c
Quoted 1 line
drivers/staging/ks7010/ks_hostif.c +0
-0
[]
drivers/staging/ks7010/ks_hostif.c int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info) · line 177
Quoted 9 lines
drivers/staging/ks7010/ks_hostif.c +1
-1@@ -171,7 +171,7 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info)"- rate_set_size=%d\n" , ap->bssid[0 ], ap->bssid[1 ], ap->bssid[2 ], ap->bssid[3 ], ap->bssid[4 ], ap->bssid[5 ], - &(ap->ssid.body[0 ]), + &ap->ssid.body[0 ], ap->rate_set.body[0 ], ap->rate_set.body[1 ], ap->rate_set.body[2 ], ap->rate_set.body[3 ], ap->rate_set.body[4], ap->rate_set.body[5],
This bit:
[]
netdev_dbg(priv->net_dev, "Link AP\n" "- bssid=%02X:%02X:%02X:%02X:%02X:%02X\n" [] ap->bssid[0], ap->bssid[1], ap->bssid[2],
should instead use the vsprintf %pM extension
"- bssid: %pM\n" [] ap->bssid,
Quoted 23 lines · Joe Perches
Quoted 1 line · Matt McCoy
Remove unnecessary parentheses reported by checkpatch.
[]
drivers/staging/ks7010/ks_hostif.c
Quoted 1 line
drivers/staging/ks7010/ks_hostif.c +0
-0[]
drivers/staging/ks7010/ks_hostif.c int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info) · line 177
Quoted 9 lines
drivers/staging/ks7010/ks_hostif.c +1
-1@@ -171,7 +171,7 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info)"- rate_set_size=%d\n" , ap->bssid[0 ], ap->bssid[1 ], ap->bssid[2 ], ap->bssid[3 ], ap->bssid[4 ], ap->bssid[5 ], - &(ap->ssid.body[0 ]), + &ap->ssid.body[0 ], ap->rate_set.body[0 ], ap->rate_set.body[1 ], ap->rate_set.body[2 ], ap->rate_set.body[3 ], ap->rate_set.body[4], ap->rate_set.body[5],This bit:
[]
netdev_dbg(priv->net_dev, "Link AP\n" "- bssid=%02X:%02X:%02X:%02X:%02X:%02X\n" [] ap->bssid[0], ap->bssid[1], ap->bssid[2],
Quoted 7 lines
should instead use the vsprintf %pM extension
"- bssid: %pM\n" [] ap->bssid,
Should I just make a v2 of this patch with 2 parts ? One being this change and the other using the %pM extension.