regulator: bd70528: Constify regulator_linear_range and regulator_ops
Subsystems (3)
PATCH 1/3 regulator: bd70528: Constify regulator_linear_range and regulator_ops
Signed-off-by Axel Lin <[email protected]>
--- drivers/regulator/bd70528-regulator.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-)
drivers/regulator/bd70528-regulator.c +8 -9
@@ -21,22 +21,22 @@#define BUCK_RAMPRATE_125MV 1#define BUCK_RAMP_MAX 250 -static struct regulator_linear_range bd70528_buck1_volts[] = { +static const struct regulator_linear_range bd70528_buck1_volts[] = {REGULATOR_LINEAR_RANGE (1200000 ,0x00 ,0x1 ,600000 ),REGULATOR_LINEAR_RANGE (2750000 ,0x2 ,0xf ,50000 ), }; -static struct regulator_linear_range bd70528_buck2_volts[] = { +static const struct regulator_linear_range bd70528_buck2_volts[] = {REGULATOR_LINEAR_RANGE (1200000 ,0x00 ,0x1 ,300000 ),REGULATOR_LINEAR_RANGE (1550000 ,0x2 ,0xd ,50000 ),REGULATOR_LINEAR_RANGE (3000000 ,0xe ,0xf ,300000 ), }; -static struct regulator_linear_range bd70528_buck3_volts[] = { +static const struct regulator_linear_range bd70528_buck3_volts[] = {REGULATOR_LINEAR_RANGE (800000 ,0x00 ,0xd ,50000 ),REGULATOR_LINEAR_RANGE (1800000 ,0xe ,0xf ,0 ), };/* All LDOs have same voltage ranges */ -static struct regulator_linear_range bd70528_ldo_volts[] = { +static const struct regulator_linear_range bd70528_ldo_volts[] = {REGULATOR_LINEAR_RANGE (1650000 ,0x0 ,0x07 ,50000 ),REGULATOR_LINEAR_RANGE (2100000 ,0x8 ,0x0f ,100000 ),REGULATOR_LINEAR_RANGE (2850000 ,0x10 ,0x19 ,50000 ),
@@ -83,7 +83,7 @@ static int bd70528_led_set_voltage_sel(struct regulator_dev *rdev,return -EBUSY ; } -static struct regulator_ops bd70528_buck_ops = { +static const struct regulator_ops bd70528_buck_ops = { .enable = regulator_enable_regmap, .disable = regulator_disable_regmap, .is_enabled = regulator_is_enabled_regmap,
@@ -94,7 +94,7 @@ static struct regulator_ops bd70528_buck_ops = { .set_ramp_delay = bd70528_set_ramp_delay, }; -static struct regulator_ops bd70528_ldo_ops = { +static const struct regulator_ops bd70528_ldo_ops = { .enable = regulator_enable_regmap, .disable = regulator_disable_regmap, .is_enabled = regulator_is_enabled_regmap,
@@ -105,7 +105,7 @@ static struct regulator_ops bd70528_ldo_ops = { .set_ramp_delay = bd70528_set_ramp_delay, }; -static struct regulator_ops bd70528_led_ops = { +static const struct regulator_ops bd70528_led_ops = { .enable = regulator_enable_regmap, .disable = regulator_disable_regmap, .is_enabled = regulator_is_enabled_regmap,
@@ -114,8 +114,7 @@ static struct regulator_ops bd70528_led_ops = { .get_voltage_sel = regulator_get_voltage_sel_regmap, }; - -static struct regulator_desc bd70528_desc[] = { +static const struct regulator_desc bd70528_desc[] = { { .name ="buck1" , .of_match =of_match_ptr ("BUCK1" ),
Signature · 1 line
2.17.1
PATCH 2/3 regulator: bd718x7: Constify regulator_ops
Signed-off-by Axel Lin <[email protected]>
--- drivers/regulator/bd718x7-regulator.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/regulator/bd718x7-regulator.c +7 -7
@@ -79,7 +79,7 @@ static int bd718xx_set_voltage_sel_pickable_restricted(return regulator_set_voltage_sel_pickable_regmap (rdev, sel); } -static struct regulator_ops bd718xx_pickable_range_ldo_ops = { +static const struct regulator_ops bd718xx_pickable_range_ldo_ops = { .enable = regulator_enable_regmap, .disable = regulator_disable_regmap, .is_enabled = regulator_is_enabled_regmap,
@@ -88,7 +88,7 @@ static struct regulator_ops bd718xx_pickable_range_ldo_ops = { .get_voltage_sel = regulator_get_voltage_sel_pickable_regmap, }; -static struct regulator_ops bd718xx_pickable_range_buck_ops = { +static const struct regulator_ops bd718xx_pickable_range_buck_ops = { .enable = regulator_enable_regmap, .disable = regulator_disable_regmap, .is_enabled = regulator_is_enabled_regmap,
@@ -98,7 +98,7 @@ static struct regulator_ops bd718xx_pickable_range_buck_ops = { .set_voltage_time_sel = regulator_set_voltage_time_sel, }; -static struct regulator_ops bd718xx_ldo_regulator_ops = { +static const struct regulator_ops bd718xx_ldo_regulator_ops = { .enable = regulator_enable_regmap, .disable = regulator_disable_regmap, .is_enabled = regulator_is_enabled_regmap,
@@ -107,7 +107,7 @@ static struct regulator_ops bd718xx_ldo_regulator_ops = { .get_voltage_sel = regulator_get_voltage_sel_regmap, }; -static struct regulator_ops bd718xx_ldo_regulator_nolinear_ops = { +static const struct regulator_ops bd718xx_ldo_regulator_nolinear_ops = { .enable = regulator_enable_regmap, .disable = regulator_disable_regmap, .is_enabled = regulator_is_enabled_regmap,
@@ -116,7 +116,7 @@ static struct regulator_ops bd718xx_ldo_regulator_nolinear_ops = { .get_voltage_sel = regulator_get_voltage_sel_regmap, }; -static struct regulator_ops bd718xx_buck_regulator_ops = { +static const struct regulator_ops bd718xx_buck_regulator_ops = { .enable = regulator_enable_regmap, .disable = regulator_disable_regmap, .is_enabled = regulator_is_enabled_regmap,
@@ -126,7 +126,7 @@ static struct regulator_ops bd718xx_buck_regulator_ops = { .set_voltage_time_sel = regulator_set_voltage_time_sel, }; -static struct regulator_ops bd718xx_buck_regulator_nolinear_ops = { +static const struct regulator_ops bd718xx_buck_regulator_nolinear_ops = { .enable = regulator_enable_regmap, .disable = regulator_disable_regmap, .is_enabled = regulator_is_enabled_regmap,
@@ -137,7 +137,7 @@ static struct regulator_ops bd718xx_buck_regulator_nolinear_ops = { .set_voltage_time_sel = regulator_set_voltage_time_sel, }; -static struct regulator_ops bd718xx_dvs_buck_regulator_ops = { +static const struct regulator_ops bd718xx_dvs_buck_regulator_ops = { .enable = regulator_enable_regmap, .disable = regulator_disable_regmap, .is_enabled = regulator_is_enabled_regmap,
Signature · 1 line
2.17.1
PATCH 3/3 regulator: bd9571mwv: Constify regulator_ops
In reply to Axel LinSigned-off-by Axel Lin <[email protected]>
--- drivers/regulator/bd9571mwv-regulator.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/regulator/bd9571mwv-regulator.c +4 -4
@@ -100,7 +100,7 @@ static int bd9571mwv_reg_set_voltage_sel_regmap(struct regulator_dev *rdev, }/* Operations permitted on AVS voltage regulator */ -static struct regulator_ops avs_ops = { +static const struct regulator_ops avs_ops = { .set_voltage_sel = bd9571mwv_avs_set_voltage_sel_regmap, .map_voltage = regulator_map_voltage_linear, .get_voltage_sel = bd9571mwv_avs_get_voltage_sel_regmap,
@@ -108,7 +108,7 @@ static struct regulator_ops avs_ops = { };/* Operations permitted on voltage regulators */ -static struct regulator_ops reg_ops = { +static const struct regulator_ops reg_ops = { .set_voltage_sel = bd9571mwv_reg_set_voltage_sel_regmap, .map_voltage = regulator_map_voltage_linear, .get_voltage_sel = regulator_get_voltage_sel_regmap,
@@ -116,13 +116,13 @@ static struct regulator_ops reg_ops = { };/* Operations permitted on voltage monitors */ -static struct regulator_ops vid_ops = { +static const struct regulator_ops vid_ops = { .map_voltage = regulator_map_voltage_linear, .get_voltage_sel = regulator_get_voltage_sel_regmap, .list_voltage = regulator_list_voltage_linear, }; -static struct regulator_desc regulators[] = { +static const struct regulator_desc regulators[] = {BD9571MWV_REG ("VD09" ,"vd09" ,VD09 , avs_ops,0 ,0x7f ,0x80 ,600000 ,10000 ,0x3c ), BD9571MWV_REG("VD18", "vd18", VD18, vid_ops, BD9571MWV_VD18_VID, 0xf,
Signature · 1 line
2.17.1
Thanks Axel,
Quoted 4 lines · Axel Lin
Signed-off-by Axel Lin <[email protected]>--- drivers/regulator/bd70528-regulator.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-)
This looks good to me =)
Signature · 4 lines
Matti Vaittinen ROHM Semiconductors ~~~ "I don't think so," said Rene Descartes. Just then, he vanished ~~~