Skip to contentSkip to conversation

PCI: dra7xx: Invoke phy_set_mode API to set PHY mode to PHY_MODE_PCIE

PATCH Applied Kishon Vijay Abraham I 2 participants 2 messages Jan 24, 2019 – Jan 31, 2019

Subsystems (3)
PCI PCI native host bridge and endpoint drivers PCI driver for TI DRA7XX/J721E
lore
Share & tools
lore

Kishon Vijay Abraham I

author
#0 lore raw

PATCH 1/1 PCI: dra7xx: Invoke phy_set_mode API to set PHY mode to PHY_MODE_PCIE

Certain PHYs used with PCIe controller can also be used with other controllers such as USB or SATA. In order to configure the PHY to work with PCIe controller, invoke phy_set_mode API with mode set to PHY_MODE_PCIE.

Signed-off-by Kishon Vijay Abraham I <[email protected]>
---
 drivers/pci/controller/dwc/pci-dra7xx.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/pci/controller/dwc/pci-dra7xx.c +4 -0
index efb26096ccb5..b287dbf6914c 100644
@@ -517,6 +517,10 @@ static int dra7xx_pcie_enable_phy(struct dra7xx_pcie *dra7xx)
 	int i;
 
 	for (i = 0; i < phy_count; i++) {
+		ret = phy_set_mode(dra7xx->phy[i], PHY_MODE_PCIE);
+		if (ret < 0)
+			goto err_phy;
+
 		ret = phy_init(dra7xx->phy[i]);
 		if (ret < 0)
 			goto err_phy;
Signature · 1 line
2.17.1
Applied
#1 lore raw
Quoted 9 lines · Kishon Vijay Abraham I

Certain PHYs used with PCIe controller can also be used with other controllers such as USB or SATA. In order to configure the PHY to work with PCIe controller, invoke phy_set_mode API with mode set to PHY_MODE_PCIE.

Signed-off-by Kishon Vijay Abraham I <[email protected]>
---
 drivers/pci/controller/dwc/pci-dra7xx.c | 4 ++++
 1 file changed, 4 insertions(+)

Applied to pci/dwc for v5.1, thanks.

Lorenzo

Quoted 18 lines
drivers/pci/controller/dwc/pci-dra7xx.c +4 -0
index efb26096ccb5..b287dbf6914c 100644
@@ -517,6 +517,10 @@ static int dra7xx_pcie_enable_phy(struct dra7xx_pcie *dra7xx)
 	int i;
 
 	for (i = 0; i < phy_count; i++) {
+		ret = phy_set_mode(dra7xx->phy[i], PHY_MODE_PCIE);
+		if (ret < 0)
+			goto err_phy;
+
 		ret = phy_init(dra7xx->phy[i]);
 		if (ret < 0)
 			goto err_phy;
Signature · 1 line
2.17.1