lightnvm: Use u64 instead of __le64 for CPU visible side
PATCH 1/1 lightnvm: Use u64 instead of __le64 for CPU visible side
Sparse complains about using strict data types:
drivers/lightnvm/pblk-read.c:254:43: warning: incorrect type in assignment (different base types)drivers/lightnvm/pblk-read.c:254:43: expected restricted __le64 <noident>drivers/lightnvm/pblk-read.c:254:43: got unsigned long long [unsigned] [usertype] <noident>drivers/lightnvm/pblk-read.c:255:29: warning: cast from restricted __le64 drivers/lightnvm/pblk-read.c:268:29: warning: cast from restricted __le64 drivers/lightnvm/pblk-read.c:328:41: warning: incorrect type in assignment (different base types)drivers/lightnvm/pblk-read.c:328:41: expected restricted __le64 <noident>drivers/lightnvm/pblk-read.c:328:41: got unsigned long long [unsigned] [usertype] <noident>
In the code it seems explicit that lba_list_mem and lba_list_media members of struct pblk_pr_ctx are used on CPU side, which means they should not be of strict types.
Change types of lba_list_mem and lba_list_media members to be u64.
--- drivers/lightnvm/pblk.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/lightnvm/pblk.h +2 -2
@@ -131,8 +131,8 @@ struct pblk_pr_ctx {unsigned int bio_init_idx;void *ppa_ptr;dma_addr_t dma_ppa_list; -__le64 lba_list_mem[NVM_MAX_VLBA ]; -__le64 lba_list_media[NVM_MAX_VLBA ]; +u64 lba_list_mem[NVM_MAX_VLBA ]; +u64 lba_list_media[NVM_MAX_VLBA ]; };/* Pad context */
Signature · 1 line
2.20.1
Quoted 40 lines · Andy Shevchenko
Sparse complains about using strict data types:
drivers/lightnvm/pblk-read.c:254:43: warning: incorrect type in assignment (different base types)drivers/lightnvm/pblk-read.c:254:43: expected restricted__le64<noident>drivers/lightnvm/pblk-read.c:254:43: got unsigned long long [unsigned] [usertype] <noident>drivers/lightnvm/pblk-read.c:255:29: warning: cast from restricted__le64drivers/lightnvm/pblk-read.c:268:29: warning: cast from restricted__le64drivers/lightnvm/pblk-read.c:328:41: warning: incorrect type in assignment (different base types)drivers/lightnvm/pblk-read.c:328:41: expected restricted__le64<noident>drivers/lightnvm/pblk-read.c:328:41: got unsigned long long [unsigned] [usertype] <noident>In the code it seems explicit that
lba_list_memandlba_list_mediamembers of structpblk_pr_ctxare used on CPU side, which means they should not be of strict types.Change types of
lba_list_memandlba_list_mediamembers to be u64.Signed-off-by Andy Shevchenko <[email protected]>---
drivers/lightnvm/pblk.h| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)drivers/lightnvm/pblk.h +2
-3@@ -131,8 +131,8 @@ struct pblk_pr_ctx {unsigned int bio_init_idx;void *ppa_ptr;dma_addr_t dma_ppa_list; -__le64 lba_list_mem[NVM_MAX_VLBA ]; -__le64 lba_list_media[NVM_MAX_VLBA ]; +u64 lba_list_mem[NVM_MAX_VLBA ]; +u64 lba_list_media[NVM_MAX_VLBA ]; };/* Pad context */ --
Quoted 1 line
2.20.1
Looks good to me. At some point these mapped directly to the metadata stored in the device and the type remained when we change it.
Quoted 28 lines · Andy Shevchenko
Sparse complains about using strict data types:
drivers/lightnvm/pblk-read.c:254:43: warning: incorrect type in assignment (different base types)drivers/lightnvm/pblk-read.c:254:43: expected restricted__le64<noident>drivers/lightnvm/pblk-read.c:254:43: got unsigned long long [unsigned] [usertype] <noident>drivers/lightnvm/pblk-read.c:255:29: warning: cast from restricted__le64drivers/lightnvm/pblk-read.c:268:29: warning: cast from restricted__le64drivers/lightnvm/pblk-read.c:328:41: warning: incorrect type in assignment (different base types)drivers/lightnvm/pblk-read.c:328:41: expected restricted__le64<noident>drivers/lightnvm/pblk-read.c:328:41: got unsigned long long [unsigned] [usertype] <noident>In the code it seems explicit that
lba_list_memandlba_list_mediamembers of structpblk_pr_ctxare used on CPU side, which means they should not be of strict types.Change types of
lba_list_memandlba_list_mediamembers to be u64.Signed-off-by Andy Shevchenko <[email protected]>--- drivers/lightnvm/pblk.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/lightnvm/pblk.h +0
-0
drivers/lightnvm/pblk.h struct pblk_pr_ctx { · line 138
Quoted 10 lines
drivers/lightnvm/pblk.h +2
-2@@ -131,8 +131,8 @@ struct pblk_pr_ctx {unsigned int bio_init_idx;void *ppa_ptr;dma_addr_t dma_ppa_list; -__le64 lba_list_mem[NVM_MAX_VLBA ]; -__le64 lba_list_media[NVM_MAX_VLBA ]; +u64 lba_list_mem[NVM_MAX_VLBA ]; +u64 lba_list_media[NVM_MAX_VLBA ]; };/* Pad context */
Thanks Andy. I've applied it for 5.1.