dt-bindings: panel: Add Feiyang FY07024DI26A30-D MIPI-DSI LCD panel
Subsystems (5)
Jagan Teki
maintainerPATCH v4 1/2 dt-bindings: panel: Add Feiyang FY07024DI26A30-D MIPI-DSI LCD panel
Feiyang FY07024DI26A30-D is 1024x600, 4-lane MIPI-DSI LCD panel.
Add dt-bingings for it.
---
Changes for v4, v3:
- none
Changes for v2:
- new patch, derived from another dsi series
.../display/panel/feiyang,fy07024di26a30d.txt | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt
Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt new file +20 -0
@@ -0,0 +1,20 @@ +Feiyang FY07024DI26A30-D 7" MIPI-DSI LCD Panel + +Required properties: +- compatible: must be "feiyang,fy07024di26a30d" +- reg: DSI virtual channel used by that screen +- avdd-supply: analog regulator dc1 switch +- dvdd-supply: 3v3 digital regulator +- reset-gpios: a GPIO phandle for the reset pin + +Optional properties: +- backlight: phandle for the backlight control. + +panel@0 { + compatible = "feiyang,fy07024di26a30d"; + reg = <0>; + avdd-supply = <®_dc1sw>; + dvdd-supply = <®_dldo2>; + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD24 */ + backlight = <&backlight>; +};
Signature · 1 line
2.18.0.321.gffc6fa0e3
Jagan Teki
maintainerPATCH v4 2/2 drm/panel: Add Feiyang FY07024DI26A30-D MIPI-DSI LCD panel
Feiyang FY07024DI26A30-D is 1024x600, 4-lane MIPI-DSI LCD panel.
Add panel driver for it.
---
Changes for v5:
- rebase on master
- adjust the hporch values to satisfy the refresh Changes for v4:
- use simple structure for command init
- update proper comments on power, reset delay sequnce
- fix to use set_display_off in disable function
- move mode type to structure
- drop refres rate value, let drm compute Changes for v2:
- new patch, derived from another dsi series
MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + .../drm/panel/panel-feiyang-fy07024di26a30d.c | 286 ++++++++++++++++++ 4 files changed, 302 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c
MAINTAINERS +6 -0
@@ -4831,6 +4831,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc S: Maintained F: drivers/gpu/drm/tve200/ +DRM DRIVER FOR FEIYANG FY07024DI26A30-D MIPI-DSI LCD PANELS +M: Jagan Teki <[email protected]> +S: Maintained +F: drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c +F: Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt + DRM DRIVER FOR ILITEK ILI9225 PANELS M: David Lechner <[email protected]> S: Maintained
drivers/gpu/drm/panel/Kconfig +9 -0
@@ -47,6 +47,15 @@ config DRM_PANEL_SIMPLE that it can be automatically turned off when the panel goes into a low power state. +config DRM_PANEL_FEIYANG_FY07024DI26A30D + tristate "Feiyang FY07024DI26A30-D MIPI-DSI LCD panel" + depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE + help + Say Y if you want to enable support for panels based on the + Feiyang FY07024DI26A30-D MIPI-DSI interface. + config DRM_PANEL_ILITEK_IL9322 tristate "Ilitek ILI9322 320x240 QVGA panels" depends on OF && SPI
drivers/gpu/drm/panel/Makefile +1 -0
@@ -3,6 +3,7 @@ obj-$(CONFIG_DRM_PANEL_ARM_VERSATILE) += panel-arm-versatile.o obj-$(CONFIG_DRM_PANEL_BANANAPI_S070WV20_ICN6211) += panel-bananapi-s070wv20-icn6211.o obj-$(CONFIG_DRM_PANEL_LVDS) += panel-lvds.o obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o +obj-$(CONFIG_DRM_PANEL_FEIYANG_FY07024DI26A30D) += panel-feiyang-fy07024di26a30d.o obj-$(CONFIG_DRM_PANEL_ILITEK_IL9322) += panel-ilitek-ili9322.o obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9881C) += panel-ilitek-ili9881c.o obj-$(CONFIG_DRM_PANEL_INNOLUX_P079ZCA) += panel-innolux-p079zca.o
drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c new file +286 -0
286 lines not on this page · raw message
Signature · 6 lines
2.18.0.321.gffc6fa0e3 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v4 2/2] drm/panel: Add Feiyang FY07024DI26A30-D MIPI-DSI LCD panel
Hi Jagan.
Thanks for this nice patch, a few comments below.
Quoted 85 lines · Jagan Teki
Feiyang FY07024DI26A30-D is 1024x600, 4-lane MIPI-DSI LCD panel.
Add panel driver for it.
Signed-off-by Jagan Teki <[email protected]>---
Changes for v5:
- rebase on master
- adjust the hporch values to satisfy the refresh Changes for v4:
- use simple structure for command init
- update proper comments on power, reset delay sequnce
- fix to useset_display_offin disable function
- move mode type to structure
- drop refres rate value, let drm compute Changes for v2:
- new patch, derived from another dsi seriesMAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + .../drm/panel/panel-feiyang-fy07024di26a30d.c | 286 ++++++++++++++++++ 4 files changed, 302 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.cMAINTAINERS +6
-0@@ -4831,6 +4831,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc S: Maintained F: drivers/gpu/drm/tve200/ +DRM DRIVER FOR FEIYANG FY07024DI26A30-D MIPI-DSI LCD PANELS +M: Jagan Teki <[email protected]> +S: Maintained +F: drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c +F: Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt + DRM DRIVER FOR ILITEK ILI9225 PANELS M: David Lechner <[email protected]> S: Maintaineddrivers/gpu/drm/panel/Kconfig +9
-0@@ -47,6 +47,15 @@ config DRM_PANEL_SIMPLE that it can be automatically turned off when the panel goes into a low power state. +config DRM_PANEL_FEIYANG_FY07024DI26A30D + tristate "Feiyang FY07024DI26A30-D MIPI-DSI LCD panel" + depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE + help + Say Y if you want to enable support for panels based on the + Feiyang FY07024DI26A30-D MIPI-DSI interface. + config DRM_PANEL_ILITEK_IL9322 tristate "Ilitek ILI9322 320x240 QVGA panels" depends on OF && SPIdrivers/gpu/drm/panel/Makefile +1
-0@@ -3,6 +3,7 @@ obj-$(CONFIG_DRM_PANEL_ARM_VERSATILE) += panel-arm-versatile.o obj-$(CONFIG_DRM_PANEL_BANANAPI_S070WV20_ICN6211) += panel-bananapi-s070wv20-icn6211.o obj-$(CONFIG_DRM_PANEL_LVDS) += panel-lvds.o obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o +obj-$(CONFIG_DRM_PANEL_FEIYANG_FY07024DI26A30D) += panel-feiyang-fy07024di26a30d.o obj-$(CONFIG_DRM_PANEL_ILITEK_IL9322) += panel-ilitek-ili9322.o obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9881C) += panel-ilitek-ili9881c.o obj-$(CONFIG_DRM_PANEL_INNOLUX_P079ZCA) += panel-innolux-p079zca.odrivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c new file +5
-0@@ -0,0 +1,286 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* Copyright (C) 2018 Amarula Solutions +* Author: Jagan Teki <[email protected]> +*/
drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c line 15
Quoted 10 lines
drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c new file +10
-0+ +#include <linux/backlight.h> +#include <linux/delay.h> +#include <linux/module.h> +#include <linux/of_device.h> + +#include <linux/gpio/consumer.h> +#include <linux/regulator/consumer.h> + +#include <drm/drmP.h>
Please do not use drmP.h in new drivers.
We are slowly gettting rid of it and in drm-misc.git the drmP.h file no longer contains anything (other than includes/forwards).
drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c line 80
Quoted 10 lines
drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c new file +10
-0+gpiod_set_value (ctx->reset,1 ); +msleep (50 ); + +gpiod_set_value (ctx->reset,0 ); +/* T5 + T6 (avdd rise + video & logic signal rise) +* T5 >= 10ms, 0 < T6 <= 10ms +*/ +msleep (20 ); + +gpiod_set_value (ctx->reset,1 );
Is it really necessary to do a 1 => 0 => 1 cycle here for reset? panel-simple do not need it.
drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c line 203
Quoted 10 lines
drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c new file +10
-0+ +static int feiyang_dsi_probe (struct mipi_dsi_device *dsi) +{ +struct feiyang *ctx; +int ret; + + ctx =devm_kzalloc (&dsi->dev,sizeof (*ctx),GFP_KERNEL ); +if (!ctx) +return -ENOMEM ; +mipi_dsi_set_drvdata (dsi, ctx);
Add empty line atfer return -ENOMEM;?
Quoted 37 lines
drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c new file +37
-0+ ctx->dsi = dsi; + +drm_panel_init (&ctx->panel); + ctx->panel.dev = &dsi->dev; + ctx->panel.funcs = &feiyang_funcs; + + ctx->dvdd =devm_regulator_get (&dsi->dev,"dvdd" ); +if (IS_ERR (ctx->dvdd)) { +DRM_DEV_ERROR (&dsi->dev,"Couldn't get dvdd regulator\n" ); +return PTR_ERR (ctx->dvdd); + } + + ctx->avdd =devm_regulator_get (&dsi->dev,"avdd" ); +if (IS_ERR (ctx->avdd)) { +DRM_DEV_ERROR (&dsi->dev,"Couldn't get avdd regulator\n" ); +return PTR_ERR (ctx->avdd); + } + + ctx->reset =devm_gpiod_get (&dsi->dev,"reset" ,GPIOD_OUT_LOW ); +if (IS_ERR (ctx->reset)) { +DRM_DEV_ERROR (&dsi->dev,"Couldn't get our reset GPIO\n" ); +return PTR_ERR (ctx->reset); + } + + ctx->backlight =devm_of_find_backlight (&dsi->dev); +if (IS_ERR (ctx->backlight)) +return PTR_ERR (ctx->backlight); + + ret =drm_panel_add (&ctx->panel); +if (ret <0 ) + goto put_backlight; + + dsi->mode_flags =MIPI_DSI_MODE_VIDEO_BURST ; + dsi->format =MIPI_DSI_FMT_RGB888 ; + dsi->lanes =4 ; + + ret =mipi_dsi_attach (dsi);
drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c line 250
Quoted 10 lines
drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c new file +10
-0+if (ret <0 ) + goto panel_remove; + +return ret; + +panel_remove: +drm_panel_remove (&ctx->panel); +put_backlight: +if (ctx->backlight) +put_device (&ctx->backlight->dev);
As devm_of_find_backlight() is used the put_device() will be done for you. No need to do it here.
I think the same is true for the panel.
drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c line 263
Quoted 13 lines
drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c new file +13
-0+ +return ret; +} + +static int feiyang_dsi_remove (struct mipi_dsi_device *dsi) +{ +struct feiyang *ctx =mipi_dsi_get_drvdata (dsi); + +mipi_dsi_detach (dsi); +drm_panel_remove (&ctx->panel); + +if (ctx->backlight) +put_device (&ctx->backlight->dev);
Likewise, use of devm_of_find_backlight() will do this for you.
Sam
Re: [v4,2/2] drm/panel: Add Feiyang FY07024DI26A30-D MIPI-DSI LCD panel
In reply to Jagan TekiQuoted 5 lines · Jagan Teki
Feiyang FY07024DI26A30-D is 1024x600, 4-lane MIPI-DSI LCD panel.
Add panel driver for it.
Signed-off-by Jagan Teki <[email protected]>
Signature · 4 lines
Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D