Skip to contentSkip to conversation

dt-bindings: ahci-fsl-qoriq: add lx2160a chip name to the list

PATCH Superseded Peng Ma 4 participants 10 messages Jan 25, 2019 – Feb 20, 2019

Subsystems (3)

v5 of 7 Superseded Latest is v7 →

lore
Share & tools
lore

Peng Ma

author
#0 lore raw

PATCH v5 1/2 dt-bindings: ahci-fsl-qoriq: add lx2160a chip name to the list

Add lx2160a compatible to bindings documentation.

---
changed for V5:
- change the lxx2160a to lx2160a

 .../devicetree/bindings/ata/ahci-fsl-qoriq.txt     |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt +1 -1
index 7c3ca0e..9ecc019 100644
@@ -3,7 +3,7 @@ Binding for Freescale QorIQ AHCI SATA Controller
 Required properties:
   - reg: Physical base address and size of the controller's register area.
   - compatible: Compatibility string. Must be 'fsl,<chip>-ahci', where
-    chip could be ls1021a, ls1043a, ls1046a, ls1088a, ls2080a etc.
+    chip could be ls1021a, ls1043a, ls1046a, ls1088a, ls2080a, lx2160a, etc.
   - clocks: Input clock specifier. Refer to common clock bindings.
   - interrupts: Interrupt specifier. Refer to interrupt binding.
 
Signature · 1 line
1.7.1
author
#1 lore raw

PATCH v5 2/2 arm64: dts: lx2160a: add sata node support

Add SATA device nodes for fsl-lx2160a and enable support for QDS and RDB boards.

---
changed for V5:
- no change

 arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts |   16 +++++++
 arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts |   16 +++++++
 arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi    |   44 +++++++++++++++++++++
 3 files changed, 76 insertions(+), 0 deletions(-)
arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts +16 -0
index 99a22ab..1a5acf6 100644
@@ -95,6 +95,22 @@
 	};
 };
 
+&sata0 {
+	status = "okay";
+};
+
+&sata1 {
+	status = "okay";
+};
+
+&sata2 {
+	status = "okay";
+};
+
+&sata3 {
+	status = "okay";
+};
+
 &uart0 {
 	status = "okay";
 };
arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts +16 -0
index 6481e5f..5b6799e 100644
@@ -102,6 +102,22 @@
 	};
 };
 
+&sata0 {
+	status = "okay";
+};
+
+&sata1 {
+	status = "okay";
+};
+
+&sata2 {
+	status = "okay";
+};
+
+&sata3 {
+	status = "okay";
+};
+
 &uart0 {
 	status = "okay";
 };
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +44 -0

50 lines not on this page · raw message

Signature · 1 line
1.7.1
#2 lore raw

Re: [v5 2/2] arm64: dts: lx2160a: add sata node support

Quoted 72 lines · Peng Ma

Add SATA device nodes for fsl-lx2160a and enable support for QDS and RDB boards.

---
changed for V5:
- no change

 arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts |   16 +++++++
 arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts |   16 +++++++
 arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi    |   44 +++++++++++++++++++++
 3 files changed, 76 insertions(+), 0 deletions(-)
arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts +16 -0
index 99a22ab..1a5acf6 100644
@@ -95,6 +95,22 @@
 	};
 };
 
+&sata0 {
+	status = "okay";
+};
+
+&sata1 {
+	status = "okay";
+};
+
+&sata2 {
+	status = "okay";
+};
+
+&sata3 {
+	status = "okay";
+};
+
 &uart0 {
 	status = "okay";
 };
arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts +16 -0
index 6481e5f..5b6799e 100644
@@ -102,6 +102,22 @@
 	};
 };
 
+&sata0 {
+	status = "okay";
+};
+
+&sata1 {
+	status = "okay";
+};
+
+&sata2 {
+	status = "okay";
+};
+
+&sata3 {
+	status = "okay";
+};
+
 &uart0 {
 	status = "okay";
 };
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +0 -0
index a79f5c1..592034b 100644

arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi line 675

Quoted 5 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +2 -0
@@ -671,6 +671,50 @@
 			status = "disabled";
 		};
 
+		sata0: sata@3200000 {
+			compatible = "fsl,lx2160a-ahci";

Has the kernel driver been patched to probe the compatible?

Shawn

Quoted 48 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +42 -0
+			reg = <0x0 0x3200000 0x0 0x10000>,
+			      <0x7 0x100520 0x0 0x4>;
+			reg-names = "ahci", "sata-ecc";
+			interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 3>;
+			dma-coherent;
+			status = "disabled";
+		};
+
+		sata1: sata@3210000 {
+			compatible = "fsl,lx2160a-ahci";
+			reg = <0x0 0x3210000 0x0 0x10000>,
+			      <0x7 0x100520 0x0 0x4>;
+			reg-names = "ahci", "sata-ecc";
+			interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 3>;
+			dma-coherent;
+			status = "disabled";
+		};
+
+		sata2: sata@3220000 {
+			compatible = "fsl,lx2160a-ahci";
+			reg = <0x0 0x3220000 0x0 0x10000>,
+			      <0x7 0x100520 0x0 0x4>;
+			reg-names = "ahci", "sata-ecc";
+			interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 3>;
+			dma-coherent;
+			status = "disabled";
+		};
+
+		sata3: sata@3230000 {
+			compatible = "fsl,lx2160a-ahci";
+			reg = <0x0 0x3230000 0x0 0x10000>,
+			      <0x7 0x100520 0x0 0x4>;
+			reg-names = "ahci", "sata-ecc";
+			interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 3>;
+			dma-coherent;
+			status = "disabled";
+		};
+
 		smmu: iommu@5000000 {
 			compatible = "arm,mmu-500";
 			reg = <0 0x5000000 0 0x800000>;
Signature · 1 line
1.7.1
author
#3 lore raw

RE: [v5 2/2] arm64: dts: lx2160a: add sata node support

Quoted 92 lines

-----Original Message-----
From: Shawn Guo <[email protected]>
Sent: 2019年2月1日 14:30
To: Peng Ma <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; Leo Li <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; Andy Tang <[email protected]>
Subject: Re: [v5 2/2] arm64: dts: lx2160a: add sata node support

Quoted 11 lines · Peng Ma

Add SATA device nodes for fsl-lx2160a and enable support for QDS and RDB boards.

---
changed for V5:
- no change

 arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts |   16 +++++++
 arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts |   16 +++++++
 arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi    |   44

+++++++++++++++++++++

Quoted 67 lines
 3 files changed, 76 insertions(+), 0 deletions(-)
arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts +16 -0
index 99a22ab..1a5acf6 100644
@@ -95,6 +95,22 @@
 	};
 };
 
+&sata0 {
+	status = "okay";
+};
+
+&sata1 {
+	status = "okay";
+};
+
+&sata2 {
+	status = "okay";
+};
+
+&sata3 {
+	status = "okay";
+};
+
 &uart0 {
 	status = "okay";
 };
arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts +16 -0
index 6481e5f..5b6799e 100644
@@ -102,6 +102,22 @@
 	};
 };
 
+&sata0 {
+	status = "okay";
+};
+
+&sata1 {
+	status = "okay";
+};
+
+&sata2 {
+	status = "okay";
+};
+
+&sata3 {
+	status = "okay";
+};
+
 &uart0 {
 	status = "okay";
 };
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +0 -0
index a79f5c1..592034b 100644
@@ -671,6 +671,50 @@
 			status = "disabled";
 		};
 
Quoted 6 lines

arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi line 675

Quoted 2 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +2 -0
+		sata0: sata@3200000 {
+			compatible = "fsl,lx2160a-ahci";

Has the kernel driver been patched to probe the compatible?

Shawn

Yes, the driver patch is http://patchwork.ozlabs.org/patch/1034083/
BR
Peng

Quoted 41 lines
Quoted 41 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +40 -0
+			reg = <0x0 0x3200000 0x0 0x10000>,
+			      <0x7 0x100520 0x0 0x4>;
+			reg-names = "ahci", "sata-ecc";
+			interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 3>;
+			dma-coherent;
+			status = "disabled";
+		};
+
+		sata1: sata@3210000 {
+			compatible = "fsl,lx2160a-ahci";
+			reg = <0x0 0x3210000 0x0 0x10000>,
+			      <0x7 0x100520 0x0 0x4>;
+			reg-names = "ahci", "sata-ecc";
+			interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 3>;
+			dma-coherent;
+			status = "disabled";
+		};
+
+		sata2: sata@3220000 {
+			compatible = "fsl,lx2160a-ahci";
+			reg = <0x0 0x3220000 0x0 0x10000>,
+			      <0x7 0x100520 0x0 0x4>;
+			reg-names = "ahci", "sata-ecc";
+			interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 3>;
+			dma-coherent;
+			status = "disabled";
+		};
+
+		sata3: sata@3230000 {
+			compatible = "fsl,lx2160a-ahci";
+			reg = <0x0 0x3230000 0x0 0x10000>,
+			      <0x7 0x100520 0x0 0x4>;
+			reg-names = "ahci", "sata-ecc";
+			interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 3>;
+			dma-coherent;
+			status = "disabled";
Quoted 8 lines
Quoted 8 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +2 -1
+		};
+
 		smmu: iommu@5000000 {
 			compatible = "arm,mmu-500";
 			reg = <0 0x5000000 0 0x800000>;
--

1.7.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#4 lore raw

Re: [v5 2/2] arm64: dts: lx2160a: add sata node support

Quoted 92 lines · Peng Ma
Quoted 92 lines

-----Original Message-----
From: Shawn Guo <[email protected]>
Sent: 2019年2月1日 14:30
To: Peng Ma <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; Leo Li <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; Andy Tang <[email protected]>
Subject: Re: [v5 2/2] arm64: dts: lx2160a: add sata node support

Quoted 11 lines · Peng Ma

Add SATA device nodes for fsl-lx2160a and enable support for QDS and RDB boards.

---
changed for V5:
- no change

 arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts |   16 +++++++
 arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts |   16 +++++++
 arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi    |   44

+++++++++++++++++++++

Quoted 67 lines
 3 files changed, 76 insertions(+), 0 deletions(-)
arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts +16 -0
index 99a22ab..1a5acf6 100644
@@ -95,6 +95,22 @@
 	};
 };
 
+&sata0 {
+	status = "okay";
+};
+
+&sata1 {
+	status = "okay";
+};
+
+&sata2 {
+	status = "okay";
+};
+
+&sata3 {
+	status = "okay";
+};
+
 &uart0 {
 	status = "okay";
 };
arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts +16 -0
index 6481e5f..5b6799e 100644
@@ -102,6 +102,22 @@
 	};
 };
 
+&sata0 {
+	status = "okay";
+};
+
+&sata1 {
+	status = "okay";
+};
+
+&sata2 {
+	status = "okay";
+};
+
+&sata3 {
+	status = "okay";
+};
+
 &uart0 {
 	status = "okay";
 };
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +0 -0
index a79f5c1..592034b 100644
@@ -671,6 +671,50 @@
 			status = "disabled";
 		};
 
Quoted 7 lines
Quoted 6 lines

arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi line 675

Quoted 2 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +2 -0
+		sata0: sata@3200000 {
+			compatible = "fsl,lx2160a-ahci";

Has the kernel driver been patched to probe the compatible?

Shawn

Yes, the driver patch is http://patchwork.ozlabs.org/patch/1034083/

Ping me when the driver patch is accepted. Ideally, we only accept dts changes after the driver counterpart lands on mainline.

Shawn

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author
#5 lore raw

RE: [v5 2/2] arm64: dts: lx2160a: add sata node support

Quoted 120 lines

-----Original Message-----
From: Shawn Guo <[email protected]>
Sent: 2019年2月11日 13:39
To: Peng Ma <[email protected]>
Cc: [email protected]; [email protected]; Andy Tang <[email protected]>; [email protected]; [email protected]; Leo Li <[email protected]>; [email protected]; [email protected]; [email protected]
Subject: Re: [v5 2/2] arm64: dts: lx2160a: add sata node support

Quoted 92 lines · Peng Ma
Quoted 92 lines

-----Original Message-----
From: Shawn Guo <[email protected]>
Sent: 2019年2月1日 14:30
To: Peng Ma <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; Leo Li <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; Andy Tang <[email protected]>
Subject: Re: [v5 2/2] arm64: dts: lx2160a: add sata node support

Quoted 11 lines · Peng Ma

Add SATA device nodes for fsl-lx2160a and enable support for QDS and RDB boards.

---
changed for V5:
- no change

 arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts |   16 +++++++
 arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts |   16 +++++++
 arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi    |   44

+++++++++++++++++++++

Quoted 67 lines
 3 files changed, 76 insertions(+), 0 deletions(-)
arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts +16 -0
index 99a22ab..1a5acf6 100644
@@ -95,6 +95,22 @@
 	};
 };
 
+&sata0 {
+	status = "okay";
+};
+
+&sata1 {
+	status = "okay";
+};
+
+&sata2 {
+	status = "okay";
+};
+
+&sata3 {
+	status = "okay";
+};
+
 &uart0 {
 	status = "okay";
 };
arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts +16 -0
index 6481e5f..5b6799e 100644
@@ -102,6 +102,22 @@
 	};
 };
 
+&sata0 {
+	status = "okay";
+};
+
+&sata1 {
+	status = "okay";
+};
+
+&sata2 {
+	status = "okay";
+};
+
+&sata3 {
+	status = "okay";
+};
+
 &uart0 {
 	status = "okay";
 };
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +0 -0
index a79f5c1..592034b 100644
@@ -671,6 +671,50 @@
 			status = "disabled";
 		};
 
Quoted 9 lines
Quoted 6 lines

arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi line 675

Quoted 2 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +2 -0
+		sata0: sata@3200000 {
+			compatible = "fsl,lx2160a-ahci";

Has the kernel driver been patched to probe the compatible?

Shawn

Yes, the driver patch is
https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatc

hwork.ozlabs.org%2Fpatch%2F1034083%2F&amp;data=02%7C01%7Cpeng.ma %40nxp

Quoted 1 line

.com%7C8daea4e4b2ea419cb2a008d68fe34f51%7C686ea1d3bc2b4c6fa92c

d99c5c30

Quoted 1 line
Quoted 8 lines

1635%7C0%7C0%7C636854603794170576&amp;sdata=z3ic8%2FAS10NcFjdP eJFpnFoo

Quoted 1 line

R2Yo4oYO%2FAASr7r2Lhg%3D&amp;reserved=0

Ping me when the driver patch is accepted. Ideally, we only accept dts changes after the driver counterpart lands on mainline.

Shawn

[Peng Ma] got it, thanks.
BR
Peng

#6 lore raw

Re: [v5 2/2] arm64: dts: lx2160a: add sata node support

In reply to Peng Ma
Quoted 102 lines · Peng Ma

Add SATA device nodes for fsl-lx2160a and enable support for QDS and RDB boards.

---
changed for V5:
- no change

 arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts |   16 +++++++
 arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts |   16 +++++++
 arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi    |   44 +++++++++++++++++++++
 3 files changed, 76 insertions(+), 0 deletions(-)
arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts +16 -0
index 99a22ab..1a5acf6 100644
@@ -95,6 +95,22 @@
 	};
 };
 
+&sata0 {
+	status = "okay";
+};
+
+&sata1 {
+	status = "okay";
+};
+
+&sata2 {
+	status = "okay";
+};
+
+&sata3 {
+	status = "okay";
+};
+
 &uart0 {
 	status = "okay";
 };
arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts +16 -0
index 6481e5f..5b6799e 100644
@@ -102,6 +102,22 @@
 	};
 };
 
+&sata0 {
+	status = "okay";
+};
+
+&sata1 {
+	status = "okay";
+};
+
+&sata2 {
+	status = "okay";
+};
+
+&sata3 {
+	status = "okay";
+};
+
 &uart0 {
 	status = "okay";
 };
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +27 -0
index a79f5c1..592034b 100644
@@ -671,6 +671,50 @@
 			status = "disabled";
 		};
 
+		sata0: sata@3200000 {
+			compatible = "fsl,lx2160a-ahci";
+			reg = <0x0 0x3200000 0x0 0x10000>,
+			      <0x7 0x100520 0x0 0x4>;
+			reg-names = "ahci", "sata-ecc";
+			interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 3>;
+			dma-coherent;
+			status = "disabled";
+		};
+
+		sata1: sata@3210000 {
+			compatible = "fsl,lx2160a-ahci";
+			reg = <0x0 0x3210000 0x0 0x10000>,
+			      <0x7 0x100520 0x0 0x4>;
+			reg-names = "ahci", "sata-ecc";
+			interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 3>;
+			dma-coherent;
+			status = "disabled";
+		};
+
+		sata2: sata@3220000 {
+			compatible = "fsl,lx2160a-ahci";
+			reg = <0x0 0x3220000 0x0 0x10000>,
+			      <0x7 0x100520 0x0 0x4>;
+			reg-names = "ahci", "sata-ecc";

arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi line 710

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +10 -0
+			interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 3>;
+			dma-coherent;
+			status = "disabled";
+		};
+
+		sata3: sata@3230000 {
+			compatible = "fsl,lx2160a-ahci";
+			reg = <0x0 0x3230000 0x0 0x10000>,
+			      <0x7 0x100520 0x0 0x4>;

You are using same reg values for sata-ecc in all sata instances. Does this actually work? No errors when the ahci_qoriq driver do ioremap on it while probing second instance and onward?

fsl-ls208xa.dtsi is the only other file here with multiple sata instances and it doesn’t care about sata-ecc.

arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi line 720

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +7 -0
+			reg-names = "ahci", "sata-ecc";
+			interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 3>;
+			dma-coherent;
+			status = "disabled";
+		};
+
 		smmu: iommu@5000000 {
 			compatible = "arm,mmu-500";
 			reg = <0 0x5000000 0 0x800000>;

BR,
Yousaf

author
#7 lore raw

RE: [v5 2/2] arm64: dts: lx2160a: add sata node support

Quoted 125 lines

-----Original Message-----
From: Mian Yousaf Kaukab <[email protected]>
Sent: 2019年2月13日 3:01
To: Peng Ma <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; Leo Li <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; Andy Tang <[email protected]>
Subject: Re: [v5 2/2] arm64: dts: lx2160a: add sata node support

Quoted 11 lines · Peng Ma

Add SATA device nodes for fsl-lx2160a and enable support for QDS and RDB boards.

---
changed for V5:
- no change

 arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts |   16 +++++++
 arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts |   16 +++++++
 arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi    |   44

+++++++++++++++++++++

Quoted 99 lines
 3 files changed, 76 insertions(+), 0 deletions(-)
arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts +16 -0
index 99a22ab..1a5acf6 100644
@@ -95,6 +95,22 @@
 	};
 };
 
+&sata0 {
+	status = "okay";
+};
+
+&sata1 {
+	status = "okay";
+};
+
+&sata2 {
+	status = "okay";
+};
+
+&sata3 {
+	status = "okay";
+};
+
 &uart0 {
 	status = "okay";
 };
arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts +16 -0
index 6481e5f..5b6799e 100644
@@ -102,6 +102,22 @@
 	};
 };
 
+&sata0 {
+	status = "okay";
+};
+
+&sata1 {
+	status = "okay";
+};
+
+&sata2 {
+	status = "okay";
+};
+
+&sata3 {
+	status = "okay";
+};
+
 &uart0 {
 	status = "okay";
 };
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +32 -0
index a79f5c1..592034b 100644
@@ -671,6 +671,50 @@
 			status = "disabled";
 		};
 
+		sata0: sata@3200000 {
+			compatible = "fsl,lx2160a-ahci";
+			reg = <0x0 0x3200000 0x0 0x10000>,
+			      <0x7 0x100520 0x0 0x4>;
+			reg-names = "ahci", "sata-ecc";
+			interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 3>;
+			dma-coherent;
+			status = "disabled";
+		};
+
+		sata1: sata@3210000 {
+			compatible = "fsl,lx2160a-ahci";
+			reg = <0x0 0x3210000 0x0 0x10000>,
+			      <0x7 0x100520 0x0 0x4>;
+			reg-names = "ahci", "sata-ecc";
+			interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 3>;
+			dma-coherent;
+			status = "disabled";
+		};
+
+		sata2: sata@3220000 {
+			compatible = "fsl,lx2160a-ahci";
+			reg = <0x0 0x3220000 0x0 0x10000>,
+			      <0x7 0x100520 0x0 0x4>;
+			reg-names = "ahci", "sata-ecc";
+			interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 3>;
+			dma-coherent;
+			status = "disabled";
+		};
Quoted 9 lines

arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi line 710

Quoted 5 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +5 -0
+
+		sata3: sata@3230000 {
+			compatible = "fsl,lx2160a-ahci";
+			reg = <0x0 0x3230000 0x0 0x10000>,
+			      <0x7 0x100520 0x0 0x4>;

You are using same reg values for sata-ecc in all sata instances. Does this actually work? No errors when the ahci_qoriq driver do ioremap on it while probing second instance and onward?

Thanks for you point out the problem. I will fixed it with two or more sata enable.

Quoted 3 lines

fsl-ls208xa.dtsi is the only other file here with multiple sata instances and it doesn’t care about sata-ecc.

The ls208xa platforms is not necessary to set sata-ecc addr. BR,
Peng

Quoted 13 lines

arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi line 720

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +7 -0
+			reg-names = "ahci", "sata-ecc";
+			interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 3>;
+			dma-coherent;
+			status = "disabled";
+		};
+
 		smmu: iommu@5000000 {
 			compatible = "arm,mmu-500";
 			reg = <0 0x5000000 0 0x800000>;

BR,
Yousaf

author
#8 lore raw

RE: [v5 2/2] arm64: dts: lx2160a: add sata node support

Hi Yousaf,

To set sata bit of ecc-addr will affect all sata controllers, The v6 patch has been sent will fixed the remap error when two or more sata controllers be probed, please review. Thanks.

Best Regards,
Peng

Quoted 166 lines

-----Original Message-----
From: Peng Ma
Sent: 2019年2月14日 17:19
To: 'Mian Yousaf Kaukab' <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; Leo Li <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; Andy Tang <[email protected]>
Subject: RE: [v5 2/2] arm64: dts: lx2160a: add sata node support

Quoted 123 lines

-----Original Message-----
From: Mian Yousaf Kaukab <[email protected]>
Sent: 2019年2月13日 3:01
To: Peng Ma <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; Leo Li <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; Andy Tang <[email protected]>
Subject: Re: [v5 2/2] arm64: dts: lx2160a: add sata node support

Quoted 11 lines · Peng Ma

Add SATA device nodes for fsl-lx2160a and enable support for QDS and RDB boards.

---
changed for V5:
- no change

 arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts |   16 +++++++
 arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts |   16 +++++++
 arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi    |   44

+++++++++++++++++++++

Quoted 99 lines
 3 files changed, 76 insertions(+), 0 deletions(-)
arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts +16 -0
index 99a22ab..1a5acf6 100644
@@ -95,6 +95,22 @@
 	};
 };
 
+&sata0 {
+	status = "okay";
+};
+
+&sata1 {
+	status = "okay";
+};
+
+&sata2 {
+	status = "okay";
+};
+
+&sata3 {
+	status = "okay";
+};
+
 &uart0 {
 	status = "okay";
 };
arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts +16 -0
index 6481e5f..5b6799e 100644
@@ -102,6 +102,22 @@
 	};
 };
 
+&sata0 {
+	status = "okay";
+};
+
+&sata1 {
+	status = "okay";
+};
+
+&sata2 {
+	status = "okay";
+};
+
+&sata3 {
+	status = "okay";
+};
+
 &uart0 {
 	status = "okay";
 };
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +32 -0
index a79f5c1..592034b 100644
@@ -671,6 +671,50 @@
 			status = "disabled";
 		};
 
+		sata0: sata@3200000 {
+			compatible = "fsl,lx2160a-ahci";
+			reg = <0x0 0x3200000 0x0 0x10000>,
+			      <0x7 0x100520 0x0 0x4>;
+			reg-names = "ahci", "sata-ecc";
+			interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 3>;
+			dma-coherent;
+			status = "disabled";
+		};
+
+		sata1: sata@3210000 {
+			compatible = "fsl,lx2160a-ahci";
+			reg = <0x0 0x3210000 0x0 0x10000>,
+			      <0x7 0x100520 0x0 0x4>;
+			reg-names = "ahci", "sata-ecc";
+			interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 3>;
+			dma-coherent;
+			status = "disabled";
+		};
+
+		sata2: sata@3220000 {
+			compatible = "fsl,lx2160a-ahci";
+			reg = <0x0 0x3220000 0x0 0x10000>,
+			      <0x7 0x100520 0x0 0x4>;
+			reg-names = "ahci", "sata-ecc";
+			interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 3>;
+			dma-coherent;
+			status = "disabled";
+		};
Quoted 9 lines

arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi line 710

Quoted 5 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +5 -0
+
+		sata3: sata@3230000 {
+			compatible = "fsl,lx2160a-ahci";
+			reg = <0x0 0x3230000 0x0 0x10000>,
+			      <0x7 0x100520 0x0 0x4>;

You are using same reg values for sata-ecc in all sata instances. Does this actually work? No errors when the ahci_qoriq driver do ioremap on it while probing second instance and onward?

Thanks for you point out the problem. I will fixed it with two or more sata enable.

Quoted 3 lines

fsl-ls208xa.dtsi is the only other file here with multiple sata instances and it doesn’t care about sata-ecc.

The ls208xa platforms is not necessary to set sata-ecc addr. BR,
Peng

Quoted 13 lines

arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi line 720

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +7 -0
+			reg-names = "ahci", "sata-ecc";
+			interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 3>;
+			dma-coherent;
+			status = "disabled";
+		};
+
 		smmu: iommu@5000000 {
 			compatible = "arm,mmu-500";
 			reg = <0 0x5000000 0 0x800000>;

BR,
Yousaf