Skip to contentSkip to conversation

systemd: rpc_pipefs.target use BindsTo= instead of Requires=

PATCH In review Yongcheng Yang 2 participants 2 messages Jan 25, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 systemd: rpc_pipefs.target use BindsTo= instead of Requires=

The rpc_pipefs.target should enter inactive state if var-lib-nfs-rpc_pipefs.mount is stopped. Otherwise, services depending rpc_pipefs.target (e.g. nfs-idmapd) fail to start after /var/lib/nfs/rpc_pipefs unmounted

---

Reproducing steps:

$ systemctl stop nfs-idmapd
$ umount /var/lib/nfs/rpc_pipefs
$ systemctl start nfs-idmapd

Thanks,
Yongcheng

 systemd/rpc_pipefs.target | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
systemd/rpc_pipefs.target +1 -1
index 01d4d27..5ce3981 100644
@@ -1,3 +1,3 @@
 [Unit]
-Requires=var-lib-nfs-rpc_pipefs.mount
+BindsTo=var-lib-nfs-rpc_pipefs.mount
 After=var-lib-nfs-rpc_pipefs.mount
Signature · 1 line
2.17.2
#1 lore raw

Hello Yongcheng,

Quoted 5 lines · Yongcheng Yang

The rpc_pipefs.target should enter inactive state if var-lib-nfs-rpc_pipefs.mount is stopped. Otherwise, services depending rpc_pipefs.target (e.g. nfs-idmapd) fail to start after /var/lib/nfs/rpc_pipefs unmounted

Quoted 7 lines

---

Reproducing steps:

$ systemctl stop nfs-idmapd
$ umount /var/lib/nfs/rpc_pipefs
$ systemctl start nfs-idmapd

I look at things like this and I think there real
fix here is... Just don't do that! :-)

Now I'm sure the patch works... but... why in the world would anybody unmount /var/lib/nfs/rpc_pipefs with NFS daemons running?

Unless you are some mad QA person trying to destroy the world! ;-)

steved.

Quoted 17 lines

Thanks,
Yongcheng

 systemd/rpc_pipefs.target | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
systemd/rpc_pipefs.target +1 -1
index 01d4d27..5ce3981 100644
@@ -1,3 +1,3 @@
 [Unit]
-Requires=var-lib-nfs-rpc_pipefs.mount
+BindsTo=var-lib-nfs-rpc_pipefs.mount
 After=var-lib-nfs-rpc_pipefs.mount