Skip to contentSkip to conversation

crypto: mark crc32 checksum as FIPS allowed

PATCH In review Milan Broz 3 participants 3 messages Jan 25, 2019 – Feb 1, 2019

Subsystems (2)
lore
Share & tools
lore

Milan Broz

author
#0 lore raw

PATCH 1/1 crypto: mark crc32 checksum as FIPS allowed

The CRC32 is not a cryptographic hash algorithm, so the FIPS restrictions should not apply to it. (The CRC32C variant is already allowed.)

This CRC32 variant is used for in dm-crypt legacy TrueCrypt IV implementation (tcw); detected by cryptsetup test suite failure in FIPS mode.

---
 crypto/testmgr.c | 1 +
 1 file changed, 1 insertion(+)
crypto/testmgr.c +1 -0
index 0f684a414acb..82bc0398bbbf 100644
@@ -2735,6 +2735,7 @@ static const struct alg_test_desc alg_test_descs[] = {
 	}, {
 		.alg = "crc32",
 		.test = alg_test_hash,
+		.fips_allowed = 1,
 		.suite = {
 			.hash = __VECS(crc32_tv_template)
 		}
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw

Am Freitag, 25. Januar 2019, 10:31:47 CET schrieb Milan Broz:

Hi Milan,

Quoted 9 lines

The CRC32 is not a cryptographic hash algorithm, so the FIPS restrictions should not apply to it. (The CRC32C variant is already allowed.)

This CRC32 variant is used for in dm-crypt legacy TrueCrypt IV implementation (tcw); detected by cryptsetup test suite failure in FIPS mode.

Ciao
Stephan

maintainer
#2 lore raw
In reply to Milan Broz
Quoted 4 lines · Milan Broz

The CRC32 is not a cryptographic hash algorithm, so the FIPS restrictions should not apply to it. (The CRC32C variant is already allowed.)

Quoted 8 lines

This CRC32 variant is used for in dm-crypt legacy TrueCrypt IV implementation (tcw); detected by cryptsetup test suite failure in FIPS mode.

---
 crypto/testmgr.c | 1 +
 1 file changed, 1 insertion(+)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt