Skip to contentSkip to conversation

RDMA/srpt: Fix a credit leak for aborted commands

PATCH In review Bart Van Assche 1 participant 1 message Jan 25, 2019

Subsystems (3)
lore
Share & tools
lore

Bart Van Assche

author maintainer
#0 lore raw

PATCH 9/16 RDMA/srpt: Fix a credit leak for aborted commands

Make sure that the next time a response is sent to the initiator that the credit it had allocated for the aborted request gets freed.

Cc Doug Ledford <[email protected]>
Cc Jason Gunthorpe <[email protected]>
Cc Nicholas Bellinger <[email protected]>
Cc Mike Christie <[email protected]>
Cc Hannes Reinecke <[email protected]>
Cc Christoph Hellwig <[email protected]>
Fixes 131e6abc674e ("target: Add TFO->abort_task for aborted task resources release") # v3.15
---
 drivers/infiniband/ulp/srpt/ib_srpt.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
drivers/infiniband/ulp/srpt/ib_srpt.c +11 -0
index d426e01905f9..1a039f16d315 100644
@@ -2870,8 +2870,19 @@ static void srpt_queue_tm_rsp(struct se_cmd *cmd)
 	srpt_queue_response(cmd);
 }
 
+/*
+ * This function is called for aborted commands if no response is sent to the
+ * initiator. Make sure that the credits freed by aborting a command are
+ * returned to the initiator the next time a response is sent by incrementing
+ * ch->req_lim_delta.
+ */
 static void srpt_aborted_task(struct se_cmd *cmd)
 {
+	struct srpt_send_ioctx *ioctx = container_of(cmd,
+				struct srpt_send_ioctx, cmd);
+	struct srpt_rdma_ch *ch = ioctx->ch;
+
+	atomic_inc(&ch->req_lim_delta);
 }
 
 static int srpt_queue_status(struct se_cmd *cmd)
Signature · 1 line
2.20.1.495.gaa96b0ce6b-goog