Skip to contentSkip to conversation

RDMA/srpt: Fix handling of TMF submission failure

PATCH In review Bart Van Assche 1 participant 1 message Jan 25, 2019

Subsystems (3)
lore
Share & tools
lore

Bart Van Assche

author maintainer
#0 lore raw

PATCH 7/16 RDMA/srpt: Fix handling of TMF submission failure

If submitting a TMF to the target core fails, send the "FUNCTION REJECTED" response to the initiator.

Cc Doug Ledford <[email protected]>
Cc Jason Gunthorpe <[email protected]>
Cc Nicholas Bellinger <[email protected]>
Cc Mike Christie <[email protected]>
Cc Christoph Hellwig <[email protected]>
---
 drivers/infiniband/ulp/srpt/ib_srpt.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/infiniband/ulp/srpt/ib_srpt.c +1 -3
index 4fc901d1c0c1..0dc2df925f76 100644
@@ -1581,11 +1581,9 @@ static void srpt_handle_tsk_mgmt(struct srpt_rdma_ch *ch,
 			       TARGET_SCF_ACK_KREF);
 	if (rc != 0) {
 		send_ioctx->cmd.se_tmr_req->response = TMR_FUNCTION_REJECTED;
-		goto fail;
+		cmd->se_tfo->queue_tm_rsp(cmd);
 	}
 	return;
-fail:
-	transport_send_check_condition_and_sense(cmd, 0, 0); // XXX:
 }
 
 /**
Signature · 1 line
2.20.1.495.gaa96b0ce6b-goog