ASN.1: mark expected switch fall-throughs
PATCH 1/1 ASN.1: mark expected switch fall-throughs
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
lib/asn1_decoder.c:386:6: warning: this statement may fall through [-Wimplicit-fallthrough=] lib/asn1_decoder.c:449:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
--- lib/asn1_decoder.c | 4 ++++ 1 file changed, 4 insertions(+)
lib/asn1_decoder.c +4 -0
@@ -385,6 +385,8 @@ int asn1_ber_decoder(const struct asn1_decoder *decoder,case ASN1_OP_END_SET_ACT :if (unlikely (!(flags &FLAG_MATCHED ))) goto tag_mismatch; +/* fall through */ +case ASN1_OP_END_SEQ :case ASN1_OP_END_SET_OF :case ASN1_OP_END_SEQ_OF :
@@ -450,6 +452,8 @@ int asn1_ber_decoder(const struct asn1_decoder *decoder, pc += asn1_op_lengths[op]; goto next_op; } +/* fall through */ +case ASN1_OP_ACT : ret = actions[machine[pc +1 ]](context, hdr, tag, data + tdp, len);if (ret <0 )
Signature · 1 line
2.20.1
Quoted 9 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
lib/asn1_decoder.c:386:6: warning: this statement may fall through [-Wimplicit-fallthrough=]lib/asn1_decoder.c:449:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
Quoted 6 lines
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>
-Kees
Quoted 29 lines
--- lib/asn1_decoder.c | 4 ++++ 1 file changed, 4 insertions(+)lib/asn1_decoder.c +4
-1@@ -385,6 +385,8 @@ int asn1_ber_decoder(const struct asn1_decoder *decoder,case ASN1_OP_END_SET_ACT :if (unlikely (!(flags &FLAG_MATCHED ))) goto tag_mismatch; +/* fall through */ +case ASN1_OP_END_SEQ :case ASN1_OP_END_SET_OF :case ASN1_OP_END_SEQ_OF :@@ -450,6 +452,8 @@ int asn1_ber_decoder(const struct asn1_decoder *decoder, pc += asn1_op_lengths[op]; goto next_op; } +/* fall through */ +case ASN1_OP_ACT : ret = actions[machine[pc +1 ]](context, hdr, tag, data + tdp, len);if (ret <0 ) --2.20.1
Signature · 1 line
Kees Cook
Quoted 11 lines · Kees Cook
Quoted 9 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
lib/asn1_decoder.c:386:6: warning: this statement may fall through [-Wimplicit-fallthrough=]lib/asn1_decoder.c:449:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
Quoted 9 lines
Quoted 6 lines
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>Reviewed-by Kees Cook <[email protected]>
Now applied to for-next/kspp, thanks.
https://git.kernel.org/gustavoars/c/482c7212e6af6a3362e337fb49e2e101e4578644
Cheers!
--
Gustavo