target/xtensa: drop function xtensa_timer_irq
PATCH 1/1 target/xtensa: drop function xtensa_timer_irq
It's a one-liner used in a single place, move its implementation there and remove its declaration.
Signed-off-by Max Filippov <[email protected]>
--- hw/xtensa/pic_cpu.c | 7 +------ target/xtensa/cpu.h | 1 - 2 files changed, 1 insertion(+), 7 deletions(-)
hw/xtensa/pic_cpu.c +1 -6
@@ -77,18 +77,13 @@ static void xtensa_set_irq(void *opaque, int irq, int active) } } -void xtensa_timer_irq (CPUXtensaState *env,uint32_t id,uint32_t active) -{ -qemu_set_irq (env->irq_inputs[env->config->timerint[id]], active); -} -static void xtensa_ccompare_cb (void *opaque) {XtensaCcompareTimer *ccompare = opaque;CPUXtensaState *env = ccompare->env;unsigned i = ccompare - env->ccompare; -xtensa_timer_irq (env, i,1 ); +qemu_set_irq (env->irq_inputs[env->config->timerint[i]],1 ); }void xtensa_irq_init (CPUXtensaState *env)
target/xtensa/cpu.h +0 -1
@@ -570,7 +570,6 @@ void xtensa_sim_open_console(Chardev *chr);void check_interrupts (CPUXtensaState *s);void xtensa_irq_init (CPUXtensaState *env);void *xtensa_get_extint (CPUXtensaState *env,unsigned extint); -void xtensa_timer_irq (CPUXtensaState *env,uint32_t id,uint32_t active);int cpu_xtensa_signal_handler (int host_signum,void *pinfo,void *puc);void xtensa_cpu_list (FILE *f,fprintf_function cpu_fprintf);void xtensa_sync_window_from_phys (CPUXtensaState *env);
Signature · 1 line
2.11.0
Quoted 8 lines · Max Filippov
It's a one-liner used in a single place, move its implementation there and remove its declaration.
Signed-off-by Max Filippov <[email protected]>--- hw/xtensa/pic_cpu.c | 7 +------ target/xtensa/cpu.h | 1 - 2 files changed, 1 insertion(+), 7 deletions(-)
Reviewed-by Richard Henderson <[email protected]>
r~
Quoted 4 lines · Max Filippov
It's a one-liner used in a single place, move its implementation there and remove its declaration.
Signed-off-by Max Filippov <[email protected]>
Reviewed-by Philippe Mathieu-Daudé <[email protected]>
Quoted 42 lines
--- hw/xtensa/pic_cpu.c | 7 +------ target/xtensa/cpu.h | 1 - 2 files changed, 1 insertion(+), 7 deletions(-)hw/xtensa/pic_cpu.c +1
-6@@ -77,18 +77,13 @@ static void xtensa_set_irq(void *opaque, int irq, int active) } } -void xtensa_timer_irq (CPUXtensaState *env,uint32_t id,uint32_t active) -{ -qemu_set_irq (env->irq_inputs[env->config->timerint[id]], active); -} -static void xtensa_ccompare_cb (void *opaque) {XtensaCcompareTimer *ccompare = opaque;CPUXtensaState *env = ccompare->env;unsigned i = ccompare - env->ccompare; -xtensa_timer_irq (env, i,1 ); +qemu_set_irq (env->irq_inputs[env->config->timerint[i]],1 ); }void xtensa_irq_init (CPUXtensaState *env)target/xtensa/cpu.h +0
-1@@ -570,7 +570,6 @@ void xtensa_sim_open_console(Chardev *chr);void check_interrupts (CPUXtensaState *s);void xtensa_irq_init (CPUXtensaState *env);void *xtensa_get_extint (CPUXtensaState *env,unsigned extint); -void xtensa_timer_irq (CPUXtensaState *env,uint32_t id,uint32_t active);int cpu_xtensa_signal_handler (int host_signum,void *pinfo,void *puc);void xtensa_cpu_list (FILE *f,fprintf_function cpu_fprintf);void xtensa_sync_window_from_phys (CPUXtensaState *env);