purgatory: Use standalond CFLAGS
Subsystems (2)
PATCH 1/1 purgatory: Use standalond CFLAGS
There has been a lot of workarounds for purgatory disabling many specified CFLAGS that will break purgatory. It will be better to not let the CFLAGS used to compile purgatory honor the CFLAGS from environment variables. So we will have stable CFLAGS for purgatory.
If anyone still wants to change purgatory CFLAGS, PURGATORY_EXTRA_CFLAGS is still honored.
--- purgatory/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
purgatory/Makefile +1 -1
@@ -45,7 +45,7 @@ purgatory/sha256.o: $(srcdir)/util_lib/sha256.c $(COMPILE.c) -o $@ $^ $(PURGATORY): CC=$(TARGET_CC) -$(PURGATORY): CFLAGS+=$(PURGATORY_EXTRA_CFLAGS) \ +$(PURGATORY): CFLAGS=$(PURGATORY_EXTRA_CFLAGS) \ $($(ARCH)_PURGATORY_EXTRA_CFLAGS) \ -Os -fno-builtin -ffreestanding \ -fno-zero-initialized-in-bss \
Signature · 7 lines
2.20.1 _______________________________________________ kexec mailing list [email protected] http://lists.infradead.org/mailman/listinfo/kexec
Quoted 7 lines · Kairui Song
There has been a lot of workarounds for purgatory disabling many specified CFLAGS that will break purgatory. It will be better to not let the CFLAGS used to compile purgatory honor the CFLAGS from environment variables. So we will have stable CFLAGS for purgatory.
If anyone still wants to change purgatory CFLAGS,
PURGATORY_EXTRA_CFLAGSis still honored.
Thanks, this seems reasonable to me.
But I'd like to wait to see if there is feedback from others before applying.
Quoted 21 lines
--- purgatory/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)purgatory/Makefile +1
-1@@ -45,7 +45,7 @@ purgatory/sha256.o: $(srcdir)/util_lib/sha256.c $(COMPILE.c) -o $@ $^ $(PURGATORY): CC=$(TARGET_CC) -$(PURGATORY): CFLAGS+=$(PURGATORY_EXTRA_CFLAGS) \ +$(PURGATORY): CFLAGS=$(PURGATORY_EXTRA_CFLAGS) \ $($(ARCH)_PURGATORY_EXTRA_CFLAGS) \ -Os -fno-builtin -ffreestanding \ -fno-zero-initialized-in-bss \Signature · 1 line
2.20.1
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
Quoted 11 lines · Simon Horman
Quoted 7 lines · Kairui Song
There has been a lot of workarounds for purgatory disabling many specified CFLAGS that will break purgatory. It will be better to not let the CFLAGS used to compile purgatory honor the CFLAGS from environment variables. So we will have stable CFLAGS for purgatory.
If anyone still wants to change purgatory CFLAGS,
PURGATORY_EXTRA_CFLAGSis still honored.Thanks, this seems reasonable to me.
But I'd like to wait to see if there is feedback from others before applying.
Thanks again, applied.
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec