Skip to contentSkip to conversation

arm: stm32mp1: deploy spl in root folder

PATCH New Sean Nyekjær 5 participants 11 messages Jan 4, 2019 – Jan 28, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: stm32mp1: deploy spl in root folder

Deploy u-boot-spl.stm32 binary in u-boot root folder like the rest of the boards.
This makes it more streamlined when building in Yocto, Buildroot etc..

---
 arch/arm/mach-stm32mp/config.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/mach-stm32mp/config.mk +3 -3
index cde5850e934..124729cd839 100644
@@ -3,11 +3,11 @@
 # Copyright (C) 2018, STMicroelectronics - All Rights Reserved
 #
 
-ALL-$(CONFIG_SPL_BUILD) += spl/u-boot-spl.stm32
+ALL-$(CONFIG_SPL_BUILD) += u-boot-spl.stm32
 
 MKIMAGEFLAGS_u-boot-spl.stm32 = -T stm32image -a $(CONFIG_SPL_TEXT_BASE) -e $(CONFIG_SPL_TEXT_BASE)
 
-spl/u-boot-spl.stm32: MKIMAGEOUTPUT = spl/u-boot-spl.stm32.log
+u-boot-spl.stm32: MKIMAGEOUTPUT = u-boot-spl.stm32.log
 
-spl/u-boot-spl.stm32: spl/u-boot-spl.bin FORCE
+u-boot-spl.stm32: spl/u-boot-spl.bin FORCE
 	$(call if_changed,mkimage)
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 arm: stm32mp1: deploy spl in root folder

Hi Sean

+Patrick Delaunay

What about keeping spl binary in /spl directory and copying it in root directory instead ? It would avoid us to update our environment regarding your proposal.

Just a minor remark, don't forget to add maintainers in copy when sending your patch.

Either use ./scripts/get_maintainer.pl <filename> which give you the people list to send your patch to or patman which adds automatically right people in cc.

For example ./scripts/get_maintainer.pl arch/arm/mach-stm32mp/config.mk gives you :

Patrick Delaunay <[email protected]> (maintainer:ARM STM STM32MP) Christophe Kerello <[email protected]> (maintainer:ARM STM STM32MP) Patrice Chotard <[email protected]> (maintainer:ARM STM STM32MP) Albert Aribaud <[email protected]> (maintainer:ARM) uboot-stm32 at st-md-mailman.stormreply.com (moderated list:ARM STM STM32MP) u-boot at lists.denx.de (open list)

Patrice

Quoted 29 lines · Sean Nyekjær

Deploy u-boot-spl.stm32 binary in u-boot root folder like the rest of the boards.
This makes it more streamlined when building in Yocto, Buildroot etc..

---
 arch/arm/mach-stm32mp/config.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/mach-stm32mp/config.mk +3 -3
index cde5850e934..124729cd839 100644
@@ -3,11 +3,11 @@
 # Copyright (C) 2018, STMicroelectronics - All Rights Reserved
 #
 
-ALL-$(CONFIG_SPL_BUILD) += spl/u-boot-spl.stm32
+ALL-$(CONFIG_SPL_BUILD) += u-boot-spl.stm32
 
 MKIMAGEFLAGS_u-boot-spl.stm32 = -T stm32image -a $(CONFIG_SPL_TEXT_BASE) -e $(CONFIG_SPL_TEXT_BASE)
 
-spl/u-boot-spl.stm32: MKIMAGEOUTPUT = spl/u-boot-spl.stm32.log
+u-boot-spl.stm32: MKIMAGEOUTPUT = u-boot-spl.stm32.log
 
-spl/u-boot-spl.stm32: spl/u-boot-spl.bin FORCE
+u-boot-spl.stm32: spl/u-boot-spl.bin FORCE
 	$(call if_changed,mkimage)
#2 lore raw

PATCH 1/1 arm: stm32mp1: deploy spl in root folder

ping

Quoted 56 lines · Patrice CHOTARD

Hi Sean

+Patrick Delaunay

What about keeping spl binary in /spl directory and copying it in root directory instead ? It would avoid us to update our environment regarding your proposal.

Just a minor remark, don't forget to add maintainers in copy when sending your patch.

Either use ./scripts/get_maintainer.pl <filename> which give you the people list to send your patch to or patman which adds automatically right people in cc.

For example ./scripts/get_maintainer.pl arch/arm/mach-stm32mp/config.mk gives you :

Patrick Delaunay <[email protected]> (maintainer:ARM STM STM32MP) Christophe Kerello <[email protected]> (maintainer:ARM STM STM32MP) Patrice Chotard <[email protected]> (maintainer:ARM STM STM32MP) Albert Aribaud <[email protected]> (maintainer:ARM) uboot-stm32 at st-md-mailman.stormreply.com (moderated list:ARM STM STM32MP) u-boot at lists.denx.de (open list)

Patrice

Quoted 28 lines · Sean Nyekjær

Deploy u-boot-spl.stm32 binary in u-boot root folder like the rest of the boards.
This makes it more streamlined when building in Yocto, Buildroot etc..

---
  arch/arm/mach-stm32mp/config.mk | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/mach-stm32mp/config.mk +3 -3
index cde5850e934..124729cd839 100644
@@ -3,11 +3,11 @@
  # Copyright (C) 2018, STMicroelectronics - All Rights Reserved
  #
 
-ALL-$(CONFIG_SPL_BUILD) += spl/u-boot-spl.stm32
+ALL-$(CONFIG_SPL_BUILD) += u-boot-spl.stm32
 
  MKIMAGEFLAGS_u-boot-spl.stm32 = -T stm32image -a $(CONFIG_SPL_TEXT_BASE) -e $(CONFIG_SPL_TEXT_BASE)
 
-spl/u-boot-spl.stm32: MKIMAGEOUTPUT = spl/u-boot-spl.stm32.log
+u-boot-spl.stm32: MKIMAGEOUTPUT = u-boot-spl.stm32.log
 
-spl/u-boot-spl.stm32: spl/u-boot-spl.bin FORCE
+u-boot-spl.stm32: spl/u-boot-spl.bin FORCE
  	$(call if_changed,mkimage)
Signature · 10 lines
Kind regards,
Sean Nyekjær
Embedded Linux Consultant

+45 42427326
sean at geanix.com

Geanix IVS
https://geanix.com
DK39600706
#3 lore raw

PATCH 1/1 arm: stm32mp1: deploy spl in root folder

Hi Sean

Quoted 10 lines · Sean Nyekjaer

ping

Quoted 7 lines · Patrice CHOTARD

Hi Sean

+Patrick Delaunay

What about keeping spl binary in /spl directory and copying it in root directory instead ? It would avoid us to update our environment regarding your proposal.

You didn't answer to the above question.

Patrice

Quoted 49 lines
Quoted 48 lines

Just a minor remark, don't forget to add maintainers in copy when sending your patch.

Either use ./scripts/get_maintainer.pl <filename> which give you the people list to send your patch to or patman which adds automatically right people in cc.

For example ./scripts/get_maintainer.pl arch/arm/mach-stm32mp/config.mk gives you :

Patrick Delaunay <[email protected]> (maintainer:ARM STM STM32MP) Christophe Kerello <[email protected]> (maintainer:ARM STM STM32MP)
Patrice Chotard <[email protected]> (maintainer:ARM STM STM32MP) Albert Aribaud <[email protected]> (maintainer:ARM) uboot-stm32 at st-md-mailman.stormreply.com (moderated list:ARM STM STM32MP) u-boot at lists.denx.de (open list)

Patrice

Quoted 26 lines · Sean Nyekjær

Deploy u-boot-spl.stm32 binary in u-boot root folder like the rest of the boards.
This makes it more streamlined when building in Yocto, Buildroot etc..

---
  arch/arm/mach-stm32mp/config.mk | 6 +++---

  1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/mach-stm32mp/config.mk +0 -0
index cde5850e934..124729cd839 100644
@@ -3,11 +3,11 @@
   # Copyright (C) 2018, STMicroelectronics - All Rights Reserved
   #

  -ALL-$(CONFIG_SPL_BUILD) += spl/u-boot-spl.stm32 +ALL-$(CONFIG_SPL_BUILD) += u-boot-spl.stm32 MKIMAGEFLAGS_u-boot-spl.stm32 = -T stm32image -a $(CONFIG_SPL_TEXT_BASE) -e $(CONFIG_SPL_TEXT_BASE) -spl/u-boot-spl.stm32: MKIMAGEOUTPUT = spl/u-boot-spl.stm32.log +u-boot-spl.stm32: MKIMAGEOUTPUT = u-boot-spl.stm32.log -spl/u-boot-spl.stm32: spl/u-boot-spl.bin FORCE +u-boot-spl.stm32: spl/u-boot-spl.bin FORCE
      $(call if_changed,mkimage)

#4 lore raw

PATCH 1/1 arm: stm32mp1: deploy spl in root folder

Hi Patrice

Quoted 9 lines
Quoted 3 lines
Quoted 3 lines

What about keeping spl binary in /spl directory and copying it in root directory instead ? It would avoid us to update our environment regarding your proposal.

You didn't answer to the above question.

Patrice

Sorry.
I really don't care how it's done :-)
But the I think the best solution is the I one posted, it's better to align things with other boards in u-boot.

/Sean

#5 lore raw

PATCH 1/1 arm: stm32mp1: deploy spl in root folder

Hi Sean,

Quoted 12 lines

From: Sean Nyekjaer <[email protected]>
Sent: jeudi 24 janvier 2019 13:38

Hi Patrice

Quoted 7 lines
Quoted 3 lines
Quoted 3 lines

What about keeping spl binary in /spl directory and copying it in root directory instead ? It would avoid us to update our environment regarding your proposal.

You didn't answer to the above question.

Quoted 7 lines
Quoted 2 lines

Patrice

Sorry.
I really don't care how it's done :-)
But the I think the best solution is the I one posted, it's better to align things with other boards in u-boot.

I checked with Patrice the other boards and most of the cases the modified spl binay (u-boot-spl.bin/ u-boot-spl.ais / u-boot-spl.img / u-boot-spl.pbl / u-boot-spl.gph) are generated in spl directory.

So I done the same for u-boot-spl.stm32.

The only case where it is populated in u-boot directory it is when it is concatenated with u-boot image (so the generated files depends on u-boot.bin) , but is not the case for us.

Perhaps I miss so other cases ?

Moreover I am working with YOCTO and using a sub-directory is not issue with latest version and with patch in poky/meta/recipes-bsp/u-boot/u-boot.inc
------------------------------------------------------------------------------------------
commit c6ab82882cd49be5510d1f8c967d0dc2da2490c2
Author: Nathan Rossi <[email protected]> Fri Mar 25 10:07:12 2016
Committer: Richard Purdie <[email protected]> Mon Mar 28 16:55:48 2016

u-boot.inc: Add sub-dir support for SPL_BINARY

Add support for the SPL_BINARY variable to handle sub directories. In some cases the SPL binary that needs to be deployed is only built to the spl/ directory in U-Boot. So that a sub directory can be specified in the SPL_BINARY variable, handle the case so that the deploy code uses the basename of the path specified in SPL_BINARY.

(From OE-Core rev: eb90d1c8fc7b82ca2593185930b3bf175f40ae13)

------------------------------------------------------------------------------------------

So, I don't understood the blocking point, and other platform do the same (the reason of the patch).

Even I agree that copy the generated u-boot-spl.stm32 in u-boot build directory could be easier (for BUILDROOT ?), I want keep the file spl/u-boot-spl.stm32 to avoid to break the current upstream effort
of YOCTO BSP support for STM32MP157 board (which expect spl file in spl directory).

I you are agree with the next proposal, I will ack you patch v2

=> a modified patch to just copy with $(call if_changed,copy)

------------------------------------------------------------------------------------------------------------

#6 lore raw

PATCH 1/1 arm: stm32mp1: deploy spl in root folder

Hi Patrick

Quoted 6 lines

I checked with Patrice the other boards and most of the cases the modified spl binay (u-boot-spl.bin/ u-boot-spl.ais / u-boot-spl.img / u-boot-spl.pbl / u-boot-spl.gph) are generated in spl directory.

So I done the same for u-boot-spl.stm32.

All the NXP iMX6 variant boards deploy the SPL to the root folder :-)

Quoted 25 lines

The only case where it is populated in u-boot directory it is when it is concatenated with u-boot image (so the generated files depends on u-boot.bin) , but is not the case for us.

Perhaps I miss so other cases ?

Moreover I am working with YOCTO and using a sub-directory is not issue with latest version and with patch in poky/meta/recipes-bsp/u-boot/u-boot.inc
------------------------------------------------------------------------------------------

    commit c6ab82882cd49be5510d1f8c967d0dc2da2490c2
    Author:	Nathan Rossi <[email protected]>  Fri Mar 25 10:07:12 2016

Committer: Richard Purdie <[email protected]> Mon Mar 28 16:55:48 2016

u-boot.inc: Add sub-dir support for SPL_BINARY

Add support for the SPL_BINARY variable to handle sub directories. In some cases the SPL binary that needs to be deployed is only built to the spl/ directory in U-Boot. So that a sub directory can be specified in the SPL_BINARY variable, handle the case so that the deploy code uses the basename of the path specified in SPL_BINARY.

(From OE-Core rev: eb90d1c8fc7b82ca2593185930b3bf175f40ae13)

Quoted 7 lines

------------------------------------------------------------------------------------------

So, I don't understood the blocking point, and other platform do the same (the reason of the patch).

Even I agree that copy the generated u-boot-spl.stm32 in u-boot build directory could be easier (for BUILDROOT ?), I want keep the file spl/u-boot-spl.stm32 to avoid to break the current upstream effort
of YOCTO BSP support for STM32MP157 board (which expect spl file in spl directory).

I got a new job (therefore new email address), so i don't have access to the Yocto source where I got into troubles with this.
If i recall correctly we where using the SPI_BINARY variable when deploying the SPL and we should have been using the SPL_BINARYNAME.

So no need for this patch.

/Sean

#7 lore raw

PATCH 1/1 arm: stm32mp1: deploy spl in root folder

Hi Sean,

Quoted 10 lines

From: Sean Nyekjaer <[email protected]>
Sent: vendredi 25 janvier 2019 08:11
To: Patrick DELAUNAY <[email protected]>; ravi at prevas.dk
Cc: Patrice CHOTARD <[email protected]>; u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCHv1] arm: stm32mp1: deploy spl in root folder
Importance: High

Hi Patrick

Quoted 1 line
Quoted 6 lines
Quoted 5 lines

I checked with Patrice the other boards and most of the cases the modified spl binay (u-boot-spl.bin/ u-boot-spl.ais / u-boot-spl.img / u-boot-spl.pbl / u-boot-spl.gph) are generated in spl directory.

So I done the same for u-boot-spl.stm32.

All the NXP iMX6 variant boards deploy the SPL to the root folder :-)

Ok, I checked and the generated files are

1 - spl/u-boot-spl.bin
2 - SPL = spl/u-boot-spl.bin + $(PLUGIN).bin + imx header 3 - u-boot.bin

SPL is no only spl but include plugin,
so it is normal for for that it is not in spl sub-directory

Quoted 38 lines
Quoted 3 lines

The only case where it is populated in u-boot directory it is when it is concatenated with u-boot image (so the generated files depends on u-

boot.bin) , but is not the case for us.

Quoted 9 lines

Perhaps I miss so other cases ?

Moreover I am working with YOCTO and using a sub-directory is not issue with latest version and with patch in poky/meta/recipes-bsp/u-boot/u-boot.inc
------------------------------------------------------------------------------------------
commit c6ab82882cd49be5510d1f8c967d0dc2da2490c2
Author: Nathan Rossi <[email protected]> Fri Mar 25 10:07:12

2016

Quoted 1 line

Committer: Richard Purdie <[email protected]> Mon Mar

28 16:55:48 2016

Quoted 9 lines

u-boot.inc: Add sub-dir support for SPL_BINARY

Add support for the SPL_BINARY variable to handle sub directories. In some cases the SPL binary that needs to be deployed is only built to the spl/ directory in U-Boot. So that a sub directory can be specified in the SPL_BINARY variable, handle the case so that the deploy code uses the basename of the path specified in SPL_BINARY.

Quoted 8 lines

(From OE-Core rev: eb90d1c8fc7b82ca2593185930b3bf175f40ae13)

----------------------------------------------------------------------
--------------------

So, I don't understood the blocking point, and other platform do the same (the

reason of the patch).

Quoted 4 lines

Even I agree that copy the generated u-boot-spl.stm32 in u-boot build directory could be easier (for BUILDROOT ?), I want keep the file spl/u-boot-spl.stm32 to avoid to break the current upstream effort of YOCTO

Quoted 8 lines

BSP support for STM32MP157 board (which expect spl file in spl directory).

I got a new job (therefore new email address), so i don't have access to the Yocto source where I got into troubles with this.
If i recall correctly we where using the SPI_BINARY variable when deploying the SPL and we should have been using the SPL_BINARYNAME.

So no need for this patch.

Ok, I think the patch can be abandon as with latest YOCTO it is working with machine value:

	SPL_BINARY = " spl/u-boot-spl.stm32"

Because path is supported in the next variables

	SPL_BINARYNAME ?= "${@os.path.basename(d.getVar("SPL_BINARY"))}"
	SPL_IMAGE ?= "${SPL_BINARYNAME}-${MACHINE}-${PV}-${PR}"
	SPL_SYMLINK ?= "${SPL_BINARYNAME}-${MACHINE}"

PS: It can also work with previous version YOCTO with

	SPL_BINARY = " spl/u-boot-spl.stm32"
	SPL_BINARYNAME = "u-boot-spl.stm32"

But I will kept my proposal in mind if other requests/complaint come in the future.

Thanks for your time and
good luck for your new job.

Quoted 2 lines

/Sean

Best regards

Patrick

#8 lore raw

PATCH 1/1 arm: stm32mp1: deploy spl in root folder

In reply to Sean Nyekjær
Quoted 6 lines · Sean Nyekjær

Deploy u-boot-spl.stm32 binary in u-boot root folder like the rest of the boards.
This makes it more streamlined when building in Yocto, Buildroot etc..

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190126/b27a3ccc/attachment.sig>
#9 lore raw

PATCH 1/1 arm: stm32mp1: deploy spl in root folder

Hi Tom,

Quoted 10 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Tom Rini
Sent: dimanche 27 janvier 2019 04:51
To: Sean Nyekjær <[email protected]>
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [U-Boot, PATCHv1] arm: stm32mp1: deploy spl in root folder

On Fri, Jan 04, 2019 at 11:37:24AM +0000, Sean Nyekjær wrote:

Quoted 8 lines
Quoted 6 lines

Deploy u-boot-spl.stm32 binary in u-boot root folder like the rest of the boards.
This makes it more streamlined when building in Yocto, Buildroot etc..

Applied to u-boot/master, thanks!

For information, I want some update for this patch in my last comment. As it is already merged I sent a updated version:

http://patchwork.ozlabs.org/patch/1031838/

Regards.

Quoted 2 lines

--
Tom

Patrick

#10 lore raw

PATCH 1/1 arm: stm32mp1: deploy spl in root folder

Quoted 19 lines · Patrick DELAUNAY

Hi Tom,

Quoted 17 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Tom Rini
Sent: dimanche 27 janvier 2019 04:51
To: Sean Nyekjær <[email protected]>
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [U-Boot, PATCHv1] arm: stm32mp1: deploy spl in root folder

Quoted 6 lines · Sean Nyekjær

Deploy u-boot-spl.stm32 binary in u-boot root folder like the rest of the boards.
This makes it more streamlined when building in Yocto, Buildroot etc..

Quoted 6 lines
Quoted 1 line

Applied to u-boot/master, thanks!

For information, I want some update for this patch in my last comment. As it is already merged I sent a updated version:

http://patchwork.ozlabs.org/patch/1031838/

Sorry for missing your comments, I'll grab your newer patch shortly.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190128/4f1b94dc/attachment.sig>