ixgbe: fix older devices that do not support IXGBE_MRQC_L3L4TXSWEN
Subsystems (2)
The enabling L3/L4 filtering for transmit switched packets for all devices caused unforeseen issue on older devices when trying to send UDP traffic in an ordered sequence. This bit was originally intended for X550 devices, which supported this feature, so limit the scope of this bit to only X550 devices.
--- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +5 -2
@@ -3953,8 +3953,11 @@ static void ixgbe_setup_mrqc(struct ixgbe_adapter *adapter)else mrqc =IXGBE_MRQC_VMDQRSS64EN ; -/* Enable L3/L4 for Tx Switched packets */ - mrqc |=IXGBE_MRQC_L3L4TXSWEN ; +/* Enable L3/L4 for Tx Switched packets only for X550, +* older devices do not support this feature +*/ +if (hw->mac.type >= ixgbe_mac_X550) + mrqc |=IXGBE_MRQC_L3L4TXSWEN ; }else {if (tcs >4 ) mrqc =IXGBE_MRQC_RTRSS8TCEN ;
Signature · 1 line
2.20.1
Bowers
Tested-by Andrew BowersQuoted 14 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Jeff Kirsher
Sent: Monday, January 28, 2019 9:45 AM
To: intel-wired-lan at lists.osuosl.org
Subject: [Intel-wired-lan] [net] ixgbe: fix older devices that do not supportIXGBE_MRQC_L3L4TXSWENThe enabling L3/L4 filtering for transmit switched packets for all devices caused unforeseen issue on older devices when trying to send UDP traffic in an ordered sequence. This bit was originally intended for X550 devices, which supported this feature, so limit the scope of this bit to only X550 devices.
Quoted 4 lines
Signed-off-by Jeff Kirsher <[email protected]>--- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)